Make $wgEmailConfirmToEdit only affect edit actions.
authorBrian Wolff <bawolff+wn@gmail.com>
Fri, 26 Aug 2016 01:29:58 +0000 (01:29 +0000)
committerLegoktm <legoktm@member.fsf.org>
Tue, 12 Jun 2018 00:37:34 +0000 (00:37 +0000)
commitf7f71359a1be8460c72824d373e12dd2b9bb8bbe
tree183156541e1448c1c9523504d1e6812fcf14d40f
parent49053c905a072e4b0e3a132854aad1d9cc274bb0
Make $wgEmailConfirmToEdit only affect edit actions.

Previously it would affect all actions that use Title::userCan.
This used to be less noticable, but recently was expanded to include
the 'read' action. This only affected the case where both
$wgBlockDisablesLogin and $wgEmailConfirmedToEdit were enabled.

I don't think anyone was relying on the old behaviour as it was
undocumented, and only affected obscure permissions (checked with
Title::userCan and not depending on "edit" rights)

Follow-up b675be2083

Bug: T143790
Change-Id: I4ad93ed78de4f1ed444f73df6dc26d405a67e553
(cherry picked from commit d561f646b9b8424bd79cfc14729a622a143d9f12)
includes/Title.php
tests/phpunit/includes/TitlePermissionTest.php