From: Jforrester <jforrester@wikimedia.org>
Date: Thu, 19 Apr 2018 18:42:12 +0000 (+0000)
Subject: Deprecate $wgUseAjax in 1.31
X-Git-Tag: 1.31.0-rc.0~26^2
X-Git-Url: http://git.cyclocoop.org/?p=lhc%2Fweb%2Fwiklou.git;a=commitdiff_plain;h=add25fea96583a6dc0fbaf9f0d5451b90a860787

Deprecate $wgUseAjax in 1.31

This setting was intended to control the legacy AJAX framework, but some
extensions mistakenly used it to control any AJAX functionality at all.

But keeping this around when we're deprecating things like $wgEnableAPI
makes no sense.

[Retro-back-ported after bf61efd87 had landed in 1.32.]

Change-Id: I7b767478f9fb44236e6514b0e83228d9fb8e856f
(cherry picked ish from commit 434f280ba9b27c9f3e3b4dbeb9b260834913649d)
---

diff --git a/RELEASE-NOTES-1.31 b/RELEASE-NOTES-1.31
index 97b8f432e1..de2abddfc7 100644
--- a/RELEASE-NOTES-1.31
+++ b/RELEASE-NOTES-1.31
@@ -39,6 +39,10 @@ production.
 * $wgValidateAllHtml was removed and will be ignored.
 * $wgScriptExtension was removed (deprecated and ignored since 1.25).
   See 1.25 release notes for more information.
+* $wgUseAjax is now marked as deprecated, just like the deprecated AJAX
+  framework that it enables. Some extensions mistakenly used this to check
+  whether any AJAX functionality at all should be enabled, further making this
+  problematic to retain.
 
 === New features in 1.31 ===
 * (T76554) User sub-pages named ….json are now protected in the same way that ….js
diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php
index 9922410c55..004a70e1e2 100644
--- a/includes/DefaultSettings.php
+++ b/includes/DefaultSettings.php
@@ -8125,6 +8125,8 @@ $wgAPIUselessQueryPages = [
 
 /**
  * Enable AJAX framework
+ *
+ * @deprecated (officially) since MediaWiki 1.31
  */
 $wgUseAjax = true;