From: Timo Tijhof <krinklemail@gmail.com>
Date: Sun, 29 Sep 2019 01:59:56 +0000 (+0100)
Subject: selenium: Remove deprecated legacy methods
X-Git-Tag: 1.34.0-rc.0~44^2
X-Git-Url: http://git.cyclocoop.org/?p=lhc%2Fweb%2Fwiklou.git;a=commitdiff_plain;h=776321bf1a83ca13aa2a6776a255f300746428a3

selenium: Remove deprecated legacy methods

These are from 2018, prior to introducing wdio-mediawiki in
commit 16a4d9da7bb81. Some extensions referenced these pageobjects
files through escalating "../../" references.

None of these are seen in Codesearch anymore, as well as no
references to these deprecated methods by other means.

Change-Id: Idbc373f13f9767cecd6404922b5c9773d796dda5
---

diff --git a/tests/selenium/pageobjects/createaccount.page.js b/tests/selenium/pageobjects/createaccount.page.js
index 99281bd202..a81511fc53 100644
--- a/tests/selenium/pageobjects/createaccount.page.js
+++ b/tests/selenium/pageobjects/createaccount.page.js
@@ -1,5 +1,4 @@
-const Page = require( 'wdio-mediawiki/Page' ),
-	Api = require( 'wdio-mediawiki/Api' );
+const Page = require( 'wdio-mediawiki/Page' );
 
 class CreateAccountPage extends Page {
 	get username() { return $( '#wpName2' ); }
@@ -19,11 +18,6 @@ class CreateAccountPage extends Page {
 		this.confirmPassword.setValue( password );
 		this.create.click();
 	}
-
-	// @deprecated Use wdio-mediawiki/Api#createAccount() instead.
-	apiCreateAccount( username, password ) {
-		return Api.createAccount( username, password );
-	}
 }
 
 module.exports = new CreateAccountPage();
diff --git a/tests/selenium/pageobjects/delete.page.js b/tests/selenium/pageobjects/delete.page.js
index 72e2d04578..754c0d2a91 100644
--- a/tests/selenium/pageobjects/delete.page.js
+++ b/tests/selenium/pageobjects/delete.page.js
@@ -1,5 +1,4 @@
-const Page = require( 'wdio-mediawiki/Page' ),
-	Api = require( 'wdio-mediawiki/Api' );
+const Page = require( 'wdio-mediawiki/Page' );
 
 class DeletePage extends Page {
 	get reason() { return $( '#wpReason' ); }
@@ -16,11 +15,6 @@ class DeletePage extends Page {
 		this.reason.setValue( reason );
 		this.submit.click();
 	}
-
-	// @deprecated Use wdio-mediawiki/Api#delete() instead.
-	apiDelete( name, reason ) {
-		return Api.delete( name, reason );
-	}
 }
 
 module.exports = new DeletePage();
diff --git a/tests/selenium/pageobjects/edit.page.js b/tests/selenium/pageobjects/edit.page.js
index 8036f2053e..4302e8f36f 100644
--- a/tests/selenium/pageobjects/edit.page.js
+++ b/tests/selenium/pageobjects/edit.page.js
@@ -1,5 +1,4 @@
-const Page = require( 'wdio-mediawiki/Page' ),
-	Api = require( 'wdio-mediawiki/Api' );
+const Page = require( 'wdio-mediawiki/Page' );
 
 class EditPage extends Page {
 	get content() { return $( '#wpTextbox1' ); }
@@ -24,11 +23,6 @@ class EditPage extends Page {
 		this.content.setValue( content );
 		this.save.click();
 	}
-
-	// @deprecated Use wdio-mediawiki/Api#edit() instead.
-	apiEdit( name, content ) {
-		return Api.edit( name, content );
-	}
 }
 
 module.exports = new EditPage();
diff --git a/tests/selenium/pageobjects/page.js b/tests/selenium/pageobjects/page.js
deleted file mode 100644
index f159990eae..0000000000
--- a/tests/selenium/pageobjects/page.js
+++ /dev/null
@@ -1,12 +0,0 @@
-const Page = require( 'wdio-mediawiki/Page' );
-
-/**
- * @deprecated Use wdio-mediawiki/Page and openTitle() instead.
- */
-class LegacyPage extends Page {
-	open( path ) {
-		browser.url( browser.options.baseUrl + '/index.php?title=' + path );
-	}
-}
-
-module.exports = LegacyPage;
diff --git a/tests/selenium/pageobjects/userlogin.page.js b/tests/selenium/pageobjects/userlogin.page.js
deleted file mode 100644
index 971e21bd4e..0000000000
--- a/tests/selenium/pageobjects/userlogin.page.js
+++ /dev/null
@@ -1,6 +0,0 @@
-const LoginPage = require( 'wdio-mediawiki/LoginPage' );
-
-/**
- * @deprecated Use wdio-mediawiki/LoginPage instead.
- */
-module.exports = LoginPage;