From: Reedy <reedy@wikimedia.org>
Date: Thu, 13 Jul 2017 22:30:25 +0000 (+0100)
Subject: Swap SqliteInstaller::MINIMUM_VERSION for SqliteInstaller::$minimumVersion
X-Git-Tag: 1.31.0-rc.0~2696^2
X-Git-Url: http://git.cyclocoop.org/?p=lhc%2Fweb%2Fwiklou.git;a=commitdiff_plain;h=4b0567a86beb3d800f90c584bce7de2b2aa7d985

Swap SqliteInstaller::MINIMUM_VERSION for SqliteInstaller::$minimumVersion

Makes it like the rest of the Installer classes

Change-Id: I940e71878f4e9454371c0e1da0ef5d6bfa51ebdd
---

diff --git a/includes/installer/SqliteInstaller.php b/includes/installer/SqliteInstaller.php
index 394337411d..0f639badd8 100644
--- a/includes/installer/SqliteInstaller.php
+++ b/includes/installer/SqliteInstaller.php
@@ -32,7 +32,8 @@ use Wikimedia\Rdbms\DBConnectionError;
  * @since 1.17
  */
 class SqliteInstaller extends DatabaseInstaller {
-	const MINIMUM_VERSION = '3.3.7';
+
+	public $minimumVersion = '3.3.7';
 
 	/**
 	 * @var DatabaseSqlite
@@ -60,8 +61,8 @@ class SqliteInstaller extends DatabaseInstaller {
 		$result = Status::newGood();
 		// Bail out if SQLite is too old
 		$db = DatabaseSqlite::newStandaloneInstance( ':memory:' );
-		if ( version_compare( $db->getServerVersion(), self::MINIMUM_VERSION, '<' ) ) {
-			$result->fatal( 'config-outdated-sqlite', $db->getServerVersion(), self::MINIMUM_VERSION );
+		if ( version_compare( $db->getServerVersion(), $this->minimumVersion, '<' ) ) {
+			$result->fatal( 'config-outdated-sqlite', $db->getServerVersion(), $this->minimumVersion );
 		}
 		// Check for FTS3 full-text search module
 		if ( DatabaseSqlite::getFulltextSearchModule() != 'FTS3' ) {