rdbms: add IDatabase::wasConnectionLoss() method
authorAaron Schulz <aschulz@wikimedia.org>
Tue, 20 Mar 2018 00:26:49 +0000 (17:26 -0700)
committerAaron Schulz <aschulz@wikimedia.org>
Tue, 20 Mar 2018 01:10:43 +0000 (01:10 +0000)
commitfe92778888a381311eb4606d7940b5a089684b14
treeb9629a0bdc5133c9ef4de56def239b5dc7375fe7
parent6558e96a3e2e6775a1c733e33a466277c7f66914
rdbms: add IDatabase::wasConnectionLoss() method

This takes the logic from wasErrorReissuable(), but puts it under
better name. The way that method was used, as well its comments,
were only about connection loss.

Make wasErrorReissuable() check if there was any error that
does not preclude the ability to retry. This matches the actual
name of the method.

Also improve some other related comments.

Change-Id: I68455d803afb2370897fecab0e79aadbb5d1a740
includes/libs/rdbms/database/DBConnRef.php
includes/libs/rdbms/database/Database.php
includes/libs/rdbms/database/DatabaseMysqlBase.php
includes/libs/rdbms/database/DatabaseSqlite.php
includes/libs/rdbms/database/IDatabase.php