AuthManager: Don't invalidate BotPasswords if a password reset email is sent
authorBrad Jorsch <bjorsch@wikimedia.org>
Tue, 17 Jul 2018 20:18:59 +0000 (16:18 -0400)
committerReedy <reedy@wikimedia.org>
Mon, 20 Apr 2020 19:05:00 +0000 (20:05 +0100)
commit3d74af3e963bdcbbdbd58e65a5efdd7819db5236
tree6b3ac8c557eee1bf4d1cff166823ffbe51232aa0
parent9dfda465706d70a1ddd9beeec62c96b4d06c36b3
AuthManager: Don't invalidate BotPasswords if a password reset email is sent

There's a difference between addition of credentials, which doesn't
need to invaliate BotPasswords, and changing or removal of credentials,
which does.

It seems most straightforward for the caller of
AuthManager::changeAuthenticationData() to know which is intended, so
let's add a flag there.

Bug: T199809
Change-Id: Ib8405734e605b94f3f0b66596ad95784cb365e4f
includes/auth/AuthManager.php
includes/auth/ConfirmLinkSecondaryAuthenticationProvider.php
includes/user/PasswordReset.php