dépôts / lhc / web / wiklou.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 8435e09) | patch
Improve ApiLogin test coverage
authorAryeh Gregor <ayg@aryeh.name>
Mon, 8 Oct 2018 13:30:13 +0000 (16:30 +0300)
committerAryeh Gregor <ayg@aryeh.name>
Wed, 10 Oct 2018 08:11:43 +0000 (11:11 +0300)
commit1496fd4b4e569cb52f903f575c0a43dfa6ec8ae7
treee4b0f95351e55bb637541778a3e614f0d64e3881tree | snapshot
parent8435e0907b14536edde76cd9db36bb18e2a3b125commit | diff
Improve ApiLogin test coverage

Coverage is 100% except for one session-related bit that seems a bit
involved to test right now.  It looks like it will be easier once
SessionManager becomes a service.

I removed the third parameter from the return value of
canonicalizeLoginData, since af37a4c7 made it always return true.

I also removed three lines of dead code from ApiLogin.php.

Change-Id: Ia0073eddd27c82827518e0031e3c313f83cfd7cc
includes/api/ApiLogin.php diff | blob | history
includes/user/BotPassword.php diff | blob | history
tests/phpunit/includes/api/ApiLoginTest.php diff | blob | history
tests/phpunit/includes/user/BotPasswordTest.php diff | blob | history
Wiklou, le Wiki du Wiklou