Deprecate MediaWikiTestCase::stashMwGlobals
authorAryeh Gregor <ayg@aryeh.name>
Sun, 7 Oct 2018 12:26:18 +0000 (15:26 +0300)
committerAryeh Gregor <ayg@aryeh.name>
Sun, 7 Oct 2018 16:39:47 +0000 (19:39 +0300)
commit09eee138e1d725a599fc5953eb1d88173c643701
tree1e9e4ca4899e9ea64eaa21267d5ace5b345e1efe
parent536e575288afd68e8e5dac0fa0ee5db5cf9ec35d
Deprecate MediaWikiTestCase::stashMwGlobals

This method encourages directly editing configuration variables.  It's a
better idea to use setMwGlobals() (or other set wrappers) so that we can
be intelligent in the future, for instance resetting services after the
config change.  Plus, a lot of the callers come out cleaner this way
anyway.

Depends-On: I8a1e81acc5c42a8d7f30938a72cface0acea4a70
Depends-On: I4105dbcf9c5399fe7239478c460ec57c015a98d4
Depends-On: I1b220996acf2f66cf7b0f092b341584663df32f9
Depends-On: Ie2d1ea65c0cb334bbde1666d00781474b7ac4dab
Change-Id: I23d77398e401f4986b1d5bd1c9e11a8a40da16f8
tests/phpunit/MediaWikiTestCase.php
tests/phpunit/includes/api/ApiMoveTest.php
tests/phpunit/includes/api/ApiQuerySiteinfoTest.php
tests/phpunit/includes/api/ApiStashEditTest.php
tests/phpunit/includes/api/ApiUserrightsTest.php
tests/phpunit/includes/auth/AuthManagerTest.php
tests/phpunit/includes/auth/TemporaryPasswordAuthenticationRequestTest.php
tests/phpunit/includes/config/GlobalVarConfigTest.php
tests/phpunit/includes/user/LocalIdLookupTest.php
tests/phpunit/tests/MediaWikiTestCaseTest.php