From fc23633035eebb24b7199cb15683e25100184e2b Mon Sep 17 00:00:00 2001 From: Kunal Mehta Date: Thu, 28 Dec 2017 00:24:40 -0800 Subject: [PATCH] Add @covers tags to languages tests I removed comments that merely repeated the location of the class being tested. There are other tests in this directory that don't have a corresponding class and need further investigation. Change-Id: Ic16f0887b5030ac53fab4382cfaedfb5426cdb08 --- tests/phpunit/languages/LanguageConverterTest.php | 2 ++ tests/phpunit/languages/LanguageTest.php | 8 ++++++-- tests/phpunit/languages/classes/LanguageArTest.php | 4 +++- tests/phpunit/languages/classes/LanguageBe_taraskTest.php | 3 +++ tests/phpunit/languages/classes/LanguageBsTest.php | 6 +++++- tests/phpunit/languages/classes/LanguageCrhTest.php | 4 ++++ tests/phpunit/languages/classes/LanguageCuTest.php | 4 +++- tests/phpunit/languages/classes/LanguageDsbTest.php | 4 +++- tests/phpunit/languages/classes/LanguageGanTest.php | 4 ++++ tests/phpunit/languages/classes/LanguageHsbTest.php | 4 +++- tests/phpunit/languages/classes/LanguageHuTest.php | 4 +++- tests/phpunit/languages/classes/LanguageHyTest.php | 6 +++++- tests/phpunit/languages/classes/LanguageIuTest.php | 4 ++++ tests/phpunit/languages/classes/LanguageKkTest.php | 5 +++++ tests/phpunit/languages/classes/LanguageKshTest.php | 4 +++- tests/phpunit/languages/classes/LanguageKuTest.php | 4 ++++ tests/phpunit/languages/classes/LanguageMlTest.php | 4 +++- tests/phpunit/languages/classes/LanguageRuTest.php | 4 +++- tests/phpunit/languages/classes/LanguageShiTest.php | 4 ++++ tests/phpunit/languages/classes/LanguageSlTest.php | 4 +++- tests/phpunit/languages/classes/LanguageSrTest.php | 5 ++++- tests/phpunit/languages/classes/LanguageTgTest.php | 4 ++++ tests/phpunit/languages/classes/LanguageTrTest.php | 4 +++- tests/phpunit/languages/classes/LanguageUkTest.php | 4 +++- tests/phpunit/languages/classes/LanguageUzTest.php | 5 ++++- tests/phpunit/languages/classes/LanguageWaTest.php | 4 +++- tests/phpunit/languages/classes/LanguageZhTest.php | 5 +++++ 27 files changed, 99 insertions(+), 18 deletions(-) diff --git a/tests/phpunit/languages/LanguageConverterTest.php b/tests/phpunit/languages/LanguageConverterTest.php index fc2ed33b65..82ab7def22 100644 --- a/tests/phpunit/languages/LanguageConverterTest.php +++ b/tests/phpunit/languages/LanguageConverterTest.php @@ -160,6 +160,8 @@ class LanguageConverterTest extends MediaWikiLangTestCase { /** * Test exhausting pcre.backtrack_limit + * + * @covers LanguageConverter::autoConvert */ public function testAutoConvertT124404() { $testString = ''; diff --git a/tests/phpunit/languages/LanguageTest.php b/tests/phpunit/languages/LanguageTest.php index e39f57ea99..0c341303f7 100644 --- a/tests/phpunit/languages/LanguageTest.php +++ b/tests/phpunit/languages/LanguageTest.php @@ -1630,7 +1630,7 @@ class LanguageTest extends LanguageClassesTestCase { } /** - * @dataProvider testFormatNumProvider + * @dataProvider provideFormatNum * @covers Language::formatNum */ public function testFormatNum( @@ -1643,7 +1643,7 @@ class LanguageTest extends LanguageClassesTestCase { $this->assertEquals( $expected, $formattedNum ); } - public function testFormatNumProvider() { + public function provideFormatNum() { return [ [ true, 'en', 100, false, '100' ], [ true, 'en', 101, true, '101' ], @@ -1657,6 +1657,7 @@ class LanguageTest extends LanguageClassesTestCase { } /** + * @covers Language::parseFormattedNumber * @dataProvider parseFormattedNumberProvider */ public function testParseFormattedNumber( $langCode, $number ) { @@ -1795,6 +1796,9 @@ class LanguageTest extends LanguageClassesTestCase { ]; } + /** + * @covers Language::equals + */ public function testEquals() { $en1 = new Language(); $en1->setCode( 'en' ); diff --git a/tests/phpunit/languages/classes/LanguageArTest.php b/tests/phpunit/languages/classes/LanguageArTest.php index 5a66759873..f3f5a3f1f1 100644 --- a/tests/phpunit/languages/classes/LanguageArTest.php +++ b/tests/phpunit/languages/classes/LanguageArTest.php @@ -4,7 +4,9 @@ * @file */ -/** Tests for MediaWiki languages/LanguageAr.php */ +/** + * @covers LanguageAr + */ class LanguageArTest extends LanguageClassesTestCase { /** * @covers Language::formatNum diff --git a/tests/phpunit/languages/classes/LanguageBe_taraskTest.php b/tests/phpunit/languages/classes/LanguageBe_taraskTest.php index 26db1062a1..de684359fa 100644 --- a/tests/phpunit/languages/classes/LanguageBe_taraskTest.php +++ b/tests/phpunit/languages/classes/LanguageBe_taraskTest.php @@ -1,6 +1,9 @@