From e9044fe58dc46551a6eb630ed8f9ac97a12e075b Mon Sep 17 00:00:00 2001 From: Thiemo Kreuz Date: Fri, 17 May 2019 16:48:35 +0200 Subject: [PATCH] Remove covers validator trait where it is not needed MediaWikiTestCase already contains this trait. Change-Id: I08224ac12a58b41121697ab71d5c54ddbdd060ec --- tests/phpunit/includes/MediaWikiVersionFetcherTest.php | 2 -- tests/phpunit/includes/libs/MWMessagePackTest.php | 2 -- .../includes/resourceloader/ResourceLoaderSkinModuleTest.php | 2 -- tests/phpunit/includes/shell/ShellTest.php | 2 -- .../includes/watcheditem/WatchedItemQueryServiceUnitTest.php | 2 -- 5 files changed, 10 deletions(-) diff --git a/tests/phpunit/includes/MediaWikiVersionFetcherTest.php b/tests/phpunit/includes/MediaWikiVersionFetcherTest.php index cb234b2c31..9803081869 100644 --- a/tests/phpunit/includes/MediaWikiVersionFetcherTest.php +++ b/tests/phpunit/includes/MediaWikiVersionFetcherTest.php @@ -12,8 +12,6 @@ */ class MediaWikiVersionFetcherTest extends MediaWikiTestCase { - use MediaWikiCoversValidator; - public function testReturnsResult() { global $wgVersion; $versionFetcher = new MediaWikiVersionFetcher(); diff --git a/tests/phpunit/includes/libs/MWMessagePackTest.php b/tests/phpunit/includes/libs/MWMessagePackTest.php index 3890cf8e19..e9bffe1a33 100644 --- a/tests/phpunit/includes/libs/MWMessagePackTest.php +++ b/tests/phpunit/includes/libs/MWMessagePackTest.php @@ -5,8 +5,6 @@ */ class MWMessagePackTest extends MediaWikiTestCase { - use MediaWikiCoversValidator; - /** * Provides test cases for MWMessagePackTest::testMessagePack * diff --git a/tests/phpunit/includes/resourceloader/ResourceLoaderSkinModuleTest.php b/tests/phpunit/includes/resourceloader/ResourceLoaderSkinModuleTest.php index 231979d689..23b0cb911b 100644 --- a/tests/phpunit/includes/resourceloader/ResourceLoaderSkinModuleTest.php +++ b/tests/phpunit/includes/resourceloader/ResourceLoaderSkinModuleTest.php @@ -7,8 +7,6 @@ use Wikimedia\TestingAccessWrapper; */ class ResourceLoaderSkinModuleTest extends MediaWikiTestCase { - use MediaWikiCoversValidator; - public static function provideGetStyles() { // phpcs:disable Generic.Files.LineLength return [ diff --git a/tests/phpunit/includes/shell/ShellTest.php b/tests/phpunit/includes/shell/ShellTest.php index 3c05583806..5fb3ac0f5f 100644 --- a/tests/phpunit/includes/shell/ShellTest.php +++ b/tests/phpunit/includes/shell/ShellTest.php @@ -10,8 +10,6 @@ use Wikimedia\TestingAccessWrapper; */ class ShellTest extends MediaWikiTestCase { - use MediaWikiCoversValidator; - public function testIsDisabled() { $this->assertInternalType( 'bool', Shell::isDisabled() ); // sanity } diff --git a/tests/phpunit/includes/watcheditem/WatchedItemQueryServiceUnitTest.php b/tests/phpunit/includes/watcheditem/WatchedItemQueryServiceUnitTest.php index 3ba8773c29..0b1d0132fb 100644 --- a/tests/phpunit/includes/watcheditem/WatchedItemQueryServiceUnitTest.php +++ b/tests/phpunit/includes/watcheditem/WatchedItemQueryServiceUnitTest.php @@ -10,8 +10,6 @@ use Wikimedia\TestingAccessWrapper; */ class WatchedItemQueryServiceUnitTest extends MediaWikiTestCase { - use MediaWikiCoversValidator; - /** * @return PHPUnit_Framework_MockObject_MockObject|CommentStore */ -- 2.20.1