From d06baad826f3a6420ace88f7c06fdc1e30e26ffb Mon Sep 17 00:00:00 2001 From: Max Semenik Date: Mon, 26 Aug 2019 19:03:09 -0700 Subject: [PATCH] Add more information to exception thrown It's not just about the preference name, because current user's properties are used for validation too. Bug: T231029 Change-Id: I268b959017bb0dce2b4295d5302a544bfa3513eb --- includes/preferences/DefaultPreferencesFactory.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/includes/preferences/DefaultPreferencesFactory.php b/includes/preferences/DefaultPreferencesFactory.php index 001c975dbc..00c290357e 100644 --- a/includes/preferences/DefaultPreferencesFactory.php +++ b/includes/preferences/DefaultPreferencesFactory.php @@ -232,7 +232,10 @@ class DefaultPreferencesFactory implements PreferencesFactory { } elseif ( $field->validate( $globalDefault, $user->getOptions() ) === true ) { $info['default'] = $globalDefault; } else { - throw new MWException( "Global default '$globalDefault' is invalid for field $name" ); + $globalDefault = json_encode( $globalDefault ); + throw new MWException( + "Default '$globalDefault' is invalid for preference $name of user $user" + ); } } -- 2.20.1