From ce5b29ff095d6f42f73264b5039fd6b6ec0eaee9 Mon Sep 17 00:00:00 2001
From: Tim Starling <tstarling@users.mediawiki.org>
Date: Sat, 28 May 2005 06:52:55 +0000
Subject: [PATCH] fixed silly switch() use, much better handled with
 if..elseif..else

---
 index.php | 18 ++++++------------
 1 file changed, 6 insertions(+), 12 deletions(-)

diff --git a/index.php b/index.php
index f22de25ff0..2dade97059 100644
--- a/index.php
+++ b/index.php
@@ -141,20 +141,14 @@ if( !$wgDisableInternalSearch && !is_null( $search ) && $search !== '' ) {
 		$wgTitle = Title::makeTitle( NS_IMAGE, $wgTitle->getDBkey() );
 	}
 
-	switch( $wgTitle->getNamespace() ) {
-	case NS_IMAGE:
+	$ns = $wgTitle->getNamespace();
+	if ( $ns == NS_IMAGE ) {
 		require_once( 'includes/ImagePage.php' );
 		$wgArticle = new ImagePage( $wgTitle );
-		break;
-	case NS_CATEGORY:
-		if ( $wgUseCategoryMagic ) {
-			require_once( 'includes/CategoryPage.php' );
-			$wgArticle = new CategoryPage( $wgTitle );
-			break;
-		}
-		# NO break if wgUseCategoryMagic is false, drop through to next (default).
-		# Don't insert other cases between NS_CATEGORY and default.
-	default:
+	} elseif ( $wgUseCategoryMagic && $ns == NS_CATEGORY ) {
+		require_once( 'includes/CategoryPage.php' );
+		$wgArticle = new CategoryPage( $wgTitle );
+	} else {
 		$wgArticle = new Article( $wgTitle );
 	}
 
-- 
2.20.1