From cb4bb23df61811c10f8cb286b80a232a80652c2b Mon Sep 17 00:00:00 2001 From: Leszek Manicki Date: Tue, 3 Jan 2017 15:13:51 +0100 Subject: [PATCH] Remove unused static methods in LanguageConverter subclasses It seems LanguageConverter::parseManualRule was removed by 69dbeb97f15b65dd5773852d76c3bc93caefc862 (2008), and LanguageConverter::parserConvert by c568220e610177114e71973375514d33871d6345 (2010), so it seems safe and reasonable to remove their implementations from few remaining language-specific Converter classes. Change-Id: I7092f5c8856723fabd2b1f99944451344feb5711 --- languages/classes/LanguageIu.php | 38 ------------------------------- languages/classes/LanguageKk.php | 25 -------------------- languages/classes/LanguageShi.php | 38 ------------------------------- languages/classes/LanguageSr.php | 25 -------------------- tests/phan/config.php | 2 +- 5 files changed, 1 insertion(+), 127 deletions(-) diff --git a/languages/classes/LanguageIu.php b/languages/classes/LanguageIu.php index a2288d09f4..e8731dcd02 100644 --- a/languages/classes/LanguageIu.php +++ b/languages/classes/LanguageIu.php @@ -96,44 +96,6 @@ class IuConverter extends LanguageConverter { ]; } - /** - * rules should be defined as -{Syllabic | Latin-} -or- - * -{code:text | code:text | ...}- - * update: delete all rule parsing because it's not used - * currently, and just produces a couple of bugs - * - * @param string $rule - * @param array $flags - * @return array - */ - function parseManualRule( $rule, $flags = [] ) { - if ( in_array( 'T', $flags ) ) { - return parent::parseManualRule( $rule, $flags ); - } - - $carray = []; - // otherwise ignore all formatting - foreach ( $this->mVariants as $v ) { - $carray[$v] = $rule; - } - - return $carray; - } - - /** - * Do not convert content on talk pages - * - * @param string $text - * @param Parser $parser - * @return string - */ - function parserConvert( $text, &$parser ) { - $this->mDoContentConvert = !( is_object( $parser->getTitle() ) - && $parser->getTitle()->isTalkPage() ); - - return parent::parserConvert( $text, $parser ); - } - /** * A function wrapper: * - if there is no selected variant, leave the link diff --git a/languages/classes/LanguageKk.php b/languages/classes/LanguageKk.php index 548c9a0e52..3605e8dd72 100644 --- a/languages/classes/LanguageKk.php +++ b/languages/classes/LanguageKk.php @@ -216,31 +216,6 @@ class KkConverter extends LanguageConverter { ]; } - /** - * rules should be defined as -{ekavian | iyekavian-} -or- - * -{code:text | code:text | ...}- - * - * update: delete all rule parsing because it's not used - * currently, and just produces a couple of bugs - * - * @param string $rule - * @param array $flags - * @return array - */ - function parseManualRule( $rule, $flags = [] ) { - if ( in_array( 'T', $flags ) ) { - return parent::parseManualRule( $rule, $flags ); - } - - $carray = []; - // otherwise ignore all formatting - foreach ( $this->mVariants as $v ) { - $carray[$v] = $rule; - } - - return $carray; - } - /** * A function wrapper: * - if there is no selected variant, leave the link diff --git a/languages/classes/LanguageShi.php b/languages/classes/LanguageShi.php index 0de396d390..36821b0602 100644 --- a/languages/classes/LanguageShi.php +++ b/languages/classes/LanguageShi.php @@ -72,44 +72,6 @@ class ShiConverter extends LanguageConverter { ]; } - /** - * rules should be defined as -{Tifinagh | Latin-} -or- - * -{code:text | code:text | ...}- - * update: delete all rule parsing because it's not used - * currently, and just produces a couple of bugs - * - * @param string $rule - * @param array $flags - * @return array - */ - function parseManualRule( $rule, $flags = [] ) { - if ( in_array( 'T', $flags ) ) { - return parent::parseManualRule( $rule, $flags ); - } - - $carray = []; - // otherwise ignore all formatting - foreach ( $this->mVariants as $v ) { - $carray[$v] = $rule; - } - - return $carray; - } - - /** - * Do not convert content on talk pages - * - * @param string $text - * @param Parser $parser - * @return string - */ - function parserConvert( $text, &$parser ) { - $this->mDoContentConvert = !( is_object( $parser->getTitle() ) - && $parser->getTitle()->isTalkPage() ); - - return parent::parserConvert( $text, $parser ); - } - /** * A function wrapper: * - if there is no selected variant, leave the link diff --git a/languages/classes/LanguageSr.php b/languages/classes/LanguageSr.php index 886ee94a35..6491f55140 100644 --- a/languages/classes/LanguageSr.php +++ b/languages/classes/LanguageSr.php @@ -75,31 +75,6 @@ class SrConverter extends LanguageConverter { ]; } - /** - * rules should be defined as -{ekavian | iyekavian-} -or- - * -{code:text | code:text | ...}- - * - * update: delete all rule parsing because it's not used - * currently, and just produces a couple of bugs - * - * @param string $rule - * @param array $flags - * @return array - */ - function parseManualRule( $rule, $flags = [] ) { - if ( in_array( 'T', $flags ) ) { - return parent::parseManualRule( $rule, $flags ); - } - - $carray = []; - // otherwise ignore all formatting - foreach ( $this->mVariants as $v ) { - $carray[$v] = $rule; - } - - return $carray; - } - /** * A function wrapper: * - if there is no selected variant, leave the link diff --git a/tests/phan/config.php b/tests/phan/config.php index 14ff52ae08..903d7cb707 100644 --- a/tests/phan/config.php +++ b/tests/phan/config.php @@ -337,7 +337,7 @@ return [ "PhanUndeclaredMethod", // approximate error count: 1342 "PhanUndeclaredProperty", - // approximate error count: 9 + // approximate error count: 3 "PhanUndeclaredStaticMethod", // approximate error count: 79 "PhanUndeclaredVariable", -- 2.20.1