From c5cdcd10db0a4ec518567f358ae532a660f174cd Mon Sep 17 00:00:00 2001 From: Amir Sarabadani Date: Thu, 27 Jun 2019 23:04:47 +0200 Subject: [PATCH] Type hint against interface for LoadBalancer in MediaWikiServices This decouples MediaWikiServices from big class of LoadBalancer Change-Id: Ic55aa8ae81d6fc8a973c4810d12667ca7673c5b1 --- includes/MediaWikiServices.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/includes/MediaWikiServices.php b/includes/MediaWikiServices.php index 689477b545..27c71ff9a2 100644 --- a/includes/MediaWikiServices.php +++ b/includes/MediaWikiServices.php @@ -33,9 +33,8 @@ use MediaWiki\Revision\RevisionStore; use OldRevisionImporter; use MediaWiki\Revision\RevisionStoreFactory; use UploadRevisionImporter; -use Wikimedia\Rdbms\LBFactory; +use Wikimedia\Rdbms\ILoadBalancer; use LinkCache; -use Wikimedia\Rdbms\LoadBalancer; use MediaHandlerFactory; use MediaWiki\Config\ConfigRepository; use MediaWiki\Linker\LinkRenderer; @@ -62,6 +61,7 @@ use SkinFactory; use TitleFormatter; use TitleParser; use VirtualRESTServiceClient; +use Wikimedia\Rdbms\LBFactory; use Wikimedia\Services\SalvageableService; use Wikimedia\Services\ServiceContainer; use Wikimedia\Services\NoSuchServiceException; @@ -549,7 +549,7 @@ class MediaWikiServices extends ServiceContainer { /** * @since 1.28 - * @return LoadBalancer The main DB load balancer for the local wiki. + * @return ILoadBalancer The main DB load balancer for the local wiki. */ public function getDBLoadBalancer() { return $this->getService( 'DBLoadBalancer' ); -- 2.20.1