From b96e76aeca3d10174a5bae12828d78e8f85aeba6 Mon Sep 17 00:00:00 2001 From: "James D. Forrester" Date: Mon, 21 Aug 2017 17:06:02 -0700 Subject: [PATCH] build: Bump eslint-config-wikimedia from 0.4.0 to 0.5.0 Change-Id: I06010cd6367c1884b5536e7929d3345feba7f305 --- package.json | 2 +- .../dm/mw.rcfilters.dm.SavedQueryItemModel.js | 2 +- .../src/mediawiki.rcfilters/mw.rcfilters.Controller.js | 8 +++----- .../ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js | 2 +- .../ui/mw.rcfilters.ui.SavedLinksListItemWidget.js | 4 ++-- 5 files changed, 8 insertions(+), 10 deletions(-) diff --git a/package.json b/package.json index 850723829c..96a425ff69 100644 --- a/package.json +++ b/package.json @@ -9,7 +9,7 @@ "devDependencies": { "deepmerge": "1.3.2", "eslint": "3.12.2", - "eslint-config-wikimedia": "0.4.0", + "eslint-config-wikimedia": "0.5.0", "grunt": "1.0.1", "grunt-banana-checker": "0.6.0", "grunt-contrib-copy": "1.0.0", diff --git a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js index c066a1ff4a..81c8306cdb 100644 --- a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js +++ b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js @@ -42,7 +42,7 @@ /** * Get an object representing the state of this item * - * @returns {Object} Object representing the current data state + * @return {Object} Object representing the current data state * of the object */ mw.rcfilters.dm.SavedQueryItemModel.prototype.getState = function () { diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js index c24e6c67d3..209e7c8ca8 100644 --- a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js +++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js @@ -458,11 +458,9 @@ this.filtersModel.toggleInvertedNamespaces(); if ( - this.filtersModel.getFiltersByView( 'namespaces' ) - .filter( function ( filterItem ) { - return filterItem.isSelected(); - } ) - .length + this.filtersModel.getFiltersByView( 'namespaces' ).filter( + function ( filterItem ) { return filterItem.isSelected(); } + ).length ) { // Only re-fetch results if there are namespace items that are actually selected this.updateChangesList(); diff --git a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js index 70a2227cef..bb837e00a4 100644 --- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js +++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js @@ -125,7 +125,7 @@ * Respond to input keyup event, this is the way to intercept 'escape' key * * @param {jQuery.Event} e Event data - * @returns {boolean} false + * @return {boolean} false */ mw.rcfilters.ui.SaveFiltersPopupButtonWidget.prototype.onInputKeyup = function ( e ) { if ( e.which === OO.ui.Keys.ESCAPE ) { diff --git a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js index cac10596cb..3655c1647c 100644 --- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js +++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js @@ -212,7 +212,7 @@ * Respond to input keyup event, this is the way to intercept 'escape' key * * @param {jQuery.Event} e Event data - * @returns {boolean} false + * @return {boolean} false */ mw.rcfilters.ui.SavedLinksListItemWidget.prototype.onInputKeyup = function ( e ) { if ( e.which === OO.ui.Keys.ESCAPE ) { @@ -307,7 +307,7 @@ /** * Get item ID * - * @returns {string} Query identifier + * @return {string} Query identifier */ mw.rcfilters.ui.SavedLinksListItemWidget.prototype.getID = function () { return this.model.getID(); -- 2.20.1