From a2bb8124b7f45c74412332754e35de412cc9c7b9 Mon Sep 17 00:00:00 2001 From: Umherirrender Date: Fri, 16 Mar 2018 17:50:59 +0100 Subject: [PATCH] Remove @dataProvider and @covers from non-test functions Only functions beginning with test* should have that annotation Change-Id: I85cd795970205943aebe692d85434145b3cf3f5b --- .../changes/ChangesListStringOptionsFilterGroupTest.php | 2 -- tests/phpunit/includes/libs/GenericArrayObjectTest.php | 4 +--- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/tests/phpunit/includes/changes/ChangesListStringOptionsFilterGroupTest.php b/tests/phpunit/includes/changes/ChangesListStringOptionsFilterGroupTest.php index 2355f7683d..b627178a6e 100644 --- a/tests/phpunit/includes/changes/ChangesListStringOptionsFilterGroupTest.php +++ b/tests/phpunit/includes/changes/ChangesListStringOptionsFilterGroupTest.php @@ -179,8 +179,6 @@ class ChangesListStringOptionsFilterGroupTest extends MediaWikiTestCase { /** * @param array $groupDefinition Group definition * @param string $input Value in URL - * - * @dataProvider provideModifyQuery */ protected function modifyQueryHelper( $groupDefinition, $input ) { $ctx = $this->createMock( IContextSource::class ); diff --git a/tests/phpunit/includes/libs/GenericArrayObjectTest.php b/tests/phpunit/includes/libs/GenericArrayObjectTest.php index a7cf755329..3be2b06465 100644 --- a/tests/phpunit/includes/libs/GenericArrayObjectTest.php +++ b/tests/phpunit/includes/libs/GenericArrayObjectTest.php @@ -173,8 +173,6 @@ abstract class GenericArrayObjectTest extends PHPUnit\Framework\TestCase { * @since 1.20 * * @param callable $function - * - * @covers GenericArrayObject::getObjectType */ protected function checkTypeChecks( $function ) { $excption = null; @@ -206,7 +204,7 @@ abstract class GenericArrayObjectTest extends PHPUnit\Framework\TestCase { * @since 1.20 * * @param array $elements - * + * @covers GenericArrayObject::getObjectType * @covers GenericArrayObject::offsetSet */ public function testOffsetSet( array $elements ) { -- 2.20.1