From 6547ac19a564774cb8c9beb879bbf21b30c78c2d Mon Sep 17 00:00:00 2001 From: Thalia Date: Wed, 17 May 2017 19:13:17 +0200 Subject: [PATCH] MediaSearchWidget: Only resize new results When repositioning images based on the "change" event, ignore images that have already been assigned to a row. Bug: T163727 Change-Id: Ida7556d8848f98d97d82aef9caf5c1d43bb47d7b --- .../MediaSearch/mw.widgets.MediaSearchWidget.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/resources/src/mediawiki.widgets/MediaSearch/mw.widgets.MediaSearchWidget.js b/resources/src/mediawiki.widgets/MediaSearch/mw.widgets.MediaSearchWidget.js index 5cbd2ec98f..1cc168abaf 100644 --- a/resources/src/mediawiki.widgets/MediaSearch/mw.widgets.MediaSearchWidget.js +++ b/resources/src/mediawiki.widgets/MediaSearch/mw.widgets.MediaSearchWidget.js @@ -351,7 +351,7 @@ }; /** - * Respond to add results event in the results widget. + * Respond to change results event in the results widget. * Override the way SelectWidget and GroupElement append the items * into the group so we can append them in groups of rows. * @@ -374,6 +374,12 @@ // Go over the added items row = search.getAvailableRow(); for ( i = 0, ilen = items.length; i < ilen; i++ ) { + + // Check item has just been added + if ( items[ i ].row !== null ) { + continue; + } + itemWidth = items[ i ].$element.outerWidth( true ); // Add items to row until it is full @@ -408,6 +414,7 @@ // Append the item search.rows[ row ].$element.append( items[ i ].$element ); + } // If we have less than 4 rows, call for more images -- 2.20.1