From 53dfc583fc1e8b8abc939f1884331a0e300b0222 Mon Sep 17 00:00:00 2001
From: S Page <spage@wikimedia.org>
Date: Fri, 1 Aug 2014 15:53:46 -0700
Subject: [PATCH] Improve KSS doc for mw-ui-checkbox and input

Improve English, end sentences with a full stop or period, show
placeholder styling in input examples.
Comments only.  `cd docs/kss && make kss && make kssopen` to check.

Change-Id: I61a7c120930b4ba76f9d0e69f36e4ef17db95ac4
---
 .../src/mediawiki.ui/components/checkbox.less |  8 ++++----
 .../src/mediawiki.ui/components/inputs.less   | 20 +++++++++----------
 2 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/resources/src/mediawiki.ui/components/checkbox.less b/resources/src/mediawiki.ui/components/checkbox.less
index eced8cfa24..6d6fdde642 100644
--- a/resources/src/mediawiki.ui/components/checkbox.less
+++ b/resources/src/mediawiki.ui/components/checkbox.less
@@ -3,10 +3,10 @@
 // Checkbox
 //
 // Styling checkboxes in a way that works cross browser is a tricky problem to solve.
-// In MediaWiki UI we wrap a checkbox and label inside mw-ui-checkbox
-// This renders in all browsers except IE6-8 which do not support the :checked selector
-// these are kept backwards compatible using the :not(#noop) selector
-// Ensure to markup the checkbox and label with id and for attributes respectively
+// In MediaWiki UI put a checkbox and label inside a mw-ui-checkbox div.
+// This renders in all browsers except IE6-8 which do not support the :checked selector;
+// these are kept backwards-compatible using the :not(#noop) selector.
+// You should give the checkbox and label matching "id" and "for" attributes, respectively.
 //
 // Markup:
 // <div class="mw-ui-checkbox">
diff --git a/resources/src/mediawiki.ui/components/inputs.less b/resources/src/mediawiki.ui/components/inputs.less
index 25dba78b9d..41707aa1f4 100644
--- a/resources/src/mediawiki.ui/components/inputs.less
+++ b/resources/src/mediawiki.ui/components/inputs.less
@@ -11,7 +11,7 @@
 }
 // Inputs
 //
-// When using an input or textarea apply the mw-ui-input class.
+// Apply the mw-ui-input class to input and textarea fields.
 //
 // Styleguide 1.
 
@@ -22,8 +22,8 @@
 // When focused a progressive highlight appears to the left of the field.
 //
 // Markup:
-// <input value="input" class="mw-ui-input" value="input">
-// <textarea class="mw-ui-input">textarea</textarea>
+// <input class="mw-ui-input" placeholder="Enter your name">
+// <textarea class="mw-ui-input">Text here</textarea>
 //
 // Styleguide 1.1.
 .mw-ui-input {
@@ -72,7 +72,7 @@ textarea.mw-ui-input {
 // Use mw-ui-input-inline with mw-ui-input in cases where you want a button to line up with the input.
 //
 // Markup:
-// <input value="input" class="mw-ui-input mw-ui-input-inline" value="input">
+// <input class="mw-ui-input mw-ui-input-inline">
 // <button class="mw-ui-button mw-ui-constructive">go</button>
 //
 // Styleguide 1.2.
@@ -84,14 +84,14 @@ textarea.mw-ui-input {
 // mw-ui-input-large
 //
 // Use mw-ui-input-large with mw-ui-input in cases where there are multiple inputs on a screen and you
-// want to draw more attention to one instance. For example add topic / reply to post forms.
-// Currently in draft status and subject to change. When used on an input, the text is styled
-// in a large font. When used alongside another mw-ui-input large they are pushed together to seem like
-// one contiguous input.
+// want to draw attention to one instance. For example, replying with a subject line and more text.
+// Currently in draft status and subject to change. When used on an input field, the text is styled
+// in a large font. When used alongside another mw-ui-input large they are pushed together to form one
+// contiguous block.
 //
 // Markup:
-// <input value="input" class="mw-ui-input mw-ui-input-large" value="input">
-// <textarea class="mw-ui-input mw-ui-input-large">textarea</textarea>
+// <input value="input" class="mw-ui-input mw-ui-input-large" value="input" placeholder="Enter subject">
+// <textarea class="mw-ui-input mw-ui-input-large" placeholder="Provide additional details"></textarea>
 //
 // Styleguide 1.3.
 .mw-ui-input-large {
-- 
2.20.1