From 524e62463738c5a31a4c6c8d32fc2fdcd6c5aa74 Mon Sep 17 00:00:00 2001 From: Chad Horohoe Date: Mon, 21 Nov 2016 13:47:09 -0800 Subject: [PATCH] Exception renderer: Remove useless check for isCommandLine() If we're on the cli, we would've never hit this else block Change-Id: Idff009ab255b1907f752e0c6b5652715923b0ed7 --- includes/exception/MWExceptionRenderer.php | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/includes/exception/MWExceptionRenderer.php b/includes/exception/MWExceptionRenderer.php index 8fdc417c1e..f713115c55 100644 --- a/includes/exception/MWExceptionRenderer.php +++ b/includes/exception/MWExceptionRenderer.php @@ -74,11 +74,7 @@ class MWExceptionRenderer { $message = MWExceptionHandler::getPublicLogMessage( $e ); } } - if ( self::isCommandLine() ) { - self::printError( $message ); - } else { - echo nl2br( htmlspecialchars( $message ) ) . "\n"; - } + echo nl2br( htmlspecialchars( $message ) ) . "\n"; } } -- 2.20.1