From 34abcda0c1c73fdd234ada7484c47990285aad56 Mon Sep 17 00:00:00 2001 From: Thiemo Kreuz Date: Tue, 19 Feb 2019 15:31:45 +0100 Subject: [PATCH] pagers: Remove unused "form" properties from two pagers I used https://codesearch.wmflabs.org/search/?q=BlockListPager https://codesearch.wmflabs.org/search/?q=ProtectedPagesPager to make sure no subclass of these two classes exist, as well as no other code that uses them in the first place. I would like to argue that this does not need a deprecation phase. Change-Id: If66f2378bc88adb5e8a6df5e637714be135dfafd --- includes/specials/pagers/BlockListPager.php | 2 -- includes/specials/pagers/ProtectedPagesPager.php | 3 +-- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/includes/specials/pagers/BlockListPager.php b/includes/specials/pagers/BlockListPager.php index 69dce53cb6..2fc946efe0 100644 --- a/includes/specials/pagers/BlockListPager.php +++ b/includes/specials/pagers/BlockListPager.php @@ -32,7 +32,6 @@ use Wikimedia\Rdbms\IResultWrapper; class BlockListPager extends TablePager { protected $conds; - protected $page; /** * Array of restrictions. @@ -46,7 +45,6 @@ class BlockListPager extends TablePager { * @param array $conds */ public function __construct( $page, $conds ) { - $this->page = $page; $this->conds = $conds; $this->mDefaultDirection = IndexPager::DIR_DESCENDING; parent::__construct( $page->getContext() ); diff --git a/includes/specials/pagers/ProtectedPagesPager.php b/includes/specials/pagers/ProtectedPagesPager.php index fbe69c4549..bc4202e2af 100644 --- a/includes/specials/pagers/ProtectedPagesPager.php +++ b/includes/specials/pagers/ProtectedPagesPager.php @@ -23,7 +23,7 @@ use MediaWiki\Linker\LinkRenderer; class ProtectedPagesPager extends TablePager { - public $mForm, $mConds; + public $mConds; private $type, $level, $namespace, $sizetype, $size, $indefonly, $cascadeonly, $noredirect; /** @@ -48,7 +48,6 @@ class ProtectedPagesPager extends TablePager { $sizetype, $size, $indefonly, $cascadeonly, $noredirect, LinkRenderer $linkRenderer ) { - $this->mForm = $form; $this->mConds = $conds; $this->type = ( $type ) ? $type : 'edit'; $this->level = $level; -- 2.20.1