From 2ba42f237449780ab61071132155f7649d723bbb Mon Sep 17 00:00:00 2001 From: =?utf8?q?Gerg=C5=91=20Tisza?= Date: Fri, 26 Jul 2019 19:51:26 +0200 Subject: [PATCH] QueryPage: allow arbitrary sorting When the value field is not provided in QueryPage::getQueryInfo, it is set to zero, essentially randomizing the result. Use a sequential index instead. Change-Id: I8b67268e3c59a51ed00bd832f80df184dd771c3b --- includes/specialpage/QueryPage.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/specialpage/QueryPage.php b/includes/specialpage/QueryPage.php index eb179bf310..223f799cb1 100644 --- a/includes/specialpage/QueryPage.php +++ b/includes/specialpage/QueryPage.php @@ -312,7 +312,7 @@ abstract class QueryPage extends SpecialPage { $num = $res->numRows(); # Fetch results $vals = []; - foreach ( $res as $row ) { + foreach ( $res as $i => $row ) { if ( isset( $row->value ) ) { if ( $this->usesTimestamps() ) { $value = wfTimestamp( TS_UNIX, @@ -321,7 +321,7 @@ abstract class QueryPage extends SpecialPage { $value = intval( $row->value ); // T16414 } } else { - $value = 0; + $value = $i; } $vals[] = [ -- 2.20.1