From 29c6ce7a9e3e78c9a93312a6284993c0d5916b40 Mon Sep 17 00:00:00 2001 From: Max Semenik Date: Fri, 23 Feb 2018 17:41:20 -0800 Subject: [PATCH] Don't suggest using extract() Especially for things as trivial as this. Bug: T28496 Change-Id: Id4bc7f0e6411e943dff45e45964c08d44e6ccb96 --- includes/libs/rdbms/database/IMaintainableDatabase.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/libs/rdbms/database/IMaintainableDatabase.php b/includes/libs/rdbms/database/IMaintainableDatabase.php index 66012dae43..d0c398e3e8 100644 --- a/includes/libs/rdbms/database/IMaintainableDatabase.php +++ b/includes/libs/rdbms/database/IMaintainableDatabase.php @@ -62,8 +62,8 @@ interface IMaintainableDatabase extends IDatabase { * This is handy when you need to construct SQL for joins * * Example: - * extract( $dbr->tableNames( 'user', 'watchlist' ) ); - * $sql = "SELECT wl_namespace,wl_title FROM $watchlist,$user + * list( $user, $watchlist ) = $dbr->tableNames( 'user', 'watchlist' ) ); + * $sql = "SELECT wl_namespace, wl_title FROM $watchlist, $user * WHERE wl_user=user_id AND wl_user=$nameWithQuotes"; * * @return array -- 2.20.1