From 1e0f30c724ba8d4c06c1ab6fe2a2cac9479bdfe7 Mon Sep 17 00:00:00 2001 From: Chad Horohoe Date: Thu, 12 Jun 2008 14:46:11 +0000 Subject: [PATCH] Clean up a bit of a mess with jsMsg(). Should be much more functional now and accept all types. --- skins/common/wikibits.js | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/skins/common/wikibits.js b/skins/common/wikibits.js index 72f0996bd3..373c8eedb4 100644 --- a/skins/common/wikibits.js +++ b/skins/common/wikibits.js @@ -810,16 +810,15 @@ function jsMsg( message, className ) { if( className ) { messageDiv.setAttribute( 'class', 'mw-js-message-'+className ); } - messageDiv.innerHTML = message; - if (typeof message == 'string') { - messageDiv.innerHTML = message; - } - else if (typeof message == 'object') { + if (typeof message === 'object') { while (messageDiv.hasChildNodes()) // Remove old content messageDiv.removeChild(messageDiv.firstChild); messageDiv.appendChild (message); // Append new content } + else { + messageDiv.innerHTML = message; + } return true; } -- 2.20.1