From 17c2f17e361051737ac9a820fc5b82840b029fd8 Mon Sep 17 00:00:00 2001
From: Fomafix <fomafix@googlemail.com>
Date: Tue, 2 Apr 2019 12:21:06 +0200
Subject: [PATCH] protect.js: Simplify by removing object ProtectionForm

Change-Id: If7060c41c9b904e174a34dfc7ea2c053ecc1c3fc
---
 resources/src/mediawiki.legacy/protect.js | 482 +++++++++++-----------
 1 file changed, 240 insertions(+), 242 deletions(-)

diff --git a/resources/src/mediawiki.legacy/protect.js b/resources/src/mediawiki.legacy/protect.js
index 4f89f7c49f..18f1c38cb2 100644
--- a/resources/src/mediawiki.legacy/protect.js
+++ b/resources/src/mediawiki.legacy/protect.js
@@ -1,255 +1,253 @@
+/* eslint-disable no-use-before-define */
 ( function () {
-	var ProtectionForm,
-		config = require( './config.json' ),
+	var config = require( './config.json' ),
 		reasonCodePointLimit = mw.config.get( 'wgCommentCodePointLimit' ),
 		reasonByteLimit = mw.config.get( 'wgCommentByteLimit' );
 
-	ProtectionForm = {
-		/**
-		 * Set up the protection chaining interface (i.e. "unlock move permissions" checkbox)
-		 * on the protection form
-		 *
-		 * @return {boolean}
-		 */
-		init: function () {
-			var $cell = $( '<td>' ),
-				$row = $( '<tr>' ).append( $cell );
-
-			if ( !$( '#mwProtectSet' ).length ) {
-				return false;
-			}
-
-			$( 'form#mw-Protect-Form' ).on( 'submit', this.toggleUnchainedInputs.bind( ProtectionForm, true ) );
-			this.getExpirySelectors().each( function () {
-				$( this ).on( 'change', ProtectionForm.updateExpiryList.bind( ProtectionForm, this ) );
-			} );
-			this.getExpiryInputs().each( function () {
-				$( this ).on( 'keyup change', ProtectionForm.updateExpiry.bind( ProtectionForm, this ) );
-			} );
-			this.getLevelSelectors().each( function () {
-				$( this ).on( 'change', ProtectionForm.updateLevels.bind( ProtectionForm, this ) );
-			} );
+	/**
+	 * Set up the protection chaining interface (i.e. "unlock move permissions" checkbox)
+	 * on the protection form
+	 *
+	 * @return {boolean}
+	 */
+	function init() {
+		var $cell = $( '<td>' ),
+			$row = $( '<tr>' ).append( $cell );
+
+		if ( !$( '#mwProtectSet' ).length ) {
+			return false;
+		}
 
-			$( '#mwProtectSet > tbody > tr:first' ).after( $row );
-
-			// If there is only one protection type, there is nothing to chain
-			if ( $( '[id ^= mw-protect-table-]' ).length > 1 ) {
-				$cell.append(
-					$( '<input>' )
-						.attr( { id: 'mwProtectUnchained', type: 'checkbox' } )
-						.on( 'click', this.onChainClick.bind( this ) )
-						.prop( 'checked', !this.areAllTypesMatching() ),
-					document.createTextNode( ' ' ),
-					$( '<label>' )
-						.attr( 'for', 'mwProtectUnchained' )
-						.text( mw.msg( 'protect-unchain-permissions' ) )
-				);
-
-				this.toggleUnchainedInputs( !this.areAllTypesMatching() );
-			}
+		$( 'form#mw-Protect-Form' ).on( 'submit', toggleUnchainedInputs.bind( this, true ) );
+		getExpirySelectors().each( function () {
+			$( this ).on( 'change', updateExpiryList );
+		} );
+		getExpiryInputs().each( function () {
+			$( this ).on( 'keyup change', updateExpiry );
+		} );
+		getLevelSelectors().each( function () {
+			$( this ).on( 'change', updateLevels );
+		} );
+
+		$( '#mwProtectSet > tbody > tr:first' ).after( $row );
+
+		// If there is only one protection type, there is nothing to chain
+		if ( $( '[id ^= mw-protect-table-]' ).length > 1 ) {
+			$cell.append(
+				$( '<input>' )
+					.attr( { id: 'mwProtectUnchained', type: 'checkbox' } )
+					.on( 'click', onChainClick )
+					.prop( 'checked', !areAllTypesMatching() ),
+				document.createTextNode( ' ' ),
+				$( '<label>' )
+					.attr( 'for', 'mwProtectUnchained' )
+					.text( mw.msg( 'protect-unchain-permissions' ) )
+			);
+
+			toggleUnchainedInputs( !areAllTypesMatching() );
+		}
 
-			// Arbitrary 75 to leave some space for the autogenerated null edit's summary
-			if ( reasonCodePointLimit ) {
-				$( '#mwProtect-reason' ).codePointLimit( reasonCodePointLimit - 75 );
-			} else if ( reasonByteLimit ) {
-				$( '#mwProtect-reason' ).byteLimit( reasonByteLimit - 75 );
-			}
+		// Arbitrary 75 to leave some space for the autogenerated null edit's summary
+		if ( reasonCodePointLimit ) {
+			$( '#mwProtect-reason' ).codePointLimit( reasonCodePointLimit - 75 );
+		} else if ( reasonByteLimit ) {
+			$( '#mwProtect-reason' ).byteLimit( reasonByteLimit - 75 );
+		}
 
-			this.updateCascadeCheckbox();
-			return true;
-		},
-
-		/**
-		 * Sets the disabled attribute on the cascade checkbox depending on the current selected levels
-		 */
-		updateCascadeCheckbox: function () {
-			this.getLevelSelectors().each( function () {
-				if ( !ProtectionForm.isCascadeableLevel( $( this ).val() ) ) {
-					$( '#mwProtect-cascade' ).prop( { checked: false, disabled: true } );
-					return false;
-				} else {
-					$( '#mwProtect-cascade' ).prop( 'disabled', false );
-				}
-			} );
-		},
-
-		/**
-		 * Checks if a certain protection level is cascadeable.
-		 *
-		 * @param {string} level
-		 * @return {boolean}
-		 */
-		isCascadeableLevel: function ( level ) {
-			return config.CascadingRestrictionLevels.indexOf( level ) !== -1;
-		},
-
-		/**
-		 * When protection levels are locked together, update the rest
-		 * when one action's level changes
-		 *
-		 * @param {Element} source Level selector that changed
-		 */
-		updateLevels: function ( source ) {
-			if ( !this.isUnchained() ) {
-				this.setAllSelectors( source.selectedIndex );
-			}
-			this.updateCascadeCheckbox();
-		},
-
-		/**
-		 * When protection levels are locked together, update the
-		 * expiries when one changes
-		 *
-		 * @param {Element} source expiry input that changed
-		 */
-
-		updateExpiry: function ( source ) {
-			if ( !this.isUnchained() ) {
-				this.getExpiryInputs().each( function () {
-					this.value = source.value;
-				} );
-			}
-			if ( this.isUnchained() ) {
-				$( '#' + source.id.replace( /^mwProtect-(\w+)-expires$/, 'mwProtectExpirySelection-$1' ) ).val( 'othertime' );
+		updateCascadeCheckbox();
+		return true;
+	}
+
+	/**
+	 * Sets the disabled attribute on the cascade checkbox depending on the current selected levels
+	 */
+	function updateCascadeCheckbox() {
+		getLevelSelectors().each( function () {
+			if ( !isCascadeableLevel( $( this ).val() ) ) {
+				$( '#mwProtect-cascade' ).prop( { checked: false, disabled: true } );
+				return false;
 			} else {
-				this.getExpirySelectors().each( function () {
-					this.value = 'othertime';
-				} );
-			}
-		},
-
-		/**
-		 * When protection levels are locked together, update the
-		 * expiry lists when one changes and clear the custom inputs
-		 *
-		 * @param {Element} source Expiry selector that changed
-		 */
-		updateExpiryList: function ( source ) {
-			if ( !this.isUnchained() ) {
-				this.getExpirySelectors().each( function () {
-					this.value = source.value;
-				} );
-				this.getExpiryInputs().each( function () {
-					this.value = '';
-				} );
+				$( '#mwProtect-cascade' ).prop( 'disabled', false );
 			}
-		},
-
-		/**
-		 * Update chain status and enable/disable various bits of the UI
-		 * when the user changes the "unlock move permissions" checkbox
-		 */
-		onChainClick: function () {
-			this.toggleUnchainedInputs( this.isUnchained() );
-			if ( !this.isUnchained() ) {
-				this.setAllSelectors( this.getMaxLevel() );
-			}
-			this.updateCascadeCheckbox();
-		},
-
-		/**
-		 * Returns true if the named attribute in all objects in the given array are matching
-		 *
-		 * @param {Object[]} objects
-		 * @param {string} attrName
-		 * @return {boolean}
-		 */
-		matchAttribute: function ( objects, attrName ) {
-			// eslint-disable-next-line no-jquery/no-map-util
-			return $.map( objects, function ( object ) {
-				return object[ attrName ];
-			} ).filter( function ( item, index, a ) {
-				return index === a.indexOf( item );
-			} ).length === 1;
-		},
-
-		/**
-		 * Are all actions protected at the same level, with the same expiry time?
-		 *
-		 * @return {boolean}
-		 */
-		areAllTypesMatching: function () {
-			return this.matchAttribute( this.getLevelSelectors(), 'selectedIndex' ) &&
-				this.matchAttribute( this.getExpirySelectors(), 'selectedIndex' ) &&
-				this.matchAttribute( this.getExpiryInputs(), 'value' );
-		},
-
-		/**
-		 * Is protection chaining off?
-		 *
-		 * @return {boolean}
-		 */
-		isUnchained: function () {
-			var element = document.getElementById( 'mwProtectUnchained' );
-			return element ?
-				element.checked :
-				true; // No control, so we need to let the user set both levels
-		},
-
-		/**
-		 * Find the highest protection level in any selector
-		 *
-		 * @return {number}
-		 */
-		getMaxLevel: function () {
-			return Math.max.apply( Math, this.getLevelSelectors().map( function () {
-				return this.selectedIndex;
-			} ) );
-		},
-
-		/**
-		 * Protect all actions at the specified level
-		 *
-		 * @param {number} index Protection level
-		 */
-		setAllSelectors: function ( index ) {
-			this.getLevelSelectors().each( function () {
-				this.selectedIndex = index;
+		} );
+	}
+
+	/**
+	 * Checks if a certain protection level is cascadeable.
+	 *
+	 * @param {string} level
+	 * @return {boolean}
+	 */
+	function isCascadeableLevel( level ) {
+		return config.CascadingRestrictionLevels.indexOf( level ) !== -1;
+	}
+
+	/**
+	 * When protection levels are locked together, update the rest
+	 * when one action's level changes
+	 *
+	 * @param {Event} event Level selector that changed
+	 */
+	function updateLevels( event ) {
+		if ( !isUnchained() ) {
+			setAllSelectors( event.target.selectedIndex );
+		}
+		updateCascadeCheckbox();
+	}
+
+	/**
+	 * When protection levels are locked together, update the
+	 * expiries when one changes
+	 *
+	 * @param {Event} event Expiry input that changed
+	 */
+
+	function updateExpiry( event ) {
+		if ( !isUnchained() ) {
+			getExpiryInputs().each( function () {
+				this.value = event.target.value;
 			} );
-		},
-
-		/**
-		 * Get a list of all protection selectors on the page
-		 *
-		 * @return {jQuery}
-		 */
-		getLevelSelectors: function () {
-			return $( 'select[id ^= mwProtect-level-]' );
-		},
-
-		/**
-		 * Get a list of all expiry inputs on the page
-		 *
-		 * @return {jQuery}
-		 */
-		getExpiryInputs: function () {
-			return $( 'input[id ^= mwProtect-][id $= -expires]' );
-		},
-
-		/**
-		 * Get a list of all expiry selector lists on the page
-		 *
-		 * @return {jQuery}
-		 */
-		getExpirySelectors: function () {
-			return $( 'select[id ^= mwProtectExpirySelection-]' );
-		},
-
-		/**
-		 * Enable/disable protection selectors and expiry inputs
-		 *
-		 * @param {boolean} val Enable?
-		 */
-		toggleUnchainedInputs: function ( val ) {
-			var setDisabled = function () {
-				this.disabled = !val;
-			};
-			this.getLevelSelectors().slice( 1 ).each( setDisabled );
-			this.getExpiryInputs().slice( 1 ).each( setDisabled );
-			this.getExpirySelectors().slice( 1 ).each( setDisabled );
 		}
-	};
-
-	$( ProtectionForm.init.bind( ProtectionForm ) );
+		if ( isUnchained() ) {
+			$( '#' + event.target.id.replace( /^mwProtect-(\w+)-expires$/, 'mwProtectExpirySelection-$1' ) ).val( 'othertime' );
+		} else {
+			getExpirySelectors().each( function () {
+				this.value = 'othertime';
+			} );
+		}
+	}
+
+	/**
+	 * When protection levels are locked together, update the
+	 * expiry lists when one changes and clear the custom inputs
+	 *
+	 * @param {Event} event Expiry selector that changed
+	 */
+	function updateExpiryList( event ) {
+		if ( !isUnchained() ) {
+			getExpirySelectors().each( function () {
+				this.value = event.target.value;
+			} );
+			getExpiryInputs().each( function () {
+				this.value = '';
+			} );
+		}
+	}
+
+	/**
+	 * Update chain status and enable/disable various bits of the UI
+	 * when the user changes the "unlock move permissions" checkbox
+	 */
+	function onChainClick() {
+		toggleUnchainedInputs( isUnchained() );
+		if ( !isUnchained() ) {
+			setAllSelectors( getMaxLevel() );
+		}
+		updateCascadeCheckbox();
+	}
+
+	/**
+	 * Returns true if the named attribute in all objects in the given array are matching
+	 *
+	 * @param {Object[]} objects
+	 * @param {string} attrName
+	 * @return {boolean}
+	 */
+	function matchAttribute( objects, attrName ) {
+		// eslint-disable-next-line no-jquery/no-map-util
+		return $.map( objects, function ( object ) {
+			return object[ attrName ];
+		} ).filter( function ( item, index, a ) {
+			return index === a.indexOf( item );
+		} ).length === 1;
+	}
+
+	/**
+	 * Are all actions protected at the same level, with the same expiry time?
+	 *
+	 * @return {boolean}
+	 */
+	function areAllTypesMatching() {
+		return matchAttribute( getLevelSelectors(), 'selectedIndex' ) &&
+			matchAttribute( getExpirySelectors(), 'selectedIndex' ) &&
+			matchAttribute( getExpiryInputs(), 'value' );
+	}
+
+	/**
+	 * Is protection chaining off?
+	 *
+	 * @return {boolean}
+	 */
+	function isUnchained() {
+		var element = document.getElementById( 'mwProtectUnchained' );
+		return element ?
+			element.checked :
+			true; // No control, so we need to let the user set both levels
+	}
+
+	/**
+	 * Find the highest protection level in any selector
+	 *
+	 * @return {number}
+	 */
+	function getMaxLevel() {
+		return Math.max.apply( Math, getLevelSelectors().map( function () {
+			return this.selectedIndex;
+		} ) );
+	}
+
+	/**
+	 * Protect all actions at the specified level
+	 *
+	 * @param {number} index Protection level
+	 */
+	function setAllSelectors( index ) {
+		getLevelSelectors().each( function () {
+			this.selectedIndex = index;
+		} );
+	}
+
+	/**
+	 * Get a list of all protection selectors on the page
+	 *
+	 * @return {jQuery}
+	 */
+	function getLevelSelectors() {
+		return $( 'select[id ^= mwProtect-level-]' );
+	}
+
+	/**
+	 * Get a list of all expiry inputs on the page
+	 *
+	 * @return {jQuery}
+	 */
+	function getExpiryInputs() {
+		return $( 'input[id ^= mwProtect-][id $= -expires]' );
+	}
+
+	/**
+	 * Get a list of all expiry selector lists on the page
+	 *
+	 * @return {jQuery}
+	 */
+	function getExpirySelectors() {
+		return $( 'select[id ^= mwProtectExpirySelection-]' );
+	}
+
+	/**
+	 * Enable/disable protection selectors and expiry inputs
+	 *
+	 * @param {boolean} val Enable?
+	 */
+	function toggleUnchainedInputs( val ) {
+		var setDisabled = function () {
+			this.disabled = !val;
+		};
+		getLevelSelectors().slice( 1 ).each( setDisabled );
+		getExpiryInputs().slice( 1 ).each( setDisabled );
+		getExpirySelectors().slice( 1 ).each( setDisabled );
+	}
+
+	$( init );
 
 }() );
-- 
2.20.1