From 0c2a40487314e9ddccd2255190d82235d40c71e4 Mon Sep 17 00:00:00 2001 From: Umherirrender Date: Tue, 18 Jun 2019 21:40:09 +0200 Subject: [PATCH] Use IDatabase as return type for BotPassword::getDB There is no guarantee that this is a maintenance able connection, but drop, create or alter is also not needed in this case Change-Id: I7dd294b3d28ef8c4e416e826f38ed39f824b2f8f --- includes/user/BotPassword.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/user/BotPassword.php b/includes/user/BotPassword.php index 6db219deec..df5edef2f3 100644 --- a/includes/user/BotPassword.php +++ b/includes/user/BotPassword.php @@ -21,7 +21,7 @@ use MediaWiki\Auth\AuthenticationResponse; use MediaWiki\MediaWikiServices; use MediaWiki\Session\BotPasswordSessionProvider; -use Wikimedia\Rdbms\IMaintainableDatabase; +use Wikimedia\Rdbms\IDatabase; /** * Utility class for bot passwords @@ -71,7 +71,7 @@ class BotPassword implements IDBAccessObject { /** * Get a database connection for the bot passwords database * @param int $db Index of the connection to get, e.g. DB_MASTER or DB_REPLICA. - * @return IMaintainableDatabase + * @return IDatabase */ public static function getDB( $db ) { global $wgBotPasswordsCluster, $wgBotPasswordsDatabase; -- 2.20.1