lhc/web/wiklou.git
10 years agoParserTests: fix `bits` column in uploaded images for test cases.
C. Scott Ananian [Tue, 3 Jun 2014 19:44:53 +0000 (15:44 -0400)]
ParserTests: fix `bits` column in uploaded images for test cases.

When running parser tests on a sqlite3 database, the insertion of the
djvu image before running the test suite will fail because `NULL` is not
a valid value for the `bits` column of the `image` table.  This will
cause the test suite to eventually fail, since {{NUMBEROFFILES}} differs.

Test uploads show that `bits` is usually set to 0 for both SVG and
DJVU uploads, so fix this (in both the standalone test runner and the
phpunit test runner).

Change-Id: I8689a547d34035534723e87c4c2680c4e67245f2

10 years agoMerge "Deprecate Language::getLangObj()"
jenkins-bot [Tue, 3 Jun 2014 21:24:39 +0000 (21:24 +0000)]
Merge "Deprecate Language::getLangObj()"

10 years agoMerge "(bug 56849) Deprecate dangerous edittime-based content update functions"
jenkins-bot [Tue, 3 Jun 2014 21:23:05 +0000 (21:23 +0000)]
Merge "(bug 56849) Deprecate dangerous edittime-based content update functions"

10 years agoMerge "Make "mini" the default alias for "thumb" in German"
jenkins-bot [Tue, 3 Jun 2014 21:22:32 +0000 (21:22 +0000)]
Merge "Make "mini" the default alias for "thumb" in German"

10 years agoDeprecate Language::getLangObj()
Max Semenik [Tue, 3 Jun 2014 18:11:27 +0000 (11:11 -0700)]
Deprecate Language::getLangObj()

Since it is unused in core and extensions, I'm marking it both
with @deprecated and wfDeprecated().

Change-Id: I3a1bf96b805339e1438fcdd6e0aeb5922e53c4e8

10 years agoMerge "Copy various random files used by tests to tests/phpunit/data"
jenkins-bot [Tue, 3 Jun 2014 21:13:27 +0000 (21:13 +0000)]
Merge "Copy various random files used by tests to tests/phpunit/data"

10 years agoMerge "Renamed $ipSet static variable in IP to something better"
jenkins-bot [Tue, 3 Jun 2014 21:11:38 +0000 (21:11 +0000)]
Merge "Renamed $ipSet static variable in IP to something better"

10 years agoCopy various random files used by tests to tests/phpunit/data
Bartosz Dziewoński [Mon, 26 May 2014 09:55:07 +0000 (11:55 +0200)]
Copy various random files used by tests to tests/phpunit/data

The tests currently depend on them never being renamed, which is bad.
(Actual file data in git is de-duplicated automatically AFAIK.)

Change-Id: Id2440326981218f9e7d51541a168db59183fdadf

10 years agoMerge "Disable jQuery Migrate by default (enable via $wgIncludejQueryMigrate)"
jenkins-bot [Tue, 3 Jun 2014 20:41:36 +0000 (20:41 +0000)]
Merge "Disable jQuery Migrate by default (enable via $wgIncludejQueryMigrate)"

10 years agoDisable jQuery Migrate by default (enable via $wgIncludejQueryMigrate)
James D. Forrester [Fri, 16 May 2014 15:04:12 +0000 (16:04 +0100)]
Disable jQuery Migrate by default (enable via $wgIncludejQueryMigrate)

Follows-up e5502d1f and 63c36506.

Per the plan[1], after a few weeks of migration, the jQuery Migrate plugin
will be disabled in MediaWiki core.

The added configuration variable allows sysadmins to continue to use code
that is not yet compatible with jQuery 1.9 and higher (e.g. extensions
and/or gadgets that still use legacy jQuery functionality).

[1] http://www.mail-archive.com/wikitech-l@lists.wikimedia.org/msg75735.html

Bug: 44740
Change-Id: If1c9ab722c7ce025b550b457506dcdf90d3326c3

10 years agoRestructure output of ApiExpandTemplates
Jackmcbarn [Mon, 2 Jun 2014 18:53:38 +0000 (14:53 -0400)]
Restructure output of ApiExpandTemplates

Create a new output format of ApiExpandTemplates and deprecate the old
one.

Change-Id: Id12cbe4aeaa39bea382cf3b78810589bb1c9368f

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 3 Jun 2014 19:28:56 +0000 (19:28 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: I70279ffd1137ec4a7c5627889a5ae24b8f62c904

10 years agoMerge "Add some SVG element namespaces"
jenkins-bot [Tue, 3 Jun 2014 19:07:31 +0000 (19:07 +0000)]
Merge "Add some SVG element namespaces"

10 years agoMerge "Made TransactionProfiler handle interlaced transactions better"
jenkins-bot [Tue, 3 Jun 2014 18:39:50 +0000 (18:39 +0000)]
Merge "Made TransactionProfiler handle interlaced transactions better"

10 years agoMerge "Remove use of strencode() outside Database classes"
jenkins-bot [Tue, 3 Jun 2014 18:37:26 +0000 (18:37 +0000)]
Merge "Remove use of strencode() outside Database classes"

10 years agoRenamed $ipSet static variable in IP to something better
Aaron Schulz [Tue, 3 Jun 2014 17:42:56 +0000 (10:42 -0700)]
Renamed $ipSet static variable in IP to something better

Change-Id: Ie7e049c9b114d2a76e1e8e985c3500bda4bbc0ef

10 years agoFix documentation for Title::getCascadeProtectionSources and others
Brad Jorsch [Tue, 3 Jun 2014 16:52:42 +0000 (12:52 -0400)]
Fix documentation for Title::getCascadeProtectionSources and others

The documentation for Title::getCascadeProtectionSources was rendered
nonsensical in r79682, and somehow several following "documentation
cleanup" revisions failed to notice this while cleaning up this same
documentation string.

Fixing that led to fixing Title::getRestrictions and
Title::getAllRestrictions as well.

Change-Id: I48638e370c01fe5ef8ad7d3ebf7fb9aa4385bad7

10 years agoMerge "Remove redundant filter for negative namespace ids in search preferences"
jenkins-bot [Tue, 3 Jun 2014 16:17:17 +0000 (16:17 +0000)]
Merge "Remove redundant filter for negative namespace ids in search preferences"

10 years agoRemove redundant filter for negative namespace ids in search preferences
Federico Leva [Tue, 3 Jun 2014 11:43:08 +0000 (13:43 +0200)]
Remove redundant filter for negative namespace ids in search preferences

Follows-up 5dc4dc099. MWNamespace::getValidNamespaces() filters these
out already.

Change-Id: Icad951fb9a4c4cb368cd994d1861dc2eff1f4ae0

10 years agoDon't double-parse edit summaries
Jackmcbarn [Tue, 3 Jun 2014 02:16:41 +0000 (22:16 -0400)]
Don't double-parse edit summaries

Fix a bug where edit summaries on permalinks would be parsed twice,
resulting in breakage of links, etc. in them. Follow-up to Ie19adfa5.

Change-Id: I3d7e70bb6d055184d36df35ef2e747ba32ad4ea0

10 years agoUpdate OOjs UI to v0.1.0-pre (6379e76bf5)
James D. Forrester [Tue, 3 Jun 2014 00:52:08 +0000 (17:52 -0700)]
Update OOjs UI to v0.1.0-pre (6379e76bf5)

New changes:
f55ab55 Localisation updates from https://translatewiki.net.
6379e76 Followup 205fa98a8dd3460a: move away from isResolved()/isRejected()

Change-Id: I54fcf6fed97d95358c606a82a6e444f03f9247ad

10 years agoUpdate OOjs UI to v0.1.0-pre (527ad0ee5a)
James D. Forrester [Mon, 2 Jun 2014 19:15:14 +0000 (12:15 -0700)]
Update OOjs UI to v0.1.0-pre (527ad0ee5a)

New changes:
50355d0 Localisation updates from https://translatewiki.net.
8dd3460 Resolve the opened promise after teardown
5153f85 Followup 205fa98a: fix incorrect use of .super

Change-Id: I81986ef0b5b768753ffb3b25ebe41bf648a796d1

10 years agoMerge "Make convertUserOptions.php more self-contained"
jenkins-bot [Mon, 2 Jun 2014 22:50:44 +0000 (22:50 +0000)]
Merge "Make convertUserOptions.php more self-contained"

10 years agoMake "mini" the default alias for "thumb" in German
Thiemo Mättig [Mon, 2 Jun 2014 20:49:51 +0000 (22:49 +0200)]
Make "mini" the default alias for "thumb" in German

It's already "mini" in other languages.

The German Wikipedia community (which is obviously not the only German
one but the biggest) always complained a bit about the previously
used "miniatur". It's German, yes, but error-prone. The solution
was to add "mini". Which made most users happy as far as I can
tell after all these years.

My patch doesn't change anything except for one little detail:
The JavaScript call
mw.config.get( 'wgWikiEditorMagicWords' ).img_thumbnail
which is created in WikiEditorHooks::getMagicWords and used by
the WikiEditor extension will return "mini" instead of "miniatur".

Change-Id: I4e9ad3f2e56e08eaf3006a1af4b1c9746cd55715

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 2 Jun 2014 20:48:50 +0000 (20:48 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: If59db33f98025822dcb2f886599fbc8dae7f2513

10 years agoAdd 'X-Robots-Tag: noindex' header in action=render pages
JuneHyeon Bae [Fri, 23 May 2014 05:04:26 +0000 (14:04 +0900)]
Add 'X-Robots-Tag: noindex' header in action=render pages

Bug: 63891
Change-Id: I297a6269fcab999610bc01755462938c70eb64a1

10 years agoMerge "Correct field used to detect incomplete POST"
jenkins-bot [Mon, 2 Jun 2014 19:55:42 +0000 (19:55 +0000)]
Merge "Correct field used to detect incomplete POST"

10 years agoAdd some SVG element namespaces
csteipp [Mon, 2 Jun 2014 19:16:58 +0000 (12:16 -0700)]
Add some SVG element namespaces

Noticed that we have several old images on commons that use these
namespaces. They seem harmless, so I think we should add them.

Change-Id: Ib80298256c5d4717867eb857d5404a9487fed784

10 years agoRemove use of strencode() outside Database classes
Kevin Israel [Mon, 2 Jun 2014 04:47:10 +0000 (00:47 -0400)]
Remove use of strencode() outside Database classes

Change-Id: Idbc38d8089541e5154b2601297b429f7433fd59e

10 years agoMerge "Sync up with Parsoid parserTests."
jenkins-bot [Mon, 2 Jun 2014 17:26:55 +0000 (17:26 +0000)]
Merge "Sync up with Parsoid parserTests."

10 years agoMerge "Include edit summary in permalink"
jenkins-bot [Mon, 2 Jun 2014 16:53:13 +0000 (16:53 +0000)]
Merge "Include edit summary in permalink"

10 years agoSync up with Parsoid parserTests.
Subramanya Sastry [Mon, 2 Jun 2014 14:52:49 +0000 (09:52 -0500)]
Sync up with Parsoid parserTests.

This now aligns with Parsoid commit 04a4bf2ba42c2ed568ef9e9c4679922f17b464d0

Change-Id: I330c1891efd47a4342474774c39dfc963b0ec13d

10 years agoCorrect doc of WikiImporter::__construct parameter
Adrian Lang [Mon, 2 Jun 2014 10:03:14 +0000 (12:03 +0200)]
Correct doc of WikiImporter::__construct parameter

Change-Id: I0c61bb4f8d1e51f3b58ff99a9c632561dfd5134d

10 years agoMerge "Change message escaping on ImagePage"
jenkins-bot [Mon, 2 Jun 2014 08:19:42 +0000 (08:19 +0000)]
Merge "Change message escaping on ImagePage"

10 years agoRevert "Use square bounding boxes for default-sized thumbnails"
Tim Starling [Mon, 2 Jun 2014 01:18:16 +0000 (01:18 +0000)]
Revert "Use square bounding boxes for default-sized thumbnails"

Reverting for further discussion, due to community complaints at https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_%28technical%29&oldid=611154541#Infobox_Image

This reverts commit 7db55341791cb44ca599b84bea707b05de2f227d.

Change-Id: Ieea6224b2a295b5d65bbd486e30cf0573376c7e9

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 1 Jun 2014 19:31:40 +0000 (19:31 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: If43d75371246e2dc84d864cef6b2263a54196457

10 years agoMerge "Update OOjs UI to v0.1.0-pre (dd888aba5c)"
jenkins-bot [Sun, 1 Jun 2014 05:31:16 +0000 (05:31 +0000)]
Merge "Update OOjs UI to v0.1.0-pre (dd888aba5c)"

10 years agoVector: Fix conflicts of "Actions" dropdown with collapsibleTabs
Bartosz Dziewoński [Sat, 31 May 2014 20:55:40 +0000 (22:55 +0200)]
Vector: Fix conflicts of "Actions" dropdown with collapsibleTabs

Follow-up to I09c8031c.

* Don't override the width of the "Actions" dropdown when collapsing
  tabs. The width was hardcoded to 24px, using the actual width now.
  This only matters when the "Actions" dropdown disappears completely
  (it has no items inside), and then something gets moved inside it
  causing it to reappear.
* Use the same collapsing speed for the dropdown and the tabs.
* Account for the width of the "Actions" dropdown if the expansion
  would hide it. This issue was there before, but was not that
  noticeable because the width of the dropdown was negligible.
  (This required making the calculateTabDistance() function in
  collapsibleTabs part of the public API.)
* Do not collapse if the width of the dropdown would exceed the width
  of the tab we're collapsing. This issue was there before as well,
  but in practice the dropdown was always smaller; this is not
  necessarily the case now, for example in Lithuanian (lt).

Bug: 44591
Change-Id: Id4548ea388fd9f4341dd78bb132c716feb14b137

10 years agoMake convertUserOptions.php more self-contained
Kevin Israel [Sun, 25 May 2014 11:00:13 +0000 (07:00 -0400)]
Make convertUserOptions.php more self-contained

* Moved the code from User::decodeOptions() to the maintenance script,
  the only place it is (indirectly) used.
* Changed the script to insert new rows itself rather than calling
  User::saveSettings(), avoiding bug 63677.
* Removed FOR UPDATE and COMMIT lacking a matching BEGIN.
* Made ORDER BY explicit.
* Removed pointless "Do each user sequentially [...]" comment dating
  back to r48732, in which the script would increment a user's ID
  to get the next one.

Bug: 63677
Change-Id: I86365a7363af3376cc4f55fa528b050b44378656

10 years agodoc: Fix DefaultSettings's assertions about possible extension types
James D. Forrester [Sun, 1 Jun 2014 00:00:01 +0000 (17:00 -0700)]
doc: Fix DefaultSettings's assertions about possible extension types

Change-Id: I79f0b6dab93272682157e2a0dcd727f14f7285e9

10 years agoRemove 'SpecialVersionExtensionTypes' hook, deprecated in 1.17.
Reedy [Sun, 1 Jun 2014 00:08:37 +0000 (01:08 +0100)]
Remove 'SpecialVersionExtensionTypes' hook, deprecated in 1.17.

Change-Id: I98d15e2bbbec2ba754c4754c97a46f32e714398a

10 years agoMerge "Localisation updates from https://translatewiki.net."
Translation updater bot [Sat, 31 May 2014 19:05:03 +0000 (19:05 +0000)]
Merge "Localisation updates from https://translatewiki.net."

10 years agoRelease notes for I09c8031c
Bartosz Dziewoński [Sat, 31 May 2014 18:57:41 +0000 (20:57 +0200)]
Release notes for I09c8031c

Change-Id: I6a3845544ae1b50989f82b5bbe7b55db59130f67

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 31 May 2014 18:55:45 +0000 (18:55 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: Ie45f563b849d231ff6173408dce004374ef18ccb

10 years agoVector: Show a label next to the actions dropdown menu
Bartosz Dziewoński [Sat, 8 Feb 2014 14:48:54 +0000 (15:48 +0100)]
Vector: Show a label next to the actions dropdown menu

The little triangle arrow is not clear enough, as evidenced
by the number of people who don't discover the page moving
functionality hidden in that dropdown.

Before: http://i.imgur.com/g2N3tek.png
After: http://i.imgur.com/nUsqgqe.png

Co-Authored-By: Bartosz Dziewoński <matma.rex@gmail.com>
Co-Authored-By: Isarra <s@zaori.org>
Bug: 44591
Change-Id: I09c8031ccd076228a3c9d720e92e04d40a8d97e8

10 years agoRemove mediawiki.toc dependency on mediawiki.util
Bartosz Dziewoński [Sat, 3 May 2014 13:08:28 +0000 (13:08 +0000)]
Remove mediawiki.toc dependency on mediawiki.util

This reverts commit 1b658bf0729692027f96c022d131c044610dd658,
which was a temporary workaround for Wikimedia deployment
cache issues.

Change-Id: I72ee359e8ce9aef93e50448067edce104014f39f

10 years agoMerge "Avoid using raw sql in SpecialUndelete.php"
jenkins-bot [Sat, 31 May 2014 15:50:48 +0000 (15:50 +0000)]
Merge "Avoid using raw sql in SpecialUndelete.php"

10 years agoDrop support for old skins that don't use head element
Daniel Friesen [Sun, 12 May 2013 08:35:42 +0000 (01:35 -0700)]
Drop support for old skins that don't use head element

These skins have been obsolete since 1.16 and aren't supported well at this point.
This deprecates those skins and begins deprecation of the creation of <head> contents
with only chunks of OutputPage stuff. The entire head should be created by OutputPage.

This also deprecates some old methods responsible for returning raw chunks of html for the head:
* getScript
* getHeadItems

Output of HeadItems is also tweaked. Previously there was no newline added
after each item, now there is. Most of the callers of addHeadItem don't use
their own newline and as a result end up on one line.

Change-Id: I13e25cc8d8fc3aa682f23b019a2fda0e809a5f64

10 years agoChange message escaping on ImagePage
umherirrender [Thu, 29 May 2014 17:23:11 +0000 (19:23 +0200)]
Change message escaping on ImagePage

by Nikerabbit on I2a91f0ef1cf82360da2d17c7dc42633ae3e79100

Change-Id: I96c42974a2bc435abd65e9b1e8daba6cc9669409

10 years agoAvoid using raw sql in SpecialUndelete.php
umherirrender [Tue, 8 Apr 2014 18:18:11 +0000 (20:18 +0200)]
Avoid using raw sql in SpecialUndelete.php

The where part for the ar_timestamp was raw sql.
Refactored to avoid this. Now the IN-List is created by the database
abstraction layer. The addQuotes and implode with comma is done there.
Just the call to Database::timestamp is still needed.

This also avoids a '1 = 1' in sql.

Change-Id: I1deb055a1437ae84fc8a4e8cf2976e18c15bda39

10 years agoUpdate OOjs UI to v0.1.0-pre (dd888aba5c)
Roan Kattouw [Sat, 31 May 2014 04:29:01 +0000 (21:29 -0700)]
Update OOjs UI to v0.1.0-pre (dd888aba5c)

New changes:
205fa98 [BREAKING CHANGE] Window refactor, introduction of Processes

Change-Id: Ia26243f74ecad4931cf455284a037216a8393348

10 years agoRemoved clumsy unused IP::toUnsigned() method
Aaron Schulz [Fri, 16 May 2014 16:47:04 +0000 (09:47 -0700)]
Removed clumsy unused IP::toUnsigned() method

* Also avoid calling ip2long() on invalid addresses in toHex()
* Also use native base_convert() in toHex() for IPv4

Change-Id: I4fe4e1ac3c91edb9812e4c5bd173e4b54e315934

10 years agoUpdate OOjs UI to v0.1.0-pre (0f101c6f5d)
Roan Kattouw [Fri, 30 May 2014 23:23:08 +0000 (16:23 -0700)]
Update OOjs UI to v0.1.0-pre (0f101c6f5d)

New changes:
e86dae9 [BREAKING CHANGE] Emit a single event from confirmation dialog

Change-Id: I305224cad8e7bcb7e48dfc31faafeab8ed8a376c

10 years agoMerge "Update OOjs UI to v0.1.0-pre (469d40c88f)"
jenkins-bot [Fri, 30 May 2014 23:03:59 +0000 (23:03 +0000)]
Merge "Update OOjs UI to v0.1.0-pre (469d40c88f)"

10 years agoMerge "Add category output to ApiExpandTemplates"
jenkins-bot [Fri, 30 May 2014 22:50:28 +0000 (22:50 +0000)]
Merge "Add category output to ApiExpandTemplates"

10 years agoUpdate OOjs UI to v0.1.0-pre (469d40c88f)
Roan Kattouw [Fri, 30 May 2014 22:29:38 +0000 (15:29 -0700)]
Update OOjs UI to v0.1.0-pre (469d40c88f)

New changes:
9af9116 Ignore SelectWidget mouseup events that started outside the widget
28a7ca8 Localisation updates from https://translatewiki.net.
469d40c Localisation updates from https://translatewiki.net.

Change-Id: Ife58c324e39e2ee1b6297e5803fb8dd69445ffab

10 years agoMerge "Don't use isset() to check for null"
jenkins-bot [Fri, 30 May 2014 22:13:18 +0000 (22:13 +0000)]
Merge "Don't use isset() to check for null"

10 years agoMerge "Allow adding Deleted log entries"
jenkins-bot [Fri, 30 May 2014 21:58:54 +0000 (21:58 +0000)]
Merge "Allow adding Deleted log entries"

10 years agoSave advanced search namespace prefs on Special:Search itself
Nemo bis [Tue, 6 May 2014 16:33:04 +0000 (18:33 +0200)]
Save advanced search namespace prefs on Special:Search itself

* Checkbox on own row below power search checkboxes per MatmaRex;
  avoiding a mw-search-ns* id leaves it untouched by All/None JS.
* The option searcheverything is removed: a "shortcut" which is no
  longer necessary now that options can be (un)selected at once
  with All/None buttons on search page itself.
* Require a token for saving: no accidental preferences changes.
* Keep the searchoptions/advancedsearchoptions prefs section in case
  something is using it (no known extension does though); options
  are converted to "api" type so it's empty and hidden by default.
* Add minimal documentation for saveSettings() and friends
  (@todo since 155ddf6de, 2009!).

Bug: 52817
Change-Id: I514cee835988600cc013658049e88a10b670e64a

10 years agoMerge "Fixed fatal in SwiftFileBackend when a bogus HTTP status is given"
jenkins-bot [Fri, 30 May 2014 21:01:02 +0000 (21:01 +0000)]
Merge "Fixed fatal in SwiftFileBackend when a bogus HTTP status is given"

10 years agoFixed fatal in SwiftFileBackend when a bogus HTTP status is given
Aaron Schulz [Fri, 30 May 2014 18:48:14 +0000 (11:48 -0700)]
Fixed fatal in SwiftFileBackend when a bogus HTTP status is given

* Error was "Fatal error: Call to a member function getSize() on a non-object"

Change-Id: Id1a1b1add9daee4402b2ed017b95c9a9f0e08170

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 30 May 2014 18:33:58 +0000 (18:33 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: I2ac98863fc1326e9eae37272a19a7174d80a8822

10 years agoAdd category output to ApiExpandTemplates
Jackmcbarn [Thu, 29 May 2014 17:50:27 +0000 (13:50 -0400)]
Add category output to ApiExpandTemplates

The preprocessor sometimes adds pages to categories itself, which don't
have any representation in the output of ApiExpandTemplates. Because of
this, add a new field containing these categories.

Change-Id: I7ae2eb9daf68e032dcc7a650bd8391d445ee1037

10 years agoAdd PPFrame::isVolatile and PPFrame::setVolatile
Brad Jorsch [Fri, 6 Dec 2013 23:28:09 +0000 (18:28 -0500)]
Add PPFrame::isVolatile and PPFrame::setVolatile

Most wikitext is safe to parse once and then cache for when that same
wikitext is used again, such as for multiple transclusions of the same
template within a page. There are occasions, though, where some piece of
wikitext has side effects and so should not be cached; a prominent
example of such wikitext is the <ref> and <references> tags in Cite.php.

This change adds PPFrame::setVolatile so parser hooks such as <ref> and
<references> can indicate that they have done something that should not
be cached, and PPFrame::isVolatile so that callers of PPFrame::expand
can know when to avoid caching.

Bug: 46815
Bug: 31834
Change-Id: I95b3cf8781cf047cdb63da221cef45f3e7d1632e

10 years agoMerge "Reduce some code duplication"
jenkins-bot [Fri, 30 May 2014 17:48:45 +0000 (17:48 +0000)]
Merge "Reduce some code duplication"

10 years agoRelease notes for Ie32cc54a
Bartosz Dziewoński [Fri, 30 May 2014 17:09:43 +0000 (19:09 +0200)]
Release notes for Ie32cc54a

Change-Id: I93d2dce7705b8855819ba0a816b2dc39fdeb3e38

10 years agoMerge "PostgreSQL: Only rollback when in a transaction"
jenkins-bot [Fri, 30 May 2014 16:27:44 +0000 (16:27 +0000)]
Merge "PostgreSQL: Only rollback when in a transaction"

10 years agoMerge "Fix typo"
jenkins-bot [Fri, 30 May 2014 16:20:43 +0000 (16:20 +0000)]
Merge "Fix typo"

10 years agoPostgreSQL: Only rollback when in a transaction
Jeff [Fri, 30 May 2014 06:42:41 +0000 (23:42 -0700)]
PostgreSQL: Only rollback when in a transaction

SQL errors would issue a rollback, even when it was
not actually in a transactions.  Doing so would cause
another error to be reported.  This could obscure the
original error, particularly during unit tests.

Fix this by not rolling back when not in a transaction.

Bug: 58095
Change-Id: Ib5220e37dd6c364feee6b7f8e7ecbdae2a2e0ba1

10 years agomediawiki.special.unwatchedPages: Use closest() instead of parents()
Timo Tijhof [Fri, 30 May 2014 05:24:27 +0000 (07:24 +0200)]
mediawiki.special.unwatchedPages: Use closest() instead of parents()

Follows-up Ie32cc54abb6f.

While it is unlikely that this item will ever end up being nested
inside another list, it is semantically incorrect and also
quite a bit slower to use parents() here.

parents() collects all ancestors between this node and the <html>
document element (each and every one of the elements in between),
and then, if a selector (e.g. "li") is supplied, it reduces that
set to only <li> elements. This can be more than one if your list
is a nested list (whether a plain sublist, or perhaps many levels
apart, e.g. part of the skin layout or whatever).

This one is slower (traverses all the way up) and creates two
collections (all ancestors, then filtered down).

closest(), as the name implies, always requires a selector and
traverses only up to the first match and then returns.

This one is faster (traverses only once and not all the way).

A 1:1 (closest) vs. a 1:many (parents) relationship.

Change-Id: I1cd9a4638285aeab4b5d538072e598601eb475b6

10 years agoMerge "PostgreSQL: Support table prefixes"
jenkins-bot [Fri, 30 May 2014 02:57:05 +0000 (02:57 +0000)]
Merge "PostgreSQL: Support table prefixes"

10 years agoMerge "Restrict empty-frame cache entries to their parent"
jenkins-bot [Fri, 30 May 2014 01:43:02 +0000 (01:43 +0000)]
Merge "Restrict empty-frame cache entries to their parent"

10 years agoRestrict empty-frame cache entries to their parent
Jackmcbarn [Thu, 29 May 2014 00:54:55 +0000 (20:54 -0400)]
Restrict empty-frame cache entries to their parent

Remove the parser's global $mTplExpandCache, and replace it with an
alternative that is separated by parent frame. This allows the integrity
of the empty-frame expansion cache to be maintained while also allowing
parent frame access.

A page with 3 copies of
http://ja.wikipedia.org/wiki/%E4%B8%AD%E5%A4%AE%E7%B7%9A_(%E9%9F%93%E5%9B%BD)
has the following statistics: Without this change, there are 4625 cache hits
on this page, and a sample of 3 parses took 16.6, 16.9, and 16.8 seconds.
With this change, there are 2588 cache hits, and a sample of 3 parses took
16.7, 16.7, and 17.0 seconds.

Change-Id: I621e9075e0f136ac188a4d2f53418b7cc957408d

10 years agoMerge "jquery.suggestions: Handle CSS ellipsis better for IE"
jenkins-bot [Thu, 29 May 2014 22:24:13 +0000 (22:24 +0000)]
Merge "jquery.suggestions: Handle CSS ellipsis better for IE"

10 years agoPostgreSQL: Support table prefixes
Jeff [Thu, 29 May 2014 06:28:04 +0000 (23:28 -0700)]
PostgreSQL: Support table prefixes

PostgreSQL is usually not used with table name prefixes,
and some of the PostgreSQL-specific code took the
shortcut of not dealing with prefixes.  However, the PHPUnit
tests do force a prefix to be used, exposing this limitation.

Make PostgreSQL code add the prefix to table names being used
in FOR UPDATE OF clause.

This fixes 13 of the 17 PostgreSQL unit tests errors against
git HEAD:

EditPageTest::testAutoMerge with data set #1 ('Elmo', 'one
EditPageTest::testAutoMerge with data set #2 ('Elmo', 'Intro
EditPageTest::testAutoMerge with data set #3 ('Adam', 'one
EditPageTest::testAutoMerge with data set #4 ('Adam', 'one
EditPageTest::testAutoMerge with data set #5 ('Adam', 'Intro
EditPageTest::testAutoMerge with data set #6 ('Berta', 'one
EditPageTest::testAutoMerge with data set #7 ('Berta', 'one
EditPageTest::testAutoMerge with data set #8 ('Berta', 'Intro
WikiPageTest::testDoEdit
WikiPageTest::testDoEditContent
WikiPageTest::testDoRollback
WikiPageTest::testDoRollbackFailureSameContent
WikiPageTest::testExists

The change also applies to 1.22.6 and fixes several unit tests
errors there.

Change-Id: I054690f49e250cadd2dc2a6d9e20dea879d896b6

10 years agoMade TransactionProfiler handle interlaced transactions better
Aaron Schulz [Thu, 29 May 2014 20:08:19 +0000 (13:08 -0700)]
Made TransactionProfiler handle interlaced transactions better

* Previously the list of involved DBs might be incomplete

Change-Id: I75b91d3b9a951169038b40b9cf2f59707ba0c11d

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 29 May 2014 19:25:00 +0000 (19:25 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: I4b2468b880c571df42a99f1a61bc452fc7c66567

10 years agoHide toc caption on print when collapsed
Fomafix [Thu, 29 May 2014 18:40:06 +0000 (18:40 +0000)]
Hide toc caption on print when collapsed

Increase specificity of the CSS selector to re-enable this function.

Bug: 482
Change-Id: I0157884c30e1a0e5624b65aa06b2c5db666dc064

10 years agoMerge "SECURITY: Don't parse usernames as wikitext"
jenkins-bot [Thu, 29 May 2014 17:33:43 +0000 (17:33 +0000)]
Merge "SECURITY: Don't parse usernames as wikitext"

10 years agoMerge "Add hash_equals() fallback and use it"
jenkins-bot [Thu, 29 May 2014 17:29:08 +0000 (17:29 +0000)]
Merge "Add hash_equals() fallback and use it"

10 years agoSECURITY: Don't parse usernames as wikitext
csteipp [Mon, 19 May 2014 19:00:57 +0000 (12:00 -0700)]
SECURITY: Don't parse usernames as wikitext

On Special:PasswordReset, don't parse the username as wikitext since
the wikitext is parsed according to the wiki's configuration (might
include wgRawHtml), and the wiki may be private.

Bug: 65501
Change-Id: Ic3e5d42e1be5acc42ba89ae853c5ecbfec04fa91

10 years agoMerge "Allow media handlers to mark files as expensive"
jenkins-bot [Thu, 29 May 2014 09:02:13 +0000 (09:02 +0000)]
Merge "Allow media handlers to mark files as expensive"

10 years agoMerge "Update OOjs UI to v0.1.0-pre (09b223d279)"
jenkins-bot [Thu, 29 May 2014 01:42:17 +0000 (01:42 +0000)]
Merge "Update OOjs UI to v0.1.0-pre (09b223d279)"

10 years agoMerge "Add border and background styling to the Parsoid styles for images"
jenkins-bot [Thu, 29 May 2014 01:41:09 +0000 (01:41 +0000)]
Merge "Add border and background styling to the Parsoid styles for images"

10 years agoUpdate OOjs UI to v0.1.0-pre (09b223d279)
James D. Forrester [Thu, 29 May 2014 01:37:16 +0000 (18:37 -0700)]
Update OOjs UI to v0.1.0-pre (09b223d279)

New changes:
09b223d StackLayout: Clean up inconsistent event firing and documentation

Change-Id: I1297880400f776bcf73753ef31ae613f0fcb0ad4

10 years agoAdd border and background styling to the Parsoid styles for images
Roan Kattouw [Thu, 29 May 2014 01:32:10 +0000 (18:32 -0700)]
Add border and background styling to the Parsoid styles for images

Without these, framed images aren't actually framed in the Parsoid HTML.

Change-Id: Ie19f1c9b4652562aef1a92de8c52c484c4407c95

10 years agoAdd hash_equals() fallback and use it
Kevin Israel [Sun, 13 Apr 2014 17:11:18 +0000 (13:11 -0400)]
Add hash_equals() fallback and use it

Two classes (User and SpecialRunJobs) currently contain string
equality checks that purport to be timing-attack resistant.

Reduce code duplication by adding and using a fallback for the
hash_equals() function from PHP 5.6 (currently in beta), in a way
addressing the comment "@todo: make a common method for this".

Change-Id: Iece006ec0216edb3fc5fbef7cc6ec00a6d182775

10 years agoMerge "Reorganize commonPrint.css"
jenkins-bot [Wed, 28 May 2014 23:07:50 +0000 (23:07 +0000)]
Merge "Reorganize commonPrint.css"

10 years agoReorganize commonPrint.css
Waldir Pimenta [Mon, 29 Oct 2012 19:14:19 +0000 (19:14 +0000)]
Reorganize commonPrint.css

- Group related rulesets together
- Harmonize comment headers for group rulesets
  and make them more visible for improved navigation

Change-Id: Ie9928e8fe566c3907fcc2b2790f2e0a15ffd0436

10 years agoMerge "Add SelfLinkBeginHook"
jenkins-bot [Wed, 28 May 2014 22:07:37 +0000 (22:07 +0000)]
Merge "Add SelfLinkBeginHook"

10 years agojquery.suggestions: Handle CSS ellipsis better for IE
Bartosz Dziewoński [Sun, 25 May 2014 12:09:10 +0000 (14:09 +0200)]
jquery.suggestions: Handle CSS ellipsis better for IE

IE is not impressed by our puny hacks and still reports the width
"in context of" the position in the document, limited by the width
of ancestor elements.

Let's temporarily apply position: absolute; to the involved elements.
This pulls them out of normal document flow and lets us figure out the
real width at last.

Also wrote a proper comment on why we need this stuff.

Verified that this fixes:
* IE 8
* IE 11

Verified that it doesn't break:
* Firefox 3.6
* Firefox 29
* Opera 12
* Opera 22

It *does not* fix IE 6. I don't think that investigating why is a good
use of my time, so I didn't. I84fbae5a made the functionality usable
on IE 6, which feels good enough for me.

Bug: 65224
Change-Id: I4a7357543ca244585ade2061b92f5a6d1e439278

10 years agoMerge "Skin: Remove dried up remains of Standard/Classic skin"
jenkins-bot [Wed, 28 May 2014 20:58:22 +0000 (20:58 +0000)]
Merge "Skin: Remove dried up remains of Standard/Classic skin"

10 years agoMerge "mediawiki.searchSuggest: Show full article title as a tooltip for each suggestion"
jenkins-bot [Wed, 28 May 2014 20:57:13 +0000 (20:57 +0000)]
Merge "mediawiki.searchSuggest: Show full article title as a tooltip for each suggestion"

10 years agoAllow media handlers to mark files as expensive
Gergő Tisza [Tue, 27 May 2014 20:09:49 +0000 (20:09 +0000)]
Allow media handlers to mark files as expensive

Allows media handlers to signal that thumbnail generation
for this file is expensive and should be throttled more agressively.
For now this is only done for large TIFF files.

Bug: 65691
Change-Id: I01b34a1d46745649f179fdee435a8cfb19c5474e

10 years agoMerge "Adding header font change to release notes for 1.24"
kaldari [Wed, 28 May 2014 20:22:57 +0000 (20:22 +0000)]
Merge "Adding header font change to release notes for 1.24"

10 years agoSkin: Remove dried up remains of Standard/Classic skin
Bartosz Dziewoński [Mon, 26 May 2014 10:27:02 +0000 (12:27 +0200)]
Skin: Remove dried up remains of Standard/Classic skin

Change-Id: I70a35cbe0d17bf8d35bbe04b1254ee0d6ce0accd

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 28 May 2014 19:22:35 +0000 (19:22 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: I4d2d181fa0ccda0dd781008d4ed0e68103de451a

10 years agoMerge "Correctly parse 'redirect' XML tag during Special:Import."
jenkins-bot [Wed, 28 May 2014 18:56:40 +0000 (18:56 +0000)]
Merge "Correctly parse 'redirect' XML tag during Special:Import."

10 years agovector: Add tabindex back to search box
Alex Monk [Sat, 24 May 2014 15:22:01 +0000 (16:22 +0100)]
vector: Add tabindex back to search box

Another regression, this time in Iaea60834. This brings back the
implementation as it was originally before I220057c799bef7e removed it as
part of the collapsibleNav module.

Bug: 29199
Change-Id: I3f29c3d80e43b9df16b397fff3dc983dc60652a7

10 years agoAdded BeforeHttpsRedirect hook allowing extensions to cancel forceHTTPS
Yuri Astrakhan [Mon, 12 May 2014 20:05:00 +0000 (16:05 -0400)]
Added BeforeHttpsRedirect hook allowing extensions to cancel forceHTTPS

For ZERO, we need to be able to avoid forceHTTPS from taking place in
case user logged in while on wifi, and later switched to
zero.wikipedia.org for the carrier who doesn't support HTTPS.
In that case, the extension will need to be able to cancel redirect
and force regular HTTP handling.

Open Question: should this code log off user in case hook returns false?

Bug 65567

Change-Id: If04c83066c5d47b3c04ad7674e3c4e95a4cd464b