lhc/web/wiklou.git
10 years agoMerge "New hook for readonly editpages"
Mwalker [Tue, 15 Apr 2014 18:15:59 +0000 (18:15 +0000)]
Merge "New hook for readonly editpages"

10 years agoMerge "Handle conflicting image format options in predictable way."
jenkins-bot [Tue, 15 Apr 2014 16:50:38 +0000 (16:50 +0000)]
Merge "Handle conflicting image format options in predictable way."

10 years agoSync up with Parsoid parserTests.
C. Scott Ananian [Tue, 15 Apr 2014 16:21:29 +0000 (12:21 -0400)]
Sync up with Parsoid parserTests.

This now aligns with Parsoid commit 207a3ba03b3a4371798c400092b76eb72b7034be

Change-Id: I4bd0ba7a2671104809ad26bc66d38c7e678fa7b6

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 15 Apr 2014 10:40:10 +0000 (10:40 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: I76b17b91656ee62b41e3f59fcd5c73a3372febf8

10 years agoMerge "Fixed some @params documentation"
jenkins-bot [Tue, 15 Apr 2014 07:52:34 +0000 (07:52 +0000)]
Merge "Fixed some @params documentation"

10 years agoNew hook for readonly editpages
Derk-Jan Hartman [Sun, 23 Mar 2014 20:07:39 +0000 (21:07 +0100)]
New hook for readonly editpages

EditPage::showReadOnlyForm:initial which is analogous to
EditPage::showEditForm:initial

Bug: 45258
Change-Id: I6885d617e18562acf0331e8db5790b53b489dbc2

10 years agoMerge "Avoid site outages due to broken job queues"
jenkins-bot [Tue, 15 Apr 2014 01:13:29 +0000 (01:13 +0000)]
Merge "Avoid site outages due to broken job queues"

10 years agoMake profiling to UDP work again
Alexandre Emsenhuber [Mon, 14 Apr 2014 18:44:18 +0000 (20:44 +0200)]
Make profiling to UDP work again

Fix for I1260bab2b5 (afa6af0).

Since $this->mCollated['-total'] is normally always defined,
this would cause no logging to UDP at all.

Change-Id: Ibce1c8662b4b3e99e77723f5377dd654b4f59be1

10 years agoMerge "Update release notes to describe user-visible change to framed images."
jenkins-bot [Mon, 14 Apr 2014 21:16:20 +0000 (21:16 +0000)]
Merge "Update release notes to describe user-visible change to framed images."

10 years agoPrevent GC during phpunit shutdown
csteipp [Wed, 2 Apr 2014 00:28:55 +0000 (17:28 -0700)]
Prevent GC during phpunit shutdown

To keep phpunit from segfaulting during shutdown, turn off GC for
php 5.3.

Bug: 62623
Change-Id: Ie59780e37cbea027cc204a43df406667c3f432ab

10 years agoMerge "Cliinstaller.php docs: Note config-install-extensions is used too"
jenkins-bot [Mon, 14 Apr 2014 21:00:21 +0000 (21:00 +0000)]
Merge "Cliinstaller.php docs: Note config-install-extensions is used too"

10 years agoUpdate release notes to describe user-visible change to framed images.
C. Scott Ananian [Mon, 14 Apr 2014 20:54:53 +0000 (16:54 -0400)]
Update release notes to describe user-visible change to framed images.

Bug: 62258
Change-Id: If69a55cb836c83b530c4da49384e6b7bc77edf0b

10 years agoMerge "ResourceLoader::makeLoaderImplementScript: Bind args as '$' and 'jQuery'"
jenkins-bot [Mon, 14 Apr 2014 20:53:47 +0000 (20:53 +0000)]
Merge "ResourceLoader::makeLoaderImplementScript: Bind args as '$' and 'jQuery'"

10 years agoCliinstaller.php docs: Note config-install-extensions is used too
James D. Forrester [Mon, 14 Apr 2014 20:46:09 +0000 (13:46 -0700)]
Cliinstaller.php docs: Note config-install-extensions is used too

Change-Id: I996c59e32de931d9d58e89ef09ad1dd0fe5199ae

10 years agoMerge "Ignore height as well as width for framed images."
jenkins-bot [Mon, 14 Apr 2014 20:07:58 +0000 (20:07 +0000)]
Merge "Ignore height as well as width for framed images."

10 years agoFixed some @params documentation
umherirrender [Mon, 14 Apr 2014 19:43:18 +0000 (21:43 +0200)]
Fixed some @params documentation

Swapped some "$var type" to "type $var" or added missing types
before the $var. Changed some other types to match the more common
spelling. Makes beginning of some text in captial.

Change-Id: I8c9f30128b46086064326708a4878228ba459447

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 14 Apr 2014 19:34:16 +0000 (19:34 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: I368d861b49bffa749b488d4600198102a42a5bd2

10 years agoRemove jquery.delayedBind module
Bartosz Dziewoński [Sat, 22 Feb 2014 19:21:39 +0000 (20:21 +0100)]
Remove jquery.delayedBind module

As promised, removing the module deprecated in 1.23.

Its test suite was already removed earlier.

Change-Id: Ifc84b09a78007a6a0ea5676b0f12a38937dca2e7

10 years agoMerge "Couple more 1.24 bumps"
jenkins-bot [Mon, 14 Apr 2014 17:12:54 +0000 (17:12 +0000)]
Merge "Couple more 1.24 bumps"

10 years agoMerge "document.createElementNS is null or not an object in IE8"
jenkins-bot [Mon, 14 Apr 2014 17:04:45 +0000 (17:04 +0000)]
Merge "document.createElementNS is null or not an object in IE8"

10 years agoCommit DB changes as normal on exception-based GUI errors
Aaron Schulz [Mon, 3 Mar 2014 21:12:11 +0000 (13:12 -0800)]
Commit DB changes as normal on exception-based GUI errors

Bug: 62091
Change-Id: I36cd645d5f7a939b60f306e5fc093507693b097b

10 years agoProfiler class refactoring
Aaron Schulz [Wed, 9 Apr 2014 22:43:12 +0000 (15:43 -0700)]
Profiler class refactoring

* Merged the "collate at end" and "running collate" logic
  into the base class to make it more unified and consistent.
* Pulled out DB code into ProfilerSimpleDB class.
* Removed the ProfilerSimple class and updated child classes.
* Made ProfilerSimpleTrace set the debug information too.
* Work around "ended by close()" bug from 99aef03f. Since the
  getRawData() method gets called while some wfProfileOut() calls
  have not yet happened, make it use the matched call data and let
  the final logData() method work on the full data as normal.
* Let ProfilerSimple classes use getFunctionReport() for the profiler
  debug log if it is setup instead of making it just return "".
* Made getRawData() work as best as possible with ProfilerMwprof.
* Removed $wgProfileToDatabase since it is now useless.
* Improved DB profile performance with sqlite.
* Updated visibility of various methods.

Change-Id: I1260bab2b5ba12dccbba701bcae4a637cb85c6e8

10 years agoCouple more 1.24 bumps
Reedy [Mon, 14 Apr 2014 16:39:53 +0000 (17:39 +0100)]
Couple more 1.24 bumps

Change-Id: I2cd845750c8dd760c74b17d632c66985999d70bd

10 years agodocument.createElementNS is null or not an object in IE8
umherirrender [Wed, 9 Apr 2014 19:25:00 +0000 (21:25 +0200)]
document.createElementNS is null or not an object in IE8

Having $wgDebugToolbar = true and visiting the wiki with IE8 will give
no debug toolbar, using ?debug=true gives a "document.createElementNS is
null or not an object" javascript fatal.

Throw a error. The function 'createSvgElement' will never be called,
because profiling gives a "An ES5 compatible javascript engine
is required for the profile visualization." in IE8.

Change-Id: I763dae7459cb88f892823b9458ed6dd1dbbf3e9d

10 years agoBump 1.24
Reedy [Mon, 14 Apr 2014 15:36:50 +0000 (16:36 +0100)]
Bump 1.24

Change-Id: Id62526dad82551eab085be612ff4e604ccfc7b23

10 years agoFixed some @params documentation
umherirrender [Thu, 10 Apr 2014 18:50:10 +0000 (20:50 +0200)]
Fixed some @params documentation

Swapped some "$var type" to "type $var" or added missing types
before the $var. Changed some other types to match the more common
spelling. Makes beginning of some text in captial.

Change-Id: I64e8cfe478cb0ba438f40b0631d6e9049cdab567

10 years agoMerge "Cache RecentChanges Atom feed in varnish for 15 seconds"
jenkins-bot [Mon, 14 Apr 2014 12:56:51 +0000 (12:56 +0000)]
Merge "Cache RecentChanges Atom feed in varnish for 15 seconds"

10 years agoCache RecentChanges Atom feed in varnish for 15 seconds
Brian Wolff [Sat, 29 Mar 2014 05:23:14 +0000 (02:23 -0300)]
Cache RecentChanges Atom feed in varnish for 15 seconds

Prior to fc20c30d209, the feed was cached for 10 seconds. That
change accidentally removed varnish caching. Re-add the caching,
and upping to 15 seconds for good measure (15 second delay on the RSS
feed shouldn't matter, people generally read those asynchronously
anyhow. I was thinking of maybe even uping to 30 seconds). Users
can still manually set an smaxage parameter via the url if they
don't like the default cache time.

This assumes nothing private (e.g. per user) is ever on the RSS
feed. Reading through the ChangesList code this appears to be
the case, as everyone is getting the feed from a shared
memcache entry.

Bug: 63249
Change-Id: I268d0a53067738ba96bee74c593358b0b28cc083

10 years agoFix CS double space in TitleValue return
addshore [Mon, 14 Apr 2014 12:43:46 +0000 (13:43 +0100)]
Fix CS double space in TitleValue return

Change-Id: Ib7eb2b070eea9f8b2df860b6d16f9c769be78cf7

10 years agoMerge "ChangesListSpecialPage: Implement two new hooks superseding 4 old ones"
jenkins-bot [Mon, 14 Apr 2014 03:13:53 +0000 (03:13 +0000)]
Merge "ChangesListSpecialPage: Implement two new hooks superseding 4 old ones"

10 years agoNormalise comments in Setup.php
Alexandre Emsenhuber [Sun, 13 Apr 2014 20:07:50 +0000 (22:07 +0200)]
Normalise comments in Setup.php

- Changed "#" to "//" for non-block comments
- Put the inline comment describing the file back
  in the file description

Change-Id: I0aec0f4c10def58b608a8f08455fccb2317e4538

10 years agoMerge "Add columns option to Special:PrefixIndex"
jenkins-bot [Sun, 13 Apr 2014 22:40:58 +0000 (22:40 +0000)]
Merge "Add columns option to Special:PrefixIndex"

10 years agoMerge "PrefixSearch: Remove unnecessary wfSuppressWarnings()"
jenkins-bot [Sun, 13 Apr 2014 22:32:04 +0000 (22:32 +0000)]
Merge "PrefixSearch: Remove unnecessary wfSuppressWarnings()"

10 years agoAdd columns option to Special:PrefixIndex
Daniel De Marco [Mon, 3 Feb 2014 20:00:53 +0000 (15:00 -0500)]
Add columns option to Special:PrefixIndex

Adds support for specifying the number of output columns to use in the
table generated by Special:PrefixIndex. Can be used as follows:

{{Special:PrefixIndex/{{FULLPAGENAME}}/|columns=2}}

Bug: 60759
Change-Id: Ic824351132ec8bf7c35116f6ab19f23386ead33e

10 years agoMerge "Made preloadFileStat/preloadCache actually work for FileBackendMultiWrite"
jenkins-bot [Sun, 13 Apr 2014 22:30:57 +0000 (22:30 +0000)]
Merge "Made preloadFileStat/preloadCache actually work for FileBackendMultiWrite"

10 years agoMerge "Wrap djvu large local copy downloads in pool counter"
jenkins-bot [Sun, 13 Apr 2014 22:30:40 +0000 (22:30 +0000)]
Merge "Wrap djvu large local copy downloads in pool counter"

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 13 Apr 2014 19:11:19 +0000 (19:11 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: Id709503721345cc2a62a4283026303526dce52e9

10 years agoAdd 'messages used' comment
umherirrender [Sun, 13 Apr 2014 15:45:07 +0000 (17:45 +0200)]
Add 'messages used' comment

Change-Id: I69acea2a1f0a1ef6854d2ebddda446f86086633e

10 years agoFormat archive and filearchive revision delete log entries
umherirrender [Sat, 12 Apr 2014 22:08:58 +0000 (00:08 +0200)]
Format archive and filearchive revision delete log entries

DeleteLogFormatter only checks for revision and oldimage, but it is also
possible to delete archived revisions or archived files, so also check
for these types to have better formatted log entries.

Change-Id: I3f8eaa3956e2c7fc216fb4030fe4bab6cb8bbd60

10 years agoMerge "Fix deprecation notice for Skin::getUsableSkins to say 1.23"
jenkins-bot [Sun, 13 Apr 2014 14:06:43 +0000 (14:06 +0000)]
Merge "Fix deprecation notice for Skin::getUsableSkins to say 1.23"

10 years agoFix deprecation notice for Skin::getUsableSkins to say 1.23
Kunal Mehta [Sun, 13 Apr 2014 01:48:42 +0000 (18:48 -0700)]
Fix deprecation notice for Skin::getUsableSkins to say 1.23

Follows-up: I0b0fdfb5615c22aa876882c3ca344ebb1f10c4bd
Change-Id: Iafd03d562ec68edbef2479f8275f8f7a09fdbc7a

10 years agoMerge "mw.hook: Use hasOwnProperty"
jenkins-bot [Sun, 13 Apr 2014 09:08:26 +0000 (09:08 +0000)]
Merge "mw.hook: Use hasOwnProperty"

10 years agoMerge "Fixing bug #63738: Debug msg not showing correctly"
jenkins-bot [Sun, 13 Apr 2014 01:01:32 +0000 (01:01 +0000)]
Merge "Fixing bug #63738: Debug msg not showing correctly"

10 years agoMerge "Rename Skin::getUsableSkins() to Skin::getAllowedSkins()"
jenkins-bot [Sun, 13 Apr 2014 00:30:53 +0000 (00:30 +0000)]
Merge "Rename Skin::getUsableSkins() to Skin::getAllowedSkins()"

10 years agoMade preloadFileStat/preloadCache actually work for FileBackendMultiWrite
Aaron Schulz [Sat, 12 Apr 2014 22:42:34 +0000 (15:42 -0700)]
Made preloadFileStat/preloadCache actually work for FileBackendMultiWrite

* Previously the path substitution did not take place

Change-Id: I58ad3e2aa44a2b08f4c6bad1a783fb92ea79dbf4

10 years agoMerge "Display a warning when the user name looked up is not registered"
jenkins-bot [Sat, 12 Apr 2014 13:14:40 +0000 (13:14 +0000)]
Merge "Display a warning when the user name looked up is not registered"

10 years agoFixing bug #63738: Debug msg not showing correctly
Sergio Santoro [Sat, 12 Apr 2014 12:39:13 +0000 (14:39 +0200)]
Fixing bug #63738: Debug msg not showing correctly

Change-Id: I49d826f63810d99aefa5b842cd3d6b88989ef086

10 years agoDisplay a warning when the user name looked up is not registered
Aditya Sastry [Thu, 10 Apr 2014 21:24:35 +0000 (02:54 +0530)]
Display a warning when the user name looked up is not registered

Changed the SpecialContributions.php and added a warning message to tell the
user that the name he looked up isn't registered.

Bug: 60524
Change-Id: Ie07001e75a9732f727930f8f367bba8feb395b3e

10 years agoMerge "Make .mw-ui-button height the same for all buttons"
jenkins-bot [Sat, 12 Apr 2014 13:01:54 +0000 (13:01 +0000)]
Merge "Make .mw-ui-button height the same for all buttons"

10 years agodoc: Fix errored variadic symbol on mediawiki.action.edit addButtons
James D. Forrester [Fri, 11 Apr 2014 22:55:04 +0000 (15:55 -0700)]
doc: Fix errored variadic symbol on mediawiki.action.edit addButtons

Change-Id: I03734a117eaad7a0a7ab5860885d3bbfb950821d

10 years agoSupport JSDuck v5.x
James D. Forrester [Fri, 11 Apr 2014 22:41:50 +0000 (15:41 -0700)]
Support JSDuck v5.x

Add support to JSDuck v5.x with a new "CustomTags.rb" following the new
format (and with a new name for one of the existing flags). Also works
for JSDuck v4.x as before. The call in maintenance/mwjsduck-gen is now
sync'ed with the call made by Jenkins in the CI environment.

Change-Id: Ie6649a3e39457bde7a0d8bd00da8ea53e76e3085

10 years agoMerge "Update QUnit from v1.11.0 to v1.14.0"
jenkins-bot [Sat, 12 Apr 2014 00:03:47 +0000 (00:03 +0000)]
Merge "Update QUnit from v1.11.0 to v1.14.0"

10 years agoMerge "Update OOjs UI to v0.1.0-pre (eca1fc20e7)"
jenkins-bot [Sat, 12 Apr 2014 00:03:45 +0000 (00:03 +0000)]
Merge "Update OOjs UI to v0.1.0-pre (eca1fc20e7)"

10 years agoMerge "Fix KSS mediawiki.ui style guide (docs)"
jenkins-bot [Sat, 12 Apr 2014 00:01:03 +0000 (00:01 +0000)]
Merge "Fix KSS mediawiki.ui style guide (docs)"

10 years agoMerge "Make DjVu metadata be stored as serialized PHP array."
jenkins-bot [Sat, 12 Apr 2014 00:00:45 +0000 (00:00 +0000)]
Merge "Make DjVu metadata be stored as serialized PHP array."

10 years agoUpdate OOjs UI to v0.1.0-pre (eca1fc20e7)
Roan Kattouw [Fri, 11 Apr 2014 23:48:01 +0000 (16:48 -0700)]
Update OOjs UI to v0.1.0-pre (eca1fc20e7)

New changes:
729c7bb Removing zh-(cn|hk|tw) i18n files, per TWN policy change
d8cdf4d ButtonedElement: Use tabIndex property and "tabindex" attribute
004e9fe doc: Clean up (remove redundant @method and minor fixes)
f7c3dfb Fix styling of list tool group label when disabled
851fc18 Make OO.ui.Element.onDOMEvent/offDOMEvent static
d7cbc78 Prevent iframe windows from wiping parent document selection
eca1fc2 Fix jsduck errors

Change-Id: Id192cceab0c78ea63f2f6ae232760da8951bafae

10 years agoUpdate QUnit from v1.11.0 to v1.14.0
Timo Tijhof [Fri, 11 Apr 2014 23:15:20 +0000 (16:15 -0700)]
Update QUnit from v1.11.0 to v1.14.0

Code:
 http://code.jquery.com/qunit/qunit-1.14.0.js
 http://code.jquery.com/qunit/qunit-1.14.0.css

Release notes:
 https://github.com/jquery/qunit/blob/v1.14.0/History.md

Notable changes for us:
* v1.12.0:
  - Use a local setTimeout reference.
* v1.13.0:
  - assert: Remove Assert.raises (deprecated in 2012)
* v1.14.0:
  - core: Cache window.clearTimeout in case it gets mocked

Change-Id: Ibf4b7ef11553555ef3c3827a6360fd405446b8f1

10 years agoWrap djvu large local copy downloads in pool counter
Aaron Schulz [Fri, 11 Apr 2014 23:05:12 +0000 (16:05 -0700)]
Wrap djvu large local copy downloads in pool counter

Change-Id: I3cade9d870f7c344434d7cee27506d53345ebdf9

10 years agoRevert "Work around HHVM bug with stdin/stdout in proc_open()"
Aaron Schulz [Fri, 11 Apr 2014 18:39:10 +0000 (11:39 -0700)]
Revert "Work around HHVM bug with stdin/stdout in proc_open()"

This was fixed in HHVM (https://github.com/facebook/hhvm/issues/1247).

This reverts commit 52e546640c5c0c0e817ae1fc5451a934b2c34de9.

bug: 56597
Change-Id: I9c97ba5645d794ff562347979e3f2027eb8b4534

10 years agoAvoid site outages due to broken job queues
Aaron Schulz [Fri, 11 Apr 2014 22:00:12 +0000 (15:00 -0700)]
Avoid site outages due to broken job queues

Change-Id: I71f1bef886850679812e23b8a49fc9b80d9b6102

10 years agoMake DjVu metadata be stored as serialized PHP array.
Brian Wolff [Thu, 5 Dec 2013 23:50:17 +0000 (19:50 -0400)]
Make DjVu metadata be stored as serialized PHP array.

Previously metadata was stored as a string of XML. Some of the
code in File expects the metadata to be an array serialized using
PHP's serialization format. In particular, this fixes the api
query=imageinfo module, and by extension instantCommons.

This supersedes Icaa16eeb

Bug: 37764
Change-Id: I5c1d2d2434f70b57137837bade797d4133c47b70

10 years agoPrefixSearch: Remove unnecessary wfSuppressWarnings()
Bartosz Dziewoński [Fri, 11 Apr 2014 21:42:45 +0000 (23:42 +0200)]
PrefixSearch: Remove unnecessary wfSuppressWarnings()

It was added in 4492854f (r68563), where the code this was suppressing
warnings for was something rather different. It doesn't seem necessary now.

Change-Id: Ia501afd1244b94563fe52294945798963f8db1a9

10 years agoMake .mw-ui-button height the same for all buttons
Juliusz Gonera [Wed, 5 Mar 2014 23:27:51 +0000 (15:27 -0800)]
Make .mw-ui-button height the same for all buttons

Regardless of their background color.

Change-Id: I00f905690e2934e972cc4ffc26631ead7c2d7567

10 years agoFix KSS mediawiki.ui style guide (docs)
Juliusz Gonera [Fri, 11 Apr 2014 21:24:42 +0000 (14:24 -0700)]
Fix KSS mediawiki.ui style guide (docs)

Broken after a change in directory structure...

Change-Id: Ibe208302c30483ee9476a176efe8dd88b21d30a5

10 years agoChangesListSpecialPage: Implement two new hooks superseding 4 old ones
Bartosz Dziewoński [Wed, 8 Jan 2014 17:17:08 +0000 (18:17 +0100)]
ChangesListSpecialPage: Implement two new hooks superseding 4 old ones

Old hooks (called by SpecialWatchlist, SpecialRecentChanges and
SpecialRecentChangesLinked) have been deprecated, but I'm not planning
to remove them anytime soon. (They have lots of usages in extensions
as of this writing.)

The new hooks (and their deprecated friends) are:

* ChangesListSpecialPageFilters:
  * Replaces: SpecialRecentChangesFilters and SpecialWatchlistFilters
  * The signature for this one is exactly the same as signatures for
    the other two. We might want to pass something else than $this
    here…

* ChangesListSpecialPageQuery
  * Replaces: SpecialRecentChangesQuery and SpecialWatchlistQuery
  * These hooks have wildly different signatures. The new one is a
    superset of the old ones, in a more reasonable order, with the
    addition of the name of the special page we're doing right now.

Change-Id: I9cceda5d2dcfc53c852c5682c466b48ad8f31202

10 years agoMerge "qunit: Remove race condition in 'test.mediawiki.qunit.testrunner'"
jenkins-bot [Fri, 11 Apr 2014 20:31:13 +0000 (20:31 +0000)]
Merge "qunit: Remove race condition in 'test.mediawiki.qunit.testrunner'"

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 11 Apr 2014 19:45:14 +0000 (19:45 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: Idaec9e5cc1c68c224d2a6f05834be4eabd88b4ae

10 years agoMerge "IEFixes: Remove relativeforfloats() as it doesn't work"
jenkins-bot [Fri, 11 Apr 2014 19:28:07 +0000 (19:28 +0000)]
Merge "IEFixes: Remove relativeforfloats() as it doesn't work"

10 years agoMerge "IEFixes: Clean up duplicate variables"
jenkins-bot [Fri, 11 Apr 2014 19:20:18 +0000 (19:20 +0000)]
Merge "IEFixes: Clean up duplicate variables"

10 years agoMerge "Revert font stack to be just sans-serif"
Bartosz Dziewoński [Fri, 11 Apr 2014 18:41:50 +0000 (18:41 +0000)]
Merge "Revert font stack to be just sans-serif"

10 years agoqunit: Remove race condition in 'test.mediawiki.qunit.testrunner'
Timo Tijhof [Fri, 11 Apr 2014 18:40:52 +0000 (11:40 -0700)]
qunit: Remove race condition in 'test.mediawiki.qunit.testrunner'

Tests should be atomic because when re-running failed tests, they
run out of order (by design).

The thing being asserted here wasn't all that useful as that is
upstream behaviour we ought to be able to rely on.

Change-Id: I2f006e1cf05f5535e8220ca8ffc2da603745d184

10 years agoIEFixes: Remove relativeforfloats() as it doesn't work
Timo Tijhof [Thu, 10 Apr 2014 18:44:59 +0000 (11:44 -0700)]
IEFixes: Remove relativeforfloats() as it doesn't work

This is intended for IE6 where there is supposedly a bug with elements
that have inline 'style="float: left/right;"' which would
need position:relative as fix-up.

Aside from that bug being questionable, the way it was implemented
doesn't actually work in IE6 (or any version of IE for that matter).

The CSSOM property for 'float' is 'Node.style.cssFloat', and in
old versions of IE (including IE6) it was 'Node.style.styleFloat',
but it was never 'Node.style.float'.

Confirmed in browserstack with Windows XP/IE6, an element like
<div style="float: left;"></div> has .cssFloat, .float does not
exist and this code does nothing.

When testing I used style['float'] to ensure this isn't just broken
because of reserved words in property names (though it doesn't matter
because .float actually works fine in ES3 engines).

Fun fact: Regardless of the spec, Chrome actually implements
'Node.style.float' as well (only Chrome though; IE and Firefox
don't). So though this is only loaded in IE6 (where it doesn't
work), if this is loaded in Chrome, it actually works.

We could find out what this bug is and provide a working patch
(if needed), but since this is legacy code and we're not actively
in the habit of providing more fixes for IE6, and since this is
and has been broken for years, removing it seems a sensible move.

Follows-up 28cca60.

Change-Id: I7d4b4bcb81b4bdaeab40bcbbb34dff0aa51f2e22

10 years agoIEFixes: Clean up duplicate variables
Timo Tijhof [Thu, 10 Apr 2014 18:40:00 +0000 (11:40 -0700)]
IEFixes: Clean up duplicate variables

Declare the global ones as global, and assign them as implicit
globals instead of having both a local variable *and* a window
property. hasClass and expandedURLs are local variable only.

Follows-up 28cca60fcf493409d9dfd.

Change-Id: I81436c218eedf7c1930703c181a58adb2e5f44b0

10 years agoResourceLoader::makeLoaderImplementScript: Bind args as '$' and 'jQuery'
Ori Livneh [Sun, 9 Mar 2014 10:19:25 +0000 (03:19 -0700)]
ResourceLoader::makeLoaderImplementScript: Bind args as '$' and 'jQuery'

Make the function that wraps ResourceLoader modules bind the first and
second arguments it receives to '$' and 'jQuery'. This patch is a
follow-up to change I0c9edac35, which updated the invocation of
mw.loader#implement so that it passes jQuery as the first and second
argument.

Change-Id: I0f0c3a04c3b0e6a28115a10bf11a2a78aca66c21

10 years agoAPI: Make more continuations unique
Brad Jorsch [Tue, 24 Dec 2013 20:26:47 +0000 (15:26 -0500)]
API: Make more continuations unique

API queries must be completely ordered for proper behavior; otherwise
you may get into a situation where a query returns the same continuation
value that was provided. Various modules that have been using timestamps
in/as their continuation parameter can easily run into this problem.

Normally we'd have to add additional fields to the relevant indexes to
be able to make this work without having filesorting queries (which
MySQL really doesn't do well, it fetches all matching rows and only
applies the limit after[1]). But InnoDB has a "feature" where it
effectively appends the table's primary key to all other indexes,[2]
which makes these queries be properly indexed in that situation.
Apparently we're ok with this, since Icc43b62f was merged depending on
this feature.

Also, this change fixes some MySQLisms and other oddities done to
ApiQueryRecentChanges in Icc43b62f.

 [1]: https://dev.mysql.com/doc/refman/5.5/en/limit-optimization.html
 [2]: https://dev.mysql.com/doc/refman/5.5/en/innodb-table-and-index.html

Bug: 24782
Change-Id: I4c9f8c0c2bfd831755d4fa20a18f93fef1effd28

10 years agoMerge "Moved "Date format" user preference to "Appearance" tab"
Bartosz Dziewoński [Fri, 11 Apr 2014 13:10:10 +0000 (13:10 +0000)]
Merge "Moved "Date format" user preference to "Appearance" tab"

10 years agoMoved "Date format" user preference to "Appearance" tab
Tony Thomas [Thu, 10 Apr 2014 18:41:01 +0000 (00:11 +0530)]
Moved "Date format" user preference to "Appearance" tab

This user preference affects the appearance of the site,
so this feels like a natural fit

Bug: 63582
Change-Id: Ib97b1b39723f1835b7f6086ff1418ab5de13a7a1

10 years agoFix typo in comment
Siebrand Mazeland [Thu, 10 Apr 2014 21:27:27 +0000 (23:27 +0200)]
Fix typo in comment

Change-Id: I18447c07a783f7d68b89b08cf74eed6149f88670

10 years agoMerge "Clarify the "Watchlist-details" message"
Siebrand [Fri, 11 Apr 2014 06:09:39 +0000 (06:09 +0000)]
Merge "Clarify the "Watchlist-details" message"

10 years agoRemoved $wgMaxBacklinksInvalidate
Aaron Schulz [Wed, 9 Apr 2014 00:26:37 +0000 (17:26 -0700)]
Removed $wgMaxBacklinksInvalidate

This was a quick hack, introduced in I4fadded0e, that was later made
redundant by $wgJobBackoffThrottling.

Change-Id: Iddc5f6cfd6554ad9b6e54b8ce1b4805af809c7c8

10 years agoClarify the "Watchlist-details" message
Aditya Sastry [Thu, 10 Apr 2014 22:01:59 +0000 (03:31 +0530)]
Clarify the "Watchlist-details" message

Bug: 53098
Change-Id: I74afadb81e15e6a495b784f0a9c95630ae09abd2

10 years agojquery.suggestions: Debounce calls to $.suggestions.special
Bartosz Dziewoński [Wed, 9 Apr 2014 12:07:49 +0000 (14:07 +0200)]
jquery.suggestions: Debounce calls to $.suggestions.special

The custom calls used there can be comparatively expensive and it
might not be a good idea to redo them on every keystroke.

Bug: 59172
Change-Id: I0cdf53eec798a714825c94d80f100b5cf5841f5d

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 10 Apr 2014 22:01:50 +0000 (22:01 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: Ie834afa64574bfbecc97a9e706370b807a9f2f50

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 10 Apr 2014 21:43:43 +0000 (21:43 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: Iae58b6b9c27350d9fe472304b06ac6eae8d88dea

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 10 Apr 2014 20:25:38 +0000 (20:25 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: Iab0abcc67f667d807a01d6c5864c1b5c4343ee74

10 years agoMerge "Update tests/frontend devDependencies"
jenkins-bot [Thu, 10 Apr 2014 19:49:53 +0000 (19:49 +0000)]
Merge "Update tests/frontend devDependencies"

10 years agoMerge "Remove trailing spaces from some language files"
jenkins-bot [Thu, 10 Apr 2014 19:27:48 +0000 (19:27 +0000)]
Merge "Remove trailing spaces from some language files"

10 years agoUpdate tests/frontend devDependencies
Timo Tijhof [Thu, 10 Apr 2014 19:04:56 +0000 (12:04 -0700)]
Update tests/frontend devDependencies

* grunt-contrib-jshint: v0.8.0 to v0.9.2
  - https://github.com/gruntjs/grunt-contrib-jshint/blob/v0.9.2/CHANGELOG
  - Minor changes and bug fixes
  - Lastest version is v0.10.0, but that embeds jshint v2.5.0
    which we don't want to use yet.

* grunt-contrib-watch: v0.5.3 to v0.6.1 (latest)
  - https://github.com/gruntjs/grunt-contrib-watch/blob/v0.6.1/CHANGELOG
  - Minor changes and bug fixes

* grunt-jscs-checker: v0.4.0 to v0.4.1 (latest)
  - https://github.com/gustavohenke/grunt-jscs-checker/compare/0.4.0...0.4.1
  - Minor changes

Change-Id: I68e9057f8e353e2c3ac8b889977de07597211c54

10 years agoMerge "mediawiki.api: Use FormData for POST requests when supported"
jenkins-bot [Thu, 10 Apr 2014 19:19:01 +0000 (19:19 +0000)]
Merge "mediawiki.api: Use FormData for POST requests when supported"

10 years agoRemove trailing spaces from some language files
umherirrender [Thu, 10 Apr 2014 19:02:25 +0000 (21:02 +0200)]
Remove trailing spaces from some language files

Change-Id: I61d015a9a6f1b8487130393f1c104bc39363a3d1

10 years agoMerge "Document new param of Title::countRevisionsBetween"
jenkins-bot [Thu, 10 Apr 2014 18:57:05 +0000 (18:57 +0000)]
Merge "Document new param of Title::countRevisionsBetween"

10 years agoExclude external RC entries (e.g. Wikidata) from Special:ActiveUsers
Brian Wolff [Thu, 10 Apr 2014 19:31:55 +0000 (16:31 -0300)]
Exclude external RC entries (e.g. Wikidata) from Special:ActiveUsers

People usually want to know who the active users are on the local
wiki, not who edited something on Wikidata.

Note, this changes the query to no longer use a covering index
when joining against the recentchanges table when displaying
the page.

Bug: 63769
Change-Id: I919123f396d0901822108a4675593a2ff5b7307f

10 years agoMerge "Fixes for messages quoting each other and punctuation"
jenkins-bot [Thu, 10 Apr 2014 18:23:48 +0000 (18:23 +0000)]
Merge "Fixes for messages quoting each other and punctuation"

10 years agoDocument new param of Title::countRevisionsBetween
umherirrender [Thu, 10 Apr 2014 17:58:34 +0000 (19:58 +0200)]
Document new param of Title::countRevisionsBetween

Follow-Up: Ie51a491ff5d22c2d84934e83d4b3f690c9dbd595
Change-Id: I61483f50512027559c4c3b63c49602b8aea755fd

10 years agoMerge "mediawiki.special: Remove HTML backwards-compatibility styles"
jenkins-bot [Thu, 10 Apr 2014 16:53:46 +0000 (16:53 +0000)]
Merge "mediawiki.special: Remove HTML backwards-compatibility styles"

10 years agoMerge "Follow-up: If985b16c – Vector external link change release notes"
jenkins-bot [Thu, 10 Apr 2014 15:54:20 +0000 (15:54 +0000)]
Merge "Follow-up: If985b16c – Vector external link change release notes"

10 years agoMerge "mediawiki.jqueryMsg: Don't throw parse errors in the user's face"
Bartosz Dziewoński [Thu, 10 Apr 2014 15:54:02 +0000 (15:54 +0000)]
Merge "mediawiki.jqueryMsg: Don't throw parse errors in the user's face"

10 years agoFollow-up: If985b16c – Vector external link change release notes
jrobson [Tue, 8 Apr 2014 15:59:32 +0000 (08:59 -0700)]
Follow-up: If985b16c – Vector external link change release notes

Also strengthen the CSS selector and remove a FIXME that it fixed.

Bug: 54604
Change-Id: I84765c536ade4087d8d3d9753966a443e49b2c38

10 years agoMerge "Remove translations of ignored 'helppage' message"
jenkins-bot [Thu, 10 Apr 2014 15:31:24 +0000 (15:31 +0000)]
Merge "Remove translations of ignored 'helppage' message"

10 years agoMerge "Remove zh-[cn|tw] in favour of zh-han[s|t]"
jenkins-bot [Thu, 10 Apr 2014 14:49:40 +0000 (14:49 +0000)]
Merge "Remove zh-[cn|tw] in favour of zh-han[s|t]"