lhc/web/wiklou.git
13 years agoUpdate $wgEXIFMessages for r86169.
Siebrand Mazeland [Sat, 16 Apr 2011 11:36:03 +0000 (11:36 +0000)]
Update $wgEXIFMessages for r86169.

13 years agoRemove some unused variables/globals
Sam Reed [Sat, 16 Apr 2011 11:28:35 +0000 (11:28 +0000)]
Remove some unused variables/globals

Fix another unreachable statement

13 years agoRebuild all language files.
Siebrand Mazeland [Sat, 16 Apr 2011 11:27:11 +0000 (11:27 +0000)]
Rebuild all language files.

Removes messages removed from MessagesEn.php in r86146, r86155, r86157, r86169.

13 years agoFix missing abstract methods, logging against r86001
Sam Reed [Sat, 16 Apr 2011 11:25:37 +0000 (11:25 +0000)]
Fix missing abstract methods, logging against r86001

13 years agoRemove trailing whitespace.
Siebrand Mazeland [Sat, 16 Apr 2011 11:22:21 +0000 (11:22 +0000)]
Remove trailing whitespace.

13 years agoFix $row = $row = $.... and unused variable from r85885
Sam Reed [Sat, 16 Apr 2011 11:22:14 +0000 (11:22 +0000)]
Fix $row = $row = $.... and unused variable from r85885

13 years agoRemove some unused variables
Sam Reed [Sat, 16 Apr 2011 11:17:14 +0000 (11:17 +0000)]
Remove some unused variables

Fix typo in wfDeprecated usage

Fix some more unreachable code

13 years agoFollowup r86169, move unreachable debug statement
Sam Reed [Sat, 16 Apr 2011 11:11:49 +0000 (11:11 +0000)]
Followup r86169, move unreachable debug statement

13 years agoFix autoloader from r86175
Sam Reed [Sat, 16 Apr 2011 11:09:20 +0000 (11:09 +0000)]
Fix autoloader from r86175

13 years agoFix for r86169: added missing items in messages.inc and rebuilt MessagesEn.php
Alexandre Emsenhuber [Sat, 16 Apr 2011 09:03:44 +0000 (09:03 +0000)]
Fix for r86169: added missing items in messages.inc and rebuilt MessagesEn.php

13 years agomoar syntax errors
Max Semenik [Sat, 16 Apr 2011 08:47:37 +0000 (08:47 +0000)]
moar syntax errors

13 years agoFixed syntax error in message docs
Max Semenik [Sat, 16 Apr 2011 08:45:57 +0000 (08:45 +0000)]
Fixed syntax error in message docs

13 years agoFollowup to r86047: Fix empty button on pages with only one rev
Leo Koppelkamm [Sat, 16 Apr 2011 08:44:33 +0000 (08:44 +0000)]
Followup to r86047: Fix empty button on pages with only one rev

13 years agoFix for r86186: correct check
Alexandre Emsenhuber [Sat, 16 Apr 2011 08:37:08 +0000 (08:37 +0000)]
Fix for r86186: correct check

13 years ago* (bug 25946) The message on the top of Special:RecentChanges is now displayed in...
Alexandre Emsenhuber [Sat, 16 Apr 2011 08:34:01 +0000 (08:34 +0000)]
* (bug 25946) The message on the top of Special:RecentChanges is now displayed in user language instead of content language

Moved 'recentchangestext' message to 'recentchanges-summary'; left 'recentchangestext' empty by default for wikis that would like to display things in content language on the top of Special:RecentChanges

13 years ago* (bug 28568) Entries in the iwlinks table are now removed on page deletion
Alexandre Emsenhuber [Sat, 16 Apr 2011 07:46:47 +0000 (07:46 +0000)]
* (bug 28568) Entries in the iwlinks table are now removed on page deletion

13 years agoPrevent bug 17790 from reappearing on Special:Preferences
Max Semenik [Sat, 16 Apr 2011 07:39:41 +0000 (07:39 +0000)]
Prevent bug 17790 from reappearing on Special:Preferences

13 years agoFirst step of reorganizing profiling files:
Chad Horohoe [Sat, 16 Apr 2011 02:19:40 +0000 (02:19 +0000)]
First step of reorganizing profiling files:
* Move them all to includes/profiling/* - If you're using StartProfiler, you'll need to update that
* Make ProfileStub subclass the Profiler rather than duplicating function definitions conditionally
* Removed unused params to wfGetProfilingOutput(), only used in the stub, and they didn't do anything with them
* TODO: Kill $wgProfiling, make $wgProfiler a config array and move the various options to that. Also make into a singleton, rather than global (not much calls it outside of core)

13 years ago(Follow-up r86169) Fix three minor issues Reedy found.
Brian Wolff [Sat, 16 Apr 2011 02:19:05 +0000 (02:19 +0000)]
(Follow-up r86169) Fix three minor issues Reedy found.

* Some strings were using double quotes needed the dollar sign escaped.
  (the strings had to do with detecting obscure text encodings for IPTC)
* FormatMetadata::collapseContactInfo should be static (for some reason I never got any E_STRICT on this. I think the api suppresses E_STRICT somehow...)
* Exif::get/makeFormattedMetadata method (which appears to no longer be used, and
  never was used, but kept in for compatability just in case) called
  another function without required argument. Also got changed from public
  to private somehow (which is generally a bad idea, especially when its only
  reason for being there is to preserve back-compat). Marked these functions
  as deprecated while I'm at it since they really should not be used.

13 years ago(Follow-up r86169) Add release notes for img metadata changes.
Brian Wolff [Sat, 16 Apr 2011 01:31:37 +0000 (01:31 +0000)]
(Follow-up r86169) Add release notes for img metadata changes.

13 years agoFix whitespace issues at top of file
Sam Reed [Sat, 16 Apr 2011 01:29:39 +0000 (01:29 +0000)]
Fix whitespace issues at top of file

13 years agoMerge to trunk everything in img_metadata branch.
Brian Wolff [Sat, 16 Apr 2011 01:23:15 +0000 (01:23 +0000)]
Merge to trunk everything in img_metadata branch.

Hope I did this in an ok fashion. svn merge --re-integrate was giving me issues
so I just essentially over-wrote my working copy with the version at img_metadata.

13 years agoRevert r85536 pending a better fix
Sam Reed [Sat, 16 Apr 2011 00:23:07 +0000 (00:23 +0000)]
Revert r85536 pending a better fix

13 years agoRevert r82922 (adding eml files to mime types). Per CR, these should be accompanied...
Chad Horohoe [Sat, 16 Apr 2011 00:16:02 +0000 (00:16 +0000)]
Revert r82922 (adding eml files to mime types). Per CR, these should be accompanied by appropriate sanity checks on upload

13 years agoMerge r81445 from 1.17: revert r70520 (js password complexity checker)
Chad Horohoe [Fri, 15 Apr 2011 23:38:34 +0000 (23:38 +0000)]
Merge r81445 from 1.17: revert r70520 (js password complexity checker)

13 years agoMerge r81448 from REL1_17: reverting RevisionMove feature back out until somebody...
Chad Horohoe [Fri, 15 Apr 2011 23:28:13 +0000 (23:28 +0000)]
Merge r81448 from REL1_17: reverting RevisionMove feature back out until somebody has the time to work on it again. Reverts r67094 and its followups in trunk: r67099, r67111, r67112, r67115, r67398, r81425, r81427

13 years ago* Made __construct() protected
Aaron Schulz [Fri, 15 Apr 2011 22:58:00 +0000 (22:58 +0000)]
* Made __construct() protected
* Minor style and doc cleanups

13 years agoRevert r77555 and followups r77563, r77572, r78116 (merge DisableAccount to core).
Chad Horohoe [Fri, 15 Apr 2011 22:49:03 +0000 (22:49 +0000)]
Revert r77555 and followups r77563, r77572, r78116 (merge DisableAccount to core).

Per CR at the time: this creates a nearly irreversable action that is not nearly well documented enough (even if disabled by default).

We already have the $wgBlockDisablesLogin kludge in place for this. If we're going to do more work on this idea, it should be well thought out, not another hack.

13 years agor85922: Fixing another table bordercase
Leo Koppelkamm [Fri, 15 Apr 2011 22:36:09 +0000 (22:36 +0000)]
r85922: Fixing another table bordercase

13 years agoFollow-up r86041: fix redirect in PurgeAction, and pass query parameters through...
Happy-melon [Fri, 15 Apr 2011 22:11:33 +0000 (22:11 +0000)]
Follow-up r86041: fix redirect in PurgeAction, and pass query parameters through the form so they can be put back on to the redirect at the end.

13 years ago(follow-up r86121) Use strict comparision.
Brian Wolff [Fri, 15 Apr 2011 21:53:55 +0000 (21:53 +0000)]
(follow-up r86121) Use strict comparision.

Third times the charm...

13 years ago(bug 28561 - follow-up r4185) remove rule .small * {font-size: 94%} causes anything...
Brian Wolff [Fri, 15 Apr 2011 20:57:24 +0000 (20:57 +0000)]
(bug 28561 - follow-up r4185) remove rule .small * {font-size: 94%} causes anything nested to be super-small

I'm not sure what the intent was, but this rule will make something like:
<span class="small">fo<b>o</b></span>
have the second o in foo be smaller then the first. Even without this rule, nested instances
of class="small" will still be smaller than a single instance, so it only causes weirdness.

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2011...
Raimond Spekking [Fri, 15 Apr 2011 20:02:58 +0000 (20:02 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-04-15 19:40:00 UTC)

13 years ago* Pass around parser options instead of users and made some parser options consistenc...
Aaron Schulz [Fri, 15 Apr 2011 18:40:25 +0000 (18:40 +0000)]
* Pass around parser options instead of users and made some parser options consistency fixes
* Moved makeParserOptions to Article.php
* Renamed currentIncludeVersions -> getRevIncludes
* Renamed updatePageCache -> setPageCache
* Moved FlaggedRevs::getCacheKey up

13 years ago(follow-up r69626) Make it so the intl normalizer_normalize function is not
Brian Wolff [Fri, 15 Apr 2011 18:39:43 +0000 (18:39 +0000)]
(follow-up r69626) Make it so the intl normalizer_normalize function is not
fed an invalid sequence in UtfNormal::cleanUp

normalizer_normalize seems to return false if fed an invalid unicode sequence (Which is quite different
from what our built in normalization functions do). So use quickIsNFC if it returns false.
(Noticed when investigating bug 28541).

13 years agoFollowup r83755: You removed them, you didn't deprecate them (there is a difference...
Chad Horohoe [Fri, 15 Apr 2011 18:06:03 +0000 (18:06 +0000)]
Followup r83755: You removed them, you didn't deprecate them (there is a difference). If you're going to remove them, go the whole way rather than having people think they might still work.

13 years agoMore function documentation
Sam Reed [Fri, 15 Apr 2011 17:44:19 +0000 (17:44 +0000)]
More function documentation

13 years ago(follow-up r86100) Make categorypage not die as much while transitioning between...
Brian Wolff [Fri, 15 Apr 2011 17:23:44 +0000 (17:23 +0000)]
(follow-up r86100) Make categorypage not die as much while transitioning between 1.16 -> 1.17 schema

Basically re-putting in the intent of r83544 per suggestion on CR of r86100

13 years ago* added E_DEPRECATED into wfSupressWarnings
Jure Kajzer [Fri, 15 Apr 2011 11:19:13 +0000 (11:19 +0000)]
* added E_DEPRECATED into wfSupressWarnings

merge into 1.17 if required PHP version will be 5.3+

13 years ago* updated tableName function changed addIdentifierQuotes, added isQuotedIdentifier...
Jure Kajzer [Fri, 15 Apr 2011 10:48:02 +0000 (10:48 +0000)]
* updated tableName function changed addIdentifierQuotes, added isQuotedIdentifier and removeIdentifierQuotes
* quoting objects in Oracle is poorly supported prior to 10g (it still has bugs in 10g) so i wish to avoid it for as long as possible
* i've added /*Q*/ marker to avoid double-prefixing of table names
* tableName quoted parameter is usable only in cases where you call it directly in functions where it might occur that tableName can get called twice it is unusable as the tableName gets prefixed twice

Oracle documentation is generally crappy. They claim a lot of things but some of those claims depend on a gazillion of factors and in case of one of this factors being a bit off have no general solution. Object name quoting is one of such things and is general practice amongst oracle DBAs that if you write the code directly you can use them but if you write abstracted or embedded code it's best to stay away if you can.

13 years agor86108: Fix var name
Leo Koppelkamm [Fri, 15 Apr 2011 08:31:05 +0000 (08:31 +0000)]
r86108: Fix var name

13 years agoFollowup ro r86088: Use data-sort-type instead of classes to specify the parser-type...
Leo Koppelkamm [Fri, 15 Apr 2011 08:23:29 +0000 (08:23 +0000)]
Followup ro r86088: Use data-sort-type instead of classes to specify the parser-type; add support for data-sort-value; strip legacy code (CR)

13 years agoUpdating jQuery from 1.4.2->1.4.4, for better data-* support. 1.4.4 contains the...
Leo Koppelkamm [Fri, 15 Apr 2011 07:28:02 +0000 (07:28 +0000)]
Updating jQuery from 1.4.2->1.4.4, for better data-* support. 1.4.4 contains the patch from r74326 in core

13 years agoadded explanation of the BeforeWelcomeCreation hook
Nimish Gautam [Fri, 15 Apr 2011 00:23:37 +0000 (00:23 +0000)]
added explanation of the BeforeWelcomeCreation hook

13 years ago(bug 28540) revert r83544 - It really breaks things when using uca-default collation...
Brian Wolff [Thu, 14 Apr 2011 23:28:11 +0000 (23:28 +0000)]
(bug 28540) revert r83544 - It really breaks things when using uca-default collation (As noticed on tw)

Various functions (particuarly the getFirstCharacter ones) all expect to have the human readable sortkey.
Passing them the binary sortkey results in the getFirstChar headers to be totally wrong. It also
causes paging not to work since the sortkey gets double encoded.

This issue probably wasn't noticed, since it wouldn't be visible on the uppercase collation
as uppercasing the first letter won't affect the first character headings, nor does double uppercasing
something matter.

Also changed one of the variable names from $rawSortkey to $humanSortkey as it confused me
(raw as in before turning to binary, or raw as in the real non-human readable sortkey)

13 years agoCompletely rewritten table sorting script.
Leo Koppelkamm [Thu, 14 Apr 2011 21:47:00 +0000 (21:47 +0000)]
Completely rewritten table sorting script.
Fixes Bug 8028, Bug 8115, Bug 15406, Bug 17141, Bug 8732

1. Sites can specify custom collations.
The script accepts an object "tableSorterCollation" which contains a lookup
table, how specific characters should be treated.
For example, after setting "tableSorterCollation={'ä':'ae', 'ß':'ss'};" in the
site's common.js any string containing an ä or Ä will be sorted as if it were a
'ae'.

2. Table rows can be forced to use a specific data type.
By setting class="sort-{Parsername}", the row will be parsed with the specified
algorithm. class="sort-date" would force date sorting etc.
The following parsers are available: text, IPAddress, number, url, currency,
date, isoDate, usLongDate, time

3. Execution time is reduced by half or more.

Sorting a 935 row * 8 columns table:

Browser     Before      After
--------    ------      -----
Chrome 10   90ms        42ms
Safari 5    115ms       48ms
Firefox 4   412ms       87ms
IE8         720ms       115ms

4. Based on the content language and the mdy vs dmy preference, the parser can
understand dates such as "17. März '11". wgMonthNames=[] and
wgMonthNamesShort=[]
in the content language and the mdy vs dmy preference are exported to js; A
table containing the following dates would be sorted correctly:
17. Jan. 01
23 Feb 1992
9.02.05
13 November 2001
14 Oktober '76

Was tested in ie6-8, chrome, safari 5, ff3 & ff4

13 years agoFollowup r85944, move UtfNormalDefins stuff out of extensions profiling area
Sam Reed [Thu, 14 Apr 2011 21:21:28 +0000 (21:21 +0000)]
Followup r85944, move UtfNormalDefins stuff out of extensions profiling area

13 years agoFollow-up r83302: Check permissions
Bryan Tong Minh [Thu, 14 Apr 2011 21:09:16 +0000 (21:09 +0000)]
Follow-up r83302: Check permissions

13 years agoAnother table parser test
Leo Koppelkamm [Thu, 14 Apr 2011 20:50:28 +0000 (20:50 +0000)]
Another table parser test

13 years agoFollowup r85885: Better error message for an insufficient pagesize in a DB2 database.
Leons Petrazickis [Thu, 14 Apr 2011 20:03:37 +0000 (20:03 +0000)]
Followup r85885: Better error message for an insufficient pagesize in a DB2 database.

13 years agoFix warning: Missing argument 1 for wfDeprecated(), called in includes/Article.php...
Alexandre Emsenhuber [Thu, 14 Apr 2011 20:00:25 +0000 (20:00 +0000)]
Fix warning: Missing argument 1 for wfDeprecated(), called in includes/Article.php on line 580 and defined in includes/GlobalFunctions.php on line 3094

13 years agoLocalisation updates for ToolserverI18N messages from translatewiki.net (2011-04...
Raimond Spekking [Thu, 14 Apr 2011 19:49:05 +0000 (19:49 +0000)]
Localisation updates for ToolserverI18N messages from translatewiki.net (2011-04-14 19:30:00 UTC)

13 years agoFollowup to r86064 (List with double line-breaks inside tables). Also contains patch...
Leo Koppelkamm [Thu, 14 Apr 2011 19:28:45 +0000 (19:28 +0000)]
Followup to r86064 (List with double line-breaks inside tables). Also contains patch for Bug 16700 by Mormegil (Additional linebreak though nested templates). Parsertests for both

13 years agoUpdate undelete.php to use short option aliases.
Alexandre Emsenhuber [Thu, 14 Apr 2011 19:01:04 +0000 (19:01 +0000)]
Update undelete.php to use short option aliases.
People using --u and --r will need to change either to -u or --user for --u and to -r or --reason for --r.

13 years agoEnsure $collationConds is defined on all paths
Sam Reed [Thu, 14 Apr 2011 18:46:37 +0000 (18:46 +0000)]
Ensure $collationConds is defined on all paths

13 years agoFix for r85990, which broke lists inside tables; adding test for it
Leo Koppelkamm [Thu, 14 Apr 2011 18:45:04 +0000 (18:45 +0000)]
Fix for r85990, which broke lists inside tables; adding test for it

13 years agoAdding some parser test for tables. Fixing one parser test, which broke due to change...
Leo Koppelkamm [Thu, 14 Apr 2011 17:46:59 +0000 (17:46 +0000)]
Adding some parser test for tables. Fixing one parser test, which broke due to changes in a string in MessagesSr_ec.php

13 years agoAllow people to use &apos; entity (sinqle quote character: ') in wikitext.
Brian Wolff [Thu, 14 Apr 2011 17:42:12 +0000 (17:42 +0000)]
Allow people to use &apos; entity (sinqle quote character: ') in wikitext.

It probably wasn't included originally, as its not part of html4,
but was introduced in XML/XHTML1. Since we do all sorts of weird stuff
with ' characters (italic/bold) its probably good to allow lowly users to
have an easy to remember way of escaping it.

There's also a whole bunch of entities in html5 that we should maybe consider
decoding as well.

13 years agoChanging icons used in installer to GNOME ones, like the rest of vector skin. Also...
Leo Koppelkamm [Thu, 14 Apr 2011 17:04:49 +0000 (17:04 +0000)]
Changing icons used in installer to GNOME ones, like the rest of vector skin. Also fixing Bug 28298 (one border extens a few pixel too much in installer)

13 years agoRemoved unmatched wfProfileOut
Niklas Laxström [Thu, 14 Apr 2011 16:09:07 +0000 (16:09 +0000)]
Removed unmatched wfProfileOut

13 years agoFollowup to r86047: Rewrite the radio-button updater & move everything to action...
Leo Koppelkamm [Thu, 14 Apr 2011 16:06:02 +0000 (16:06 +0000)]
Followup to r86047: Rewrite the radio-button updater & move everything to action.history. Also move to fixCompare version by Helder, since HTMLdiff is scrapped

13 years agoAdded one @since annotation I had to check out
Niklas Laxström [Thu, 14 Apr 2011 16:05:59 +0000 (16:05 +0000)]
Added one @since annotation I had to check out

13 years agoAdded wrapper mw.api() for API calls
Max Semenik [Thu, 14 Apr 2011 15:56:40 +0000 (15:56 +0000)]
Added wrapper mw.api() for API calls

13 years agoChanges to SpecialPage: deprecate any syntax for defining pages other than $wgSpecial...
Happy-melon [Thu, 14 Apr 2011 15:11:30 +0000 (15:11 +0000)]
Changes to SpecialPage: deprecate any syntax for defining pages other than $wgSpecialPage['PageName'] = 'ClassName', including SpecialRedirectToSpecial, which is ugly and nasty anyway.

13 years agoFollowup to r86047: Declare dependency to JUI button more cleanly
Leo Koppelkamm [Thu, 14 Apr 2011 13:52:08 +0000 (13:52 +0000)]
Followup to r86047: Declare dependency to JUI button more cleanly

13 years agoRecommit r84805, but without removing UsersPager, which is actually a Good Thing...
Happy-melon [Thu, 14 Apr 2011 13:27:50 +0000 (13:27 +0000)]
Recommit r84805, but without removing UsersPager, which is actually a Good Thing to use for this class of queries.  Yay for the end of global-function-based special pages in core.  About fifteen left in extensions now...

13 years agoHistory: Adding JS that converts buttons to links for better UX. Patch based on...
Leo Koppelkamm [Thu, 14 Apr 2011 13:18:39 +0000 (13:18 +0000)]
History: Adding JS that converts  buttons to links for better UX. Patch based on one by Matthew Flaschen. Fixes Bug 16165

13 years agoUpdating jQuery UI to 1.8.11 (was 1.8.2). Also loosening button css, since j.ui.butto...
Leo Koppelkamm [Thu, 14 Apr 2011 13:09:02 +0000 (13:09 +0000)]
Updating jQuery UI to 1.8.11 (was 1.8.2). Also loosening button css, since j.ui.button works for non <button> elements as well

13 years agoFollow-up r 86041 per CR and IRC:
Happy-melon [Thu, 14 Apr 2011 12:17:24 +0000 (12:17 +0000)]
Follow-up r 86041 per CR and IRC:
* Article constructor needs to be called with zero as second parameter
* Run stylize.php over new files
* Add Action::getLang() for consistency with other context accessors
* Fix declaration of FormAction::alterForm(), doesn't need to be passed by reference
* Fix inline use of Credits::getCredits() in SkinTemplate and SkinLegacy

13 years agoFix regression introduced in r82451. Only happens when getAllHeaders was not called...
Niklas Laxström [Thu, 14 Apr 2011 11:58:52 +0000 (11:58 +0000)]
Fix regression introduced in r82451. Only happens when getAllHeaders was not called before LanguageSelector hook was executed, not sure in which conditions this happens or not.

13 years agoMove $rxTc initialization next to where it is used
Niklas Laxström [Thu, 14 Apr 2011 11:37:03 +0000 (11:37 +0000)]
Move $rxTc initialization next to where it is used

13 years agor86001, now with less scariness :P I took out the delete action and did purge instea...
Happy-melon [Thu, 14 Apr 2011 10:38:29 +0000 (10:38 +0000)]
r86001, now with less scariness :P  I took out the delete action and did purge instead, which is a much more self-contained action-with-a-form.  Also implement a few changes suggested by Brion on IRC last night.

13 years agoFixing line-break issues with r85922
Leo Koppelkamm [Thu, 14 Apr 2011 10:02:51 +0000 (10:02 +0000)]
Fixing line-break issues with r85922

13 years ago(bug 28507) Fix for r85844: that revision was not actually sufficient to fix bug...
Tim Starling [Thu, 14 Apr 2011 07:10:59 +0000 (07:10 +0000)]
(bug 28507) Fix for r85844: that revision was not actually sufficient to fix bug 28235, since URLs can have more than one question mark in them.

13 years agoMove </td> and </th> to its own line (unless it's an empty cell)
Platonides [Wed, 13 Apr 2011 23:50:33 +0000 (23:50 +0000)]
Move </td> and </th> to its own line (unless it's an empty cell)
Fixes the other r86004 test case and r86010 one.

13 years agoCreated BeforeWelcomeCreation hook to be run before any welcome message gets displayed
Nimish Gautam [Wed, 13 Apr 2011 23:47:01 +0000 (23:47 +0000)]
Created BeforeWelcomeCreation hook to be run before any welcome message gets displayed

13 years agoAnother evil test to join r86004 (didn't produce malformed output in the pre-r85922...
Platonides [Wed, 13 Apr 2011 23:36:49 +0000 (23:36 +0000)]
Another evil test to join r86004 (didn't produce malformed output in the pre-r85922 parser)

13 years agoRevert r86001: Brion says it's too scary :D will recommit in pieces
Happy-melon [Wed, 13 Apr 2011 23:36:27 +0000 (23:36 +0000)]
Revert r86001: Brion says it's too scary :D  will recommit in pieces

13 years agoFollow up r85922 moving the </caption> to another line, fixing one of the tests added...
Platonides [Wed, 13 Apr 2011 23:19:27 +0000 (23:19 +0000)]
Follow up r85922 moving the </caption> to another line, fixing one of the tests added in r86004.

13 years agoAdd a couple of broken tests showing why having the table closing tags in the same...
Platonides [Wed, 13 Apr 2011 23:16:22 +0000 (23:16 +0000)]
Add a couple of broken tests showing why having the table closing tags in the same line is not a good idea.

13 years agoFollow up r85991. For some reason I committed the test for r85921 parser, not for...
Platonides [Wed, 13 Apr 2011 23:12:25 +0000 (23:12 +0000)]
Follow up r85991. For some reason I committed the test for r85921 parser, not for r85922

13 years agoNew infrastructure for actions, as discussed on wikitech-l. Fairly huge commit.
Happy-melon [Wed, 13 Apr 2011 23:04:07 +0000 (23:04 +0000)]
New infrastructure for actions, as discussed on wikitech-l.  Fairly huge commit.
* Actions come in two flavours: the show-a-form-then-do-something-with-the-result (delete, protect, edit, etc) and the just-do-something (watch, rollback, patrol, etc).  Create abstract base classes Action and FormlessAction to support these two cases.  HTMLForm is an integral part of the form-based structure.
* Look mum, no globals!  :D  Fully context-based.
* Implement watch/unwatch, credits and delete actions in the new system as proof-of-concept.  This also gives the delete frontend a much-needed overhaul.
* Stub out the newly-deprecated functions from Article.php.  This already reduces its linecount by about 15%, and there are plenty more actions still to do.
* Centralising actions like this is going to render a lot of hooks type-incompatible.  There's simply nowhere you can put the ArticleConfirmDelete hook, for instance, where it can be passed an OutputPage as the second parameter.  On the other hand, we can implement new hooks like ActionModifyFormFields and ActionBeforeFormDisplay, which can do much prettier stuff to the forms, like adding extra fields the 'right' way.  Update LiquidThreads to use these new hooks where appropriate.

13 years agoUnbundle OutputPage::showErrorPage() in Exception.php to allow ErrorPageError objects...
Happy-melon [Wed, 13 Apr 2011 22:30:13 +0000 (22:30 +0000)]
Unbundle OutputPage::showErrorPage() in Exception.php to allow ErrorPageError objects to be passed a Message object for a more complicated display.

13 years agoReadd support for headings inside tables, broken in r85922 and reported on its CodeRe...
Platonides [Wed, 13 Apr 2011 22:20:14 +0000 (22:20 +0000)]
Readd support for headings inside tables, broken in r85922 and reported on its CodeReview.
Added testcase for it.
It changes again Parser24.

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2011...
Raimond Spekking [Wed, 13 Apr 2011 20:02:04 +0000 (20:02 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-04-13 19:20:00 UTC)

13 years agoTables: Fix Bug 20078, add test for it
Leo Koppelkamm [Wed, 13 Apr 2011 20:01:23 +0000 (20:01 +0000)]
Tables: Fix Bug 20078, add test for it

13 years agoFollowup to r85922: Adapt to MW-coding style
Leo Koppelkamm [Wed, 13 Apr 2011 19:46:09 +0000 (19:46 +0000)]
Followup to r85922: Adapt to MW-coding style

13 years agoLook mum, no globals! Implement a RequestContext for HTMLForm, passed in the constru...
Happy-melon [Wed, 13 Apr 2011 16:51:22 +0000 (16:51 +0000)]
Look mum, no globals!  Implement a RequestContext for HTMLForm, passed in the constructor.  Currently this is optional with B/C; at a later date it should be made compulsory.  Doing this removes the need to call $form->setTitle() on every single use; only when you want to set the title to something other than the page context title.  Implemented the new syntax in a sample of forms.  Also fix a few minor errors in HTMLForm.php that my IDE complained about.

13 years agoImplement user-is-blocked and wiki-is-read-only as exceptions.
Happy-melon [Wed, 13 Apr 2011 14:30:55 +0000 (14:30 +0000)]
Implement user-is-blocked and wiki-is-read-only as exceptions.

13 years agoFollow-up r85929: update MediaWiki::articleFromTitle() call in SearchEngine.php
Happy-melon [Wed, 13 Apr 2011 14:27:59 +0000 (14:27 +0000)]
Follow-up r85929: update MediaWiki::articleFromTitle() call in SearchEngine.php

13 years agoRelated to bug 28470 (Doxygen not updating)
Sam Reed [Wed, 13 Apr 2011 13:09:17 +0000 (13:09 +0000)]
Related to bug 28470 (Doxygen not updating)

Move require_once( MWInit::compiledPath( 'includes/normal/UtfNormalDefines.php' ) ); to Setup.php

Might want relocating in Setup.php though

13 years agoFollowup to r85922: Output th instead of td for tfoot
Leo Koppelkamm [Wed, 13 Apr 2011 12:44:33 +0000 (12:44 +0000)]
Followup to r85922: Output th instead of td for tfoot

13 years agoFollowup to r85922: Fix STRICT error, rmv redundant whitespace
Leo Koppelkamm [Wed, 13 Apr 2011 11:24:38 +0000 (11:24 +0000)]
Followup to r85922: Fix STRICT error, rmv redundant whitespace

13 years agoreverting some changes unintentionally committed in r85939
Neil Kandalgaonkar [Wed, 13 Apr 2011 05:40:51 +0000 (05:40 +0000)]
reverting some changes unintentionally committed in r85939

13 years agofollowup to r85929 -- missing the break;s for non-default cases.
Neil Kandalgaonkar [Wed, 13 Apr 2011 05:31:22 +0000 (05:31 +0000)]
followup to r85929 -- missing the break;s for non-default cases.

13 years ago* Removed getSelectOptions, which did nothing other than send FOR UPDATE on some...
Aaron Schulz [Wed, 13 Apr 2011 00:50:44 +0000 (00:50 +0000)]
* Removed getSelectOptions, which did nothing other than send FOR UPDATE on some slave queries to barely used features
* Removed only Core use of forUpdate(); same issue

13 years agoFollow-up r85928: back out unrelated changes.
Happy-melon [Tue, 12 Apr 2011 23:28:23 +0000 (23:28 +0000)]
Follow-up r85928: back out unrelated changes.

13 years agoFollow-up r85928: AutoLoader entry.
Happy-melon [Tue, 12 Apr 2011 23:02:02 +0000 (23:02 +0000)]
Follow-up r85928: AutoLoader entry.

13 years agoImplement a $context and getContext/setContext methods for Article (and its subclasses).
Happy-melon [Tue, 12 Apr 2011 23:00:49 +0000 (23:00 +0000)]
Implement a $context and getContext/setContext methods for Article (and its subclasses).

13 years agoallow methods to generate a "user does not have required permissions" error by throwi...
Happy-melon [Tue, 12 Apr 2011 22:59:17 +0000 (22:59 +0000)]
allow methods to generate a "user does not have required permissions" error by throwing an exception rather than calling $wgOut->permissionRequired().  Currently somewhat circular as the exception goes back to OutputPage::showErrorPage(), but hopefully that global dependency can be reduced in future.