lhc/web/wiklou.git
12 years agoAdd mediawiki.language/languages/nl.js and mediawiki.language/languages/pt.js
Santhosh Thottingal [Mon, 26 Sep 2011 06:08:46 +0000 (06:08 +0000)]
Add mediawiki.language/languages/nl.js and mediawiki.language/languages/pt.js

12 years agoAdd digitTransformTable for pt, pt-br and nl
Santhosh Thottingal [Mon, 26 Sep 2011 05:23:50 +0000 (05:23 +0000)]
Add digitTransformTable for pt, pt-br and nl

12 years agoCache negative results for interwiki prefix checks. Also helps filecache fail-over...
Aaron Schulz [Mon, 26 Sep 2011 03:37:20 +0000 (03:37 +0000)]
Cache negative results for interwiki prefix checks. Also helps filecache fail-over mode if DB is down.

12 years agoFollowup r98056; Add to this screwed up NewParserTest phpunit stuff as well.
Daniel Friesen [Mon, 26 Sep 2011 02:04:17 +0000 (02:04 +0000)]
Followup r98056; Add to this screwed up NewParserTest phpunit stuff as well.

12 years agoLocalisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Sun, 25 Sep 2011 19:40:13 +0000 (19:40 +0000)]
Localisation updates for core and extension messages from translatewiki.net

12 years agoemail -> e-mail for consistency
Raimond Spekking [Sun, 25 Sep 2011 18:43:57 +0000 (18:43 +0000)]
email -> e-mail for consistency

12 years agoRaise the specificity of the sortable header.
Derk-Jan Hartman [Sun, 25 Sep 2011 17:26:33 +0000 (17:26 +0000)]
Raise the specificity of the sortable header.
Many installations have something like: table.wikitable th {background:color;} which would override the background of the sortable header.

12 years agoTalk page links were bluelinks if the root page existed instead of the subpage (i...
Robin Pepermans [Sun, 25 Sep 2011 16:32:15 +0000 (16:32 +0000)]
Talk page links were bluelinks if the root page existed instead of the subpage (i.e. a link to MediaWiki talk:Xyz/nl was blue if MediaWiki talk:Xyz existed). This is present in at least MW 1.16 - now.

12 years agoSimplify things by using wfMessage() instead of wfMsg() et al.
Alexandre Emsenhuber [Sun, 25 Sep 2011 14:38:54 +0000 (14:38 +0000)]
Simplify things by using wfMessage() instead of wfMsg() et al.

12 years agoFollow-up r96958: forgot one use of $wgUser
Alexandre Emsenhuber [Sun, 25 Sep 2011 10:14:42 +0000 (10:14 +0000)]
Follow-up r96958: forgot one use of $wgUser

12 years agoFollowup r98053; Add $wgCleanupPresentationalAttributes to the globals setup so that...
Daniel Friesen [Sun, 25 Sep 2011 04:35:25 +0000 (04:35 +0000)]
Followup r98053; Add $wgCleanupPresentationalAttributes to the globals setup so that tests are always run with it on.

12 years agoFollowup r94465 and r94465; Add phpunit tests for Sanitizer::fixDeprecatedAttributes...
Daniel Friesen [Sun, 25 Sep 2011 04:08:23 +0000 (04:08 +0000)]
Followup r94465 and r94465; Add phpunit tests for Sanitizer::fixDeprecatedAttributes and fix bugs related to clear="all" and mixed/uppercase attributes and values.

12 years agoFollowup r94465; Add parser tests and turn the feature on-by-default like I intended...
Daniel Friesen [Sun, 25 Sep 2011 02:58:03 +0000 (02:58 +0000)]
Followup r94465; Add parser tests and turn the feature on-by-default like I intended for it (I guess I forgot to return it to true when I was testing it as off)

12 years agoFollowup r94465; Release notes.
Daniel Friesen [Sun, 25 Sep 2011 02:27:10 +0000 (02:27 +0000)]
Followup r94465; Release notes.

12 years agoFollowup r94465; Don't use empty.
Daniel Friesen [Sun, 25 Sep 2011 02:24:47 +0000 (02:24 +0000)]
Followup r94465; Don't use empty.

12 years agoFollowup r96717; Fix whitespace.
Daniel Friesen [Sun, 25 Sep 2011 02:09:42 +0000 (02:09 +0000)]
Followup r96717; Fix whitespace.

12 years agoRelease notes for my common*.css improvements.
Daniel Friesen [Sun, 25 Sep 2011 02:06:58 +0000 (02:06 +0000)]
Release notes for my common*.css improvements.

12 years agoFollowup r98045, release notes.
Daniel Friesen [Sun, 25 Sep 2011 02:03:40 +0000 (02:03 +0000)]
Followup r98045, release notes.

12 years agoImprove the accessibility of our jump-to functionality
Daniel Friesen [Sun, 25 Sep 2011 00:49:39 +0000 (00:49 +0000)]
Improve the accessibility of our jump-to functionality
- Stop hiding with display: none;, this hides our jump links from modern screen readers and users with motor disabilities (ie: nowadays, pratically everyone they are intended to help).
- Instead hide with an overflow that will make the links viable <tab> targets. This alone is enough to help screen reader users.
- Add in a script that will show the jump-links area on-focus for motor-impared users who can still see who have js enabled (this can't be done with css unfortunately)

12 years agoFU r98029 - message documentation.
Happy-melon [Sat, 24 Sep 2011 21:37:03 +0000 (21:37 +0000)]
FU r98029 - message documentation.

12 years agoArticle refactoring and changes for bug 31144. Dependency inject ParserOutput objects...
Aaron Schulz [Sat, 24 Sep 2011 21:12:26 +0000 (21:12 +0000)]
Article refactoring and changes for bug 31144. Dependency inject ParserOutput objects in some places and let hooks set $outputDone as the parser output used.

12 years ago(bug 30636) integrate the remaining functionality of the PasswordReset extension...
Happy-melon [Sat, 24 Sep 2011 21:11:41 +0000 (21:11 +0000)]
(bug 30636) integrate the remaining functionality of the PasswordReset extension into core, to make the fact that its Special:PasswordReset conflicts (as of 1.18) with the new core special page of the same name no longer relevant.

The extension just allows admins with the 'passwordreset' permission to arbitrarily change other users' passwords, which is really scary.  This core change uses the same permission, but instead gives them the ability to view the password reset email that would be sent to another user.  So they can record the temporary password, and give it to the user via a medium other than email; but when the user logs in with it they will be forced to change it and the admin will no longer know what it is.

It would be nice to log these viewing actions, but I'm not sure which log it should go into, or whether it's worth creating a new one just for this (rare and disabled-by-default) action.

12 years agoUse local context instead of global variables
Alexandre Emsenhuber [Sat, 24 Sep 2011 21:10:08 +0000 (21:10 +0000)]
Use local context instead of global variables

12 years agoLocalisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Sat, 24 Sep 2011 20:11:56 +0000 (20:11 +0000)]
Localisation updates for core and extension messages from translatewiki.net

12 years ago* restore DB connection after unserialization. This is needed in all DB variants...
Markus Glaser [Sat, 24 Sep 2011 20:07:21 +0000 (20:07 +0000)]
* restore DB connection after unserialization. This is needed in all DB variants safe for MySQL. Found when running PagedTiffHandler Selenium tests on Postgres. Credits to Dan Nessett.

12 years agoMinor cleanup and line breaking to formatTimePeriod()
Aaron Schulz [Sat, 24 Sep 2011 17:55:34 +0000 (17:55 +0000)]
Minor cleanup and line breaking to formatTimePeriod()

12 years agoAllow LogEventsList::showLogExtract() to get a Title object instead of having to...
Alexandre Emsenhuber [Sat, 24 Sep 2011 17:52:53 +0000 (17:52 +0000)]
Allow LogEventsList::showLogExtract() to get a Title object instead of having to do Title -> string -> Title conversion

12 years agoPer CR on r97962, introduce an array parameter for formatTimePeriod() rather than...
Roan Kattouw [Sat, 24 Sep 2011 15:44:43 +0000 (15:44 +0000)]
Per CR on r97962, introduce an array parameter for formatTimePeriod() rather than adding more boolean params.

12 years agoFollowup r97962: add qqq for new messages, and expand it for the -abbrev messages.
Roan Kattouw [Sat, 24 Sep 2011 15:24:13 +0000 (15:24 +0000)]
Followup r97962: add qqq for new messages, and expand it for the -abbrev messages.

12 years agoRegister new message keys from r97962
Raimond Spekking [Sat, 24 Sep 2011 06:13:43 +0000 (06:13 +0000)]
Register new message keys from r97962

12 years agoAdded filecache support for history pages
Aaron Schulz [Sat, 24 Sep 2011 01:17:04 +0000 (01:17 +0000)]
Added filecache support for history pages

12 years agoFU r97978: removed more raw page file cache code
Aaron Schulz [Sat, 24 Sep 2011 00:55:49 +0000 (00:55 +0000)]
FU r97978: removed more raw page file cache code

12 years agoRemoved action=raw support from HTMLFileCache. Obsolete due to RL.
Aaron Schulz [Sat, 24 Sep 2011 00:37:11 +0000 (00:37 +0000)]
Removed action=raw support from HTMLFileCache. Obsolete due to RL.

12 years agoFollowup r97954: fix unit tests for wfShellMaintenanceCmd() to work on Unix as well...
Brion Vibber [Fri, 23 Sep 2011 22:17:41 +0000 (22:17 +0000)]
Followup r97954: fix unit tests for wfShellMaintenanceCmd() to work on Unix as well as Windows

12 years agoMake Language::formatTimePeriod() more flexible so it can produce stuff like '3 hours...
Roan Kattouw [Fri, 23 Sep 2011 22:17:10 +0000 (22:17 +0000)]
Make Language::formatTimePeriod() more flexible so it can produce stuff like '3 hours ago'.

* Add a $noAbbrevs parameter that causes the 'seconds', 'minutes', etc. messages to be used instead of the 'seconds-abbrev', 'minutes-abbrev', etc. messages
* Add the 'seconds', 'minutes', 'hours' and 'days' messages
* Change the -abbrev messages to take a parameter rather than having the number prepended to them. This is for compatibility with 'seconds' et al, which need the parameter for {{PLURAL:}}. It also generally makes more sense. This does BREAK the messages in non-English languages that override them; Niklas told me to leave this alone and ping the TranslateWiki folks
* Introduce an 'ago' message for '$1 ago'. Not currently used in core, but I want to use it in an extension and it seemed stupid not to have such a thing in core.
* Refactor the function to use message objects and pass the number as a parameter
* Add tests! They exposed a subtle bug in my first iteration; all hail tests!

12 years agoRewrite testFormatTimePeriod() with a data provider
Roan Kattouw [Fri, 23 Sep 2011 22:02:36 +0000 (22:02 +0000)]
Rewrite testFormatTimePeriod() with a data provider

12 years agoAdded wfShellMaintenanceCmd() for Het Deploy support
Aaron Schulz [Fri, 23 Sep 2011 20:42:22 +0000 (20:42 +0000)]
Added wfShellMaintenanceCmd() for Het Deploy support

12 years agoFix single character access
Sam Reed [Fri, 23 Sep 2011 20:20:41 +0000 (20:20 +0000)]
Fix single character access

12 years agoLocalisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Fri, 23 Sep 2011 20:09:54 +0000 (20:09 +0000)]
Localisation updates for core and extension messages from translatewiki.net

12 years agoGod. Damn. You. Php.
Sam Reed [Fri, 23 Sep 2011 18:01:40 +0000 (18:01 +0000)]
God. Damn. You. Php.

Followup r97919

12 years agoUse local context instead of global variables
Alexandre Emsenhuber [Fri, 23 Sep 2011 17:21:08 +0000 (17:21 +0000)]
Use local context instead of global variables

12 years ago* Call Linker methods statically
Alexandre Emsenhuber [Fri, 23 Sep 2011 16:15:30 +0000 (16:15 +0000)]
* Call Linker methods statically
* Moved wfReadOnly() check after permissions so that users don't think the error is temporary if they and don't have permissions and the database is locked
* Removed "unexpected value of 'oldimage'" message which seems to say there's an internal error somewhere instead that the oldimage parameter is not in correct format

12 years agoMostly revert r97328
Sam Reed [Fri, 23 Sep 2011 14:14:55 +0000 (14:14 +0000)]
Mostly revert r97328

Swap substring to be done on smaller (more correct) values

12 years agoFactorise calls to $this->getSkin()->getUser() in SkinCologneBlue::quickBar(); also...
Alexandre Emsenhuber [Fri, 23 Sep 2011 12:55:01 +0000 (12:55 +0000)]
Factorise calls to $this->getSkin()->getUser() in SkinCologneBlue::quickBar(); also moved the call $this->getSkin()->getTitle() near the only place where it's used

12 years agoadd mwscript handling for call of fetchText.php maintenance script
Ariel Glenn [Fri, 23 Sep 2011 07:48:30 +0000 (07:48 +0000)]
add mwscript handling for call of fetchText.php maintenance script

12 years agohandle naming checkpoint file with first/last pageID when the file is empty
Ariel Glenn [Fri, 23 Sep 2011 06:15:20 +0000 (06:15 +0000)]
handle naming checkpoint file with first/last pageID when the file is empty

12 years agoRarrgh
Sam Reed [Thu, 22 Sep 2011 23:53:37 +0000 (23:53 +0000)]
Rarrgh

Swapping " for ' doesn't make it en-gb

Deleted also on TW

12 years ago* (bug 31089) Fix regression in Special:Block reasons list (MediaWiki:Ipbreason-dropd...
Brion Vibber [Thu, 22 Sep 2011 22:10:41 +0000 (22:10 +0000)]
* (bug 31089) Fix regression in Special:Block reasons list (MediaWiki:Ipbreason-dropdown parsing)

Followup to r83298: makes HTMLSelectAndOtherField backwards-compatible with Xml::listDropDown as it was apparently intended to be.

Also fixed double-escaping in the options for HTMLSelectAndOtherField.

Followup to r83795: fixes regression in Special:Block by fixing HTMLSelectAndOtherField which got used in place of Xml::listDropDown, but wasn't compatible.

Note that this removes the clever thing that lets you have separate values and texts in your dropdown; since Xml::listDropDown had no such feature and actual usage includes texts containing links and other stuch where the pipe character is a legit part of the content.

12 years ago* (bug 31100) Fix regression in sidebar (special: page links lost parameters)
Brion Vibber [Thu, 22 Sep 2011 21:35:24 +0000 (21:35 +0000)]
* (bug 31100) Fix regression in sidebar (special: page links lost parameters)

Regression in Title::fixSpecialName() in r86255; fixed and added a unit test case to TitleTest.

12 years agorv r97851 for further inspection, causes PHP notices
Niklas Laxström [Thu, 22 Sep 2011 21:27:04 +0000 (21:27 +0000)]
rv r97851 for further inspection, causes PHP notices

12 years agoFU r95640: documentation for message change. Also replace a deprecated <font> elemen...
Happy-melon [Thu, 22 Sep 2011 21:06:55 +0000 (21:06 +0000)]
FU r95640: documentation for message change.  Also replace a deprecated <font> element that my IDE complained about.

12 years agofollowup r79862: the for loop only cleans up half the output handlers (since $i count...
Ilmari Karonen [Thu, 22 Sep 2011 20:44:05 +0000 (20:44 +0000)]
followup r79862: the for loop only cleans up half the output handlers (since $i counts up while ob_get_level() counts down); check the return value of ob_end_clean() instead.
(I just noticed this while eyeballing the code -- apparently most people don't have multiple output handlers active, given that nobody had caught this in over eight months.)

12 years agoRe-do r96798 ("LanguageConverter now depends on the page content language"), without...
Robin Pepermans [Thu, 22 Sep 2011 20:31:23 +0000 (20:31 +0000)]
Re-do r96798 ("LanguageConverter now depends on the page content language"), without the change in WikiPage which caused an infinite loop (see bug 31098)

12 years agoLocalisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Thu, 22 Sep 2011 19:48:56 +0000 (19:48 +0000)]
Localisation updates for core and extension messages from translatewiki.net

12 years agoPer Aaron, fix for r97658: removed double call to parent constructor that will also...
Alexandre Emsenhuber [Thu, 22 Sep 2011 19:15:25 +0000 (19:15 +0000)]
Per Aaron, fix for r97658: removed double call to parent constructor that will also fix the E_NOTICE

12 years agoParser test for bug 31098, disabled of course
Niklas Laxström [Thu, 22 Sep 2011 16:00:33 +0000 (16:00 +0000)]
Parser test for bug 31098, disabled of course

12 years agoGuard against
Sam Reed [Thu, 22 Sep 2011 15:08:32 +0000 (15:08 +0000)]
Guard against

PHP fatal error in /home/wikipedia/common/php-1.18/includes/Linker.php line 831:
Argument 1 passed to Linker::makeMediaLinkObj() must be an instance of Title, null given, called in /home/wikipedia/common/php-1.18/includes/Linker.php on line 1221 and defined

12 years agoFix single character access
Sam Reed [Thu, 22 Sep 2011 14:57:08 +0000 (14:57 +0000)]
Fix single character access

12 years agoDon't load all languages just to check whether message is known.
Niklas Laxström [Thu, 22 Sep 2011 14:04:08 +0000 (14:04 +0000)]
Don't load all languages just to check whether message is known.
I'm pretty sure I already fixed this once in the past.

12 years ago* (bug 31081) $wgEnotifUseJobQ causes many unnecessary jobs to be queued
Sam Reed [Thu, 22 Sep 2011 12:14:21 +0000 (12:14 +0000)]
* (bug 31081) $wgEnotifUseJobQ causes many unnecessary jobs to be queued

Do some of the cheap checks before spawning attempting to send emails via any method

12 years agostylize.php - minor whitespace fixes.
Santhosh Thottingal [Thu, 22 Sep 2011 11:52:44 +0000 (11:52 +0000)]
stylize.php - minor whitespace fixes.

12 years agoFix mixed tabs and spaces from r97793
Sam Reed [Thu, 22 Sep 2011 11:06:48 +0000 (11:06 +0000)]
Fix mixed tabs and spaces from r97793

Couple of minor style tweaks also

12 years agoMerge r97789 into trunk
Sam Reed [Thu, 22 Sep 2011 11:04:30 +0000 (11:04 +0000)]
Merge r97789 into trunk

Follows up r92528 where this was introduced

12 years agoAdd number grouping pattern. Ref Bug 29495. Ml and Hi added in r97793
Santhosh Thottingal [Thu, 22 Sep 2011 09:21:54 +0000 (09:21 +0000)]
Add number grouping pattern. Ref Bug 29495. Ml and Hi added in r97793

12 years agoremove cruft that didn't all get cleaned up before commit in r95260, addressing fixme.
Ariel Glenn [Thu, 22 Sep 2011 07:03:25 +0000 (07:03 +0000)]
remove cruft that didn't all get cleaned up before commit in r95260, addressing fixme.

12 years agoFixed User::getGroups(), apparently broken since r33333. User::load() doesn't load...
Tim Starling [Thu, 22 Sep 2011 06:17:26 +0000 (06:17 +0000)]
Fixed User::getGroups(), apparently broken since r33333. User::load() doesn't load groups anymore, so calling $this->getGroups() was the same as just accessing $this->mGroups. Usually it doesn't matter, since most factory functions are funnelled into loadFromId() which calls loadGroups() or loads the groups from the cache, but loadFromRow() was potentially broken.

It's necessary for User::loadFromRow() to set $this->mGroups to null, same as the calling code in User::loadFromDatabase(), so that they will be loaded dynamically when User::newFromRow() is called.

No bugs found that are caused by this but it couldn't hurt to have working accessors. Tested from eval.php.

12 years agoAdd support for Number grouping(commafy) based on CLDR number grouping patterns like...
Santhosh Thottingal [Thu, 22 Sep 2011 05:01:19 +0000 (05:01 +0000)]
Add support for Number grouping(commafy) based on CLDR number grouping patterns like ##,##,###.
Testcases for Malayalam and Dutch
Number grouping Patterns added to Ml and Hi Message classes.
Reference: Bug 29495

12 years agoZero padding for #firstHeading makes text cut for scripts like Devanagari , Malayalam...
Santhosh Thottingal [Thu, 22 Sep 2011 03:51:59 +0000 (03:51 +0000)]
Zero padding for #firstHeading makes text cut for scripts like Devanagari , Malayalam etc(Bug 29405 and Bug 30809), especially when the glyphs are stacked or
having lower diacritic marks. Remove padding-top:0 and padding-bottom:0 to allow h1 inherit the padding bottom and top values from commonElements.css fixes this.

12 years agostylize.php changes.
Santhosh Thottingal [Thu, 22 Sep 2011 03:42:14 +0000 (03:42 +0000)]
stylize.php changes.

12 years agoRemoved the redundant wfMkdirParents() call added to BitmapHandler::doTransform(...
Tim Starling [Thu, 22 Sep 2011 03:37:39 +0000 (03:37 +0000)]
Removed the redundant wfMkdirParents() call added to BitmapHandler::doTransform() in r79845. This causes problems on Wikimedia due to incorrect NFS access. If a sysadmin misconfigures their thumbnail destination directory, they should get a helpful error message, it shouldn't transparently fall back to client-side scaling and cache the resulting HTML forever.

12 years agoAdded array type hinting too getGroupPermissions()
Aaron Schulz [Thu, 22 Sep 2011 03:21:43 +0000 (03:21 +0000)]
Added array type hinting too getGroupPermissions()

12 years ago* (bug 29154) Allow upload-by-URL to follow HTTP redirects
Brion Vibber [Thu, 22 Sep 2011 01:15:06 +0000 (01:15 +0000)]
* (bug 29154) Allow upload-by-URL to follow HTTP redirects

12 years ago* (bug 30041) Fix installer cache selection field to keep the selected radio button...
Brion Vibber [Thu, 22 Sep 2011 00:35:55 +0000 (00:35 +0000)]
* (bug 30041) Fix installer cache selection field to keep the selected radio button, initialize the memcached server fold-out correctly when coming back to the page

12 years ago* (bug 30041) Fix memcached validation in installer to accept resolvable hostnames
Brion Vibber [Thu, 22 Sep 2011 00:11:03 +0000 (00:11 +0000)]
* (bug 30041) Fix memcached validation in installer to accept resolvable hostnames

'localhost:11211' was rejected because 'localhost' isn't an IP address... however it's a perfectly legit host to connect to. :)

Followup to r82687 which introduced the IP address check.

12 years agoClear findFile() process cache of file moves (issue came up with bug bug 31056)
Aaron Schulz [Wed, 21 Sep 2011 21:32:24 +0000 (21:32 +0000)]
Clear findFile() process cache of file moves (issue came up with bug bug 31056)

12 years agoLocalisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Wed, 21 Sep 2011 21:30:38 +0000 (21:30 +0000)]
Localisation updates for core and extension messages from translatewiki.net

12 years agoMade trimCache() protected
Aaron Schulz [Wed, 21 Sep 2011 20:51:26 +0000 (20:51 +0000)]
Made trimCache() protected

12 years agoAdded lock/unlock function stubs. Fixes:
Aaron Schulz [Wed, 21 Sep 2011 20:25:58 +0000 (20:25 +0000)]
Added lock/unlock function stubs. Fixes:
PHP fatal error in /usr/local/apache/common-local/php-1.18/includes/objectcache/MemcachedPhpBagOStuff.php line 91:
Call to undefined method MemCachedClientforWiki::lock()

12 years ago* follow-up r97636: decrease indentation & mention revision per Nikerabbit
Robin Pepermans [Wed, 21 Sep 2011 19:30:08 +0000 (19:30 +0000)]
* follow-up r97636: decrease indentation & mention revision per Nikerabbit
* add @since for r97071

12 years agoRevert r93388 because it was a fix for r93386 which was reverted.
Robin Pepermans [Wed, 21 Sep 2011 16:52:44 +0000 (16:52 +0000)]
Revert r93388 because it was a fix for r93386 which was reverted.

12 years agoReturn documentation
Sam Reed [Wed, 21 Sep 2011 16:36:43 +0000 (16:36 +0000)]
Return documentation

12 years agoComment out unreachable code
Sam Reed [Wed, 21 Sep 2011 16:34:23 +0000 (16:34 +0000)]
Comment out unreachable code

Remove unreachable return false;

12 years ago* (bug 30245) Use the correct way to construct a log page title
Niklas Laxström [Wed, 21 Sep 2011 09:41:40 +0000 (09:41 +0000)]
* (bug 30245) Use the correct way to construct a log page title

12 years agoDon't use isset() to check for null
Alexandre Emsenhuber [Wed, 21 Sep 2011 09:11:26 +0000 (09:11 +0000)]
Don't use isset() to check for null

12 years agoWrap the copyright when its language is not the user's language; avoids problem when...
Alexandre Emsenhuber [Wed, 21 Sep 2011 09:03:53 +0000 (09:03 +0000)]
Wrap the copyright when its language is not the user's language; avoids problem when direction of the two languages is different

12 years agoAdded missing calls to SpecialPage::setHeaders() and SpecialPage::outputHeader()
Alexandre Emsenhuber [Wed, 21 Sep 2011 08:54:14 +0000 (08:54 +0000)]
Added missing calls to SpecialPage::setHeaders() and SpecialPage::outputHeader()

12 years agoFU 97704: I was thinking the space was already added in this case
Aaron Schulz [Wed, 21 Sep 2011 08:52:57 +0000 (08:52 +0000)]
FU 97704: I was thinking the space was already added in this case

12 years agoCall Linker methods statically
Alexandre Emsenhuber [Wed, 21 Sep 2011 08:40:40 +0000 (08:40 +0000)]
Call Linker methods statically

12 years agoTweaked diff size number location to make sp:contribs look prettier and more consiste...
Aaron Schulz [Wed, 21 Sep 2011 08:39:36 +0000 (08:39 +0000)]
Tweaked diff size number location to make sp:contribs look prettier and more consistent with how it was without them

12 years agoPer Nikerabbit, follow-up r97658: change getAuthor() into getPerformer() for consistency
Alexandre Emsenhuber [Wed, 21 Sep 2011 07:41:45 +0000 (07:41 +0000)]
Per Nikerabbit, follow-up r97658: change getAuthor() into getPerformer() for consistency

12 years agoFix a conflict(?) in Special:Contributions in r97658.
Niklas Laxström [Wed, 21 Sep 2011 05:52:55 +0000 (05:52 +0000)]
Fix a conflict(?) in Special:Contributions in r97658.

12 years agoMake per page edit notices work in namespaces without subpages enabled.
Brian Wolff [Wed, 21 Sep 2011 00:19:09 +0000 (00:19 +0000)]
Make per page edit notices work in namespaces without subpages enabled.

12 years ago* (bug 31048) Fix for width/height reported on Special:Upload thumbnail for EXIF...
Brion Vibber [Tue, 20 Sep 2011 22:25:54 +0000 (22:25 +0000)]
* (bug 31048) Fix for width/height reported on Special:Upload thumbnail for EXIF-rotated images

Followup to r79867: switch the reported width/height as well as rotating the thumbnail image. This matches the logical width/height later seen when we complete the upload.

12 years ago* (bug 6672, 31024) Fixes for handling of images with an EXIF orientation
Brion Vibber [Tue, 20 Sep 2011 22:13:34 +0000 (22:13 +0000)]
* (bug 6672, 31024) Fixes for handling of images with an EXIF orientation

- sets an image's reported width/height to the logical form (portait image reports itself as portait)
- everything works in logical coordinates when sizing -- we don't touch the physical pre-rotation dimensions again until it's actual low-level resize time. This fixes several problems with incorrect thumb sizing (eg getting a 600x800 image when we asked for something that fits in 800x600 box)
- fixes unit test cases in ExifRotationTest that were reporting that the width/height were coming back with the physical form which we don't want
- removes some test cases on ExifRotationTest that tested dimension swapping in a place where we don't want it
- ensures that only logical width/height need be exposed to API etc, making exif-rotated images work via ForeignAPIRepo

Note that this may actually cause file metadata to get loaded twice during File::getPropsFromPath, as the $image parameter it passes in to the handler's getImageSize function is bogus and can't be used to fetch an already-loaded metadata blob. This should not generally be too expensive though; it's not a fast path.

Rotated files that were uploaded under previous versions may still have their width/height reversed; an action=purge on the file page will refresh it and cause thumbs to be regenerated.

Follows up on r79845, r90016, r92246, r92279, r96687, r97651, r97656, r97659.

Needs merge to 1.18.

12 years agoCleaned up leftovers from applying a patch
Trevor Parscal [Tue, 20 Sep 2011 21:41:40 +0000 (21:41 +0000)]
Cleaned up leftovers from applying a patch

12 years agoHaz moar spaces :) ... follow-up to r97554 as per Jack Phoenix.
Sean Colombo [Tue, 20 Sep 2011 21:39:25 +0000 (21:39 +0000)]
Haz moar spaces :) ... follow-up to r97554 as per Jack Phoenix.

12 years agoLocalisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Tue, 20 Sep 2011 20:49:59 +0000 (20:49 +0000)]
Localisation updates for core and extension messages from translatewiki.net

12 years agoFixed IE6 issues in RTL mode
Trevor Parscal [Tue, 20 Sep 2011 20:40:54 +0000 (20:40 +0000)]
Fixed IE6 issues in RTL mode

12 years agoFurther tweaks to r96687, r90016, r97398, r97656 etc tests: try several thumbnail...
Brion Vibber [Tue, 20 Sep 2011 20:04:26 +0000 (20:04 +0000)]
Further tweaks to r96687, r90016, r97398, r97656 etc tests: try several thumbnail resolutions so we test both width-only and width & height requests

12 years ago* Made IndexPager extend ContextSource
Alexandre Emsenhuber [Tue, 20 Sep 2011 20:00:05 +0000 (20:00 +0000)]
* Made IndexPager extend ContextSource
* Updated special pages using IndexPager or one if its subclasses to pass the context object and use it instead of global variables
* Call Linker methods statically
* Changed LogPager::getUser() to LogPager::getAuthor() to avoid conflict with ContextSource::getUser()