lhc/web/wiklou.git
12 years agosome eol w/s
Mark A. Hershberger [Wed, 26 Oct 2011 02:56:27 +0000 (02:56 +0000)]
some eol w/s

12 years agoBug 31948 - Special:Contributions doesn't remember tagfilter in
Mark A. Hershberger [Wed, 26 Oct 2011 02:56:04 +0000 (02:56 +0000)]
Bug 31948 - Special:Contributions doesn't remember tagfilter in
options form

Patch from MrBlueSky.

12 years agoFollowup to r97033 - removed wgWhatlinksherelimit and started the conversion to wgQue...
Sean Colombo [Tue, 25 Oct 2011 23:18:00 +0000 (23:18 +0000)]
Followup to r97033 - removed wgWhatlinksherelimit and started the conversion to wgQueryPageDefaultLimit, but didn't see too many places using a default of 50.

12 years agoIf the page contains __NOEDITSECTION__, it will never have edit sections, so don...
Platonides [Tue, 25 Oct 2011 22:18:33 +0000 (22:18 +0000)]
If the page contains __NOEDITSECTION__, it will never have edit sections, so don't create markers. Follow-up r99250.
Fix for bug 31647: Regression: __NOEDITSECTION__ is ignored when the page is read from the parser cache

12 years agoPort Special:Lockdb and Special:Unlockdb to HTMLForm using FormSpecialPage
Alexandre Emsenhuber [Tue, 25 Oct 2011 18:20:44 +0000 (18:20 +0000)]
Port Special:Lockdb and Special:Unlockdb to HTMLForm using FormSpecialPage

12 years ago* Removed $wgRCShowChangedSize check in sp:Contributions for size diffs since this...
Aaron Schulz [Tue, 25 Oct 2011 18:19:26 +0000 (18:19 +0000)]
* Removed $wgRCShowChangedSize check in sp:Contributions for size diffs since this isn't RC
* Replaced revision size information on history pages with size diff to be consistent with other places

12 years agoUnstub $wgLang if still stubbed before storing it; avoid storing a StubUserLang insta...
Alexandre Emsenhuber [Tue, 25 Oct 2011 18:14:30 +0000 (18:14 +0000)]
Unstub $wgLang if still stubbed before storing it; avoid storing a StubUserLang instance in ParserOptions and errors when getting the object (per report of Lockal on IRC)

12 years agoAdded temporary LocalFilePurgeThumbnails hook for bug 27641
Aaron Schulz [Tue, 25 Oct 2011 17:19:28 +0000 (17:19 +0000)]
Added temporary LocalFilePurgeThumbnails hook for bug 27641

12 years ago(bug 31514) Followup r99031: allow clicking of links in table headers in a different...
Roan Kattouw [Tue, 25 Oct 2011 14:41:58 +0000 (14:41 +0000)]
(bug 31514) Followup r99031: allow clicking of links in table headers in a different way that doesn't break expand/collapse links.

12 years agoMarked purgeThumbList() protected
Aaron Schulz [Tue, 25 Oct 2011 05:20:01 +0000 (05:20 +0000)]
Marked purgeThumbList() protected

12 years agoFollowup r100391: fix caret position test case on Opera, Firefox 3.5/3.6/4.0/5.0
Brion Vibber [Mon, 24 Oct 2011 22:28:09 +0000 (22:28 +0000)]
Followup r100391: fix caret position test case on Opera, Firefox 3.5/3.6/4.0/5.0

Opera (through 11.52 at least) & Firefox prior to 6.0 set the caret initially to the end of the textarea, which gave a mismatch. All we really need is to know we got a sane value, so checking for both (start == 0; end == text.length) gets the job done.
Under ideal circumstances, we'd check after a user clicks in the textarea on the first line, but no good way to trigger that. :)

12 years agoFU r100645: don't pass unused param
Aaron Schulz [Mon, 24 Oct 2011 22:19:02 +0000 (22:19 +0000)]
FU r100645: don't pass unused param

12 years ago* Remove $abort parameter from MediaWiki::checkMaxLag(); unused and it's a private...
Alexandre Emsenhuber [Mon, 24 Oct 2011 20:37:54 +0000 (20:37 +0000)]
* Remove $abort parameter from MediaWiki::checkMaxLag(); unused and it's a private function.
* Restore wfGetLB()->getMaxLag() call since we are no more in index.php

12 years agoLocalisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Mon, 24 Oct 2011 20:02:53 +0000 (20:02 +0000)]
Localisation updates for core and extension messages from translatewiki.net

12 years agoAdd user_former_groups table to PG updater
OverlordQ [Mon, 24 Oct 2011 19:55:01 +0000 (19:55 +0000)]
Add user_former_groups table to PG updater

12 years agoUpdate Postgres with missing uploadstash tables
OverlordQ [Mon, 24 Oct 2011 19:43:16 +0000 (19:43 +0000)]
Update Postgres with missing uploadstash tables

12 years agoBasic support for Postgres phpunit testing, currently throws 5 errors, 1 inc, 5 skipped
OverlordQ [Mon, 24 Oct 2011 19:28:31 +0000 (19:28 +0000)]
Basic support for Postgres phpunit testing, currently throws 5 errors, 1 inc, 5 skipped

12 years agoTests for r96188 features
Antoine Musso [Mon, 24 Oct 2011 17:45:45 +0000 (17:45 +0000)]
Tests for r96188 features

That revision let us pass an array of values to 'class', 'rel'
and 'accesskey'. The revision requested some tests :)

12 years agoAdded OutputPage::setPageTitleMsg() and OutputPage::setHTMLTitleMsg() as modified...
Alexandre Emsenhuber [Mon, 24 Oct 2011 17:24:38 +0000 (17:24 +0000)]
Added OutputPage::setPageTitleMsg() and OutputPage::setHTMLTitleMsg() as modified versions of OutputPage::setPageTitle() and OutputPage::setHTMLTitle() that take an message name and its parameters; updated all calls in core that can use the two new functions

12 years agoRemoved unused and deprecated global declaration of $wgDeferredUpdateList
Alexandre Emsenhuber [Mon, 24 Oct 2011 16:17:46 +0000 (16:17 +0000)]
Removed unused and deprecated global declaration of $wgDeferredUpdateList

12 years ago* (bug 31921) Fix for r78201: magic words REVISIONDAY, REVISIONMONTH and REVISIONYEAR...
Alexandre Emsenhuber [Mon, 24 Oct 2011 16:14:49 +0000 (16:14 +0000)]
* (bug 31921) Fix for r78201: magic words REVISIONDAY, REVISIONMONTH and REVISIONYEAR now give current values on preview

12 years agoUpdate formatting. Update "<space><tab>" and "<tab><space>" where needed.
Siebrand Mazeland [Mon, 24 Oct 2011 16:10:04 +0000 (16:10 +0000)]
Update formatting. Update "<space><tab>" and "<tab><space>" where needed.

12 years agomakes HTML5 five only attributes a global property
Antoine Musso [Mon, 24 Oct 2011 13:58:03 +0000 (13:58 +0000)]
makes HTML5 five only attributes a global property

This patch move an array hidden in Html::expandAttributes() to the top of
the class definition as self::$HTMLFiveOnlyAttribs.
That also make the Html::expandAttributes() method a bit more concise.

12 years agotest that preloaded text is unstripped
Antoine Musso [Mon, 24 Oct 2011 10:51:46 +0000 (10:51 +0000)]
test that preloaded text is unstripped

bug 27467 reported our preloaded system did not unstrip <nowiki>
or <pre> enclosed text. The fix was applied by r82473.

12 years agotest {{SERVERNAME}} with relative URLS
Antoine Musso [Mon, 24 Oct 2011 09:32:33 +0000 (09:32 +0000)]
test {{SERVERNAME}} with relative URLS

bug 31176 mentionned an issue with {{SERVERNAME}} returning the full
URL instead of servername when using relative URLs (//localhost).
The fix was made by r98193.

This patch test three different URL protocols (http, https & relative)
and check we return the expected 'localhost'.

12 years agousing real identity for hashar
Antoine Musso [Mon, 24 Oct 2011 09:08:13 +0000 (09:08 +0000)]
using real identity for hashar

Converting my pseudonym to use my real identity instead:
Ashar Voultoiz -> Antoine Musso

12 years agoTest handling of escaped CSS comments
Antoine Musso [Mon, 24 Oct 2011 08:39:58 +0000 (08:39 +0000)]
Test handling of escaped CSS comments

r85856 fixed a CSS injection issue but lacked testing. This
test verify we properly strip out CSS comments even when the
token delimiter '/*' is backslash-escaped : \2f\2a

12 years agoUpdated documentation of $wgMaxImageArea for r99911 etc.
Tim Starling [Mon, 24 Oct 2011 04:45:26 +0000 (04:45 +0000)]
Updated documentation of $wgMaxImageArea for r99911 etc.

12 years agoFU r100535:
Aaron Schulz [Mon, 24 Oct 2011 03:08:45 +0000 (03:08 +0000)]
FU r100535:
* Changed custom functions to work via a $thgThumbCallbacks variable
* Added 'checkCache' and 'fillCache' hooks to $thgThumbCallbacks
* Minor regex cleanup to wfExtractThumbParams()
* Re-organized a bit of the wfStreamThumbViaCurl() code

12 years ago(follow-up r100575 / r99477) unit-tests for jpegMetadataExtractor dealing with paddin...
Brian Wolff [Mon, 24 Oct 2011 02:47:22 +0000 (02:47 +0000)]
(follow-up r100575 / r99477) unit-tests for jpegMetadataExtractor dealing with padding bytes.

12 years ago(follow up r99477) not sure what I was doing on r99477, but its not right (doesn...
Brian Wolff [Mon, 24 Oct 2011 02:41:34 +0000 (02:41 +0000)]
(follow up r99477) not sure what I was doing on r99477, but its not right (doesn't work for odd number padding bytes)

Will commit unittests in follow up.

12 years ago(bug 31740) JpegMetadataExtractor and friends weren't checking for unexpected end...
Brian Wolff [Mon, 24 Oct 2011 02:19:11 +0000 (02:19 +0000)]
(bug 31740) JpegMetadataExtractor and friends weren't checking for unexpected end of input properly

I created a new wrapper around unpack - wfUnpack which throws an exception if it runs out of input
(but i didn't use that on GIFMetadataExtractor/PNGMetadataExtractor because those files have a header saying that they weren't external dependencies minimized for potential re-users. I don't think anyone actually re-uses those files, but I didn't want to add a dependency on wfUnpack just in case).

I also changed fopen( blah, "r" ) -> fopen( blah, "rb" ) since these are binary formats, so we don't want newlines converted on windows.

12 years agoUpdate green buttons to a color that doesn't clash with Vector.
Brandon Harris [Sun, 23 Oct 2011 22:49:03 +0000 (22:49 +0000)]
Update green buttons to a color that doesn't clash with Vector.

12 years agoLocalisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Sun, 23 Oct 2011 19:48:36 +0000 (19:48 +0000)]
Localisation updates for core and extension messages from translatewiki.net

12 years agoAdding functions to HTMLForm for explicitly setting the content of the header and...
John Du Hart [Sun, 23 Oct 2011 18:38:22 +0000 (18:38 +0000)]
Adding functions to HTMLForm for explicitly setting the content of the header and footer.
Also adds a function for setting the intro, as a counterpart to addPreText

12 years agoHTMLForm is now a context source.
John Du Hart [Sun, 23 Oct 2011 18:09:44 +0000 (18:09 +0000)]
HTMLForm is now a context source.
Replace wfMessage() calls with $this->msg()

12 years agoAdding flatlists to HTMLRadioField, sort of like HTMLMultiSelect
John Du Hart [Sun, 23 Oct 2011 16:57:53 +0000 (16:57 +0000)]
Adding flatlists to HTMLRadioField, sort of like HTMLMultiSelect

12 years agoAdd check to see if the user has permission to view the log. Right now the page title...
John Du Hart [Sun, 23 Oct 2011 16:45:08 +0000 (16:45 +0000)]
Add check to see if the user has permission to view the log. Right now the page title and description are still set.

12 years agoRemoved wrong comment in doBatchLookups()
Aaron Schulz [Sun, 23 Oct 2011 10:15:51 +0000 (10:15 +0000)]
Removed wrong comment in doBatchLookups()

12 years agoReverted r99195 quick-fix per r99897
Aaron Schulz [Sun, 23 Oct 2011 09:51:13 +0000 (09:51 +0000)]
Reverted r99195 quick-fix per r99897

12 years agoUse getId() accessors for Revision object (fixes fatal)
Aaron Schulz [Sun, 23 Oct 2011 09:38:52 +0000 (09:38 +0000)]
Use getId() accessors for Revision object (fixes fatal)

12 years agoAdded a basic thumb-handler.php file, configured via thumb.config.php. The code is...
Aaron Schulz [Sun, 23 Oct 2011 09:36:35 +0000 (09:36 +0000)]
Added a basic thumb-handler.php file, configured via thumb.config.php. The code is based on the wmf thumb handler, but simplified. It is disabled by default.
* The thumb.php parameter extraction can also be overridden by the config to handle more complex setups and things like OggHandler and PagedTiffHandler.
* A simple 404 error page is also included. It can be overridden by the config.
* Additional HTTP headers can be passed through cURL via the config.

12 years ago* Changed action=history to use an Action subclass
Alexandre Emsenhuber [Sun, 23 Oct 2011 09:21:02 +0000 (09:21 +0000)]
* Changed action=history to use an Action subclass
* Use local context instead of global variables
* Removed obsolete aliases PageHistory and PageHistoryPager; no longer used
* Made Action::getContext() and related methods public for the call in HistoryPager's constructor and also for consistency with other classes

12 years agoGroup shell-related functions
Alexandre Emsenhuber [Sun, 23 Oct 2011 08:54:48 +0000 (08:54 +0000)]
Group shell-related functions

12 years agoUse attr() instead of this.href, to make sure that we don't absolutify the URI.
Derk-Jan Hartman [Sun, 23 Oct 2011 08:17:19 +0000 (08:17 +0000)]
Use attr() instead of this.href, to make sure that we don't absolutify the URI.

Fixes bug 31899

12 years ago* Use local context to get messages
Alexandre Emsenhuber [Sun, 23 Oct 2011 08:13:52 +0000 (08:13 +0000)]
* Use local context to get messages
* Simply use getLang() instead of getContext()->getLang() now that this method exists
* Also changed addWikiMsgArray() to use a Message object with addWikiText() for the parse operation; removed its $options parameter, no caller was using it

12 years agoCheck first that $wgDisableLangConversion is false and we are not in a special page...
Alexandre Emsenhuber [Sun, 23 Oct 2011 07:55:45 +0000 (07:55 +0000)]
Check first that $wgDisableLangConversion is false and we are not in a special page before doing the language variant check

12 years agoFollow up r100512, adding @since tags and using wfMessage
John Du Hart [Sun, 23 Oct 2011 01:10:23 +0000 (01:10 +0000)]
Follow up r100512, adding @since tags and using wfMessage

12 years agoAllowing moving -> allow moving; use past tense
Robin Pepermans [Sat, 22 Oct 2011 20:48:59 +0000 (20:48 +0000)]
Allowing moving -> allow moving; use past tense

12 years agoLocalisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Sat, 22 Oct 2011 20:29:38 +0000 (20:29 +0000)]
Localisation updates for core and extension messages from translatewiki.net

12 years agoRemoving extra stuff that was committed in r100512
John Du Hart [Sat, 22 Oct 2011 20:10:41 +0000 (20:10 +0000)]
Removing extra stuff that was committed in r100512

12 years agoAdding functions to HTMLForm for setting the submitText and WrapperLegend to messages...
John Du Hart [Sat, 22 Oct 2011 20:03:40 +0000 (20:03 +0000)]
Adding functions to HTMLForm for setting the submitText and WrapperLegend to messages instead of having to use wfMsg every single time

12 years agoFollow up to r79085. Fixes bug 31408.
Derk-Jan Hartman [Sat, 22 Oct 2011 19:50:43 +0000 (19:50 +0000)]
Follow up to r79085. Fixes bug 31408.

There was a typo, causing the minoredit tag not to show up in the enhanced recentchanges.

12 years agoTypo.
Rotem Liss [Sat, 22 Oct 2011 17:35:20 +0000 (17:35 +0000)]
Typo.

12 years ago* Call Linker methods statically
Alexandre Emsenhuber [Sat, 22 Oct 2011 05:06:54 +0000 (05:06 +0000)]
* Call Linker methods statically
* Use local context to get messages

12 years agoRevision objects now always use the current name of users, loading it on demand if...
Aaron Schulz [Fri, 21 Oct 2011 23:20:52 +0000 (23:20 +0000)]
Revision objects now always use the current name of users, loading it on demand if necessary (e.g. when given a $row with no user_name but rev_user is not 0)

12 years agoFix fatal: Fatal error: func_get_args(): Can't be used as a function parameter in...
Platonides [Fri, 21 Oct 2011 22:18:02 +0000 (22:18 +0000)]
Fix fatal: Fatal error: func_get_args(): Can't be used as a function parameter in includes/context/ContextSource.php on line 121

12 years agoLocalisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Fri, 21 Oct 2011 20:30:08 +0000 (20:30 +0000)]
Localisation updates for core and extension messages from translatewiki.net

12 years agoFollowup r100396, use is_string instead of !is_array
John Du Hart [Fri, 21 Oct 2011 20:24:03 +0000 (20:24 +0000)]
Followup r100396, use is_string instead of !is_array

12 years agoUse local context to get messages
Alexandre Emsenhuber [Fri, 21 Oct 2011 20:09:27 +0000 (20:09 +0000)]
Use local context to get messages

12 years ago* Call Linker methods statically
Alexandre Emsenhuber [Fri, 21 Oct 2011 16:54:25 +0000 (16:54 +0000)]
* Call Linker methods statically
* Removed now-useless parameter RevisionDeleter::getLogLinks(), updated the only caller

12 years ago* (bug 31847) Fix positioning of WikiEditor 'header' insertions when selection is...
Brion Vibber [Fri, 21 Oct 2011 00:15:45 +0000 (00:15 +0000)]
* (bug 31847) Fix positioning of WikiEditor 'header' insertions when selection is empty in IE 7/8

Follows up to the test cases added in r100391. jquery.textSelection's getCaretPosition() for IE needs to focus the textarea first in order to get consistent results when there's an empty selection -- getSelection() which returns the text already does this.

Because focus had previously been stolen by the drop-down menus in WikiEditor's toolbar, the saveCursorAndScrollTop() was getting a bogus result from getCaretPosition, saving that, then restoring the bad selection (wiping out the original caret position) right before going ahead with the encapsulateText call.

Now seems to get the correct caret position, and also doesn't appear to interfere with selections.

12 years agoBugfix to r96441, class_exists throws warnings when arrays are passed to it
John Du Hart [Fri, 21 Oct 2011 00:09:56 +0000 (00:09 +0000)]
Bugfix to r96441, class_exists throws warnings when arrays are passed to it

12 years agoQUnit test cases for bug 31847: will trigger a fail on IE 6/7/8
Brion Vibber [Thu, 20 Oct 2011 22:50:04 +0000 (22:50 +0000)]
QUnit test cases for bug 31847: will trigger a fail on IE 6/7/8

jquery.textSelection's getCaretPosition() gives bogus results on IE 6/7/8 when there's not a selection set in the textarea; it seems to give us some value somewhere in the middle of the textarea, rather than what we expected.
If we actually set an empty selection, then it gets it back just fine!
But if the cursor is in initial state, or has been moved by the user, we get back garbage. This is causing WikiEditor to sometimes insert things in the wrong place, as it tries to pull the caret position and manipulate the selection to do insertions; we then end up using the bogus selection when it gets saved in via selection restoration.

12 years agoUpdating jquery.qunit from upstream
Krinkle [Thu, 20 Oct 2011 22:35:27 +0000 (22:35 +0000)]
Updating jquery.qunit from upstream
* Source: https://github.com/jquery/qunit/tree/ee156923cdb01820e35e6bb579d5cf6bf55736d4
-- Several bug fixes
-- New hooks system
-- Version numbers, finally (this is 1.2.0pre)
-- (BREAKING CHANGE) start/stop now takes count instead of timeout as first argument (read more at https://github.com/jquery/qunit/pull/125 and http://docs.jquery.com/QUnit/stop)

12 years ago[JSTesting] Fix dependencies. Of course jquery.qunit.completenessTest needs jquery...
Krinkle [Thu, 20 Oct 2011 22:34:05 +0000 (22:34 +0000)]
[JSTesting] Fix dependencies. Of course jquery.qunit.completenessTest needs jquery.qunit

12 years ago[JSTesting] Don't rely on the timeout argument of start/stop. This behavior is remove...
Krinkle [Thu, 20 Oct 2011 22:33:05 +0000 (22:33 +0000)]
[JSTesting] Don't rely on the timeout argument of start/stop. This behavior is removed in the latest QUnit version.
-- Actually, in the latest QUnit version start/stop take 'count' as first argument. It would internally set the number of wait levels to 5000 xD

12 years agoAfter r100379, move release notes for bug 29392
Sam Reed [Thu, 20 Oct 2011 21:22:59 +0000 (21:22 +0000)]
After r100379, move release notes for bug 29392

12 years agoLocalisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Thu, 20 Oct 2011 19:16:53 +0000 (19:16 +0000)]
Localisation updates for core and extension messages from translatewiki.net

12 years agoMore whitespace tweaks...and fixed doc typo
Aaron Schulz [Thu, 20 Oct 2011 19:05:48 +0000 (19:05 +0000)]
More whitespace tweaks...and fixed doc typo

12 years agoRemoved deprecated getFullPath(); no callers
Aaron Schulz [Thu, 20 Oct 2011 17:13:53 +0000 (17:13 +0000)]
Removed deprecated getFullPath(); no callers

12 years agoeol w/s
Mark A. Hershberger [Thu, 20 Oct 2011 15:12:13 +0000 (15:12 +0000)]
eol w/s

12 years agoRevert r79363, r79364, and r79369 to disable datalists support entirely based
Mark A. Hershberger [Thu, 20 Oct 2011 14:46:29 +0000 (14:46 +0000)]
Revert r79363, r79364, and r79369 to disable datalists support entirely based
on Bug 31602, Bug 31697, Bug 31654, Bug 31658, and even Aryeh Gregor's
comments in
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2010-December/029593.html

12 years ago(bug 31345) document API Revisions parameters as enum
Antoine Musso [Thu, 20 Oct 2011 14:28:41 +0000 (14:28 +0000)]
(bug 31345) document API Revisions parameters as enum

Patch by Brad Jorsch.

12 years agoFix for r100333: forgot to override requiresWrite() and requiresUnblock()
Alexandre Emsenhuber [Thu, 20 Oct 2011 10:29:51 +0000 (10:29 +0000)]
Fix for r100333: forgot to override requiresWrite() and requiresUnblock()

12 years ago* Changed action=raw to use an Action subclass
Alexandre Emsenhuber [Thu, 20 Oct 2011 08:10:25 +0000 (08:10 +0000)]
* Changed action=raw to use an Action subclass
* Left RawPage with back compat code for extensions that use it
* Removed calls to Skin for gen=(css|js). Calling action=raw&gen=(css|js) will now unconditionally return empty content
* Removed Skin::generateUserJs() and Skin::generateUserStylesheet() since they were only used in RawPage

12 years ago* (bug 25306) Add link of old page title to MediaWiki:Delete_and_move_reason
Raimond Spekking [Thu, 20 Oct 2011 07:36:22 +0000 (07:36 +0000)]
* (bug 25306) Add link of old page title to MediaWiki:Delete_and_move_reason

12 years ago* Simplified r100286 by just using the field 'user_name' and removed the COALESCE
Aaron Schulz [Thu, 20 Oct 2011 03:03:45 +0000 (03:03 +0000)]
* Simplified r100286 by just using the field 'user_name' and removed the COALESCE
* Simplified contribs pager with Revision::selectFields()

12 years agoMoved contribs rev parent ID batch query into doBatchLookups()
Aaron Schulz [Thu, 20 Oct 2011 02:26:59 +0000 (02:26 +0000)]
Moved contribs rev parent ID batch query into doBatchLookups()

12 years ago* Made ?contribs=user actually show the results for the *user* if 'newbies' was given...
Aaron Schulz [Thu, 20 Oct 2011 01:15:28 +0000 (01:15 +0000)]
* Made ?contribs=user actually show the results for the *user* if 'newbies' was given as the user.
* Added a link batch query to newbie contribs paging

12 years ago* Added a proper Pager::doBatchLookups() function
Aaron Schulz [Thu, 20 Oct 2011 00:43:43 +0000 (00:43 +0000)]
* Added a proper Pager::doBatchLookups() function
* Made HistoryPager use a link batch via Pager::doBatchLookups()

12 years agoFU r100300, r100286:
Aaron Schulz [Thu, 20 Oct 2011 00:41:48 +0000 (00:41 +0000)]
FU r100300, r100286:
* Updated link batch code in MergeHistory
* Marked some Revision functions explicitly public

12 years agoJOIN to get user_name in Contributions, HistoryPage, RevisionList, RevisionDelete...
Aaron Schulz [Thu, 20 Oct 2011 00:04:14 +0000 (00:04 +0000)]
JOIN to get user_name in Contributions, HistoryPage, RevisionList, RevisionDelete, and MergeHistory

12 years agoFU r100286: Added sanity check to fetchFromConds() join conds
Aaron Schulz [Wed, 19 Oct 2011 23:56:48 +0000 (23:56 +0000)]
FU r100286: Added sanity check to fetchFromConds() join conds

12 years ago* Tweaked Revision class to handle loading the current user name instead of rev_user_...
Aaron Schulz [Wed, 19 Oct 2011 22:25:26 +0000 (22:25 +0000)]
* Tweaked Revision class to handle loading the current user name instead of rev_user_text. It still falls back to rev_user_text when building objects from DB rows for b/c.
* Moved JOIN conds to fetchFromConds() as that's where the tables are specified. This lets us avoid the same page_id=rev_page join conds plastered all over the code. Also, we can't mix WHERE and JOIN style join conds.
* Removed duplication in fetchFromConds() by using selectPageFields().
* Removed duplicate rev_parent_id field from contribs SELECT.

Yo make use of these changes, Pagers and lists still need to be updated to use Revision::selectUserFields() and join on the user table.

12 years agoCode cleanups & fixed strange comma
Aaron Schulz [Wed, 19 Oct 2011 21:21:20 +0000 (21:21 +0000)]
Code cleanups & fixed strange comma

12 years agoLocalisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Wed, 19 Oct 2011 20:15:34 +0000 (20:15 +0000)]
Localisation updates for core and extension messages from translatewiki.net

12 years agoAdd some braces
Sam Reed [Wed, 19 Oct 2011 20:08:15 +0000 (20:08 +0000)]
Add some braces

Unindent most of the code

12 years agoRevert r100262 — wasn't the right place for it and other problems,
Mark A. Hershberger [Wed, 19 Oct 2011 20:01:50 +0000 (20:01 +0000)]
Revert r100262 — wasn't the right place for it and other problems,
like broken parser tests.

Please read [[Manual:Pre-commit checklist]] before committing.

12 years agowe want to get the edit token, not edit the token...
Jeroen De Dauw [Wed, 19 Oct 2011 19:38:17 +0000 (19:38 +0000)]
we want to get the edit token, not edit the token...

12 years agoGive a clear error message instead of un-intelligible UNIQ.*QINU
Mark A. Hershberger [Wed, 19 Oct 2011 19:34:56 +0000 (19:34 +0000)]
Give a clear error message instead of un-intelligible UNIQ.*QINU
markers.

Not sure the preg_match() is actually needed.  Or it may be
appropriate to use MARKER_SUFFIX for the match.

The error message may also need to be rewritten to be more
user-friendly, but I'm pretty sure *an* error message is friendlier
than UNIQ garbage.  And making them visible error messages makes them
easier to be found.

12 years agoJoin ipb_by to user table to get the user name. If we can't find a user, fallback...
Aaron Schulz [Wed, 19 Oct 2011 18:50:34 +0000 (18:50 +0000)]
Join ipb_by to user table to get the user name. If we can't find a user, fallback to ipb_by_text. This lets centralauth blocks have the blocking user be displayable again.

12 years ago* Fixed undefined var $g error
Aaron Schulz [Wed, 19 Oct 2011 17:30:55 +0000 (17:30 +0000)]
* Fixed undefined var $g error
* Style cleanups

12 years agoChange the hook case per CR r95152
Raimond Spekking [Wed, 19 Oct 2011 17:15:05 +0000 (17:15 +0000)]
Change the hook case per CR r95152

12 years agoFollow-up r82285: we should not apply case conversion to these names, because it...
Happy-melon [Wed, 19 Oct 2011 17:09:04 +0000 (17:09 +0000)]
Follow-up r82285: we should not apply case conversion to these names, because it's unintuitive and potentially risky when they could theoretically contain weird characters.  It was necessary before r86508, but not now there is a prefix meaning the group name is not at the start of the title.  Plus the default messages are already at the lowercase titles.

12 years agoFollow-up r100227:
Alexandre Emsenhuber [Wed, 19 Oct 2011 15:30:02 +0000 (15:30 +0000)]
Follow-up r100227:
* Missed one call to ParserOptions::getUserLang() in Parser
* Also convert RefreshLinksJob and RefreshLinksJob2 to use ParserOptions::newFromUserAndLang() and pass $wgContLang instead of whatever $wgLang could be

12 years agoIt is valid (albeit silly) to specify lang;q=1.000 No more than three decimals are...
Platonides [Wed, 19 Oct 2011 15:15:08 +0000 (15:15 +0000)]
It is valid (albeit silly) to specify lang;q=1.000 No more than three decimals are allowed.
(rfc2616 section 3.9: Quality Values)
The language-range may contain more than one - (section 14.4) such as x-pig-latin
(section 3.10: Language Tags)

12 years agoDon't reinvent the wheel in LegacyTemplate::pageStats(), just use them items from...
Alexandre Emsenhuber [Wed, 19 Oct 2011 14:52:26 +0000 (14:52 +0000)]
Don't reinvent the wheel in LegacyTemplate::pageStats(), just use them items from SkinTemplate

12 years ago* Changed ParserOptions to store a Language object instead of only a string, avoids...
Alexandre Emsenhuber [Wed, 19 Oct 2011 14:16:01 +0000 (14:16 +0000)]
* Changed ParserOptions to store a Language object instead of only a string, avoids object -> string -> object conversion
* ParserOptions::getUserLang() will still return a string for compatibility, added ParserOptions::getUserLangObj() to get the object
* Added ParserOptions::newFromUserAndLang() and ParserOptions::newFromContext() to easily get a ParserOptions object when a context is available or when someone wants to force the language
* Updated OutputPage and Preferences to use newFromContext() and WikiPage to use newFromUserAndLang()
* ParserOptions::setUserLang() still accepts either a string or a Language object, but changed the calls to pass an object instead of a string
* Changed Parser::getFunctionLang() to return the Language object from ParserOptions when parsing interface messages rather than $wgLang directly and updated the documentation to say that $wgLang should not be used directly (as $wgUser, $wgTitle and $wgRequest)

12 years agoRevert unihan.zip's version to 5.2.0.
Philip Tzou [Wed, 19 Oct 2011 14:13:41 +0000 (14:13 +0000)]
Revert unihan.zip's version to 5.2.0.