lhc/web/wiklou.git
13 years ago* Swapping enableForOther locked input-field from disabled to readonly. No need to...
Krinkle [Tue, 23 Nov 2010 00:40:45 +0000 (00:40 +0000)]
* Swapping enableForOther locked input-field from disabled to readonly. No need to block users from selecting the text inside, only block editing it field.
* On top of that, also using javascript to hide the input-field if/when not needed, untill needed (PHP has a backup check to only use this value if the radio-button was on 'other')
* Escaping special html characters in the attributes. The message for .mw-help-field-hint contained the phrase "  content pages, in a "'''project namespace'''".  " which (raw, unescaped) ends the attribute right after the "a". Fixed now.

13 years agoPressing enter in an input field doesn't trigger display:none elements in WebKit...
Krinkle [Tue, 23 Nov 2010 00:04:02 +0000 (00:04 +0000)]
Pressing enter in an input field doesn't trigger display:none elements in WebKit-browsers. Either put Back-button after Continue (visually not a good choise)... or keep the current double-button-first-hidden approach but in a different way that doesn't use display:none. Doing the latter for now.

13 years agowhitespace commit (removing trailing space)
Krinkle [Mon, 22 Nov 2010 23:55:37 +0000 (23:55 +0000)]
whitespace commit (removing trailing space)

13 years agoPutting .config-page-list (sidebar nav) floating to the right as part of the page...
Krinkle [Mon, 22 Nov 2010 23:52:59 +0000 (23:52 +0000)]
Putting .config-page-list (sidebar nav) floating to the right as part of the page (instead of floating outside the page content). This takes away the dead white space on longer pages by making it grey instead of white (previously this made the page look very unorganized and off-grid in more narrow windows). This also fixes a layout bug in Safari where the tops didn't line up.

13 years agofixing a TypeError when the function would be called without any arguments
Krinkle [Mon, 22 Nov 2010 23:40:07 +0000 (23:40 +0000)]
fixing a TypeError when the function would be called without any arguments

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Mon, 22 Nov 2010 20:38:23 +0000 (20:38 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-11-22 20:22:00 UTC)

13 years agoMove storing of $db down to SearchEngine
Platonides [Mon, 22 Nov 2010 16:08:12 +0000 (16:08 +0000)]
Move storing of $db down to SearchEngine
Fixes the r76809 issue of SearchDbTest not being marked as requiring a Database.

13 years agoFix typo
Platonides [Mon, 22 Nov 2010 16:03:56 +0000 (16:03 +0000)]
Fix typo

13 years agoFix a doxygen warning
Alexandre Emsenhuber [Mon, 22 Nov 2010 15:36:17 +0000 (15:36 +0000)]
Fix a doxygen warning

13 years agoRemove Arabic fallback. Shouldn't be RTL.
Siebrand Mazeland [Mon, 22 Nov 2010 14:09:29 +0000 (14:09 +0000)]
Remove Arabic fallback. Shouldn't be RTL.

13 years agoTweak param documentation
Sam Reed [Sun, 21 Nov 2010 23:18:52 +0000 (23:18 +0000)]
Tweak param documentation

13 years ago* Break lines at 80 chars
Alexandre Emsenhuber [Sun, 21 Nov 2010 21:35:30 +0000 (21:35 +0000)]
* Break lines at 80 chars
* Remove trailing whitespaces

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Sun, 21 Nov 2010 20:20:38 +0000 (20:20 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-11-21 19:57:00 UTC)

13 years agoRefactoring of *Field classes:
Max Semenik [Sun, 21 Nov 2010 19:56:51 +0000 (19:56 +0000)]
Refactoring of *Field classes:
* Made them all implement one common interface (might add more functions to it later)
* Moved MySQLField to DatabaseMysql.php
* Renamed nullable() to isNullable()
* Removed maxLength() from:
** SQLiteField: makes no sense
** MySQLField: doesn't do what people may think, useless for this class' purpose of assisting querying the DB schema

13 years agoPer r77072 CR, followup r66872 (seemingly my crappy code from 5 months ago) like...
Sam Reed [Sun, 21 Nov 2010 17:27:13 +0000 (17:27 +0000)]
Per r77072 CR, followup r66872 (seemingly my crappy code from 5 months ago) like r77079

13 years agoPer Reedy, follow-up to r77072: don't use array_merge() to add just one item
Alexandre Emsenhuber [Sun, 21 Nov 2010 17:02:12 +0000 (17:02 +0000)]
Per Reedy, follow-up to r77072: don't use array_merge() to add just one item

13 years agoFollow up r77058 per CR
Platonides [Sun, 21 Nov 2010 16:26:23 +0000 (16:26 +0000)]
Follow up r77058 per CR

13 years agoFix path
Alexandre Emsenhuber [Sun, 21 Nov 2010 15:44:46 +0000 (15:44 +0000)]
Fix path

13 years agoAdd UploadStashFile
Platonides [Sun, 21 Nov 2010 15:20:04 +0000 (15:20 +0000)]
Add UploadStashFile

13 years agoAdd PhpHttpRequest, added in r60811
Platonides [Sun, 21 Nov 2010 14:35:39 +0000 (14:35 +0000)]
Add PhpHttpRequest, added in r60811

13 years ago* (bug 26006) prop=langlinks now allows obtaining full URL
Alexandre Emsenhuber [Sun, 21 Nov 2010 14:04:10 +0000 (14:04 +0000)]
* (bug 26006) prop=langlinks now allows obtaining full URL

13 years agoNote version and revision deprecating wfGetMimeMagic (fu r68837)
Antoine Musso [Sun, 21 Nov 2010 12:03:17 +0000 (12:03 +0000)]
Note version and revision deprecating wfGetMimeMagic (fu r68837)

13 years agoNote about CC Licence marks (follow up r66559)
Antoine Musso [Sun, 21 Nov 2010 11:52:13 +0000 (11:52 +0000)]
Note about CC Licence marks (follow up r66559)

13 years ago*(bug 25920) Moved forward ref to a back ref to really get v6 regex to compile on...
Aaron Schulz [Sun, 21 Nov 2010 10:49:54 +0000 (10:49 +0000)]
*(bug 25920) Moved forward ref to a back ref to really get v6 regex to compile on older PCRE versions. Works around PCRE 8 nested named ref bug that killed r76928.
* Added another simple v6 assertion

13 years agoclass portlet -> class portal (Vector). #mw-panel's class for the items themselfs...
Krinkle [Sat, 20 Nov 2010 21:07:34 +0000 (21:07 +0000)]
class portlet -> class portal (Vector). #mw-panel's class for the items themselfs is also different in Vector. Now the sidebar finally looks the way it should (like Vector-skin in-wiki)

13 years agoMaking path to bullet.gif in config.css relative to it self instead of absolute.
Krinkle [Sat, 20 Nov 2010 20:24:48 +0000 (20:24 +0000)]
Making path to bullet.gif in config.css relative to it self instead of absolute.
* Installer has a 'Status of 404 (Not Found)' (/w/skins/skins/vector/images/bullet.gif). Source of this problem is "str_replace( 'images/', '../skins/vector/images/',  );" on line 99 of WebInstallerOutput.php::GetCSS() which transforms this line:
  list-style-image: url(../skins/common/images/bullet.gif);
into this:
  list-style-image: url(../skins/common/../skins/vector/images/bullet.gif);
 all other stylesheets do it relative also, therefor changing this accordingly to:
  list-style-image: url(images/bullet.gif);
But since the installer does not load them directly but includes them from a different path, the str_replace() has been changed from a single replace for both files to two replaces, since they are not both in /vector/ images, config.css is in /common/ and it's images are in /common/images, not /vector/images. Fixed now.

13 years agoVector has 'body' as portlet class (Follow-up r76880), Monobook had 'pBody', also...
Krinkle [Sat, 20 Nov 2010 20:09:05 +0000 (20:09 +0000)]
Vector has 'body' as portlet class (Follow-up r76880), Monobook had 'pBody', also removing redundant </div>.
* #mw-panel > div.portlet > div.body is the CSS rule, didn't work before causing the rule to hide list bullets to be ignored
* 'Unmatched </div> encountered.  Ignoring tag.'-error solved

13 years agoFollow-up on r76987 (and it's comment) - adding dependency to make the script-call...
Krinkle [Sat, 20 Nov 2010 19:51:26 +0000 (19:51 +0000)]
Follow-up on r76987 (and it's comment) - adding dependency to make the script-call in mw.util work

13 years agoRevert r76394 after r76806 and document in getInstallSteps() the existance of such...
Platonides [Sat, 20 Nov 2010 15:19:51 +0000 (15:19 +0000)]
Revert r76394 after r76806 and document in getInstallSteps() the existance of such messages.

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Sat, 20 Nov 2010 11:54:40 +0000 (11:54 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-11-20 11:25:00 UTC)

13 years agoDon't add newlines and tabs in the documentation, wordwrap() already does this
Alexandre Emsenhuber [Sat, 20 Nov 2010 11:14:11 +0000 (11:14 +0000)]
Don't add newlines and tabs in the documentation, wordwrap() already does this

13 years ago* (bug 26023) Corrected deleteBacth.php's documentation
Alexandre Emsenhuber [Sat, 20 Nov 2010 11:11:20 +0000 (11:11 +0000)]
* (bug 26023) Corrected deleteBacth.php's documentation

13 years agoPer CR r77020, followup to r77046: add a constant so that extensions can more easily...
Tim Starling [Sat, 20 Nov 2010 07:05:02 +0000 (07:05 +0000)]
Per CR r77020, followup to r77046: add a constant so that extensions can more easily support versions of MediaWiki without $wgResourceModules. But note that the ClickTracking style of registration would have worked as well, since an array index write works even if the variable is unset.

13 years agoFix typo in doc comment.
Tim Starling [Sat, 20 Nov 2010 07:01:14 +0000 (07:01 +0000)]
Fix typo in doc comment.

13 years agoFixed order of statements - function was referred to before it was defined.
Trevor Parscal [Fri, 19 Nov 2010 23:01:53 +0000 (23:01 +0000)]
Fixed order of statements - function was referred to before it was defined.

13 years agowrap the redirect message (arrow image + target page name) into a div that has the...
Jack Phoenix [Fri, 19 Nov 2010 21:23:50 +0000 (21:23 +0000)]
wrap the redirect message (arrow image + target page name) into a div that has the class "redirectMsg" so that the redirection arrow can be customized with on-wiki CSS instead of having to overwrite skins/common/images/redirect(ltr|rtl).png

13 years agoSQLite types can be non-nullable
Max Semenik [Fri, 19 Nov 2010 20:34:44 +0000 (20:34 +0000)]
SQLite types can be non-nullable

13 years agosample configuration to run selenium against a grid server
Markus Glaser [Fri, 19 Nov 2010 14:12:54 +0000 (14:12 +0000)]
sample configuration to run selenium against a grid server

13 years agofixed broken path
Markus Glaser [Fri, 19 Nov 2010 14:12:07 +0000 (14:12 +0000)]
fixed broken path

13 years ago@fixme command doesn't exist in doxygen
Alexandre Emsenhuber [Fri, 19 Nov 2010 11:49:47 +0000 (11:49 +0000)]
@fixme command doesn't exist in doxygen

13 years ago* (bug 25987) prop=info&inprop=watched now also works for missing pages
Alexandre Emsenhuber [Fri, 19 Nov 2010 10:53:08 +0000 (10:53 +0000)]
* (bug 25987) prop=info&inprop=watched now also works for missing pages

13 years ago* Made Resources.php return a pure-data array instead of an ugly mix of data and...
Tim Starling [Fri, 19 Nov 2010 10:41:06 +0000 (10:41 +0000)]
* Made Resources.php return a pure-data array instead of an ugly mix of data and code. This allows the class code to be lazy-loaded with the autoloader, for a performance advantage especially on non-APC installs. And using the convention where if the class is omitted, ResourceLoaderFileModule is assumed, the registration code becomes shorter and simpler.
* Modified ResourceLoader to lazy-initialise module objects, for a further performance advantage.
* Deleted ResourceLoader::getModules(), provided getModuleNames() instead. Although the startup module needs this functionality, it's slow to generate, so to avoid misuse, it's better to provide a foolproof fast interface and let the startup module do the slow thing itself.
* Modified ResourceLoader::register() to optionally accept an info array instead of an object.
* Added $wgResourceModules, allowing extensions to efficiently define their own resource loader modules. The trouble with hooks is that they contain code, and code is slow. We've been through all this before with i18n. Hooks are useful as a performance tool only if you call them very rarely.
* Moved ResourceLoader settings to their own section in DefaultSettings.php
* Added options to ResourceLoaderFileModule equivalent to the $localBasePath and $remoteBasePath parameters, to allow it to be instantiated via the new array style. Also added remoteExtPath, which allows modules to be registered before $wgExtensionAssetsPath is known.
* Added OutputPage::getResourceLoader(), mostly for debugging.
* The time saving at the moment is about 5ms per request with no extensions, which is significant already with 6 load.php requests for a cold cache page view. This is a much more scalable interface; the relative saving will grow as more extensions are added which use this interface, especially for non-APC installs.

Although the interface is backwards compatible, extension updates will follow in a subsequent commit.

13 years ago* In ResourceLoaderContext, lazy-load $this->direction and $this->language, to avoid...
Tim Starling [Fri, 19 Nov 2010 06:52:38 +0000 (06:52 +0000)]
* In ResourceLoaderContext, lazy-load $this->direction and $this->language, to avoid loading the whole English localisation for load.php requests which never call getHash().
* Interpreted some Trevor-speak in the doc comment of ResourceLoader::preloadModuleInfo().
* Made setMsgBlobMtime() (called from preloadModuleInfo()) actually work, by making getMsgBlobMtime() use the cached blob times if they are available.

13 years ago* Some tweaks to wfMemoryLimit() to make it a bit faster.
Tim Starling [Fri, 19 Nov 2010 06:49:15 +0000 (06:49 +0000)]
* Some tweaks to wfMemoryLimit() to make it a bit faster.
* Fixed inappropriate use of empty(), added "break missing" comments as in zend_atol()

13 years agoFollowup to r76867. Only add canonical if there is no local page for the shared file.
Derk-Jan Hartman [Fri, 19 Nov 2010 01:40:56 +0000 (01:40 +0000)]
Followup to r76867. Only add canonical if there is no local page for the shared file.
Bug 25960

13 years agoUse wfGetCache( CACHE_ANYTHING ) instead of $wgMemc to store the result of ResourceLo...
Tim Starling [Fri, 19 Nov 2010 01:40:00 +0000 (01:40 +0000)]
Use wfGetCache( CACHE_ANYTHING ) instead of $wgMemc to store the result of ResourceLoader::filter(). Speeds up cold cache view of the main page on a non-APC default installation by a factor of 2.3 (measured using siege, no concurrency, URL list captured from Firefox, server = my laptop).

13 years agoBreak long lines
Tim Starling [Fri, 19 Nov 2010 01:31:53 +0000 (01:31 +0000)]
Break long lines

13 years ago* In CoreInstaller, fixed notice when extensions are present, due to incorrect format...
Tim Starling [Fri, 19 Nov 2010 01:31:16 +0000 (01:31 +0000)]
* In CoreInstaller, fixed notice when extensions are present, due to incorrect format of extensions callback entry
* In LocalSettingsGenerator, fixed PHP escaping of extension name.

13 years agoFollow-up r76987. Apparently this works better in Firefox 2.
Krinkle [Fri, 19 Nov 2010 00:18:42 +0000 (00:18 +0000)]
Follow-up r76987. Apparently this works better in Firefox 2.

13 years agojquery.placeholder.js rewritten
Krinkle [Fri, 19 Nov 2010 00:12:43 +0000 (00:12 +0000)]
jquery.placeholder.js rewritten
* Instead of calling placeholder() and passing the placeholder-text to it (which meant having to manage text-messages in javascript as well and calling it for each different one), it is now expected that the placeholder-attribute already exists on the page generated by PHP. placeholder() is then called on all input-elements with that attribute to provide fallback for browsers that don't support it.

13 years agoMoved rightClickEdit
Trevor Parscal [Thu, 18 Nov 2010 22:59:26 +0000 (22:59 +0000)]
Moved rightClickEdit

13 years agoMoved rightClickEdit
Trevor Parscal [Thu, 18 Nov 2010 22:04:46 +0000 (22:04 +0000)]
Moved rightClickEdit

13 years agoFollow-up on r76972, renaming files inside the folder accordingly
Krinkle [Thu, 18 Nov 2010 22:04:22 +0000 (22:04 +0000)]
Follow-up on r76972, renaming files inside the folder accordingly

13 years agoCleaned up the code a bit, and added a return false to prevent other bindings from...
Trevor Parscal [Thu, 18 Nov 2010 22:03:57 +0000 (22:03 +0000)]
Cleaned up the code a bit, and added a return false to prevent other bindings from being fired.

13 years agorenaming mediawiki.specials to mediawiki.special (matches the Special-pagename and...
Krinkle [Thu, 18 Nov 2010 22:02:53 +0000 (22:02 +0000)]
renaming mediawiki.specials to mediawiki.special (matches the Special-pagename and the 'singlular' convention)

13 years agoRenamed mediawiki.views.* to mediawiki.action.* to better relate to the action= URL...
Trevor Parscal [Thu, 18 Nov 2010 21:54:28 +0000 (21:54 +0000)]
Renamed mediawiki.views.* to mediawiki.action.* to better relate to the action= URL param

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Thu, 18 Nov 2010 21:11:56 +0000 (21:11 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-11-18 20:47:00 UTC)

13 years agogetDiffBody() cleanups:
Aaron Schulz [Thu, 18 Nov 2010 20:34:02 +0000 (20:34 +0000)]
getDiffBody() cleanups:
* marked it explicitly public
* cleaned up return types on failure
* broke long lines

13 years agoRelease notes for r68872
Max Semenik [Thu, 18 Nov 2010 19:58:27 +0000 (19:58 +0000)]
Release notes for r68872

13 years ago* simple smoke test for file upload
Markus Glaser [Thu, 18 Nov 2010 16:12:41 +0000 (16:12 +0000)]
* simple smoke test for file upload

13 years ago* Oracle: prefetching column names in ORAResult so i can release statement after...
Jure Kajzer [Thu, 18 Nov 2010 13:17:16 +0000 (13:17 +0000)]
* Oracle: prefetching column names in ORAResult so i can release statement after constructor.
This fixes too many open cursors issue, importing of large sets now works.

13 years agoReverting r76928, causes segfault
Sam Reed [Thu, 18 Nov 2010 02:32:58 +0000 (02:32 +0000)]
Reverting r76928, causes segfault

13 years agoUpdated jquery.tipsy and added it to the Resources manifest.
Trevor Parscal [Thu, 18 Nov 2010 00:27:32 +0000 (00:27 +0000)]
Updated jquery.tipsy and added it to the Resources manifest.

13 years ago(bug 25920) Moved forward ref to a nested ref to really get v6 regex to compile on...
Aaron Schulz [Thu, 18 Nov 2010 00:25:58 +0000 (00:25 +0000)]
(bug 25920) Moved forward ref to a nested ref to really get v6 regex to compile on older PCRE versions

13 years ago* Moved author count check to new Title::countAuthorsBetween() function
Aaron Schulz [Thu, 18 Nov 2010 00:08:37 +0000 (00:08 +0000)]
* Moved author count check to new Title::countAuthorsBetween() function
* Added static DifferenceEngine::intermediateEditsMsg() function
* diff-multi msg use by FlaggedRevs wasn't updated after $2 param was added. Fixed this.
* Minor cleanups to getMultiNotice()

13 years agosome code comments, fix some indentation issues
Antoine Musso [Wed, 17 Nov 2010 21:12:52 +0000 (21:12 +0000)]
some code comments, fix some indentation issues

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Wed, 17 Nov 2010 20:30:02 +0000 (20:30 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-11-17 19:51:00 UTC)

13 years agoFileRepo stuff no longer uses WikiError since ages
Alexandre Emsenhuber [Wed, 17 Nov 2010 18:30:20 +0000 (18:30 +0000)]
FileRepo stuff no longer uses WikiError since ages

13 years agoFix for r76088: if you want the Vector stylesheets you have to use the Vector documen...
Tim Starling [Wed, 17 Nov 2010 11:43:57 +0000 (11:43 +0000)]
Fix for r76088: if you want the Vector stylesheets you have to use the Vector document structure, not a mix of Vector, Monobook and JustPlainBroken.

13 years ago* Reduced some pointless regex capture overhead
Aaron Schulz [Wed, 17 Nov 2010 09:12:18 +0000 (09:12 +0000)]
* Reduced some pointless regex capture overhead
* Made preg_replace calls easier to verify w.r.t. captures
* (bug 25920) Made RE_IPV6_ADD avoid conditions on whether a named group matched anything, which requires PCRE 6.7+ (not bundled with PHP 5.1.0)

13 years agoAdded two key ipv6 tests
Aaron Schulz [Wed, 17 Nov 2010 01:02:55 +0000 (01:02 +0000)]
Added two key ipv6 tests

13 years agoFollow-up on r76326 - Fixing milliseconds zero padding for mw.log
Krinkle [Wed, 17 Nov 2010 00:41:42 +0000 (00:41 +0000)]
Follow-up on r76326 - Fixing milliseconds zero padding for mw.log

13 years agoWhen displaying non-local File pages, add link rel=canonical.
Derk-Jan Hartman [Wed, 17 Nov 2010 00:23:30 +0000 (00:23 +0000)]
When displaying non-local File pages, add link rel=canonical.
Solves bug 25960

13 years agoClearing up this working copy. Adding a couple of braces
Sam Reed [Tue, 16 Nov 2010 23:02:08 +0000 (23:02 +0000)]
Clearing up this working copy. Adding a couple of braces

13 years agoreorganise targets, use variables for common objects, add comments.
Antoine Musso [Tue, 16 Nov 2010 21:20:45 +0000 (21:20 +0000)]
reorganise targets, use variables for common objects, add comments.

13 years agoFixed passing of parameter array to wfMessage()
Max Semenik [Tue, 16 Nov 2010 20:40:20 +0000 (20:40 +0000)]
Fixed passing of parameter array to wfMessage()

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Tue, 16 Nov 2010 20:33:22 +0000 (20:33 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-11-16 20:13:00 UTC)

13 years agoFixed some doxygen warnings
Alexandre Emsenhuber [Tue, 16 Nov 2010 20:14:13 +0000 (20:14 +0000)]
Fixed some doxygen warnings

13 years agoMoved /0 prefix tests to valid...it just means "everything"
Aaron Schulz [Tue, 16 Nov 2010 18:28:25 +0000 (18:28 +0000)]
Moved /0 prefix tests to valid...it just means "everything"

13 years agoAdded --env-checks parameter to install.php that checks for prerequisites instead...
Max Semenik [Tue, 16 Nov 2010 18:13:35 +0000 (18:13 +0000)]
Added --env-checks parameter to install.php that checks for prerequisites instead of installing

13 years agoThe default value of isPermaLink is true, not including it does nothing.
Platonides [Tue, 16 Nov 2010 17:44:08 +0000 (17:44 +0000)]
The default value of isPermaLink is true, not including it does nothing.
http://www.rssboard.org/rss-specification#ltguidgtSubelementOfLtitemgt

13 years agoFollow-up r76805: removed outdated comment, introduced new group "Search"
Max Semenik [Tue, 16 Nov 2010 16:54:48 +0000 (16:54 +0000)]
Follow-up r76805: removed outdated comment, introduced new group "Search"

13 years agoFix stupid get vs. set typo in nextJobDB.php
Roan Kattouw [Tue, 16 Nov 2010 16:48:20 +0000 (16:48 +0000)]
Fix stupid get vs. set typo in nextJobDB.php

13 years agoRevert r76393 and make $wgUpgradeKey like $wgSecretKey. Followup for r76391
Platonides [Tue, 16 Nov 2010 16:16:09 +0000 (16:16 +0000)]
Revert r76393 and make $wgUpgradeKey like $wgSecretKey. Followup for r76391

13 years agoFixed SearchUpdateTest, it doesn't mess with database anymore. More fixes in the...
Max Semenik [Tue, 16 Nov 2010 16:06:46 +0000 (16:06 +0000)]
Fixed SearchUpdateTest, it doesn't mess with database anymore. More fixes in the line of r76617.

13 years agoFix copy+paste error from r76798
Chad Horohoe [Tue, 16 Nov 2010 16:02:48 +0000 (16:02 +0000)]
Fix copy+paste error from r76798

13 years agoEnvironment checks don't need to be public
Chad Horohoe [Tue, 16 Nov 2010 15:50:32 +0000 (15:50 +0000)]
Environment checks don't need to be public

13 years agoLocalization update for he.
Rotem Liss [Tue, 16 Nov 2010 15:38:49 +0000 (15:38 +0000)]
Localization update for he.

13 years agoFollow up r76708
Platonides [Tue, 16 Nov 2010 15:33:29 +0000 (15:33 +0000)]
Follow up r76708
1) IPTest::testValidBlocks
Undefined variable: invalid in phase3/maintenance/tests/phpunit/includes/IPTest.php:174

2) IPTest::testInvalidBlocks
Undefined variable: invalid in phase3/maintenance/tests/phpunit/includes/IPTest.php:197

Note that the 30.242.52.14/0 test does not pass (it is deemed a valid block)

13 years agoTab to space, might as well be consistent
Chad Horohoe [Tue, 16 Nov 2010 15:32:19 +0000 (15:32 +0000)]
Tab to space, might as well be consistent

13 years agoMove preference for PEAR higher up the list, apt and yum repos tend to be out of...
Chad Horohoe [Tue, 16 Nov 2010 15:29:48 +0000 (15:29 +0000)]
Move preference for PEAR higher up the list, apt and yum repos tend to be out of date

13 years agoMore is_a() -> instanceof
Chad Horohoe [Tue, 16 Nov 2010 15:10:46 +0000 (15:10 +0000)]
More is_a() -> instanceof

13 years agoFollowup r76782: is_a() -> instanceof (we dropped PHP 4 support over 3 years ago...
Roan Kattouw [Tue, 16 Nov 2010 14:23:34 +0000 (14:23 +0000)]
Followup r76782: is_a() -> instanceof (we dropped PHP 4 support over 3 years ago), or -> ||

13 years agoVariablise $navigationBar
Sam Reed [Tue, 16 Nov 2010 14:06:21 +0000 (14:06 +0000)]
Variablise $navigationBar

Add a couple of braces

13 years agoFix for r69917: Should be using DB_ADMIN if we were using $wgUseRootUser
Chad Horohoe [Tue, 16 Nov 2010 13:44:51 +0000 (13:44 +0000)]
Fix for r69917: Should be using DB_ADMIN if we were using $wgUseRootUser

13 years ago* Fixed ipv6 range test calls
Aaron Schulz [Tue, 16 Nov 2010 10:51:24 +0000 (10:51 +0000)]
* Fixed ipv6 range test calls
* Made testisIPAddress test results more readable on failure

13 years agoremoved mac-specific temp dir path for debug log
Neil Kandalgaonkar [Tue, 16 Nov 2010 07:11:39 +0000 (07:11 +0000)]
removed mac-specific temp dir path for debug log

13 years agofixed typo
Neil Kandalgaonkar [Tue, 16 Nov 2010 07:09:46 +0000 (07:09 +0000)]
fixed typo

13 years agoFixed bug#25784 (thumbnails of stashed files had wrong description URLs).
Neil Kandalgaonkar [Tue, 16 Nov 2010 06:57:46 +0000 (06:57 +0000)]
Fixed bug#25784 (thumbnails of stashed files had wrong description URLs).

This fixes the more general problem that the imageinfo returned with stashed uploads was inaccurate, since it was relying on
code that only worked with non-stashed files.

So, I had to:
- move the ApiQueryStashImageInfo module into core. Which others had asked for anyway, and was anticipated sometime later.
  - add lines to AutoLoader and ApiQuery to accomodate the new module

- add an ugly if/then to UploadBase -- based on the type of uploaded file, it will use a different API module to simulate a getImageInfo call.
  I left a TODO that this situation wasn't ideal, but the way things are now, imageInfo is constructed by the API modules, when it should probably
  really be the File modules. Then the API can wrap that info into various formats.

- add a few new lines to the tests to check imageinfo information in both regular and stashed upload files

13 years agoremoved URL hackery, now using SpecialPage::getTitleFor(). Followup to r75906
Neil Kandalgaonkar [Tue, 16 Nov 2010 01:15:58 +0000 (01:15 +0000)]
removed URL hackery, now using SpecialPage::getTitleFor(). Followup to r75906