lhc/web/wiklou.git
10 years agoUser::pingLimiter() profiles per action as well
Antoine Musso [Mon, 19 May 2014 10:45:11 +0000 (12:45 +0200)]
User::pingLimiter() profiles per action as well

We had an outage beginning of may that involved rate limiting of the
'renderfile-nonstandard' action.  This makes User::pingLimiter() to
record a per action profiling point in addition to the generic one, that
would let us finely graph actions being throttled.

Ref:
https://wikitech.wikimedia.org/wiki/Incident_documentation/20140503-Thumbnails#What_can_be_improved

Bug: 65477
Change-Id: Iac7930e85f7d9101663656ccb2bccdbebf908693

10 years agoMerge "Avoid fatals in begin/commit/rollback if close() was called"
jenkins-bot [Mon, 19 May 2014 04:20:00 +0000 (04:20 +0000)]
Merge "Avoid fatals in begin/commit/rollback if close() was called"

10 years agoFix error message when swap is disabled
Tim Starling [Mon, 19 May 2014 00:41:52 +0000 (10:41 +1000)]
Fix error message when swap is disabled

Bug: 65465
Change-Id: Ibb1b14f5271d60c039398e8ce8a9c2a5d245241f

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 18 May 2014 19:56:04 +0000 (19:56 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: Idc2498ae827432f400c278e873295ec42aa9ca0e

10 years agoMerge "Remove unneeded $classes from SpecialTrackingCategories.php"
jenkins-bot [Sun, 18 May 2014 14:07:57 +0000 (14:07 +0000)]
Merge "Remove unneeded $classes from SpecialTrackingCategories.php"

10 years agoMerge "Update jscs and jshint config"
jenkins-bot [Sun, 18 May 2014 10:11:53 +0000 (10:11 +0000)]
Merge "Update jscs and jshint config"

10 years agoMerge "vector: Suppress watch star focus outline when animating it"
jenkins-bot [Sun, 18 May 2014 10:03:06 +0000 (10:03 +0000)]
Merge "vector: Suppress watch star focus outline when animating it"

10 years agoRemove unneeded $classes from SpecialTrackingCategories.php
umherirrender [Fri, 16 May 2014 15:50:00 +0000 (17:50 +0200)]
Remove unneeded $classes from SpecialTrackingCategories.php

Change-Id: I9f10db9f6596ac0bfe0aa1595acbeeef4ca5713a

10 years agoMerge "For job param arrays of scalars, show the key/values as JSON in the log"
jenkins-bot [Sun, 18 May 2014 02:33:30 +0000 (02:33 +0000)]
Merge "For job param arrays of scalars, show the key/values as JSON in the log"

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 17 May 2014 19:47:00 +0000 (19:47 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: Id6f998e098596b26744d4948c0ee37883e4d325d

10 years agovector: Suppress watch star focus outline when animating it
Bartosz Dziewoński [Sat, 17 May 2014 13:46:23 +0000 (15:46 +0200)]
vector: Suppress watch star focus outline when animating it

It looks really funny, but that's not the effect we're aiming for.
The star is not supposed to look clickable during the rotation
animation anyway.

Bug: 65434
Change-Id: I3a7c91f5b7df0d70abd532cc234e8aa1bac9e129

10 years agoUpdate OOjs UI to v0.1.0-pre (d4086ff6e6)
Roan Kattouw [Fri, 16 May 2014 23:32:43 +0000 (16:32 -0700)]
Update OOjs UI to v0.1.0-pre (d4086ff6e6)

New changes:
a635ace build: Update jscs config
fd23e56 Localisation updates from https://translatewiki.net.
f5e6413 PanelLayout: Remove call to getDir()

Change-Id: I19fe3aa6c9909ab2d970b87a5ec21a019d8bb241

10 years agoAlways render copyright notice in user language
kaldari [Mon, 24 Mar 2014 22:57:59 +0000 (15:57 -0700)]
Always render copyright notice in user language

All other footer content is rendered in the user language and the
copyright notice on the edit page is also in the user language.
See EditPage::getCopyrightWarning().

We already do this on WMF wikis through the WikimediaMessages
extension (which sets $forContent to false). The same behaviour has
been requested for 3rd party wikis as well.

Bug: 49116
Change-Id: I1dddfa7771c7063ec319fa441c2e400a374abc92

10 years agoMerge "Minor fix to DatabaseBase::close() logic"
jenkins-bot [Fri, 16 May 2014 22:40:30 +0000 (22:40 +0000)]
Merge "Minor fix to DatabaseBase::close() logic"

10 years agoFor job param arrays of scalars, show the key/values as JSON in the log
Aaron Schulz [Fri, 16 May 2014 22:23:26 +0000 (15:23 -0700)]
For job param arrays of scalars, show the key/values as JSON in the log

Change-Id: Ia9056dd1d4669102178046961ddaf6e8560e5903

10 years agoMerge "Drop rc_cur_time from recentchanges"
jenkins-bot [Fri, 16 May 2014 20:23:12 +0000 (20:23 +0000)]
Merge "Drop rc_cur_time from recentchanges"

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 16 May 2014 19:55:30 +0000 (19:55 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: I195193fb9a06a3f8fe09697977e075e86b11c516

10 years agoMinor fix to DatabaseBase::close() logic
Aaron Schulz [Fri, 16 May 2014 18:22:31 +0000 (11:22 -0700)]
Minor fix to DatabaseBase::close() logic

* Only set mOpened to false if closeConnection() was called (or mConn was unset)

bug: 65100
Change-Id: I1ba6b765cfc647a47f21048d993047c0fe0cfe19

10 years agoFix @since of Parser::stripOuterParagraph
umherirrender [Fri, 16 May 2014 17:50:09 +0000 (19:50 +0200)]
Fix @since of Parser::stripOuterParagraph

Was merged after release branch.

Follow-Up: I6bb3597898324556df912a23a7ffc9ff250b8f58
Change-Id: Idab16dc1e322ede31f6688236fddae5365ac133c

10 years agoAvoid fatals in begin/commit/rollback if close() was called
Aaron Schulz [Fri, 16 May 2014 17:50:05 +0000 (10:50 -0700)]
Avoid fatals in begin/commit/rollback if close() was called

Change-Id: I3c555ece5c1e16c6ffcdbec6645d659531400a1b

10 years agojquery.suggestions: Use body width instead of full document width
Fomafix [Tue, 29 Apr 2014 19:02:30 +0000 (19:02 +0000)]
jquery.suggestions: Use body width instead of full document width

When there is a overflowing element in the content, the width of
the "document" is wider than the visible width within the browser
window. Use <body> instead of document.

This reverts 4d799b48 (a fix for bug 45668).

Bug: 54091
Bug: 64233
Change-Id: I5268eaf7307159b2eaa4c5749346aa562574a6e2

10 years agoMerge "mediawiki.util: Decode parentheses and bang in wikiUrlencode"
jenkins-bot [Fri, 16 May 2014 17:27:54 +0000 (17:27 +0000)]
Merge "mediawiki.util: Decode parentheses and bang in wikiUrlencode"

10 years agoMerge "vector.collapsibleTabs: Rename $settings to settings"
jenkins-bot [Fri, 16 May 2014 16:52:54 +0000 (16:52 +0000)]
Merge "vector.collapsibleTabs: Rename $settings to settings"

10 years agovector.collapsibleTabs: Rename $settings to settings
Timo Tijhof [Fri, 16 May 2014 16:08:59 +0000 (18:08 +0200)]
vector.collapsibleTabs: Rename $settings to settings

This is just a plain object.

Change-Id: I062e2a081e605a002c841ad69fe0dcd90fbee057

10 years agomediawiki.searchSuggest: Adjust font size for all inputs, not just magic ones
Bartosz Dziewoński [Tue, 13 May 2014 22:31:02 +0000 (00:31 +0200)]
mediawiki.searchSuggest: Adjust font size for all inputs, not just magic ones

I have no idea why the fix was limited, this issue affects every single
input on every single page (including ones that are part of MediaWiki
interface itself, not skins, see If4ae687b).

Change-Id: I7a6dfbcced64dbfce5d1ab31201c98a134f72fe9

10 years agomediawiki.searchSuggest: Remove duplicate code
Bartosz Dziewoński [Tue, 13 May 2014 22:25:53 +0000 (00:25 +0200)]
mediawiki.searchSuggest: Remove duplicate code

The 'result' function for skin-provided search box is already provided
above as "generic functionality", repeating it doesn't do anything.

Change-Id: I8693f3dbbfb64ac2816da86759233e3870234d77

10 years agoMerge "Use precise ApiMain/ApiQuery type hints in all API modules"
jenkins-bot [Fri, 16 May 2014 15:42:26 +0000 (15:42 +0000)]
Merge "Use precise ApiMain/ApiQuery type hints in all API modules"

10 years agoMerge "HTMLForm vform styling"
jenkins-bot [Fri, 16 May 2014 15:41:19 +0000 (15:41 +0000)]
Merge "HTMLForm vform styling"

10 years agoHTMLForm vform styling
wctaiwan [Mon, 7 Apr 2014 19:16:45 +0000 (15:16 -0400)]
HTMLForm vform styling

Style <select> like other input fields (full width), and fix the issue
where validation errors partially obfuscate the fields by setting display:
block. Refactor code for styling error boxes and improve documentation.

Bug: 63644
Change-Id: I00a35c932a7e0b91b7b01fc327c0c1b9bae66c78

10 years agoUse precise ApiMain/ApiQuery type hints in all API modules
Thiemo Mättig [Tue, 25 Mar 2014 17:22:11 +0000 (18:22 +0100)]
Use precise ApiMain/ApiQuery type hints in all API modules

Which type is used depends on the ApiModuleManager responsible for
the API module. There are two managers, one in ApiMain and one in
ApiQuery. Both contain a list of API modules they instantiate.
Both use $this as the first parameter in the constructors of the
individual modules. There is no other regular way to instantiate the
modules, so we know the type must either be ApiMain or ApiQuery.

The lists don't intersect.

I would have prefered the naming scheme $mainModule for ApiMain
modules and $queryModule for ApiQuery modules but since this
doesn't add much I left the shorter variable names untouched.

Change-Id: Ie6bf19150f1c9b619655a06a8e051412665e54db

10 years agoMerge "Load shared MediaWiki styles when generating the style guide"
jenkins-bot [Fri, 16 May 2014 14:39:03 +0000 (14:39 +0000)]
Merge "Load shared MediaWiki styles when generating the style guide"

10 years agoLoad shared MediaWiki styles when generating the style guide
Bartosz Dziewoński [Fri, 16 May 2014 14:31:34 +0000 (16:31 +0200)]
Load shared MediaWiki styles when generating the style guide

Among other things it defines styles for .errorbox and friends, which
are showcased in the guide.

Change-Id: I14279400b9aa362d19040e8083032e4e7c1c4ba6

10 years agoUpdate jscs and jshint config
Timo Tijhof [Fri, 16 May 2014 14:07:41 +0000 (16:07 +0200)]
Update jscs and jshint config

Continue specifying our coding style more accurately in jscs,
and phase out more deprecated jshint coding style options.

jshint:
* Update to grunt-contrib-jshint v0.10.0 (jshint v2.5.0).
* Remove coding style option "curly" (already covered by jscs).
* Remove coding style option "smarttabs" (already covered by jscs).
* Remove option "regexp".
* Enable new option "freeze" (prohibits changing native prototypes).
  http://www.jshint.com/blog/new-in-jshint-oct-2013/#option-freeze
* Re-order to match http://www.jshint.com/docs/options/

jscs:
* Update to grunt-contrib-jshint v0.4.4 (jscs v1.4.5).
* Format .jscsrc file in a more spacious way and order the
  properties less arbitrarily (using the jscs's readme order).
* Improve rule "requireCurlyBraces": Add more keywords that
    should have their code block wrapped in curly braces.
* Improve rule "requireMultipleVarDecl": Use onevar instead of true.
* Remove rules for "sticky operators", these rules are buggy
    and have been deprecated. Using the SpaceBefore/After rules
    for Unary and Binary operators instead.
* Enable rule "disallowYodaConditions".

Change-Id: I6f385e8860e91d9ef4d1f5abecf517d36af45565

10 years agoMerge "SpecialUnwatchedpages: Ajaxify watch links"
jenkins-bot [Fri, 16 May 2014 07:49:37 +0000 (07:49 +0000)]
Merge "SpecialUnwatchedpages: Ajaxify watch links"

10 years agomediawiki.user.test: Use FakeXHR and clean up
Timo Tijhof [Thu, 8 May 2014 10:32:40 +0000 (12:32 +0200)]
mediawiki.user.test: Use FakeXHR and clean up

The test was quite vague (type array, contain '*') which was
because it made an actual API request and that means the actual
user and wiki configuration influence it, naturally.

Replaced with a mock (also speeds up the test), which lets us
do a more appropiate and strict unit test.

There was also a test for asserting mw.config 'wgUserGroups' and
ApiQueryUserInfo/prop=groups return the same thing. This had to
be removed. Not sure where this would belong (if anywhere). Both
OutputPage and ApiQueryUserInfo get it from User::getEffectiveGroups().

Change-Id: I052ad0b93e8cef7a27f7020411ba4665132675f5

10 years agoSpecialUnwatchedpages: Ajaxify watch links
Eranroz [Mon, 30 Apr 2012 18:58:27 +0000 (21:58 +0300)]
SpecialUnwatchedpages: Ajaxify watch links

Add user friendly handling to watch pages from Special:UnwatchedPages
using ajax. Emits a notification message upon completion of the action
and strikes through the list item.

Bug: 17367
Change-Id: Ie32cc54abb6f888a433f7f18ef5ad747a80d7187

10 years agoRevert "Declare visibility on class properties of includes/parser/"
Ori.livneh [Fri, 16 May 2014 00:48:01 +0000 (00:48 +0000)]
Revert "Declare visibility on class properties of includes/parser/"

See https://bugzilla.wikimedia.org/65375#c4

This reverts commit f359cdf61462782743a87943938ef4cce78b2647.

Bug: 65375
Change-Id: I12a60b5cc52a07a6deabcbf47c7c99cd2faac3c3

10 years agoMerge "mediawiki.api: Add parameter ajaxOptions to postWithToken()"
jenkins-bot [Thu, 15 May 2014 22:32:44 +0000 (22:32 +0000)]
Merge "mediawiki.api: Add parameter ajaxOptions to postWithToken()"

10 years agoMerge "Make validation for page more strict on djvu to take only numbers"
jenkins-bot [Thu, 15 May 2014 21:44:57 +0000 (21:44 +0000)]
Merge "Make validation for page more strict on djvu to take only numbers"

10 years agoMerge "Tweaks to compareParserCache.php"
jenkins-bot [Thu, 15 May 2014 20:59:18 +0000 (20:59 +0000)]
Merge "Tweaks to compareParserCache.php"

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 15 May 2014 20:20:52 +0000 (20:20 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: I4caa3eef8a82b0d055227684b327bb784c873725

10 years agoMerge "Delete the post-edit cookie using the correct domain"
Robmoen [Thu, 15 May 2014 18:48:47 +0000 (18:48 +0000)]
Merge "Delete the post-edit cookie using the correct domain"

10 years agomediawiki.api: Add parameter ajaxOptions to postWithToken()
Fomafix [Thu, 15 May 2014 11:39:03 +0000 (11:39 +0000)]
mediawiki.api: Add parameter ajaxOptions to postWithToken()

This allows to upload a file with token.

var api = new mw.Api();
api.postWithToken(
'edit',
{
action: 'upload',
format: 'json',
filename: 'Foobar.png',
file: file
},
{
contentType: 'multipart/form-data'
}
);

Change-Id: I7a0fec3c1ef2c7881d4c04b1a9dd44fac02cb346

10 years agoMerge "Minor fix to contenthandler.txt doc."
jenkins-bot [Thu, 15 May 2014 17:32:30 +0000 (17:32 +0000)]
Merge "Minor fix to contenthandler.txt doc."

10 years agoSpeed up CIDR matching from $wgSquidServersNoPurge
Brandon Black [Tue, 6 May 2014 18:49:26 +0000 (13:49 -0500)]
Speed up CIDR matching from $wgSquidServersNoPurge

This adds a new generic library class IPSet, which precomputes
a reasonably-efficient data structure from the input list of
addresses and CIDR net/mask specs for fast runtime matching,
and then uses it to check trusted XFF-setters.

See also: 32b4f19f173fc5cff1029eedee63a39a2d72dd3a
Bug: 57021
Change-Id: Ia3b12fb90c3e7e492374a128943b014481cc2730

10 years agoDrop rc_cur_time from recentchanges
umherirrender [Mon, 14 Apr 2014 18:44:22 +0000 (20:44 +0200)]
Drop rc_cur_time from recentchanges

Field was removed in 1.23 from sql statements, but kept to allow easier
rollback on version update from 1.22 -> 1.23, when something gets wrong
with the new version.

Bug: 40667
Follow-Up: I4a9c2fa813d1f25dfb755e564f7677a212934d7b
Change-Id: I48989aceec31019f0b6c98aaeafaf60e975244df

10 years agoMinor fix to contenthandler.txt doc.
Subramanya Sastry [Thu, 15 May 2014 17:09:37 +0000 (12:09 -0500)]
Minor fix to contenthandler.txt doc.

Change-Id: I45c1a750b2308dc30d609910d802d25a4252a7e5

10 years agoAllow LogEntry::setRelations to work with array(tag => value)
umherirrender [Wed, 16 Apr 2014 17:20:36 +0000 (19:20 +0200)]
Allow LogEntry::setRelations to work with array(tag => value)

Change-Id: I5a3d9799cd2125a02871b1c6a9ef7745eadb518d

10 years agoMerge "Create Parser::stripOuterParagraph to avoid code duplication"
jenkins-bot [Thu, 15 May 2014 16:31:36 +0000 (16:31 +0000)]
Merge "Create Parser::stripOuterParagraph to avoid code duplication"

10 years agoMerge "Allow editing transcluded sections via the API"
jenkins-bot [Thu, 15 May 2014 16:22:01 +0000 (16:22 +0000)]
Merge "Allow editing transcluded sections via the API"

10 years agoCreate Parser::stripOuterParagraph to avoid code duplication
Bartosz Dziewoński [Sat, 22 Feb 2014 15:21:36 +0000 (16:21 +0100)]
Create Parser::stripOuterParagraph to avoid code duplication

We've had the logic for stripping the outer <p/> element in three
separate places. The version in OutputPage was missing the '$' at the
end of the regex, that was most likely a mistake caused by the
duplication.

Also, extend the logic in order not to generate invalid HTML if the
input contains more than one <p/> tag. Added tests for this and the
previous behaviour.

https://www.mail-archive.com/mediawiki-api@lists.wikimedia.org/msg03188.html

Change-Id: I6bb3597898324556df912a23a7ffc9ff250b8f58

10 years agoMerge "Check for Language::getSpecialPageAliases returning null in SpecialPageFactory"
jenkins-bot [Thu, 15 May 2014 16:09:21 +0000 (16:09 +0000)]
Merge "Check for Language::getSpecialPageAliases returning null in SpecialPageFactory"

10 years agoMerge "Fix documentation for mw.cookie.set"
jenkins-bot [Thu, 15 May 2014 15:57:36 +0000 (15:57 +0000)]
Merge "Fix documentation for mw.cookie.set"

10 years agoMerge "Upgrade jQuery to 1.11.1"
jenkins-bot [Thu, 15 May 2014 15:46:56 +0000 (15:46 +0000)]
Merge "Upgrade jQuery to 1.11.1"

10 years agoTweaks to compareParserCache.php
Aaron Schulz [Thu, 15 May 2014 15:39:21 +0000 (08:39 -0700)]
Tweaks to compareParserCache.php

* Skip parsing if there is no cache entry to compare to
* Mention the total number of pages with differences

Change-Id: I8905ae02b4d6c414690a30aec01b11abd1e22d14

10 years agoUpgrade jQuery to 1.11.1
Timo Tijhof [Thu, 15 May 2014 15:09:06 +0000 (17:09 +0200)]
Upgrade jQuery to 1.11.1

Follows-up I468d6b45eae83. Per the plan[1], upgrading our copy
of jQuery to v1.11.1 and serving the jQuery Migrate plugin along
with it (no longer just in debug mode, because we need it to
fill in the deprecated functionility jQuery 1.9 removed).

Code:
 https://code.jquery.com/jquery-1.11.1.js

Info:
 http://jquery.com/upgrade-guide/1.9/#jquery-migrate-plugin

Release notes:
 http://blog.jquery.com/2013/01/15/jquery-1-9-final
 http://blog.jquery.com/2013/02/04/jquery-1-9-1-released/
 http://blog.jquery.com/2013/05/24/jquery-1-10-0
 http://blog.jquery.com/2013/05/30/jquery-1-10-1
 http://blog.jquery.com/2013/07/03/jquery-1-10-2
 http://blog.jquery.com/2014/01/24/jquery-1-11
 http://blog.jquery.com/2014/05/01/jquery-1-11-1

[1]
 http://www.mail-archive.com/wikitech-l@lists.wikimedia.org/msg75735.html
 http://lists.wikimedia.org/pipermail/wikitech-l/2014-May/076340.html

Bug: 44740
Change-Id: I097c9639e366eb394dcf2f3c3c62edfcc974155c

10 years agoMerge "Remove underscore from classes WebInstaller_*"
jenkins-bot [Thu, 15 May 2014 15:07:47 +0000 (15:07 +0000)]
Merge "Remove underscore from classes WebInstaller_*"

10 years agoMerge "Added unicode encoding support flags to FileBackend"
jenkins-bot [Thu, 15 May 2014 15:06:19 +0000 (15:06 +0000)]
Merge "Added unicode encoding support flags to FileBackend"

10 years agoMerge "Fixed "file already exist" optimization in File::transform()"
jenkins-bot [Thu, 15 May 2014 15:04:48 +0000 (15:04 +0000)]
Merge "Fixed "file already exist" optimization in File::transform()"

10 years agoFix coding style from Ie40c0721ec (e9f01c9)
Alexandre Emsenhuber [Thu, 15 May 2014 14:44:25 +0000 (16:44 +0200)]
Fix coding style from Ie40c0721ec (e9f01c9)

- Opening brace goes on the same line as the function definition
- No backslash before class name in @return

Change-Id: I4c43e047c36d0ce6e9c2344f6ee98786b2b8eac4

10 years agoMerge "Inserted getter for the XMLReader and change the visibility of some functions...
jenkins-bot [Thu, 15 May 2014 14:39:08 +0000 (14:39 +0000)]
Merge "Inserted getter for the XMLReader and change the visibility of some functions for use in hooks. Bug 64657"

10 years agoMerge "Installer: properly override default $wgLogo value"
jenkins-bot [Thu, 15 May 2014 13:21:21 +0000 (13:21 +0000)]
Merge "Installer: properly override default $wgLogo value"

10 years agoFix documentation for mw.cookie.set
Sam Smith [Thu, 15 May 2014 12:54:25 +0000 (13:54 +0100)]
Fix documentation for mw.cookie.set

The options.expires parameter can either be a Date or null.

Change-Id: I22ab2d518f6bb29dcf852115ec26d864647dc60f

10 years agoInserted getter for the XMLReader and change the visibility of some
Alexander Lehmann [Tue, 13 May 2014 12:22:27 +0000 (14:22 +0200)]
Inserted getter for the XMLReader and change the visibility of some
functions for use in hooks.
Bug 64657

Change-Id: Ie40c0721ec32935294756d60ea6686ebeefa61af

10 years agoMerge "Move mw.cookie release notes to RELEASE-NOTES-1.24"
jenkins-bot [Thu, 15 May 2014 07:02:39 +0000 (07:02 +0000)]
Merge "Move mw.cookie release notes to RELEASE-NOTES-1.24"

10 years agoDelete the post-edit cookie using the correct domain
Sam Smith [Mon, 31 Mar 2014 14:21:19 +0000 (15:21 +0100)]
Delete the post-edit cookie using the correct domain

Use the mediawiki.cookie#set to delete the post-edit cookie so that the
correct domain is used.

Bug: 61979
Change-Id: I0cba8d1421f359ff78f3f994af358e9997f27041

10 years agoMerge "Remove messageTypes.inc and replace it by a hook"
jenkins-bot [Thu, 15 May 2014 06:38:45 +0000 (06:38 +0000)]
Merge "Remove messageTypes.inc and replace it by a hook"

10 years agoMove mw.cookie release notes to RELEASE-NOTES-1.24
Matthew Flaschen [Thu, 15 May 2014 06:14:06 +0000 (02:14 -0400)]
Move mw.cookie release notes to RELEASE-NOTES-1.24

Leaving it in RELEASE-NOTES-1.23 was an oversight.

Followup to 7c585b5a33d57469d19e9b176f14b84403488b73

Change-Id: If752905a1bae93582b1392a8280dc33eec4ad12e

10 years agoMake validation for page more strict on djvu to take only numbers
Brian Wolff [Thu, 15 May 2014 00:48:43 +0000 (21:48 -0300)]
Make validation for page more strict on djvu to take only numbers

This change causes wiki syntax like
 [[File:Foo.djvu|thumb|Page 7 of document]]
to be interpreted as a caption instead, of saying select page 7
of the djvu. Previously it eventually ran intval( '7 of document' ),
so flipped to page 7.

Only possible downside I could see is this would cause things like
left-to-right marks and weird unicode spaces to no longer be ignored.
I don't think that's a big deal.

Change-Id: Ie8c953009a38557876a274bf0f71ab470f66ef4e

10 years agoMerge "Added a script to compare current parser output to cache"
jenkins-bot [Thu, 15 May 2014 00:07:38 +0000 (00:07 +0000)]
Merge "Added a script to compare current parser output to cache"

10 years agoMerge "Avoid an infinite redirect in $wgSecureLogin handling"
jenkins-bot [Wed, 14 May 2014 23:56:16 +0000 (23:56 +0000)]
Merge "Avoid an infinite redirect in $wgSecureLogin handling"

10 years agoAdded a script to compare current parser output to cache
Aaron Schulz [Fri, 2 May 2014 18:13:26 +0000 (11:13 -0700)]
Added a script to compare current parser output to cache

* This works on a random set of pages in a namespace and can
  be used to compare different PHP interpreters.
* This can, like any maintenance script, be used with --profiler.

Change-Id: Ica69a3ef27df29af1c6e4dc4c8413b55a03df49e

10 years agoMWException: Remove deprecated methods
Chad Horohoe [Mon, 12 May 2014 21:36:15 +0000 (14:36 -0700)]
MWException: Remove deprecated methods

No callers in core or extensions.

Change-Id: I3e2dc615bcd23838cf096625a767a7cf50fea140

10 years agoMerge "Update OOjs UI to v0.1.0-pre (80f1797a5c)"
jenkins-bot [Wed, 14 May 2014 21:35:42 +0000 (21:35 +0000)]
Merge "Update OOjs UI to v0.1.0-pre (80f1797a5c)"

10 years agoUpdate OOjs UI to v0.1.0-pre (80f1797a5c)
James D. Forrester [Wed, 14 May 2014 18:14:12 +0000 (19:14 +0100)]
Update OOjs UI to v0.1.0-pre (80f1797a5c)

New changes:
9e4d2c6 Remove @abstract from classes which can be instantiated
0b43fbe Button accessibility
f61558d Add confirmation dialog
f52f1f2 Localisation updates from https://translatewiki.net.
d6849d5 build: Update jscs and jshint config
d0a5670 ConfirmationDialog clean up
513cb9d Auto-hide menus by default

Local changes:
Add the confirmation dialog messages to MW core's list in Resources.php

Bug: 50955
Change-Id: I67329820a631f46ed537d93398f35456f0e58679

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 14 May 2014 19:23:41 +0000 (19:23 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: I7826e5f6fdb2e4e2af623e8fdfc44323469aebac

10 years agoMerge "Linker.php: Do not double escape accesskey in tooltip"
jenkins-bot [Wed, 14 May 2014 18:31:00 +0000 (18:31 +0000)]
Merge "Linker.php: Do not double escape accesskey in tooltip"

10 years agoMerge "Implement mediawiki.cookie module"
Robmoen [Wed, 14 May 2014 18:17:55 +0000 (18:17 +0000)]
Merge "Implement mediawiki.cookie module"

10 years agoUse FOR UPDATE in prior LocalFile timestamp check
Aaron Schulz [Wed, 14 May 2014 16:43:02 +0000 (09:43 -0700)]
Use FOR UPDATE in prior LocalFile timestamp check

* This covers the case with a snapshotted transaction outside of lock()/unlock()

Change-Id: I8639c2e51cb918f452dc1576681d6224fb4fb2c0

10 years agomediawiki.util: Decode parentheses and bang in wikiUrlencode
Timo Tijhof [Wed, 14 May 2014 15:08:23 +0000 (17:08 +0200)]
mediawiki.util: Decode parentheses and bang in wikiUrlencode

Matches behaviour of wfUrlencode() and creates prettier urls.

Change-Id: I9b3ecda19f743cd87e790d99d50dd6b730e5ee21

10 years agoRemove unused variables from SpecialAllpages::showToplevel()
Alexandre Emsenhuber [Wed, 14 May 2014 07:12:45 +0000 (09:12 +0200)]
Remove unused variables from SpecialAllpages::showToplevel()

Follow-up If750cad676 (71fe7c5)

Change-Id: I95bf953b0eb742e94ddff1b6adf6d784fb5dc87c

10 years agoImplement mediawiki.cookie module
Sam Smith [Tue, 25 Mar 2014 15:18:09 +0000 (15:18 +0000)]
Implement mediawiki.cookie module

Provides functonality similar to WebRequest#getCookie and WebResponse#setcookie.

Wraps $.cookie and automatically takes care of wgCookiePrefix etc.

Bug: 49156
Change-Id: I217ef258aecf1acd335e2cea56ae08b22541c7d4
Co-Author: Matthew Flaschen <mflaschen@wikimedia.org>
Co-Author: Timo Tijhof <krinklemail@gmail.com>

10 years agoAvoid an infinite redirect in $wgSecureLogin handling
Tim Starling [Wed, 14 May 2014 03:49:26 +0000 (13:49 +1000)]
Avoid an infinite redirect in $wgSecureLogin handling

If, for some reason, (e.g. https://gerrit.wikimedia.org/r/#/c/133205/ )
HTTPS requests are not recognised as such and WebRequest::getProtocol()
unconditionally returns "http", use the fromhttp parameter to avoid an
infinite redirect loop.

Change-Id: Iefbf679ef995f5e347e2b9c3f1f5a5b22055e107

10 years agoMerge "qunit: Make use of 'config' and 'messages' shortcuts in module setup"
jenkins-bot [Wed, 14 May 2014 00:16:00 +0000 (00:16 +0000)]
Merge "qunit: Make use of 'config' and 'messages' shortcuts in module setup"

10 years agoqunit: Make use of 'config' and 'messages' shortcuts in module setup
umherirrender [Wed, 7 May 2014 18:41:01 +0000 (20:41 +0200)]
qunit: Make use of 'config' and 'messages' shortcuts in module setup

While calling mw.config and mw.messages manually works fine (the sandbox
covers mw.config and mw.messages in general, not just when using the
shortcut), let's consistently use the shortcuts.

Also clean up the extra local variable in some cases.

Change-Id: I9ac467ad87816c7dc681b62e9b085b643024c15e

10 years agoFixed "file already exist" optimization in File::transform()
Aaron Schulz [Tue, 13 May 2014 23:07:15 +0000 (16:07 -0700)]
Fixed "file already exist" optimization in File::transform()

* Previously, the resulting thumbnail did not handle hasFile() and
  stream() properly. This effected doCachedWork() in thumb.php

Change-Id: I8fd025204b5b41472be6c09924892fe8ee9dd260

10 years agoMerge "MWException: Don't send headers multiple times"
jenkins-bot [Tue, 13 May 2014 22:28:43 +0000 (22:28 +0000)]
Merge "MWException: Don't send headers multiple times"

10 years agoMerge "Made LocalFile avoid duplicate (name,timestamp) pairs"
jenkins-bot [Tue, 13 May 2014 22:21:16 +0000 (22:21 +0000)]
Merge "Made LocalFile avoid duplicate (name,timestamp) pairs"

10 years agoMade LocalFile avoid duplicate (name,timestamp) pairs
Aaron Schulz [Tue, 13 May 2014 22:03:32 +0000 (15:03 -0700)]
Made LocalFile avoid duplicate (name,timestamp) pairs

* Various bits of code seem to assume uniqueness already

bug: 65264
Change-Id: Ib00fdbe87a79296c640cd69d74928236ce7a4aee

10 years agoMerge "Revert "Simplify thumbnail styling to have consistency with mobile implementat...
jenkins-bot [Tue, 13 May 2014 21:56:38 +0000 (21:56 +0000)]
Merge "Revert "Simplify thumbnail styling to have consistency with mobile implementation""

10 years agoRevert "Simplify thumbnail styling to have consistency with mobile implementation"
Jforrester [Tue, 13 May 2014 21:52:07 +0000 (21:52 +0000)]
Revert "Simplify thumbnail styling to have consistency with mobile implementation"

Causes significant breakage for videos, author not around this week to address concerns.

This reverts commit b0012d2aeb6a5ef8172223c58ceb8fa5c78c5138.

Change-Id: If1d7ba81b47b9351427111a9060ea9893c87c96e

10 years agoMWException: Don't send headers multiple times
Chad Horohoe [Tue, 13 May 2014 19:15:06 +0000 (12:15 -0700)]
MWException: Don't send headers multiple times

Ideally we wouldn't have sent headers yet, but in some weird
code paths where we output stuff raw (like Export) we might
have already sent them.

All depends on when the failure happened.

Should silence all of the "headers already sent" being seen
from exports.

Change-Id: I12e0532e93d30b2255f73a9d0e017c73e30c3e28

10 years agoMerge "Improve a bit the code of SpecialAllpages::showChunk()"
jenkins-bot [Tue, 13 May 2014 21:15:18 +0000 (21:15 +0000)]
Merge "Improve a bit the code of SpecialAllpages::showChunk()"

10 years agoAdded unicode encoding support flags to FileBackend
Aaron Schulz [Sat, 12 Apr 2014 06:50:58 +0000 (23:50 -0700)]
Added unicode encoding support flags to FileBackend

* Fixed bug where even using Swift/Azure on Windows
  would disallow non-ASCII file names.

bug: 1780
Change-Id: I19ed72da0b099d35cae74fb08eeb22c113da1065

10 years agoMerge "Installer: Minor tweaks to UI"
jenkins-bot [Tue, 13 May 2014 20:43:47 +0000 (20:43 +0000)]
Merge "Installer: Minor tweaks to UI"

10 years agoMerge "jquery.accessKeyLabel: Replace hardcoded brackets and space"
jenkins-bot [Tue, 13 May 2014 20:42:40 +0000 (20:42 +0000)]
Merge "jquery.accessKeyLabel: Replace hardcoded brackets and space"

10 years agoMerge "Make phpcs-strict pass on includes/ (6/~10)"
jenkins-bot [Tue, 13 May 2014 20:29:44 +0000 (20:29 +0000)]
Merge "Make phpcs-strict pass on includes/ (6/~10)"

10 years agoMerge "Allow floating point values for $wgJobBackoffThrottling"
jenkins-bot [Tue, 13 May 2014 20:29:25 +0000 (20:29 +0000)]
Merge "Allow floating point values for $wgJobBackoffThrottling"

10 years agoMerge "Update documentation and method visibility for SkinTemplate"
jenkins-bot [Tue, 13 May 2014 20:24:35 +0000 (20:24 +0000)]
Merge "Update documentation and method visibility for SkinTemplate"

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 13 May 2014 20:08:01 +0000 (20:08 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: I2be71c60446c0de60944b9a1439ec52e4c99e129