lhc/web/wiklou.git
11 years agoClean up applyPatch() usage in the installer.
Mark A. Hershberger [Sun, 8 Jul 2012 08:00:36 +0000 (04:00 -0400)]
Clean up applyPatch() usage in the installer.

Change-Id: I4b25c16a1cd3813fe216ea8bcf46cca2fc54d943

11 years agoMerge "Add some trailing full stops"
Krinkle [Sun, 8 Jul 2012 21:27:16 +0000 (21:27 +0000)]
Merge "Add some trailing full stops"

11 years agoMerge "Localisation updates from http://translatewiki.net."
Translation updater bot [Sun, 8 Jul 2012 19:48:58 +0000 (19:48 +0000)]
Merge "Localisation updates from translatewiki.net."

11 years agomediawiki.api.edit: Use the new 'tokens' api action
Kaldari [Sun, 8 Jul 2012 04:58:30 +0000 (21:58 -0700)]
mediawiki.api.edit: Use the new 'tokens' api action

Use action=tokens instead of the old way with info properties
for a fake title.

Change-Id: I35cd26180e7af7122ff64ce146199cdaa5f7d88b

11 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Sun, 8 Jul 2012 19:11:42 +0000 (19:11 +0000)]
Localisation updates from translatewiki.net.

Change-Id: Ifbcaa781fc601b7887525fe83a93d8148569b624

11 years agoMerge "(bug 38237) Add missing parentheses around diff links on Special:Undelete"
Reedy [Sat, 7 Jul 2012 21:31:00 +0000 (21:31 +0000)]
Merge "(bug 38237) Add missing parentheses around diff links on Special:Undelete"

11 years agoMerge "CLI install exited with 0 status code"
Reedy [Sat, 7 Jul 2012 21:29:18 +0000 (21:29 +0000)]
Merge "CLI install exited with 0 status code"

11 years agoMerge "Send correct HTML when reporting a MWException object and the OuputPage object...
Aaron Schulz [Sat, 7 Jul 2012 21:28:10 +0000 (21:28 +0000)]
Merge "Send correct HTML when reporting a MWException object and the OuputPage object cannot be used."

11 years agoMerge "Use Revision::getParentLengths in history"
Reedy [Sat, 7 Jul 2012 21:27:42 +0000 (21:27 +0000)]
Merge "Use Revision::getParentLengths in history"

11 years agoMerge "Added assertArrayEquals method to MediaWikiTestCase to avoid duplicating asort...
Aaron Schulz [Sat, 7 Jul 2012 21:25:33 +0000 (21:25 +0000)]
Merge "Added assertArrayEquals method to MediaWikiTestCase to avoid duplicating asort and array_values all over the place"

11 years agoMerge "Added SpecialPageAfterExecute and SpecialPageBeforeExecute hooks"
Reedy [Sat, 7 Jul 2012 21:23:42 +0000 (21:23 +0000)]
Merge "Added SpecialPageAfterExecute and SpecialPageBeforeExecute hooks"

11 years agoMerge "Improve documentation of maintenance scripts."
Reedy [Sat, 7 Jul 2012 21:03:24 +0000 (21:03 +0000)]
Merge "Improve documentation of maintenance scripts."

11 years agoMerge "(bug 31313) Clarify watchlist preference messages"
Reedy [Sat, 7 Jul 2012 20:56:35 +0000 (20:56 +0000)]
Merge "(bug 31313) Clarify watchlist preference messages"

11 years ago(bug 38237) Add missing parentheses around diff links on Special:Undelete
Alex Monk [Sat, 7 Jul 2012 20:41:47 +0000 (21:41 +0100)]
(bug 38237) Add missing parentheses around diff links on Special:Undelete

Change-Id: Id6846abd42f3c3e1210e760a583b3180d1aab18d

11 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Sat, 7 Jul 2012 19:24:47 +0000 (19:24 +0000)]
Localisation updates from translatewiki.net.

Change-Id: Ia7d6bf5c1515498956cb4b06745a2b1ce5700d15

11 years agoCLI install exited with 0 status code
Antoine Musso [Sat, 7 Jul 2012 18:09:45 +0000 (20:09 +0200)]
CLI install exited with 0 status code

The CliInstaller used the '0' exit code whenever the status was not OK.
That makes third party script assuming the install actually ran fine
since a 0 exit code is mostly considered as a success. By sending an
error code > 0 (here 1), our automatic installers will be able to catch
the failure and stop proceeding.

I had that issue with a Jenkins job which ran the CLI installer and kept
continuing although there was an error about LocalSettings.php already
existing.

Change-Id: I4f4727df85c09c0a04e4630df91c6213dfce6e9a

11 years agoRemove BOM from cleanupPreferences
Reedy [Sat, 7 Jul 2012 15:19:58 +0000 (16:19 +0100)]
Remove BOM from cleanupPreferences

Change-Id: I3c049c0229bb9ed1365f2781baa44b4c8e1e1e18

11 years agoAdd some trailing full stops
Reedy [Sat, 7 Jul 2012 15:09:47 +0000 (16:09 +0100)]
Add some trailing full stops

Change-Id: I878b24102a4de0c5a5fc1c1b1f9d52b053595002

11 years agoUse Revision::getParentLengths in history
umherirrender [Sat, 7 Jul 2012 14:45:24 +0000 (16:45 +0200)]
Use Revision::getParentLengths in history

Using new method from I6e388e75

Change-Id: I902dd1e2699c7291c49cd68fce271941ff4c6e34

11 years ago(bug 35980) drcontinue should pay attention to drdir in "all" mode
Brad Jorsch [Fri, 1 Jun 2012 21:46:40 +0000 (23:46 +0200)]
(bug 35980) drcontinue should pay attention to drdir in "all" mode

In "all" mode (mode #3 in the module's documentation), the drdir
parameter is treated by the result ordering as if it were always
drdir=newer; drcontinue, on the other hand, always tries to honor drdir
correctly, leading to the drcontinue not actually working unless drdir
is specifically given.

This fixes that.

Change-Id: Icf6982d0ba55490b7a7ae3a1ee6c94c40f1c3c64

11 years agoMerge "(bug 30836) API siteinfo specialpagealiases should not return nonexistent...
MaxSem [Fri, 6 Jul 2012 22:41:41 +0000 (22:41 +0000)]
Merge "(bug 30836) API siteinfo specialpagealiases should not return nonexistent special pages"

11 years ago(bug 30836) API siteinfo specialpagealiases should not return nonexistent special...
Brad Jorsch [Sat, 2 Jun 2012 20:20:14 +0000 (22:20 +0200)]
(bug 30836) API siteinfo specialpagealiases should not return nonexistent special pages

Some special pages are conditionally registered (e.g.
Special:Popularpages only exists when $wgDisableCounters is false), or
sometimes an alias exists for a special page that does not. The API
should probably not return entries for these from
meta=siteinfo&siprop=specialpagealiases.

Change-Id: I59eb82eae45fb47c6a769195cc1bd28711b4fcac

11 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Fri, 6 Jul 2012 21:12:53 +0000 (21:12 +0000)]
Localisation updates from translatewiki.net.

Change-Id: Ic30774dd104bf2b329e3682312c8badc54b99ecc

11 years agoMerge "I18n of display of change tags"
MaxSem [Fri, 6 Jul 2012 20:30:25 +0000 (20:30 +0000)]
Merge "I18n of display of change tags"

11 years agoSend correct HTML when reporting a MWException object and the OuputPage object cannot...
Alexandre Emsenhuber [Thu, 28 Jun 2012 09:52:43 +0000 (11:52 +0200)]
Send correct HTML when reporting a MWException object and the OuputPage object cannot be used.

Currently only the body was sent, without doc type, <html>, <head> or <body> items.

Change-Id: I2d5cc3f69f55d0e1b212148f57f736f100bd2554

11 years agoparse.php Windows uses CTRL+Z as a EOF sequence
Antoine Musso [Fri, 6 Jul 2012 18:22:00 +0000 (20:22 +0200)]
parse.php Windows uses CTRL+Z as a EOF sequence

Follow up:
1fc2bb9 - parse.php note about using ^D to end output

The previous patch assumed ^D to be the standard.

Change-Id: If573c1a03eb9679d74fcb24c1be6931eee361158

11 years agoMerge "Pass the full context to the ApiMain instance from api.php."
Reedy [Fri, 6 Jul 2012 18:18:11 +0000 (18:18 +0000)]
Merge "Pass the full context to the ApiMain instance from api.php."

11 years agoPass the full context to the ApiMain instance from api.php.
Alexandre Emsenhuber [Fri, 6 Jul 2012 08:41:17 +0000 (10:41 +0200)]
Pass the full context to the ApiMain instance from api.php.

Passing only the WebRequest instance is not the best
thing when it accepts a complete context.

Change-Id: If02148c850b395a2382f87cbeafbc25887ce8728

11 years agoUse estimateRowPage if wiki is using wgMiserMode
Reedy [Fri, 6 Jul 2012 16:57:40 +0000 (17:57 +0100)]
Use estimateRowPage if wiki is using wgMiserMode

Change-Id: I59404e9514a87f65faf3eb865fafe358d9f01079

11 years agoAdded SpecialPageAfterExecute and SpecialPageBeforeExecute hooks
jeroendedauw [Fri, 6 Jul 2012 11:36:01 +0000 (13:36 +0200)]
Added SpecialPageAfterExecute and SpecialPageBeforeExecute hooks

Danwe apparently needs them :)

Change-Id: Ic74c7ba7f4168d2b0cfbd3c4e551218f6cb2693a

11 years agoMerge "Tweaked mysql_affected_rows() check in WikiPage since it can return -1."
MaxSem [Fri, 6 Jul 2012 13:45:15 +0000 (13:45 +0000)]
Merge "Tweaked mysql_affected_rows() check in WikiPage since it can return -1."

11 years agoMerge "Simplify factory methods of RecentChange."
MaxSem [Fri, 6 Jul 2012 13:03:07 +0000 (13:03 +0000)]
Merge "Simplify factory methods of RecentChange."

11 years agoMerge "Fixed cp error in method name"
MaxSem [Fri, 6 Jul 2012 12:51:53 +0000 (12:51 +0000)]
Merge "Fixed cp error in method name"

11 years agorm duplicate "Antoine Musso" in README
Antoine Musso [Fri, 6 Jul 2012 12:20:57 +0000 (14:20 +0200)]
rm duplicate "Antoine Musso" in README

Change-Id: I8051199582955b95542f0a258d57a80668f070d5

11 years agoFixed cp error in method name
jeroendedauw [Fri, 6 Jul 2012 11:10:47 +0000 (13:10 +0200)]
Fixed cp error in method name

Change-Id: Idf5a397773418ee85ea17bcd3e3cbbf16d1a57b5

11 years agoSimplify factory methods of RecentChange.
Alexandre Emsenhuber [Fri, 29 Jun 2012 09:51:55 +0000 (11:51 +0200)]
Simplify factory methods of RecentChange.

* Make RecentChange::newFromId() use RecentChange::newFromConds()
* We have DatabaseBase::selectRow() for the purpose of selecting
  a single row.

Change-Id: Ie818205437ecea6a4860b74f49b2940c91132a66

11 years agoAdd some explicit member variable definitions
Reedy [Wed, 4 Jul 2012 22:27:30 +0000 (23:27 +0100)]
Add some explicit member variable definitions

Bits of parameter documentation

Change-Id: If99a344222900a6715114fa61eadcd4dd3e13db6

11 years agoMinor stylize, add some braces
Reedy [Thu, 5 Jul 2012 22:53:57 +0000 (23:53 +0100)]
Minor stylize, add some braces

Couple of bits of member variable docs

Change-Id: Iccf861b1b93543f21f43c50864107ec6bb233bd1

11 years agoMerge "Use Linker::getInvalidTitleDescription() to display invalid title entries...
Aaron Schulz [Thu, 5 Jul 2012 21:42:39 +0000 (21:42 +0000)]
Merge "Use Linker::getInvalidTitleDescription() to display invalid title entries in Special:Undelete."

11 years agoAdd a context parameter to Liker::generateRollback() and Linker::buildRollbackLink...
Alexandre Emsenhuber [Thu, 5 Jul 2012 21:07:58 +0000 (23:07 +0200)]
Add a context parameter to Liker::generateRollback() and Linker::buildRollbackLink() and updated callers.

This allows both methods to not always rely on global object, but also to use the local context when possible.

Change-Id: Id10f55ed9b18c889afd8d9937d9f35acb376cce4

11 years agoTweaked mysql_affected_rows() check in WikiPage since it can return -1.
Aaron [Thu, 5 Jul 2012 20:54:33 +0000 (13:54 -0700)]
Tweaked mysql_affected_rows() check in WikiPage since it can return -1.

In theory, a DBError or something should be thrown already; this is just for sanity.

Change-Id: Ie54dc764ee4d4c6e450b7bcff5663c1707027c6d

11 years agoChange entry point of SpecialPage
jeroendedauw [Thu, 5 Jul 2012 20:47:15 +0000 (22:47 +0200)]
Change entry point of SpecialPage

The old entry point is the execute method, which clearly is not meant to be an entry point,
as it's overloaded in most subclasses, making it impossible for the deriving classes to do anything
before or after (which for instance sucks big time in SpecialCachedPage).

Change-Id: I74c22a1dc3b1a9d062295d5fb709fb87577810ae

11 years agoMerge "Reimplement CORS properly, addressing Tim's concerns"
Reedy [Thu, 5 Jul 2012 20:31:39 +0000 (20:31 +0000)]
Merge "Reimplement CORS properly, addressing Tim's concerns"

11 years agoReimplement CORS properly, addressing Tim's concerns
Catrope [Fri, 1 Jun 2012 12:14:47 +0000 (05:14 -0700)]
Reimplement CORS properly, addressing Tim's concerns

Tim's concerns (listed at
https://bugzilla.wikimedia.org/show_bug.cgi?id=20814#c6) were:
* Lack of Vary: Origin breaks Squid caching
* Vary: Origin on everything would be disastrous, so add an origin param
* Origin header is space-separated list, wasn't treated as such

This commit:
* Remove CORS code from api.php and reimplement it in ApiMain.php
* Add 'origin' parameter to ApiMain
* If 'origin' parameter doesn't match Origin header, send a 403
* If origin is whitelisted, set CORS headers and set Vary: Origin
* Add https?:// to wildcard matching logic, wasn't there but is needed

CORS now works :) you can test it locally as follows:
Set $wgCrossSiteAJAXdomains[] = '*.wikipedia.org';
Log into MediaWiki on localhost
Go to Wikipedia, open a JS console, and run:
$.ajax( {
'url': 'http://localhost/w/api.php',
'data': {
'action': 'query',
'meta': 'userinfo',
'format': 'json',
'origin': 'https://en.wikipedia.org'
// or whichever domain you're on; must be correct!
},
'xhrFields': {
'withCredentials': true
},
'success': function( data ) {
alert( 'Foreign user ' + data.query.userinfo.name +
' (ID ' + data.query.userinfo.id + ')' );
}
} );

Change-Id: I725ce176866d7c81dd9ad6d7bc4a86b7160f2458

11 years agoIn ApiMain, gather Vary headers in OutputPage
Catrope [Fri, 1 Jun 2012 11:11:32 +0000 (04:11 -0700)]
In ApiMain, gather Vary headers in OutputPage

Using OutputPage for this rather than something like WebResponse
probably isn't optimal, but it's a lot nicer than the mess we had
before.

Change-Id: I9dce06d3eb69dd7952eafc6c94ead2ad5ad88792

11 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Thu, 5 Jul 2012 19:42:03 +0000 (19:42 +0000)]
Localisation updates from translatewiki.net.

Change-Id: Ie9fc1396e26a2ef8f71b74fd92c4a80bb0d8b493

11 years agoPass objects to methods accepting them instead of relying on global objects.
Alexandre Emsenhuber [Wed, 4 Jul 2012 09:33:00 +0000 (11:33 +0200)]
Pass objects to methods accepting them instead of relying on global objects.

* Pass the User object to Title::quickUserCan()
* Pass the Context object to ChangesList::showCharacterDifference()

Change-Id: I53e5338c66c9d43b7b2257cd0515fe37dd05f5e3

11 years agoFix parameter name: $displayText does not exist, but $altUserName does.
Alexandre Emsenhuber [Wed, 4 Jul 2012 09:38:56 +0000 (11:38 +0200)]
Fix parameter name: $displayText does not exist, but $altUserName does.

Change-Id: Ic901d6a74701eb8c1802ac7a28c479b253353a14

11 years agoMerge "Remove some old debugging code"
Aaron Schulz [Thu, 5 Jul 2012 17:29:38 +0000 (17:29 +0000)]
Merge "Remove some old debugging code"

11 years agoFix method siganture mismatch causing notice
jeroendedauw [Thu, 5 Jul 2012 15:08:10 +0000 (17:08 +0200)]
Fix method siganture mismatch causing notice

Change-Id: If2eb0441c19f2f9635d3ce0633e2da7005a9d9b0

11 years agoMerge "(bug 37604) Update jquery.cookie.js from 2009 to 2011"
Krinkle [Thu, 5 Jul 2012 03:59:01 +0000 (03:59 +0000)]
Merge "(bug 37604) Update jquery.cookie.js from 2009 to 2011"

11 years ago(bug 37604) Update jquery.cookie.js from 2009 to 2011
Mark Holmquist [Thu, 14 Jun 2012 19:14:30 +0000 (12:14 -0700)]
(bug 37604) Update jquery.cookie.js from 2009 to 2011

* Upstream
 - version: 2009 -> 2011
 - commit: https://github.com/carhartl/jquery-cookie/commit/faa09dc38bd3c791212e8fca67ee661af55fa530

* Copyright noted 2006, but that wasn't updated until 2009..

Change-Id: Id9277c7bb99c2e0a170b4dfa3e83b7b41926ea2e

11 years agoMerge "Allow API meta=siteinfo to return list of know variable IDs"
Reedy [Thu, 5 Jul 2012 01:04:16 +0000 (01:04 +0000)]
Merge "Allow API meta=siteinfo to return list of know variable IDs"

11 years agoAllow API meta=siteinfo to return list of know variable IDs
Brad Jorsch [Sat, 2 Jun 2012 20:34:18 +0000 (22:34 +0200)]
Allow API meta=siteinfo to return list of know variable IDs

To know whether something like {{foo}} is a template, variable, or
function, you have to first check if it's a magic word, and then look up
the magic word ID in the list of variables and the list of function
hooks. The API already can return the list of known magic word mappings
(siprop=magicwords) and function hooks (siprop=functionhooks), this
completes the set by allowing siprop=variables.

Change-Id: If13df9c3796ea6815393d847a3c6f70380bba58a

11 years agoMerge "Sync DeviceDetection with MF"
Reedy [Thu, 5 Jul 2012 00:58:20 +0000 (00:58 +0000)]
Merge "Sync DeviceDetection with MF"

11 years agoMerge "(bug 38152) jquery.tablesorter: Use .data() instead of .attr()"
Kaldari [Thu, 5 Jul 2012 00:54:19 +0000 (00:54 +0000)]
Merge "(bug 38152) jquery.tablesorter: Use .data() instead of .attr()"

11 years agoMerge "Revert "Watchlist grouping (not ready for review)""
Reedy [Wed, 4 Jul 2012 22:35:00 +0000 (22:35 +0000)]
Merge "Revert "Watchlist grouping (not ready for review)""

11 years agohook InternalParseBeforeSanitize
Daniel Werner [Sun, 24 Jun 2012 20:43:17 +0000 (22:43 +0200)]
hook InternalParseBeforeSanitize

This patch add the hook 'InternalParseBeforeSanitize' which gets called
during Parser's internalParse method just before the parser removes
unwanted/dangerous HTML tags.

Change-Id: If32053f9304088d7943aa0c9e78716a644c34fe1

11 years agoMerge "*(bug 30976) Add maintenance script to remove preferences from $wgHiddenPrefs"
Reedy [Wed, 4 Jul 2012 22:11:18 +0000 (22:11 +0000)]
Merge "*(bug 30976) Add maintenance script to remove preferences from $wgHiddenPrefs"

11 years ago*(bug 30976) Add maintenance script to remove preferences from $wgHiddenPrefs
TyA [Wed, 30 May 2012 03:49:17 +0000 (04:49 +0100)]
*(bug 30976) Add maintenance script to remove preferences from $wgHiddenPrefs

Change-Id: Ie74fab1edeac2c6b275c51e6af3a7924b3aac46b

11 years agoMerge "Fix small typo in comment"
Reedy [Wed, 4 Jul 2012 22:01:25 +0000 (22:01 +0000)]
Merge "Fix small typo in comment"

11 years ago(bug 32383) Allow descending order for list=langbacklinks
umherirrender [Sun, 17 Jun 2012 07:59:19 +0000 (09:59 +0200)]
(bug 32383) Allow descending order for list=langbacklinks

Change-Id: I5ebcb8c3d49f85eba14c1caafb5b5b78ccee4605

11 years ago(bug 32381) Allow descending order for list=backlinks, list=embeddedin
umherirrender [Mon, 30 Apr 2012 12:24:48 +0000 (14:24 +0200)]
(bug 32381) Allow descending order for list=backlinks, list=embeddedin
and list=imageusage

Also avoid some filesorts when using redirect param of that modules
due to fields in order by, which are constant in where

Change-Id: I4b1c4282ab3be9cb93601c57d660520456cf8617

11 years ago(bug 32382) Allow descending order for list=iwbacklinks
umherirrender [Sun, 17 Jun 2012 07:46:30 +0000 (09:46 +0200)]
(bug 32382) Allow descending order for list=iwbacklinks

Change-Id: If9425f3d6dbee3da34e875c1b02088478c3d6d53

11 years ago(bug 17865) Add a "ParserAfterParse" hook
Brad Jorsch [Sun, 17 Jun 2012 00:34:36 +0000 (20:34 -0400)]
(bug 17865) Add a "ParserAfterParse" hook

In order to correctly output an error message that might contain
wikilinks, Cite.php needs a hook that is called after the page is parsed
but before the call to replaceLinkHolders().

Change-Id: Iaa2755f994edb081eb1d176f632f7add41640dbf

11 years ago(bug 38152) jquery.tablesorter: Use .data() instead of .attr()
Timo Tijhof [Tue, 3 Jul 2012 20:55:43 +0000 (22:55 +0200)]
(bug 38152) jquery.tablesorter: Use .data() instead of .attr()

* .data() is faster when looking up repeatedly

* .data() will return the latest value, even if it has changed over
   time, whereas .attr() only gives the value as it was when the page
   was generated. Much like the difference between attr() and prop()
   when it comes to value, checked, disabled etc.

* Moved buildCache() call outside `if ( firstTime )`.
  Tests show that this is fast enough to do on the fly. Left inline
  comment with proposal on how to make this more elaborate in the
  future would it become necessary.

* jquery.tablesorter.test.js:
 - Add tests for bug 38152
 - Clean up double quotes
 - Use more descriptive id (prefix with mw-bug-)

Change-Id: Ie4f801c5b1f93617fd3fd173d2eaaf173a7604e9

11 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Wed, 4 Jul 2012 20:03:46 +0000 (20:03 +0000)]
Localisation updates from translatewiki.net.

Change-Id: Ie04d0ed3e4238ff292aa4656e8ed897085cf04aa

11 years agoRemove some old debugging code
Reedy [Wed, 4 Jul 2012 15:31:01 +0000 (16:31 +0100)]
Remove some old debugging code

Add a couple more bits of function parameter documentation

Change-Id: If355978801b2bfc8a51f642f53f2cea6f87fc351

11 years agoMerge "No need to wrap the result of DatabaseBase::select() in a ResultWrapper object."
Nikerabbit [Wed, 4 Jul 2012 13:03:09 +0000 (13:03 +0000)]
Merge "No need to wrap the result of DatabaseBase::select() in a ResultWrapper object."

11 years agoAdded wikitext parsertests for dashes
Subramanya Sastry [Tue, 3 Jul 2012 16:16:53 +0000 (11:16 -0500)]
Added wikitext parsertests for dashes

Change-Id: I0f595f05057068e6459062fc8e8f9fad23021dec

11 years agoMerge "Revert "jquery.byteLimit: Partial rewrite to fix logic errors""
Hashar [Wed, 4 Jul 2012 09:01:33 +0000 (09:01 +0000)]
Merge "Revert "jquery.byteLimit: Partial rewrite to fix logic errors""

11 years agoNo need to wrap the result of DatabaseBase::select() in a ResultWrapper object.
Alexandre Emsenhuber [Wed, 4 Jul 2012 08:55:09 +0000 (10:55 +0200)]
No need to wrap the result of DatabaseBase::select() in a ResultWrapper object.

Change-Id: I2cceb363b4573a850a7a63c93d2ca9899e477a7f
DatabaseBase::select() already returns a ResultWrapper object, so its useless to wrap it again.

11 years agoRevert "jquery.byteLimit: Partial rewrite to fix logic errors"
Siebrand [Wed, 4 Jul 2012 08:50:02 +0000 (08:50 +0000)]
Revert "jquery.byteLimit: Partial rewrite to fix logic errors"

This causes bug 38158.

This reverts commit 1ceab34587b98abae29bba9027838ed354330025

11 years agoMerge "f-prot isn't so open now, so might aswell not advertise it in DefaultSetttings...
Siebrand [Wed, 4 Jul 2012 08:12:43 +0000 (08:12 +0000)]
Merge "f-prot isn't so open now, so might aswell not advertise it in DefaultSetttings under antivirus"

11 years agoMerge "jshint: add .jshintrc / .jshintignore files"
Catrope [Wed, 4 Jul 2012 06:28:37 +0000 (06:28 +0000)]
Merge "jshint: add .jshintrc / .jshintignore files"

11 years agoMerge "(bug 31895) Fix bug in mediawiki.js with early domready handlers."
Catrope [Wed, 4 Jul 2012 06:23:00 +0000 (06:23 +0000)]
Merge "(bug 31895) Fix bug in mediawiki.js with early domready handlers."

11 years agoMerge "jquery.byteLimit: Partial rewrite to fix logic errors"
Catrope [Wed, 4 Jul 2012 06:17:35 +0000 (06:17 +0000)]
Merge "jquery.byteLimit: Partial rewrite to fix logic errors"

11 years ago(bug 31895) Fix bug in mediawiki.js with early domready handlers.
Timo Tijhof [Sat, 23 Jun 2012 14:48:09 +0000 (16:48 +0200)]
(bug 31895) Fix bug in mediawiki.js with early domready handlers.

Previously it used a local `ready` variable set to false, that is
set to true from a $.fn.ready callback. Sounds good, except that
we're not the only one in that callback list. And, more
importantly, not always the first one.

Thus if an earlier domready callback calls mw.loader, the value is
still false, and the wrong load method could be used (bug 31895).

Fixing by using $.isReady directly, which is set to true right
before the domready callback list is fired.

This is bug is impossible to hit within a MediaWiki environment
since mediawiki.js is the first script loaded from the startup
module and is blocking as well.

But browser-userscripts, greasemonkey and/or browse extensions can
sometimes get in an odd position in between or before.

Change-Id: I146c1d2245aae71c538ce84daee30b4ec490b874

11 years agojquery.byteLimit: Partial rewrite to fix logic errors
Timo Tijhof [Sat, 23 Jun 2012 02:16:06 +0000 (04:16 +0200)]
jquery.byteLimit: Partial rewrite to fix logic errors

* Previously it was hooking into the keypress event, this meant
  that it had to do all sorts of calculation to figure out what
  the string length would be *after* the to-be-pressed key
  is allowed to be pressed. This sounds trivial, but is quite the
  contrary. First of all are control, alt, shift etc. those were
  covered.

  What wasn't covered and imho can't be realistically covered
  without bugs is: copy/paste, drag/drop, text selection and
  replacing or removing more at once. Or even a combination of the
  above. And then there is custom insert methods such as Narayam,
  where the character will not be literally inserted at all.

  Therefore I've changed it to instead listen to *after* the insert.
  and if necessary undo the last (one or more) characters until the
  byteLimit is satisfied. This works much more stable. Still very
  fast and not noticeable to the user.

  This also fixes the bug where when the limit is reached, you
  select all and type something else, you couldn't because it would
  prevent the keypress since the limit is reached.

* Updated documentation comments.

* Updated unit tests to simulate onkeyup instead of onkeypress.
 - hasLimit option in byteLimitTest() was redundant, using limit
   directly, instead of duplicating it twice.
 - Added more comments and better test names. Tests themselves
   have not changed.
 - Removed redundant tests at the bottom that no longer make sense
   in the new version (and were broken) since the property is
   now always unset instead of just if there is a callback.
   The native limit must not interfere.

Change-Id: I9ace3ab79f488d24ad13baace32118c151c06347

11 years agoMerge "(bug 36310) jquery.byteLimit should skip < 0 due to Firefox bug."
Catrope [Wed, 4 Jul 2012 06:00:51 +0000 (06:00 +0000)]
Merge "(bug 36310) jquery.byteLimit should skip < 0 due to Firefox bug."

11 years agoFix small typo in comment
Ori Livneh [Wed, 4 Jul 2012 05:50:19 +0000 (22:50 -0700)]
Fix small typo in comment

Change-Id: I5f7309699685e8fc3640e0c650a7877ef53fec40

11 years agoRevert "Watchlist grouping (not ready for review)"
Aaron Pramana [Wed, 4 Jul 2012 02:51:22 +0000 (02:51 +0000)]
Revert "Watchlist grouping (not ready for review)"

This reverts commit 9d1bb4f3e401786a86c12ae4b20b425c27ddcb91

11 years agof-prot isn't so open now, so might aswell not advertise it in DefaultSetttings under...
Reedy [Tue, 3 Jul 2012 23:14:33 +0000 (00:14 +0100)]
f-prot isn't so open now, so might aswell not advertise it in DefaultSetttings under antivirus

Change-Id: I2f9e1ced05e434655202ee3b425b90344d854065

11 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Tue, 3 Jul 2012 20:51:32 +0000 (20:51 +0000)]
Localisation updates from translatewiki.net.

Change-Id: I047eb13fb40e3b1c3be3460001a33c0e6b36e4ca

11 years agoMerge "(bug 38148) Fix E_WARNING in ChangesList.php line 1218"
Catrope [Tue, 3 Jul 2012 18:50:01 +0000 (18:50 +0000)]
Merge "(bug 38148) Fix E_WARNING in ChangesList.php line 1218"

11 years agoMerge "Fixed exception in diff size formatter."
Catrope [Tue, 3 Jul 2012 18:35:57 +0000 (18:35 +0000)]
Merge "Fixed exception in diff size formatter."

11 years agoFixed exception in diff size formatter.
Aaron [Tue, 3 Jul 2012 18:20:24 +0000 (11:20 -0700)]
Fixed exception in diff size formatter.

Change-Id: Iaa4887453ba6b136e507e51af6c80849b7c6873c

11 years agoMerge "Introduce a new hook that allows extensions to add to My Contributions"
Catrope [Tue, 3 Jul 2012 18:18:16 +0000 (18:18 +0000)]
Merge "Introduce a new hook that allows extensions to add to My Contributions"

11 years agoMerge "Make OutputPage's mechanism for gathering Vary headers reusable"
Aaron Schulz [Tue, 3 Jul 2012 18:01:31 +0000 (18:01 +0000)]
Merge "Make OutputPage's mechanism for gathering Vary headers reusable"

11 years agoIntroduce a new hook that allows extensions to add to My Contributions
mlitn [Mon, 2 Jul 2012 13:31:06 +0000 (15:31 +0200)]
Introduce a new hook that allows extensions to add to My Contributions

Meanwhile also:
- refactored reallyDoQuery in Pager.php, to make outside intervention possible
- extend reallyDoQuery in SpecialContributions.php, adding in the hook and composing the final results array based on the combined results of all queries added through the hook

Change-Id: Ifd63cdf1950f914a3fba1757a905385aca311eda

11 years ago(bug 38148) Fix E_WARNING in ChangesList.php line 1218
Alexandre Emsenhuber [Tue, 3 Jul 2012 17:46:53 +0000 (19:46 +0200)]
(bug 38148) Fix E_WARNING in ChangesList.php line 1218

The error is PHP Warning: explode() expects parameter 2 to be string, array given in includes/ChangesList.php on line 1218.
The problem is that $classes is always an array, so no need to explode() it.

Change-Id: I6917273aecc6b9ddbf377e69ecbd343ee25fa8ef

11 years agoMerge "Pass $classes in the ContributionsLineEnding hook"
Aaron Schulz [Tue, 3 Jul 2012 17:45:25 +0000 (17:45 +0000)]
Merge "Pass $classes in the ContributionsLineEnding hook"

11 years agoPass $classes in the ContributionsLineEnding hook
mlitn [Tue, 3 Jul 2012 17:38:09 +0000 (10:38 -0700)]
Pass $classes in the ContributionsLineEnding hook

Originally part of https://gerrit.wikimedia.org/r/13880

Change-Id: I05d9d13e8dc4e9442ecfba79a7d1af8bf192c28b

11 years agoFix FakeResultWrapper::fetchRow, which (contrary to ResultWrapper::fetchRow) didn...
mlitn [Tue, 3 Jul 2012 17:33:42 +0000 (10:33 -0700)]
Fix FakeResultWrapper::fetchRow, which (contrary to ResultWrapper::fetchRow) didn't always return an array

This was originally part of https://gerrit.wikimedia.org/r/13880

Change-Id: I0b737bafa59c97ff0b658189c53022388bb7a56d

11 years ago(bug 36991) Fix jquery.tablesorter date sorting
Brad Jorsch [Sun, 20 May 2012 18:10:09 +0000 (14:10 -0400)]
(bug 36991) Fix jquery.tablesorter date sorting

jquery.tablesorter should extract date sort format from date string
instead of global config. Dates like "April 1 2012" and "1 April 2012" now sort correctly regardless of the content language's
DefaultDateFormat setting (exposed as wgDefaultDateFormat in
mw.config).

Previously jquery.tablesorter sorted dates like "1 Apr 2012" (DMY) or
"Apr 1 2012" (MDY) incorrectly. It just converted it to "1 4 2012"
and "4 1 2012", respectively, and then assumes MDY or DMY order based
on the global wiki configuration.

This patch fixes that.

Change-Id: I8061b1a7892633e34be4d4a0273a4dd5045fd2ee

11 years agojshint: add .jshintrc / .jshintignore files
Timo Tijhof [Tue, 3 Jul 2012 07:33:51 +0000 (09:33 +0200)]
jshint: add .jshintrc / .jshintignore files

* More commits to follow that further fine-tune the settings and fix
  lint errors in the actual files.

* Quick how-to on how to use jshint from the command-line interface:
 - Prerequisites: node and npm
   http://nodejs.org/
   http://npmjs.org/

 - `$ npm install -g jshint`
   https://github.com/jshint/node-jshint/

 - Done!
   All: `/mediawiki/core$ jshint .`
   Dir: `/mediawiki/core$ jshint resources`
   Dir: `/mediawiki/core$ jshint resources/jquery`
   File(s): `/mediawiki/core$ jshint resources/startup.js resources/mediawiki/mediawiki.js`

Change-Id: Ia9297cb72c8faa7543ccfbdf48c7ee4e8af4ae17

11 years agoMake OutputPage's mechanism for gathering Vary headers reusable
Catrope [Fri, 1 Jun 2012 10:23:53 +0000 (03:23 -0700)]
Make OutputPage's mechanism for gathering Vary headers reusable

Maybe WebResponse would be a better place for this, but this'll work for
now.

* Add getVaryHeader() to get the serialized version of $mVaryHeader.
* Remove 'Cookie' from the initializer, and add it explicitly later
** This allows reuse by code that doesn't want 'Cookie' in there

Change-Id: Ifa8f74a21f832154b05e54ced95b9f9eb6052fcd

11 years agoparse.php note about using ^D to end output
Antoine Musso [Tue, 3 Jul 2012 12:04:52 +0000 (14:04 +0200)]
parse.php note about using ^D to end output

Change-Id: I8ddc6b565044038ba1660dcd3a5942f82420ca9a

11 years agoUse Linker::getInvalidTitleDescription() to display invalid title entries in Special...
Alexandre Emsenhuber [Tue, 3 Jul 2012 08:02:37 +0000 (10:02 +0200)]
Use Linker::getInvalidTitleDescription() to display invalid title entries in Special:Undelete.

Change-Id: I520afdc3fbfe653cb1115a947185152ff589fbc8

11 years agoMerge "Revert changes from 792a960b2e3404235b4b195edb8333cd57372b90."
Siebrand Mazeland [Tue, 3 Jul 2012 08:32:35 +0000 (08:32 +0000)]
Merge "Revert changes from 792a960b2e3404235b4b195edb8333cd57372b90."