lhc/web/wiklou.git
10 years agoRemove remaining calls to MWInit methods
Kevin Israel [Thu, 8 Aug 2013 03:18:34 +0000 (23:18 -0400)]
Remove remaining calls to MWInit methods

... as well as the require_once statements in includes/WebStart.php
and maintenance/doMaintenance.php, now that the autoloader lists
MWInit (since r85807 / c68957c5e3ada65806294bc9bc5938aa18c6e50c).

Also removed code paths in maintenance/userDupes.inc that seem to be
dead (class_exists( 'Revision' ) should always be true) and useless
global/require_once statements in languages/Language.php.

Follows-up Ic3e769f1fbad4f7ad26dd819406796fee48c6b45.

Change-Id: I48fd6810fdb923b3065ae98024912eb18d394415

10 years agoMerge "Web installer: correctly show note for I4ecd0659"
jenkins-bot [Sun, 15 Sep 2013 18:38:44 +0000 (18:38 +0000)]
Merge "Web installer: correctly show note for I4ecd0659"

10 years agoWeb installer: correctly show note for I4ecd0659
Kevin Israel [Mon, 2 Sep 2013 22:12:45 +0000 (18:12 -0400)]
Web installer: correctly show note for I4ecd0659

InstallDocFormatter didn't escape the double underscores in
__TOC__. I also noticed that wfEscapeWikiText had a similar
bug, which I reported as bug 53658 (fixed separately).

Change-Id: Ib5346b9c234f1c5ef361cc4357352b09def5dc25

10 years agoMerge "Always pass user to LogPage::addEntry"
jenkins-bot [Sat, 14 Sep 2013 15:02:02 +0000 (15:02 +0000)]
Merge "Always pass user to LogPage::addEntry"

10 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Fri, 13 Sep 2013 21:08:14 +0000 (21:08 +0000)]
Localisation updates from translatewiki.net.

Change-Id: Id3cc828ebb6b0c06ea052977fcabeec78cacd606

10 years agoAlways pass user to LogPage::addEntry
umherirrender [Fri, 13 Sep 2013 19:14:36 +0000 (21:14 +0200)]
Always pass user to LogPage::addEntry

This avoids getting $wgUser in LogPage::addEntry

Change-Id: Ie105cef4ebc3d69aeaef5ee40ce6ee0087a74c69

10 years agoMerge "Consistently follow conventions for documenting parameters"
jenkins-bot [Fri, 13 Sep 2013 13:54:06 +0000 (13:54 +0000)]
Merge "Consistently follow conventions for documenting parameters"

10 years agoConsistently follow conventions for documenting parameters
Ori Livneh [Fri, 13 Sep 2013 04:50:45 +0000 (21:50 -0700)]
Consistently follow conventions for documenting parameters

Per MW:CC/PHP, the type goes before the variable name, and built-in types are
not uppercase.

Change-Id: Ibb753acd9529ace3579d57654adc47673fa49719

10 years agoMerge "wfMkdirParents: recover from mkdir race condition"
jenkins-bot [Thu, 12 Sep 2013 23:48:36 +0000 (23:48 +0000)]
Merge "wfMkdirParents: recover from mkdir race condition"

10 years agowfMkdirParents: recover from mkdir race condition
Elliott Eggleston [Thu, 12 Sep 2013 22:55:45 +0000 (18:55 -0400)]
wfMkdirParents: recover from mkdir race condition

If mkdir fails, check again to see if dir has been created
since our initial check, and return true if so.

Also, in initial check, only return true if $dir is really
a directory, not a file.

Bug: 49391
Change-Id: I2b331669fae70948ce79ba1477c05968a3095c3d

10 years agoMerge "Make line breaks in <blockquote> behave like <div> (bug 6200)."
jenkins-bot [Thu, 12 Sep 2013 23:24:31 +0000 (23:24 +0000)]
Merge "Make line breaks in <blockquote> behave like <div> (bug 6200)."

10 years agoMerge "Localisation updates from http://translatewiki.net."
Translation updater bot [Thu, 12 Sep 2013 19:40:06 +0000 (19:40 +0000)]
Merge "Localisation updates from translatewiki.net."

10 years agoMerge "Remove "Misc" tab from Special:Preferences"
jenkins-bot [Thu, 12 Sep 2013 19:22:15 +0000 (19:22 +0000)]
Merge "Remove "Misc" tab from Special:Preferences"

10 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Thu, 12 Sep 2013 19:22:12 +0000 (19:22 +0000)]
Localisation updates from translatewiki.net.

Change-Id: I96c07ba05dd7466f54cd6f3cef315705fc716588

10 years agoMerge "SpecialPrefixindex: Try not to generate unclickable links"
jenkins-bot [Thu, 12 Sep 2013 19:17:43 +0000 (19:17 +0000)]
Merge "SpecialPrefixindex: Try not to generate unclickable links"

10 years agoMerge "jquery.tablesorter: Support genitive month names"
jenkins-bot [Thu, 12 Sep 2013 19:13:24 +0000 (19:13 +0000)]
Merge "jquery.tablesorter: Support genitive month names"

10 years agoMerge "Adding support for query string params to mw.util.wikiGetlink"
Jdlrobson [Thu, 12 Sep 2013 17:45:25 +0000 (17:45 +0000)]
Merge "Adding support for query string params to mw.util.wikiGetlink"

10 years agoMake line breaks in <blockquote> behave like <div> (bug 6200).
C. Scott Ananian [Tue, 6 Aug 2013 19:22:18 +0000 (15:22 -0400)]
Make line breaks in <blockquote> behave like <div> (bug 6200).

This is an old, old bug: the earliest filed dup is bug 1857, on 2005-04-10.
See bug 51086 for a modern discussion, and bug 52763 for some non-obvious
consequences: indented text inside a blockquote must not trigger
creation of a <pre> block (unlike <div>).

This patch should bring the PHP parser and Parsoid closer together.

This also fixes (or works around) bug 15491, which is really a bug in tidy.
But because <blockquote> content is typically wrapped with <p> tags now,
we don't trigger the tidy bug (see
https://bugzilla.wikimedia.org/show_bug.cgi?id=15491#c7 for details).

Credit to Aryeh Gregor (https://bugzilla.wikimedia.org/show_bug.cgi?id=6200#c8)
and Vitaliy Filippov (https://bugzilla.wikimedia.org/show_bug.cgi?id=6200#c37)
for almost-correct patches for this bug, which saved me a bunch of effort.
Thanks to Subramanya Sastry for pointing out bug 52763 and preventing a
bunch of broken articles on enwiki.

Bug: 6200
Bug: 15491
Bug: 52763
Change-Id: I3696d4ab7b8ad6ebccf8483d6da1722353c1697d

10 years agoMerge "Clarify "unknown gender" option is a non-answer and resort"
jenkins-bot [Thu, 12 Sep 2013 09:41:08 +0000 (09:41 +0000)]
Merge "Clarify "unknown gender" option is a non-answer and resort"

10 years agoMerge "Fix English gender-unknown message"
jenkins-bot [Thu, 12 Sep 2013 09:39:37 +0000 (09:39 +0000)]
Merge "Fix English gender-unknown message"

10 years agoFix English gender-unknown message
Tim Starling [Thu, 12 Sep 2013 02:57:16 +0000 (12:57 +1000)]
Fix English gender-unknown message

Fix for I81f02f03: the verb "detail" means to give details, i.e. to
say more than a single word in response to a question. It does not make
sense in this context.

Bug: 53311
Change-Id: Ifddf5c9a07dc62bc22dd0a3d2986e41a55b8ef33

10 years agoOptimize Parser::doQuotes().
C. Scott Ananian [Sat, 24 Aug 2013 17:25:54 +0000 (19:25 +0200)]
Optimize Parser::doQuotes().

Performance improvements to doQuotes(), since it is a hot function.

Co-authored-by: Tyler Anthony Romeo <tylerromeo@gmail.com>
Change-Id: If78d4372a2acd78d58b020385da400978716cbf5

10 years agoMade HTMLForm wrap the submit buttons in a container for styling
Aaron Schulz [Wed, 11 Sep 2013 21:47:11 +0000 (14:47 -0700)]
Made HTMLForm wrap the submit buttons in a container for styling

Change-Id: I6510493a80c18ba5a466a16e3ca39396f9a60f60

10 years agoMerge "API: Enforce limit max in ApiQueryBacklinks"
jenkins-bot [Wed, 11 Sep 2013 21:17:01 +0000 (21:17 +0000)]
Merge "API: Enforce limit max in ApiQueryBacklinks"

10 years agoAPI: Enforce limit max in ApiQueryBacklinks
Brad Jorsch [Wed, 11 Sep 2013 20:57:09 +0000 (13:57 -0700)]
API: Enforce limit max in ApiQueryBacklinks

Change-Id: Id0f0943771e3593c30563469df4820437ded9a99

10 years agoAdding support for query string params to mw.util.wikiGetlink
kaldari [Wed, 11 Sep 2013 17:52:14 +0000 (10:52 -0700)]
Adding support for query string params to mw.util.wikiGetlink

This will enable us to easily migrate MobileFrontend from
using M.pageApi.getPageUrl (mobile custom version) to
mw.util.wikiGetlink.

Includes a unit test.

Change-Id: I5224a0910a822f1c3b1b34f505dbcdf879052b39

10 years agoAdd StubObject::unstub, and use it for $wgAuth->getUserInstance()
Brad Jorsch [Wed, 11 Sep 2013 19:55:15 +0000 (12:55 -0700)]
Add StubObject::unstub, and use it for $wgAuth->getUserInstance()

PHP's __call magic method can't handle functions with reference
parameters correctly,[1] which means that we need to manually unstub
StubObjects before calling such a method. Or you could use call-time
pass by reference with call_user_func_array, which is rather backwards
and verbose.

This change adds a convenience function to do this, and applies it to
the two calls which brought it to my attention.

[1]: https://bugs.php.net/bug.php?id=40694,
https://bugs.php.net/bug.php?id=62455

Change-Id: I74a0c04bf358e164f753b82fbefbd6205d9b2451

10 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Wed, 11 Sep 2013 19:35:51 +0000 (19:35 +0000)]
Localisation updates from translatewiki.net.

Change-Id: I7f09413ca5fd56cc4a0fc8b806464495577c101e

10 years agoMerge "Improved search backend fallback in Special:Search"
jenkins-bot [Tue, 10 Sep 2013 21:35:30 +0000 (21:35 +0000)]
Merge "Improved search backend fallback in Special:Search"

10 years agoImproved search backend fallback in Special:Search
Reedy [Tue, 10 Sep 2013 20:10:48 +0000 (21:10 +0100)]
Improved search backend fallback in Special:Search

Use the srbackend parameter if it's valid.

If it's not, use $wgSearchType if it's not null.

Finally, fall back to the search type of the database.

Bug: 53982
Change-Id: I3605cb4add270543aa20afb037401b2dfbe462f0

10 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Tue, 10 Sep 2013 19:48:13 +0000 (19:48 +0000)]
Localisation updates from translatewiki.net.

Change-Id: Ib9eb5a43ec80cd1fd531c2aa60770c17a328794b

10 years agoMerge "Fix inaccurate jQueryMsg comment"
jenkins-bot [Tue, 10 Sep 2013 11:09:03 +0000 (11:09 +0000)]
Merge "Fix inaccurate jQueryMsg comment"

10 years agoFix inaccurate jQueryMsg comment
Matthew Flaschen [Tue, 10 Sep 2013 08:45:00 +0000 (01:45 -0700)]
Fix inaccurate jQueryMsg comment

It's done by mediawiki.js, as it says at the bottom of the file.

Change-Id: I2505cde86ff9d9532fce75f3924f88e898a5f5f6

10 years agoMerge "ToC: Use display:table, so that we can behave like a block element"
jenkins-bot [Mon, 9 Sep 2013 19:48:24 +0000 (19:48 +0000)]
Merge "ToC: Use display:table, so that we can behave like a block element"

10 years agoToC: Use display:table, so that we can behave like a block element
Derk-Jan Hartman [Thu, 22 Aug 2013 19:32:32 +0000 (21:32 +0200)]
ToC: Use display:table, so that we can behave like a block element

The downside to inline-block is that you don't clear other inline
elements. Although inline elements surrounding the ToC are rare, they
are common enough that this introduced some problems on English
Wikipedia.

Instead, let's just display as table. This is a block element and has
all the boxmodel behavior that we want (that of a table, an intrinsic
wide block element). It's not the nicest perhaps, but it works in all
modern browsers without known problems as far as I'm aware.

We still fallback to inline mode on browsers that don't properly
support display:table.

Followup to: I4ecd0659d1f955a9b593d281a3fef0a81c218a52
Bug: 658
Change-Id: Ib8e2801f9a143de370589728aad01926906ffae0

10 years agoMerge "mediawiki.action.edit.preview: Add .limitreport to live preview"
jenkins-bot [Mon, 9 Sep 2013 17:45:48 +0000 (17:45 +0000)]
Merge "mediawiki.action.edit.preview: Add .limitreport to live preview"

10 years agomediawiki.action.edit.preview: Add .limitreport to live preview
Bartosz Dziewoński [Sun, 8 Sep 2013 16:13:01 +0000 (18:13 +0200)]
mediawiki.action.edit.preview: Add .limitreport to live preview

Change-Id: Id65c93322d2d9de2983ba7278f269f9b061e3ade

10 years agoMerge "Use redirect=no for links to file redirects in "file usages" section"
TheDJ [Sun, 8 Sep 2013 13:34:32 +0000 (13:34 +0000)]
Merge "Use redirect=no for links to file redirects in "file usages" section"

10 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Sat, 7 Sep 2013 19:47:58 +0000 (19:47 +0000)]
Localisation updates from translatewiki.net.

Change-Id: I4f52889299ffc8ae8d49634fd8b36d73c66d8b5a

10 years agoAllow toggling elements with space
Marius Hoch [Sat, 7 Sep 2013 12:46:35 +0000 (14:46 +0200)]
Allow toggling elements with space

This seems more convenient than having the space key
do nothing as it does right now.
Furthermore this is more consistent with the various
other collapsible things we have around than to just
scroll the page on a space keypress.

Bug: 53797
Change-Id: If9292ef6a8fd82b097c597dc166e38c8ca31f4ff

10 years agoMerge "jquery.byteLength: Improve documentation and tests"
jenkins-bot [Sat, 7 Sep 2013 10:40:58 +0000 (10:40 +0000)]
Merge "jquery.byteLength: Improve documentation and tests"

10 years agojquery.byteLength: Improve documentation and tests
David Chan [Fri, 6 Sep 2013 02:08:36 +0000 (19:08 -0700)]
jquery.byteLength: Improve documentation and tests

Change-Id: I6793487b7cd9f58b23554bc29c853bd3f02da49c

10 years agoUse redirect=no for links to file redirects in "file usages" section
umherirrender [Sat, 24 Aug 2013 18:27:39 +0000 (20:27 +0200)]
Use redirect=no for links to file redirects in "file usages" section

Bug: 50051
Change-Id: Ie77af42b2d9183ba2f56a300a6604c3f71ee89b8

10 years agoMerge "Removes portal-url, currentevents-url and helppage from default Sidebar"
jenkins-bot [Fri, 6 Sep 2013 20:17:16 +0000 (20:17 +0000)]
Merge "Removes portal-url, currentevents-url and helppage from default Sidebar"

10 years agoRemoves portal-url, currentevents-url and helppage from default Sidebar
Quim Gil [Fri, 30 Aug 2013 15:07:21 +0000 (08:07 -0700)]
Removes portal-url, currentevents-url and helppage from default Sidebar

portal-url ("Community portal"), currentevents-url ("Current events")
and helppage ("Help") lead to empty pages in a fresh MediaWiki install,
when most projects won't need these pages ever. Removing the
corresponding lines.

Bug 53862
Change-Id: Icb0e1b91e40bd682629f8a6f7291dbf8588b586b

10 years agoMerge "Add plain semicolons to wfEscapeWikitext()."
jenkins-bot [Fri, 6 Sep 2013 18:01:14 +0000 (18:01 +0000)]
Merge "Add plain semicolons to wfEscapeWikitext()."

10 years agoMerge "jquery.makeCollapsible: Tests for collapsible <table>, <ul>, <ol>"
jenkins-bot [Fri, 6 Sep 2013 17:59:36 +0000 (17:59 +0000)]
Merge "jquery.makeCollapsible: Tests for collapsible <table>, <ul>, <ol>"

10 years agoMerge "jquery.makeCollapsible: Only trigger custom events once per collapsible"
jenkins-bot [Fri, 6 Sep 2013 17:52:26 +0000 (17:52 +0000)]
Merge "jquery.makeCollapsible: Only trigger custom events once per collapsible"

10 years agoReturn normalized file name on warning "exists-normalized"
rillke [Sat, 10 Aug 2013 12:14:03 +0000 (14:14 +0200)]
Return normalized file name on warning "exists-normalized"

Make API action=upload return normalized file name on warning
"exists-normalized" instead of filename to be uploaded to.

This enables humans to see which file the current upload conflicts
with.
There is no point in returning the filename the upload should go to
because the client that makes the request is usually aware of this.

Bug: 52699
Change-Id: I898b7f234d43eb1e524952f6de80e401a8c96671

10 years agoClarify "unknown gender" option is a non-answer and resort
Federico Leva [Fri, 6 Sep 2013 11:16:01 +0000 (13:16 +0200)]
Clarify "unknown gender" option is a non-answer and resort

It is easier in other languages, but in English some worry
about "I prefer not to detail" not being an answer to the
question used as label of the option; parentheses should
be enough to clarify it is about not answering the question
because you don't care.

Also put such (default) "zero answer" first and move feminine
before male as suggested by Jared to avoid any appearance of
bias in the user interface, though the fallback works that way
in the code anyway for merely grammatical reasons.

Bug: 53311
Bug: 53834
Change-Id: Iea77e903c91063a648fff5e4be41c0be51ac172a

10 years agocollapsibleTabs: Minor code style fixes
MatmaRex [Fri, 6 Sep 2013 09:28:49 +0000 (11:28 +0200)]
collapsibleTabs: Minor code style fixes

Change-Id: Ifef92ac277cce91c64dc9af637e86c9389bfd241

10 years agoMerge "Special:PagesWithProp: Distinguish content from interface"
jenkins-bot [Thu, 5 Sep 2013 22:17:34 +0000 (22:17 +0000)]
Merge "Special:PagesWithProp: Distinguish content from interface"

10 years agoMerge "Add cache versioning to InfoAction."
jenkins-bot [Thu, 5 Sep 2013 22:15:07 +0000 (22:15 +0000)]
Merge "Add cache versioning to InfoAction."

10 years agoMerge "Removing all disambiguation code from core"
jenkins-bot [Thu, 5 Sep 2013 21:13:03 +0000 (21:13 +0000)]
Merge "Removing all disambiguation code from core"

10 years agoRemoving all disambiguation code from core
kaldari [Wed, 17 Jul 2013 00:14:31 +0000 (17:14 -0700)]
Removing all disambiguation code from core

Disambiguation related functions have been re-implemented in the
Disambiguator extension.

Bug: 35981
Change-Id: I4afa30bf2677c6541ef355013f8eaef46abfbe03
Dependency: I41637ea43a9e5000bcb8a782441ce36f1068881f

10 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Thu, 5 Sep 2013 20:28:26 +0000 (20:28 +0000)]
Localisation updates from translatewiki.net.

Change-Id: Id0e30f9293e0dc3a9fb402adf6fc8b005fb97fdc

10 years agoAdd plain semicolons to wfEscapeWikitext().
Liangent [Thu, 5 Sep 2013 19:21:11 +0000 (19:21 +0000)]
Add plain semicolons to wfEscapeWikitext().

It's a part of language conversion syntax, even when not used at
beginning of lines.

Change-Id: I848b6d13096887d51618f2694da93b6d65c0376e

10 years agoMerge "Reorder SpecialRecentChanges::webOutput"
jenkins-bot [Thu, 5 Sep 2013 18:12:08 +0000 (18:12 +0000)]
Merge "Reorder SpecialRecentChanges::webOutput"

10 years agoMerge "Allow registration of Actions using a callback that returns an Action instance"
jenkins-bot [Thu, 5 Sep 2013 10:11:02 +0000 (10:11 +0000)]
Merge "Allow registration of Actions using a callback that returns an Action instance"

10 years agoGive grep a chance to find the usages
shirayuki [Wed, 4 Sep 2013 11:56:47 +0000 (20:56 +0900)]
Give grep a chance to find the usages

Change-Id: I7fc00b055b21bbbbab209a1b1d23f23172862a0b

10 years agoMerge "Call $wgContLang->findVariantLink() in {{PAGESINCATEGORY: }}"
jenkins-bot [Thu, 5 Sep 2013 07:41:39 +0000 (07:41 +0000)]
Merge "Call $wgContLang->findVariantLink() in {{PAGESINCATEGORY: }}"

10 years agoCall $wgContLang->findVariantLink() in {{PAGESINCATEGORY: }}
Liangent [Thu, 18 Apr 2013 04:01:53 +0000 (12:01 +0800)]
Call $wgContLang->findVariantLink() in {{PAGESINCATEGORY: }}

Corrects inconsistent return value for number of pages in a
category when language variants are in use.

Change-Id: I27668ba348c45bc34b264f8771e91e58a9920552

10 years agoMerge "vector/screen.css: Remove some unnecessary rules"
jenkins-bot [Wed, 4 Sep 2013 22:03:09 +0000 (22:03 +0000)]
Merge "vector/screen.css: Remove some unnecessary rules"

10 years agovector/screen.css: Remove some unnecessary rules
MatmaRex [Sat, 31 Aug 2013 18:50:39 +0000 (20:50 +0200)]
vector/screen.css: Remove some unnecessary rules

* There is no label inside div#simpleSearch.
* Inside div#simpleSearch, input and input#searchInput are the
  same in practice (there is a <input type=submit>, but it is hidden).

Change-Id: I1d9657a5ab608d1a54314dd7c96144af96c53d59

10 years agoAllow registration of Actions using a callback that returns an Action instance
jeroendedauw [Mon, 18 Feb 2013 22:23:16 +0000 (23:23 +0100)]
Allow registration of Actions using a callback that returns an Action instance

Basically implementing what Brion suggested on wikitech

This allows for injecting dependencies while still only loading the actual class when needed.

Simple example:

$wgActions['epundo'] = function( Page $page, IContextSource $context = null ) use ( $differ ) {
$undoAction = new \EducationProgram\UndoAction( $page, $context );
$undoAction->setDiffer( $differ );
return $undoAction;
};

Change-Id: I6c0f4022f1df1ebaf9cd1a5fe4bd362d0ecc0d62

10 years agoMerge "Localisation updates from http://translatewiki.net."
Translation updater bot [Wed, 4 Sep 2013 19:56:36 +0000 (19:56 +0000)]
Merge "Localisation updates from translatewiki.net."

10 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Wed, 4 Sep 2013 19:50:47 +0000 (19:50 +0000)]
Localisation updates from translatewiki.net.

Change-Id: I5e7da5913a10c7f75cdf223f2166cc7873134949

10 years agojquery.suggestions: Add some comments
MatmaRex [Wed, 4 Sep 2013 19:41:41 +0000 (21:41 +0200)]
jquery.suggestions: Add some comments

Change-Id: I0706e1f847f8ebf3d48cbb40a88dd6f6d487d2e6

10 years agoMerge "No spaces after (casts)"
jenkins-bot [Wed, 4 Sep 2013 18:14:05 +0000 (18:14 +0000)]
Merge "No spaces after (casts)"

10 years agoNo spaces after (casts)
MatmaRex [Sat, 31 Aug 2013 16:36:02 +0000 (18:36 +0200)]
No spaces after (casts)

Also removed some unnecessary ones. I think I've caught them all.

The spaceless version already appears in core ~300 times (after
accounting for false positives when grepping). Some consistency would
be nice.

Change-Id: I607655b5f4366e66dc78730d5fd2f57ed8776cae

10 years agoMerge "Use canonical class name, remove unused globals."
jenkins-bot [Wed, 4 Sep 2013 17:55:34 +0000 (17:55 +0000)]
Merge "Use canonical class name, remove unused globals."

10 years agoMerge "Add a deferrable update class for callback/closure udpates"
jenkins-bot [Wed, 4 Sep 2013 16:32:38 +0000 (16:32 +0000)]
Merge "Add a deferrable update class for callback/closure udpates"

10 years agoMerge "Make mwCustomEditButtons a no-op and mark it as deprecated"
jenkins-bot [Wed, 4 Sep 2013 16:11:53 +0000 (16:11 +0000)]
Merge "Make mwCustomEditButtons a no-op and mark it as deprecated"

10 years agojquery.makeCollapsible: Tests for collapsible <table>, <ul>, <ol>
MatmaRex [Sun, 21 Jul 2013 12:42:02 +0000 (14:42 +0200)]
jquery.makeCollapsible: Tests for collapsible <table>, <ul>, <ol>

Also expanded basic tests for <div>.

Change-Id: I33b067a70f8ea9a788c687c793fbf561db083a34

10 years agojquery.makeCollapsible: Only trigger custom events once per collapsible
MatmaRex [Wed, 4 Sep 2013 14:48:09 +0000 (16:48 +0200)]
jquery.makeCollapsible: Only trigger custom events once per collapsible

The callback to $.fn.animate()-family functions is fired once per animated
element, not once per call.

Use $.when instead, which behaves the way we need here.

Discovered when writing tests committed in I33b067a7.

Change-Id: I9d61a34374d42609d8d80206f4a4b315f76a8d8d

10 years agoMerge "Parse limitation warnings as 'text' and in user language"
jenkins-bot [Wed, 4 Sep 2013 08:59:06 +0000 (08:59 +0000)]
Merge "Parse limitation warnings as 'text' and in user language"

10 years agoAdd a deferrable update class for callback/closure udpates
bsitu [Tue, 3 Sep 2013 20:43:40 +0000 (13:43 -0700)]
Add a deferrable update class for callback/closure udpates

Change-Id: Ifdf2a0937df50eb2f04d514b5cc2ef39a54ebe8f

10 years agoRemoved "requires JavaScript" from preference texts
rahul21 [Sun, 24 Feb 2013 17:26:41 +0000 (22:56 +0530)]
Removed "requires JavaScript" from preference texts

Bug: 44947
Change-Id: I15e34206437cd55f1033d2cf76f377a2505aaffc

10 years agoFix typo in property name
Alex Monk [Wed, 4 Sep 2013 00:32:29 +0000 (01:32 +0100)]
Fix typo in property name

Change I270bde41 introduced a typo to RecentChanges.php, referring to
'$this->mExtras' when '$this->mExtra' was intended. This caused the IRC
log action comment to be omitted from the IRC RC feed.

Bug: 53720
Change-Id: I7f29ba8392861e00a37a2196833154bac41298b4

10 years agoMerge "Improve wfEscapeWikiText"
jenkins-bot [Tue, 3 Sep 2013 23:46:39 +0000 (23:46 +0000)]
Merge "Improve wfEscapeWikiText"

10 years agoSECURITY: Fix extension detection with 2 .'s
Tim Starling [Wed, 14 Aug 2013 16:31:05 +0000 (09:31 -0700)]
SECURITY: Fix extension detection with 2 .'s

Fix IE6 extension detection, to prevent XSS in the API response.

Bug: 52746
Change-Id: If58a81b62209b36bd143a1766a8a20c9c34dbe3b

10 years agoSECURITY: Prevent tokens in jsonp mode
Brad Jorsch [Thu, 29 Aug 2013 16:45:30 +0000 (09:45 -0700)]
SECURITY: Prevent tokens in jsonp mode

Add checks to token-returning functions to prevent returning tokens in
jsonp mode. This affects action=tokens, action=login,
action=createaccount, and action=query&list=deletedrevs.

Also, remove the "gettoken" parameter to action=block and
action=unblock, which has been deprecated since 1.20.

Bug: 49090
Change-Id: Ibeaa5c72d8084585092b15935a3f5709104bf7f7

10 years agoSECURITY: Prevent FPD on exceptions in load.php
csteipp [Fri, 16 Aug 2013 23:20:26 +0000 (16:20 -0700)]
SECURITY: Prevent FPD on exceptions in load.php

Sanitize error messages in ResourceLoader if $wgShowExceptionDetails is
false.

Bug: 46332

Change-Id: Ia14ae21972192d291cb86dce65568e9e8b4674f7

10 years agoImprove wfEscapeWikiText
Brad Jorsch [Tue, 3 Sep 2013 20:00:56 +0000 (16:00 -0400)]
Improve wfEscapeWikiText

The following are now correctly escaped:
* Space at the start of a line
* Start-of-line characters after \r
* Magic links such as "RFC 123" with non-space whitespace
* URIs that don't use "://", such as "urn:foo"
* Double-underscore magic words

Bug: 53658
Change-Id: Ie8803a03b20e3fd7e5cc7e55829f24bb86f60b17

10 years agoMerge "Hide server IP addresses from DB error pages"
jenkins-bot [Tue, 3 Sep 2013 21:02:37 +0000 (21:02 +0000)]
Merge "Hide server IP addresses from DB error pages"

10 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Tue, 3 Sep 2013 20:58:38 +0000 (20:58 +0000)]
Localisation updates from translatewiki.net.

Change-Id: I5dc3f7f303f05290e4b29dceecc69d7347e65e51

10 years agoHide server IP addresses from DB error pages
Kevin Israel [Sun, 3 Mar 2013 14:27:47 +0000 (09:27 -0500)]
Hide server IP addresses from DB error pages

Error details are now omitted if both $wgShowHostnames and
$wgShowSQLErrors are false. WMF wikis have the former set to true;
users of those wikis can still include the details in bug reports.

Fixing this for DBConnectionError was more or less straightforward.
However, in the case of DBQueryError, this involved splitting the
error message into multiple smaller messages (killing a raw HTML
message in the process).

Note that this is an incomplete fix: information disclosure is,
for now, still possible from DBUnexpectedError exceptions (are
these even supposed to go into the exception log?) or exceptions
that occur from within the exception handler. Yet this is still
an improvement.

Bug: 26811
Change-Id: I1756b296d5e8d1d22511a3c3b58b5bb0dd025fec

10 years agoMerge "Actually use $ignoreInvalidDB in UserRightProxy::getDB()"
jenkins-bot [Tue, 3 Sep 2013 17:00:27 +0000 (17:00 +0000)]
Merge "Actually use $ignoreInvalidDB in UserRightProxy::getDB()"

10 years agoMerge "Add/update comments for grep"
jenkins-bot [Tue, 3 Sep 2013 13:32:28 +0000 (13:32 +0000)]
Merge "Add/update comments for grep"

10 years agoMake mwCustomEditButtons a no-op and mark it as deprecated
Alex Monk [Sat, 29 Jun 2013 15:48:09 +0000 (16:48 +0100)]
Make mwCustomEditButtons a no-op and mark it as deprecated

Bug: 50310
Change-Id: I59d081b4f2581cea25485c69ef2933b94681e82a

10 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Mon, 2 Sep 2013 19:42:19 +0000 (19:42 +0000)]
Localisation updates from translatewiki.net.

Change-Id: Ibd05bfafcc2d7bbe5e5a7248625da61f5aaed83c

10 years agoMerge "Add converted namespace names as aliases to avoid confusion."
jenkins-bot [Mon, 2 Sep 2013 17:47:46 +0000 (17:47 +0000)]
Merge "Add converted namespace names as aliases to avoid confusion."

10 years agoMerge "Remove dead code"
jenkins-bot [Sun, 1 Sep 2013 22:27:12 +0000 (22:27 +0000)]
Merge "Remove dead code"

10 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Sun, 1 Sep 2013 19:25:36 +0000 (19:25 +0000)]
Localisation updates from translatewiki.net.

Change-Id: I4e6557cfbd773ac932c5e218adcfe7e7e6207b78

10 years agoMerge "Also redirect if prefixed https cookie is preset"
jenkins-bot [Sun, 1 Sep 2013 16:41:07 +0000 (16:41 +0000)]
Merge "Also redirect if prefixed https cookie is preset"

10 years agoMerge "Make morenotlisted more grammar-friendly"
jenkins-bot [Sun, 1 Sep 2013 09:55:52 +0000 (09:55 +0000)]
Merge "Make morenotlisted more grammar-friendly"

10 years agoMake morenotlisted more grammar-friendly
Nemo bis [Sat, 27 Jul 2013 17:10:04 +0000 (19:10 +0200)]
Make morenotlisted more grammar-friendly

It's nice to be able to have different translations compared to
moredotdotdot, but normally "More not listed..." is not worth
the grammatical hassles and is not one-size-fits-all.
<https://translatewiki.net/wiki/Thread:Support/MediaWiki:Morenotlisted_too_general>

Change-Id: Ica649d7630106143204c3495c544025439bb1921

10 years agoAdd email recipient username as a parameter to emailuser confirmation
Nemo bis [Fri, 9 Aug 2013 16:50:27 +0000 (18:50 +0200)]
Add email recipient username as a parameter to emailuser confirmation

Just as optional parameter, strictly following the bug summary, should be enough.
I sometimes open many tabs, forget who I emailed and have to check my email,
but unless someone thinks this common I don't think it's worth changing
the actual text of the confirmation adding more clutter.

Bug: 44668
Change-Id: Icf0ac18150847424728121e614849f87bee2e0e7

10 years agoUse login-throttled properly everywhere
Nemo bis [Mon, 19 Aug 2013 13:34:33 +0000 (15:34 +0200)]
Use login-throttled properly everywhere

Actually proper usage would probably be to split the messages.
Followup to Id385be840f340476fbe7a818ff1d05154fe86d68;
spotted by Shirayuki.
https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Login-throttled/en

Change-Id: I565971a90fc383327a51d717a80013cb7a3e9c9b

10 years agoAdd missing bug number for I458fb688
Kevin Israel [Sat, 31 Aug 2013 20:30:03 +0000 (16:30 -0400)]
Add missing bug number for I458fb688

Bug: 14431
Change-Id: I193abd91ce89971d40297c22d386e0ac3c453b88