Sam Reed [Thu, 26 May 2011 00:57:54 +0000 (00:57 +0000)]
* (bug 29144) Move action=dublincore and action=creativecommons to extensions
Add back links for metadata in <head>
Sam Reed [Thu, 26 May 2011 00:08:16 +0000 (00:08 +0000)]
* (bug 29144) Move action=dublincore and action=creativecommons to extensions
Moved CreativeCommonsRDF out to extension
Brion Vibber [Wed, 25 May 2011 23:59:43 +0000 (23:59 +0000)]
* (bug 27465) Fix metadata extraction for SVG files using unusual namespace names
The previous fix (in r82307) only checked explicitly for a namespace given the 'svg' prefix; this fix use XML namespacing support on XMLReader to check for the actual namespace URI correctly.
Fixed up a test case (for RDF extraction) and added trimming on the whitespace.
Also added another test case file that doesn't use a namespace name on the root.
Brion Vibber [Wed, 25 May 2011 23:57:44 +0000 (23:57 +0000)]
Reverting r82307 (bug 27465) as initial step to recommitting a cleaner fix.
Sam Reed [Wed, 25 May 2011 23:55:15 +0000 (23:55 +0000)]
* (bug 29144) Move action=dublincore and action=creativecommons to extensions
Moved dublincore out to extension
Brion Vibber [Wed, 25 May 2011 23:34:20 +0000 (23:34 +0000)]
Test cases for bug 27465: problems with XML namespace handling break SVGMetadataExtractor::getMetadata()
$ php phpunit.php includes/media/SVGMetadataExtractorTest.php
PHPUnit 3.5.13 by Sebastian Bergmann.
..E
Time: 1 second, Memory: 14.00Mb
There was 1 error:
1) SVGMetadataExtractorTest::testGetMetadata with data set #2 ('/var/www/trunk/tests/phpunit/includes/media/US_states_by_total_state_tax_revenue.svg', array(593, 959))
MWException: Expected <svg> tag, got ns0:svg
/var/www/trunk/includes/media/SVGMetadataExtractor.php:105
/var/www/trunk/includes/media/SVGMetadataExtractor.php:78
/var/www/trunk/includes/media/SVGMetadataExtractor.php:30
/var/www/trunk/tests/phpunit/includes/media/SVGMetadataExtractorTest.php:14
/var/www/trunk/tests/phpunit/MediaWikiTestCase.php:63
/var/www/trunk/tests/phpunit/MediaWikiPHPUnitCommand.php:20
/var/www/trunk/tests/phpunit/phpunit.php:60
FAILURES!
Tests: 3, Assertions: 2, Errors: 1.
Jeroen De Dauw [Wed, 25 May 2011 22:32:42 +0000 (22:32 +0000)]
added @since tag
Brion Vibber [Wed, 25 May 2011 22:01:08 +0000 (22:01 +0000)]
* (bug 29140) FirePHP debugging assist extension
FirePHP is an extension to Firebug, an awesome debugging extension to Firefox.
It allows pulling debug log data in from your PHP script via HTTP headers, which then get displayed in Firebug's console along with errors, warnings, and AJAX hits from the web page.
Added 'Debug' hook which gets called from wfDebug() and wfDebugLog() to take this; note that a few lines of output won't make it to FirePHP as they are output either before we've done all plugin initialization, or after we've flushed output and can no longer add HTTP headers.
BSD-licensed FirePHPCore library from firephp-libs commit
aff25803a3ff460b2797:
https://github.com/cadorn/firephp-libs/blob/
aff25803a3ff460b2797/packages/core/lib/FirePHPCore/FirePHP.class.php
There's not a lot of fancy integration; everything's just output as a 'log' line.
You can use $wgFirePHP global (or call FirePHP::getInstance() yourself) to get direct access to FirePHP's fancier features in test code.
Sam Reed [Wed, 25 May 2011 20:57:15 +0000 (20:57 +0000)]
We check self::$pageCount, then assign it to another array, and return it from that array
Not ever caching stuff further
Follows up some ancient revisions
Raimond Spekking [Wed, 25 May 2011 20:35:59 +0000 (20:35 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-05-25 20:01:00 UTC)
Chad Horohoe [Wed, 25 May 2011 20:19:18 +0000 (20:19 +0000)]
Fix for r83799: mw.org -> mediawiki.org
Sam Reed [Wed, 25 May 2011 18:58:02 +0000 (18:58 +0000)]
More documentation stuffs
Alexandre Emsenhuber [Wed, 25 May 2011 18:56:05 +0000 (18:56 +0000)]
* Check existence in correct language
* Simplify a bit existence check
Sam Reed [Wed, 25 May 2011 18:41:31 +0000 (18:41 +0000)]
Documentation
Alexandre Emsenhuber [Wed, 25 May 2011 18:37:32 +0000 (18:37 +0000)]
Also change $wgLanguageCode along with $wgContLang, this was breaking when arriving at LanguageConverterTest with "nooo!"
Alexandre Emsenhuber [Wed, 25 May 2011 18:32:04 +0000 (18:32 +0000)]
Moved wfGetCaller(), wfGetAllCallers() and wfFormatStackFrame() near other related functions
Krinkle [Wed, 25 May 2011 17:18:52 +0000 (17:18 +0000)]
Removing the last occurrences/mentions of mw.loader.go
* Follow-up r88125, r88790.
* Also cleaned up some comments to use the same uppercase/colon use as the rest of this file.
Search results: http://toolserver.org/~krinkle/wikimedia-svn-search/view.php?id=202&hash=
96029a8f5c6a5aaadc61767532e01571
Sam Reed [Wed, 25 May 2011 17:06:04 +0000 (17:06 +0000)]
Move DB utility classes into own file
Updated AutoLoader to match
Sam Reed [Wed, 25 May 2011 17:03:15 +0000 (17:03 +0000)]
Move DB(.*?)Error classes into own file
Updated AutoLoader to match
Sam Reed [Wed, 25 May 2011 16:14:59 +0000 (16:14 +0000)]
Fix undefined variable from r39635
Chad Horohoe [Wed, 25 May 2011 15:59:30 +0000 (15:59 +0000)]
Followup r87468: remove refs to CleanUpTest from Makefile
Mark A. Hershberger [Wed, 25 May 2011 15:39:47 +0000 (15:39 +0000)]
Misc EOL w/s and spaces-instead-of-tabs fixes. One day I'll get around to nagging people for this stuff, but for now, I'll JFDI myself.
Roan Kattouw [Wed, 25 May 2011 15:28:21 +0000 (15:28 +0000)]
Fix syntax error in r88794
Mark A. Hershberger [Wed, 25 May 2011 15:19:38 +0000 (15:19 +0000)]
Fixes Bug #29133: “Special:PasswordReset button text not i18n-able” by
adding the alterForm() method to set the submit button text.
Roan Kattouw [Wed, 25 May 2011 15:19:16 +0000 (15:19 +0000)]
Use $.extend() in mw.util and mw.util.jpegmeta so they can be loaded in either order. This means mw.util.jpegmeta doesn't depend on mw.util loading first any more
Roan Kattouw [Wed, 25 May 2011 14:16:21 +0000 (14:16 +0000)]
Fix r88125: forgot to remove another call to mw.loader.go()
Aaron Schulz [Wed, 25 May 2011 10:11:06 +0000 (10:11 +0000)]
* Follow-up r88740:
* Fixed parse() arguments in getRevIncludes()
* Changed clearTagHook() to avoid preprocessed-xml cache corruption
* Check current version cache in getRevIncludes()
Aaron Schulz [Wed, 25 May 2011 05:26:54 +0000 (05:26 +0000)]
Finish r88768, *ahem*
Chad Horohoe [Wed, 25 May 2011 00:49:51 +0000 (00:49 +0000)]
Workaround for duplicate key errors
Chad Horohoe [Wed, 25 May 2011 00:30:06 +0000 (00:30 +0000)]
Extend MediaWikiTestCase in a few places
Aaron Schulz [Wed, 25 May 2011 00:25:29 +0000 (00:25 +0000)]
* Changed @ => wfSuppressWarnings
* Added wfSuppressWarnings to Bitmap.php:
Notice: unserialize(): Error at offset 0 of 2 bytes in D:\www\MW_trunk\phase3\includes\media\Bitmap.php on line 685
Platonides [Tue, 24 May 2011 22:56:42 +0000 (22:56 +0000)]
Don't generate the footer div if there isn't any footer link.
Removed blank line between the <li>s of $validFooterLinks
Raimond Spekking [Tue, 24 May 2011 21:34:27 +0000 (21:34 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-05-24 20:59:00 UTC)
Chad Horohoe [Tue, 24 May 2011 21:22:36 +0000 (21:22 +0000)]
Fixup phpunit tests so we don't drop/create tables on EVERY SINGLE TEST.
Now just create them on the first test that needsDB() and skip creation on the rest.
Leaves you with a bunch of useless tables at the end of a run, but oh well at least its faster :)
Brion Vibber [Tue, 24 May 2011 21:04:50 +0000 (21:04 +0000)]
* (bug 29116) Fix regression breaking CheckUser extension
Fixes regression from r84475 and friends which made Block->load() and its new front-end Block::newFromTarget() fail when an empty string was passed in as the IP / $vagueTarget parameter to indicate skipping IP-based lookups.
Added phpunit test cases to confirm that both Block->load() and Block::newFromTarget() work when given null (already ok), '' (as done from CheckUser), or false (not seen, but perfectly legit sounding).
Adjusted comparisons to work as expected.
Aaron Schulz [Tue, 24 May 2011 19:52:27 +0000 (19:52 +0000)]
Follow-up r88740: forgot to commit this guy
Happy-melon [Tue, 24 May 2011 19:03:41 +0000 (19:03 +0000)]
(bug 29116) follow-up r84475: normalise the empty string to null in Block::newFromTarget().
Brion Vibber [Tue, 24 May 2011 18:50:43 +0000 (18:50 +0000)]
r88734 followup: pretty up the doc link added to qunit test result page; per Krinkle's suggestion moved it into the qunit toolbar div and it's much happier :D
Brion Vibber [Tue, 24 May 2011 18:41:26 +0000 (18:41 +0000)]
Add quick and dirty link to mediawiki.org/wiki/Manual:JavaScript_unit_testing from the qunit runner page
It's not styled; qunit result styles are entirely id-based for some reason so you can't just add a div or p with matching style.
Brion Vibber [Tue, 24 May 2011 18:35:30 +0000 (18:35 +0000)]
add a @fixme comment about toggleToc test case: doesn't actually test if the function works, just confirms that it exists.
Max Semenik [Tue, 24 May 2011 17:48:22 +0000 (17:48 +0000)]
Introduced Maintenance::getDB() and corresponding setDB() to control externally what database object should be used by maintenance script. Currently used by updater to avoid DatabaseSqliteTest from running stuff like Populate* on the live database instead of the one used for testing.
Alexandre Emsenhuber [Tue, 24 May 2011 17:28:21 +0000 (17:28 +0000)]
Simplify message existence checks by using wfMessage() instead of wfEmptyMsg()
Krinkle [Tue, 24 May 2011 16:52:28 +0000 (16:52 +0000)]
Reverting r88607. This downgrades jQuery from 1.5.2 back to 1.4.4.
* The main reason being the problems with $.ajax that arose in UploadWizard (as remarked on wikitech-l).
* My plan is to take the following week (or two) to talk a bit about JavaScript unit testing and how we plan to do distributed continuous integration testing for it. After that we could upgrade right to 1.6.1
* See also bug 28904 and "[Wikitech-l] Any issues with pending jQuery 1.6.1 update on trunk?"
Alexandre Emsenhuber [Tue, 24 May 2011 16:16:00 +0000 (16:16 +0000)]
Fixed api=compare example to use existing parameters
Sam Reed [Tue, 24 May 2011 16:04:03 +0000 (16:04 +0000)]
* (bug 29120) ApiQueryLogEvents: let letype accept multiple values
Description already hinted at multiple
Brion Vibber [Tue, 24 May 2011 00:42:42 +0000 (00:42 +0000)]
* (bug 29107) Fix regression in ResourceLoader debug mode for WikiEditor
One of WikiEditor's modules had only messages, no scripts; updates to the debug mode loader had ended up failing in the case where no scripts got passed in (if passed with a loader function we were fine, hence non-debug mode being ok)
This commit explicitly checks for the empty-array case and marks the module as ready immediately, instead of waiting for the last item in the loop to finish, which never happens. :)
Also consolidated three calls to the same few lines of code into a lambda function.
Krinkle [Tue, 24 May 2011 00:21:42 +0000 (00:21 +0000)]
Rewriting mw.loader test suite. The previous one didn't work properly in IE6-IE8.
Krinkle [Mon, 23 May 2011 22:35:51 +0000 (22:35 +0000)]
Removing tests for no longer existing methods (Follow-up r88667). Should calm down TestSwarm.
Brion Vibber [Mon, 23 May 2011 20:24:09 +0000 (20:24 +0000)]
Follow-up to r88667; finish reverting bogus test cases from r87964. It looks like these cases need to be re-added, but correctly; for instance getLocalUrl() **DOES NOT** return something in $wgArticlePath space when an action is given that's not view. It **MUST** return the matching $wgActionPath or else use $wgScript directly, to ensure that URL structuring rules & security rules are followed.
Raimond Spekking [Mon, 23 May 2011 20:06:24 +0000 (20:06 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-05-23 19:53:00 UTC)
Russ Nelson [Mon, 23 May 2011 19:53:49 +0000 (19:53 +0000)]
Space cadet\!
Alexandre Emsenhuber [Mon, 23 May 2011 19:42:00 +0000 (19:42 +0000)]
Moved wfEmptyMsg() near other message functions
Krinkle [Mon, 23 May 2011 19:08:26 +0000 (19:08 +0000)]
Moving check higher up in case there's a premade toggle _but_ no .wm-collapsible-content premade. This way the link will be caught before it's inner-wrapped, after which it would no longer be a direct child.
Brion Vibber [Mon, 23 May 2011 19:03:17 +0000 (19:03 +0000)]
Revert r87964: destroyed standard segregation of non-view action links outside of $wgArticlePath, which would have created huge extra search spider traffic to sites and put more bogus URLs into indexes.
This also reverts some convenience functions that were being added at the same time (??) to attempt to parse local links from JS.
Happy-melon [Mon, 23 May 2011 18:57:30 +0000 (18:57 +0000)]
Follow-up r85403: rm unwanted "new" declaration.
Happy-melon [Mon, 23 May 2011 18:52:36 +0000 (18:52 +0000)]
Follow-up r84475: Block::parseTarget() should always return an array.
Happy-melon [Mon, 23 May 2011 18:49:14 +0000 (18:49 +0000)]
Follow-up r84475: update userBlockedMessage() caller.
Alexandre Emsenhuber [Mon, 23 May 2011 17:55:26 +0000 (17:55 +0000)]
Use $act instead of a second call to $this->getAction()
Alexandre Emsenhuber [Mon, 23 May 2011 17:53:31 +0000 (17:53 +0000)]
Follow-up r88653: removed the remaining of OutputPage's stubbing
Sam Reed [Mon, 23 May 2011 17:52:37 +0000 (17:52 +0000)]
* (bug 29117) A string is missing when the UI is in Hebrew
Alexandre Emsenhuber [Mon, 23 May 2011 17:22:14 +0000 (17:22 +0000)]
Per comment on r87680: make parser tests work again.
Can somebody explain me why on earth do we need ParserTest::setUp() since all of this is done before each test in ParserTest::setupGlobals()?
Alexandre Emsenhuber [Mon, 23 May 2011 16:37:56 +0000 (16:37 +0000)]
exit -> return now that we are in a function
Alexandre Emsenhuber [Mon, 23 May 2011 16:32:52 +0000 (16:32 +0000)]
* Simplify message existence checks by using wfMessage() instead of wfMsg() with wfEmptyMsg()
* Fixed one check in Skin::addToSidebarPlain() that used user language for existence and content language for message's content
* Changed SkinTemplate::buildContentNavigationUrls() to use Title::getDefaultMessageText() instead of wfEmptyMsg()
Aaron Schulz [Mon, 23 May 2011 04:28:58 +0000 (04:28 +0000)]
* In core:
** Added hooks for custom RC/newpages filters
** Added tables,fields,and join_conds to SpecialNewPagesConditions hook
** Removed superflous $nameSpace logic in watchlist code
** Removed some copy-paste code for RC/watchlist filters
** Updates hooks.txt
* In FlaggedRevs:
* Added "hide reviewed edits" filter to RC/newpages
* Combined two handlers into modifyChangesListQuery. Removed is_array() check - always true now.
* Fixed onBeforePageDisplay() so that CSS worked on sp:Watchlist
* @TODO: remove $wgUseRCPatrol stuff...this gets us closer.
Russ Nelson [Mon, 23 May 2011 02:30:20 +0000 (02:30 +0000)]
Fill-in missing implementations of abstract function appendFinish()
Aaron Schulz [Mon, 23 May 2011 01:47:39 +0000 (01:47 +0000)]
Added missing getUser() function to Pager:
Fatal error: Call to undefined method NewPagesPager::getUser() in D:\www\MW_trunk\phase3\includes\specials\SpecialNewpages.php on line 491
Russ Nelson [Mon, 23 May 2011 01:18:06 +0000 (01:18 +0000)]
Swift needs to rewrite entire files. We need this call to prevent N**2 operations while appending
Krinkle [Mon, 23 May 2011 00:01:06 +0000 (00:01 +0000)]
Release notes for r88625, r88553, r88511 (bringing back 'Other changes' like in REL1_17 release notes)
Krinkle [Sun, 22 May 2011 23:52:16 +0000 (23:52 +0000)]
jquery.tabIndex.js was broken, not it works (for the first time?)
* Defaulting to null
* Setting to initial value during first iteration (instead of outside the loop), that way we dont have to set minTabIndex to some insane high value to let if ( .. > .. ) work
* (bug 29048) jQuery.tabIndex: firstTabIndex() outputs the same as lastTabIndex()
* Added extra <textarea> to test suite to make sure the 'correct answer' is not the first or last element
Platonides [Sun, 22 May 2011 23:36:17 +0000 (23:36 +0000)]
Revert unintended change in r88620
Krinkle [Sun, 22 May 2011 23:36:17 +0000 (23:36 +0000)]
Adding test suite for jquery.tabIndex.js, currently broken per:
(bug 29048) jQuery.tabIndex: firstTabIndex() outputs the same as lastTabIndex()
Platonides [Sun, 22 May 2011 23:24:56 +0000 (23:24 +0000)]
Use doc comment
Sam Reed [Sun, 22 May 2011 23:20:59 +0000 (23:20 +0000)]
* (bug 29101) Special:FileDuplicateSearch shows silly message
Patch by William Demchick
Platonides [Sun, 22 May 2011 22:10:08 +0000 (22:10 +0000)]
/* to /**
Platonides [Sun, 22 May 2011 22:05:18 +0000 (22:05 +0000)]
Changes to doc-comments. /* to /** in language folder.
Krinkle [Sun, 22 May 2011 21:54:32 +0000 (21:54 +0000)]
Update our jQuery from 1.4.4 to the latest version of 1.5 (1.5.2). See also bug 28904.
Sam Reed [Sun, 22 May 2011 19:21:22 +0000 (19:21 +0000)]
* (bug 28272) Special:Allmessages should have only one "Go" button
Patch by MZMcBride
Alexandre Emsenhuber [Sun, 22 May 2011 18:38:04 +0000 (18:38 +0000)]
Moved MediaWiki::articleFromTitle() to Article::newFromTitle(), this has nothing to do in the MediaWiki class
Chad Horohoe [Sun, 22 May 2011 18:05:17 +0000 (18:05 +0000)]
$wgArticle ain't needed here either ;) (followup r88588)
Chad Horohoe [Sun, 22 May 2011 17:59:47 +0000 (17:59 +0000)]
$wgArticle is deprecated! Possible removal in 1.20 or 1.21!
* Encapsulate index.php in wfIndexMain() (similar to r77873)
* Kill $wgArticle check in Exception, not necessary anymore
* Kill $wgArticle in Setup, also not necessary
* Add angry note about $wgArticle to rebuildFileCache.
* Remove note about $wgArticle in Parser since it's dying anyway
Chad Horohoe [Sun, 22 May 2011 17:57:29 +0000 (17:57 +0000)]
Just throw an exception, rather than calling wfDie()
Krinkle [Sun, 22 May 2011 10:40:57 +0000 (10:40 +0000)]
Adding fixme note for bug 29088.
Alexandre Emsenhuber [Sun, 22 May 2011 08:41:24 +0000 (08:41 +0000)]
Simplify a bit message existence checks, and also check existence of grouppage-* messages in content language
Krinkle [Sun, 22 May 2011 08:33:34 +0000 (08:33 +0000)]
Highlighting breaking change
Alexandre Emsenhuber [Sun, 22 May 2011 08:24:07 +0000 (08:24 +0000)]
Use wfMessage() so that we can check message existence in content language instead of user language
Krinkle [Sat, 21 May 2011 23:41:41 +0000 (23:41 +0000)]
Follow-up r88554: Passing null for now, fixed php error about missing arguments.
Chad Horohoe [Sat, 21 May 2011 23:22:47 +0000 (23:22 +0000)]
Report importDump to subclass Maintenance
Krinkle [Sat, 21 May 2011 23:14:53 +0000 (23:14 +0000)]
Passing token paremeter in mw.action.watch.ajax since this is required as of r88522.
Follow-up: r88511, r88522, r88527, r88553
Krinkle [Sat, 21 May 2011 22:52:32 +0000 (22:52 +0000)]
Adding user.tokens module and loading by default. (ResourceLoaderUserTokensModule Class)
Krinkle [Sat, 21 May 2011 21:05:55 +0000 (21:05 +0000)]
Changing float to text-align for conveniencelinks and editreasons links. Since headings have overflow:hidden this is causing the border to stop when this block is touched (atleast in Chrome/Safari), since headings don't clear float. This doesn't have to be a float from what I can see and is better done as text-align so that any later elements on the page will not be affected by the page flow.
Remove the line from Vector's main.css since it was already in shared.css
Niklas Laxström [Sat, 21 May 2011 20:39:31 +0000 (20:39 +0000)]
Quick unbreak r88495: initialising the variable caused it not to be filled with messages
Raimond Spekking [Sat, 21 May 2011 20:30:39 +0000 (20:30 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-05-21 20:20:00 UTC)
Krinkle [Sat, 21 May 2011 20:06:58 +0000 (20:06 +0000)]
Putting debughtml after visualClear in Vector skin. Messed up Special:UserLogin (debug starts to the right of the form. Doesn't affect other skins.
Sam Reed [Sat, 21 May 2011 20:06:57 +0000 (20:06 +0000)]
More documentation updates and additions
Getting bored of this tonight now I think...
Sam Reed [Sat, 21 May 2011 19:55:05 +0000 (19:55 +0000)]
Lots more documentation lines to MagicWord
Sam Reed [Sat, 21 May 2011 19:54:24 +0000 (19:54 +0000)]
More documentation tweaks and updates
Krinkle [Sat, 21 May 2011 19:46:32 +0000 (19:46 +0000)]
Follow-up r88527: Fix array item name
Sam Reed [Sat, 21 May 2011 19:36:03 +0000 (19:36 +0000)]
More comment updates, addition of some braces also
Sam Reed [Sat, 21 May 2011 19:35:16 +0000 (19:35 +0000)]
Fix function level comments that start with /* not /**
Sam Reed [Sat, 21 May 2011 19:22:01 +0000 (19:22 +0000)]
More documentation
Addition of spaces according to our coding style guidelines
dépôts / lhc / web / wiklou.git / log