From: Fomafix <fomafix@googlemail.com>
Date: Wed, 29 May 2019 09:18:47 +0000 (+0200)
Subject: jquery.suggestions: Do not show suggestions on prefilled values
X-Git-Tag: 1.34.0-rc.0~1560^2
X-Git-Url: http://git.cyclocoop.org/?a=commitdiff_plain;h=fd573383038356f27da73d724848a6329ee3f637;p=lhc%2Fweb%2Fwiklou.git

jquery.suggestions: Do not show suggestions on prefilled values

Show the suggestions on load only if the current value differs to the
defaultValue from the HTML. This prevents suggestions if there is
already a prefilled value in the input field.

Also direct call $.suggestions.update() instead of trigger a keypress.

This change is a follow-up to 72f61f7a5930cf03d4e8ddde62c2ef627b05dd69.

Bug: T224524
Change-Id: I501596996a20c62d1497bf66e23c7858b58bf4ea
---

diff --git a/resources/src/jquery/jquery.suggestions.js b/resources/src/jquery/jquery.suggestions.js
index 9e6ecc888d..e970c0637e 100644
--- a/resources/src/jquery/jquery.suggestions.js
+++ b/resources/src/jquery/jquery.suggestions.js
@@ -776,10 +776,12 @@
 						}
 						$.suggestions.hide( context );
 						$.suggestions.cancel( context );
-					} )
-					// Simulate a keypress on load. This loads the search suggestions when there are already
-					// typed characters before the JavaScript is loaded.
-					.trigger( 'keypress' );
+					} );
+				// Load suggestions if the value is changed because there are already
+				// typed characters before the JavaScript is loaded.
+				if ( this.value !== this.defaultValue ) {
+					$.suggestions.update( context, false );
+				}
 			}
 
 			// Store the context for next time