From: Umherirrender <umherirrender_de.wp@web.de>
Date: Sat, 29 Jun 2019 14:11:57 +0000 (+0200)
Subject: Remove unneeded redeclaration of mPage in Article subclasses
X-Git-Tag: 1.34.0-rc.0~454^2
X-Git-Url: http://git.cyclocoop.org/?a=commitdiff_plain;h=fc7c916b6fc986d8aa4f4d9b3060ead0feb448d7;p=lhc%2Fweb%2Fwiklou.git

Remove unneeded redeclaration of mPage in Article subclasses

It is already set in the parent class

To make phan happy, set the new type with a @property annotation

Change-Id: I47a83e3c4848b0a75284dc08c72df60b3d5dd19b
---

diff --git a/includes/page/CategoryPage.php b/includes/page/CategoryPage.php
index 491726bedd..dda13d3da9 100644
--- a/includes/page/CategoryPage.php
+++ b/includes/page/CategoryPage.php
@@ -24,16 +24,13 @@
 /**
  * Special handling for category description pages, showing pages,
  * subcategories and file that belong to the category
+ *
+ * @property WikiCategoryPage $mPage Set by overwritten newPage() in this class
  */
 class CategoryPage extends Article {
 	# Subclasses can change this to override the viewer class.
 	protected $mCategoryViewerClass = CategoryViewer::class;
 
-	/**
-	 * @var WikiCategoryPage
-	 */
-	protected $mPage;
-
 	/**
 	 * @param Title $title
 	 * @return WikiCategoryPage
diff --git a/includes/page/ImagePage.php b/includes/page/ImagePage.php
index 2e43e8c53b..d3f063877f 100644
--- a/includes/page/ImagePage.php
+++ b/includes/page/ImagePage.php
@@ -27,6 +27,8 @@ use Wikimedia\Rdbms\ResultWrapper;
  * Class for viewing MediaWiki file description pages
  *
  * @ingroup Media
+ *
+ * @property WikiFilePage $mPage Set by overwritten newPage() in this class
  */
 class ImagePage extends Article {
 	/** @var File|false */
@@ -41,11 +43,6 @@ class ImagePage extends Article {
 	/** @var bool */
 	protected $mExtraDescription = false;
 
-	/**
-	 * @var WikiFilePage
-	 */
-	protected $mPage;
-
 	/**
 	 * @param Title $title
 	 * @return WikiFilePage