From: Kunal Mehta Date: Thu, 28 Dec 2017 08:24:40 +0000 (-0800) Subject: Add @covers tags to languages tests X-Git-Tag: 1.31.0-rc.0~1060^2 X-Git-Url: http://git.cyclocoop.org/?a=commitdiff_plain;h=fc23633035eebb24b7199cb15683e25100184e2b;p=lhc%2Fweb%2Fwiklou.git Add @covers tags to languages tests I removed comments that merely repeated the location of the class being tested. There are other tests in this directory that don't have a corresponding class and need further investigation. Change-Id: Ic16f0887b5030ac53fab4382cfaedfb5426cdb08 --- diff --git a/tests/phpunit/languages/LanguageConverterTest.php b/tests/phpunit/languages/LanguageConverterTest.php index fc2ed33b65..82ab7def22 100644 --- a/tests/phpunit/languages/LanguageConverterTest.php +++ b/tests/phpunit/languages/LanguageConverterTest.php @@ -160,6 +160,8 @@ class LanguageConverterTest extends MediaWikiLangTestCase { /** * Test exhausting pcre.backtrack_limit + * + * @covers LanguageConverter::autoConvert */ public function testAutoConvertT124404() { $testString = ''; diff --git a/tests/phpunit/languages/LanguageTest.php b/tests/phpunit/languages/LanguageTest.php index e39f57ea99..0c341303f7 100644 --- a/tests/phpunit/languages/LanguageTest.php +++ b/tests/phpunit/languages/LanguageTest.php @@ -1630,7 +1630,7 @@ class LanguageTest extends LanguageClassesTestCase { } /** - * @dataProvider testFormatNumProvider + * @dataProvider provideFormatNum * @covers Language::formatNum */ public function testFormatNum( @@ -1643,7 +1643,7 @@ class LanguageTest extends LanguageClassesTestCase { $this->assertEquals( $expected, $formattedNum ); } - public function testFormatNumProvider() { + public function provideFormatNum() { return [ [ true, 'en', 100, false, '100' ], [ true, 'en', 101, true, '101' ], @@ -1657,6 +1657,7 @@ class LanguageTest extends LanguageClassesTestCase { } /** + * @covers Language::parseFormattedNumber * @dataProvider parseFormattedNumberProvider */ public function testParseFormattedNumber( $langCode, $number ) { @@ -1795,6 +1796,9 @@ class LanguageTest extends LanguageClassesTestCase { ]; } + /** + * @covers Language::equals + */ public function testEquals() { $en1 = new Language(); $en1->setCode( 'en' ); diff --git a/tests/phpunit/languages/classes/LanguageArTest.php b/tests/phpunit/languages/classes/LanguageArTest.php index 5a66759873..f3f5a3f1f1 100644 --- a/tests/phpunit/languages/classes/LanguageArTest.php +++ b/tests/phpunit/languages/classes/LanguageArTest.php @@ -4,7 +4,9 @@ * @file */ -/** Tests for MediaWiki languages/LanguageAr.php */ +/** + * @covers LanguageAr + */ class LanguageArTest extends LanguageClassesTestCase { /** * @covers Language::formatNum diff --git a/tests/phpunit/languages/classes/LanguageBe_taraskTest.php b/tests/phpunit/languages/classes/LanguageBe_taraskTest.php index 26db1062a1..de684359fa 100644 --- a/tests/phpunit/languages/classes/LanguageBe_taraskTest.php +++ b/tests/phpunit/languages/classes/LanguageBe_taraskTest.php @@ -1,6 +1,9 @@