From: Timo Tijhof <krinklemail@gmail.com>
Date: Wed, 7 Aug 2019 18:29:30 +0000 (+0100)
Subject: DefaultSettings: Document wgTmpDirectory guarantees and expectations
X-Git-Tag: 1.34.0-rc.0~724^2
X-Git-Url: http://git.cyclocoop.org/?a=commitdiff_plain;h=bbfe2c14a234ed7eb13764109caacc6b369a6905;p=lhc%2Fweb%2Fwiklou.git

DefaultSettings: Document wgTmpDirectory guarantees and expectations

Bug: T218207
Change-Id: I40c22e4e8d9fe2f1865503c849f278a799b4a363
---

diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php
index 1b348f3d3b..50a2057855 100644
--- a/includes/DefaultSettings.php
+++ b/includes/DefaultSettings.php
@@ -330,15 +330,22 @@ $wgAppleTouchIcon = false;
 $wgReferrerPolicy = false;
 
 /**
- * The local filesystem path to a temporary directory. This is not required to
- * be web accessible.
- *
- * When this setting is set to false, its value will be set through a call
- * to wfTempDir(). See that methods implementation for the actual detection
- * logic.
- *
- * Developers should use the global function wfTempDir() instead of this
- * variable.
+ * The local filesystem path to a temporary directory. This must not be web accessible.
+ *
+ * When this setting is set to false, its value will automatically be decided
+ * through the first call to wfTempDir(). See that method's implementation for
+ * the actual detection logic.
+ *
+ * To find the temporary path for the current wiki, developers must not use
+ * this variable directly. Use the global function wfTempDir() instead.
+ *
+ * The temporary directory is expected to be shared with other applications,
+ * including other MediaWiki instances (which might not run the same version
+ * or configution). When storing files here, take care to avoid conflicts
+ * with other instances of MediaWiki. For example, when caching the result
+ * of a computation, the file name should incorporate the input of the
+ * computation so that it cannot be confused for the result of a similar
+ * computation by another MediaWiki instance.
  *
  * @see wfTempDir()
  * @note Default changed to false in MediaWiki 1.20.