From: Tim Starling <tstarling@wikimedia.org>
Date: Wed, 1 Aug 2018 01:30:49 +0000 (+1000)
Subject: Fix pingback on non-MySQL
X-Git-Tag: 1.34.0-rc.0~4598^2
X-Git-Url: http://git.cyclocoop.org/?a=commitdiff_plain;h=ba54f7f90dce0e06ff3c4ad1ec141362f10be9a9;p=lhc%2Fweb%2Fwiklou.git

Fix pingback on non-MySQL

MySQL has its own implementation of upsert(), but the others rely on
$uniqueIndexes being a field list, not a field/value associative array.
The previous code generated an SQL error when checking for existing
values.

Bug: T200864
Change-Id: Ifb56f7f350fbb84144bc6f5a1dd76939816338a6
---

diff --git a/includes/Pingback.php b/includes/Pingback.php
index ee608c2d9c..8d7c3b6e4d 100644
--- a/includes/Pingback.php
+++ b/includes/Pingback.php
@@ -99,7 +99,7 @@ class Pingback {
 		return $dbw->upsert(
 			'updatelog',
 			[ 'ul_key' => $this->key, 'ul_value' => $timestamp ],
-			[ 'ul_key' => $this->key ],
+			[ 'ul_key' ],
 			[ 'ul_value' => $timestamp ],
 			__METHOD__
 		);