From: Brion Vibber <brion@users.mediawiki.org>
Date: Thu, 31 Jul 2008 23:20:37 +0000 (+0000)
Subject: Revert r38302,38306 -- "Add an order by to the list of watched pages."
X-Git-Tag: 1.31.0-rc.0~46240
X-Git-Url: http://git.cyclocoop.org/?a=commitdiff_plain;h=94d79db03ebc2753342493a0e9ce375b94dc04dd;p=lhc%2Fweb%2Fwiklou.git

Revert r38302,38306 -- "Add an order by to the list of watched pages."
This looks wrong -- an order by title wouldn't be indexed properly, and could be rather slow.
---

diff --git a/includes/WatchlistEditor.php b/includes/WatchlistEditor.php
index d13523003d..fcfdb78294 100644
--- a/includes/WatchlistEditor.php
+++ b/includes/WatchlistEditor.php
@@ -208,9 +208,6 @@ class WatchlistEditor {
 		$sql = "SELECT wl_namespace, wl_title, page_id, page_len, page_is_redirect
 			FROM {$watchlist} LEFT JOIN {$page} ON ( wl_namespace = page_namespace
 			AND wl_title = page_title ) WHERE wl_user = {$uid}";
-		if ( !$dbr->implicitOrderby() ) {
-			$sql .= ' ORDER BY wl_title';
-		}
 		$res = $dbr->query( $sql, __METHOD__ );
 		if( $res && $dbr->numRows( $res ) > 0 ) {
 			$cache = LinkCache::singleton();