From: James D. Forrester <jforrester@wikimedia.org>
Date: Tue, 27 Aug 2019 20:40:40 +0000 (-0700)
Subject: ApiFeedContributions: Drop 'newbies' feature
X-Git-Tag: 1.34.0-rc.0~526^2
X-Git-Url: http://git.cyclocoop.org/?a=commitdiff_plain;h=7fba6829efacee250d795c4a78349dad40b3d84e;p=lhc%2Fweb%2Fwiklou.git

ApiFeedContributions: Drop 'newbies' feature

It has been broken since 2011 (r100315), so no need for
deprecation.

Change-Id: I099f52211c8ce401d827405cb313e1d3932b92f8
---

diff --git a/includes/api/ApiFeedContributions.php b/includes/api/ApiFeedContributions.php
index 28b0a4b714..fabe4a2e7c 100644
--- a/includes/api/ApiFeedContributions.php
+++ b/includes/api/ApiFeedContributions.php
@@ -71,18 +71,15 @@ class ApiFeedContributions extends ApiBase {
 			' [' . $config->get( 'LanguageCode' ) . ']';
 		$feedUrl = SpecialPage::getTitleFor( 'Contributions', $params['user'] )->getFullURL();
 
-		$target = 'newbies';
-		if ( $params['user'] != 'newbies' ) {
-			try {
-				$target = $this->titleParser
-					->parseTitle( $params['user'], NS_USER )
-					->getText();
-			} catch ( MalformedTitleException $e ) {
-				$this->dieWithError(
-					[ 'apierror-baduser', 'user', wfEscapeWikiText( $params['user'] ) ],
-					'baduser_' . $this->encodeParamName( 'user' )
-				);
-			}
+		try {
+			$target = $this->titleParser
+				->parseTitle( $params['user'], NS_USER )
+				->getText();
+		} catch ( MalformedTitleException $e ) {
+			$this->dieWithError(
+				[ 'apierror-baduser', 'user', wfEscapeWikiText( $params['user'] ) ],
+				'baduser_' . $this->encodeParamName( 'user' )
+			);
 		}
 
 		$feed = new $feedClasses[$params['feedformat']] (