From: gbt248 <fx-eckart@gmx.de>
Date: Sun, 2 Mar 2014 13:37:16 +0000 (+0100)
Subject: Preferences.php: avoid "Undefined index" if key 'realname' don't exist in $formdata
X-Git-Tag: 1.31.0-rc.0~16566^2
X-Git-Url: http://git.cyclocoop.org/?a=commitdiff_plain;h=7110eb061a03b517b66c34017be2998a8979adfa;p=lhc%2Fweb%2Fwiklou.git

Preferences.php: avoid "Undefined index" if key 'realname' don't exist in $formdata

Added additional check for missing key "realname" in $formData which can cause
an undefined index: realname

Bug: 62029
Change-Id: I6763c12d9b4d8b1e574eb3162168f4f5380df93a
---

diff --git a/includes/Preferences.php b/includes/Preferences.php
index 9a16383459..b47115bd03 100644
--- a/includes/Preferences.php
+++ b/includes/Preferences.php
@@ -1418,7 +1418,7 @@ class Preferences {
 
 		// Fortunately, the realname field is MUCH simpler
 		// (not really "private", but still shouldn't be edited without permission)
-		if ( !in_array( 'realname', $wgHiddenPrefs ) && $user->isAllowed( 'editmyprivateinfo' ) ) {
+		if ( !in_array( 'realname', $wgHiddenPrefs ) && $user->isAllowed( 'editmyprivateinfo' ) && array_key_exists( 'realname', $formData ) ) {
 			$realName = $formData['realname'];
 			$user->setRealName( $realName );
 		}