From: Thiemo Kreuz <thiemo.kreuz@wikimedia.de>
Date: Tue, 15 Jan 2019 11:36:04 +0000 (+0100)
Subject: Add missing "@return StatusValue" to all abstract do… methods
X-Git-Tag: 1.34.0-rc.0~3078
X-Git-Url: http://git.cyclocoop.org/?a=commitdiff_plain;h=65bbe6c7dc91694ba0f4ab24d490a936bcf6220f;p=lhc%2Fweb%2Fwiklou.git

Add missing "@return StatusValue" to all abstract do… methods

All implementations do this, and all callers expect this. I wonder how
the documentation for this detail got lost?

Change-Id: If4977c9f4032ca5d93ea91f49cdc70f7ef1175ba
---

diff --git a/includes/libs/filebackend/FileBackend.php b/includes/libs/filebackend/FileBackend.php
index 27e6924476..178831bac4 100644
--- a/includes/libs/filebackend/FileBackend.php
+++ b/includes/libs/filebackend/FileBackend.php
@@ -436,6 +436,7 @@ abstract class FileBackend implements LoggerAwareInterface {
 	 * @see FileBackend::doOperations()
 	 * @param array $ops
 	 * @param array $opts
+	 * @return StatusValue
 	 */
 	abstract protected function doOperationsInternal( array $ops, array $opts );
 
@@ -673,6 +674,7 @@ abstract class FileBackend implements LoggerAwareInterface {
 	/**
 	 * @see FileBackend::doQuickOperations()
 	 * @param array $ops
+	 * @return StatusValue
 	 * @since 1.20
 	 */
 	abstract protected function doQuickOperationsInternal( array $ops );
@@ -819,6 +821,7 @@ abstract class FileBackend implements LoggerAwareInterface {
 	/**
 	 * @see FileBackend::prepare()
 	 * @param array $params
+	 * @return StatusValue
 	 */
 	abstract protected function doPrepare( array $params );
 
@@ -850,6 +853,7 @@ abstract class FileBackend implements LoggerAwareInterface {
 	/**
 	 * @see FileBackend::secure()
 	 * @param array $params
+	 * @return StatusValue
 	 */
 	abstract protected function doSecure( array $params );
 
@@ -883,6 +887,7 @@ abstract class FileBackend implements LoggerAwareInterface {
 	/**
 	 * @see FileBackend::publish()
 	 * @param array $params
+	 * @return StatusValue
 	 */
 	abstract protected function doPublish( array $params );
 
@@ -909,6 +914,7 @@ abstract class FileBackend implements LoggerAwareInterface {
 	/**
 	 * @see FileBackend::clean()
 	 * @param array $params
+	 * @return StatusValue
 	 */
 	abstract protected function doClean( array $params );