From: Brad Jorsch <bjorsch@wikimedia.org>
Date: Tue, 1 May 2018 13:24:36 +0000 (-0400)
Subject: Fix MySQLism in populateRevisionLength.php
X-Git-Tag: 1.34.0-rc.0~5570
X-Git-Url: http://git.cyclocoop.org/?a=commitdiff_plain;h=5e6efe18d01f64f2c9a0a8bcb213ffe30999530f;p=lhc%2Fweb%2Fwiklou.git

Fix MySQLism in populateRevisionLength.php

Use addQuotes() to make a quoted string instead of MySQL's nonstandard
use of double-quotes.

Change-Id: Ie2d017a33b694417a3db140b2798a8d55f911985
---

diff --git a/maintenance/populateRevisionLength.php b/maintenance/populateRevisionLength.php
index ffa4ff7efa..dcb89d193f 100644
--- a/maintenance/populateRevisionLength.php
+++ b/maintenance/populateRevisionLength.php
@@ -103,7 +103,7 @@ class PopulateRevisionLength extends LoggedUpdateMaintenance {
 						"{$prefix}_len IS NULL",
 						$dbr->makeList( [
 							"{$prefix}_len = 0",
-							"{$prefix}_sha1 != \"phoiac9h4m842xq45sp7s6u21eteeq1\"", // sha1( "" )
+							"{$prefix}_sha1 != " . $dbr->addQuotes( 'phoiac9h4m842xq45sp7s6u21eteeq1' ), // sha1( "" )
 						], IDatabase::LIST_AND )
 					], IDatabase::LIST_OR )
 				],