From: River Tarnell <kateturner@users.mediawiki.org>
Date: Wed, 6 Jul 2005 02:47:19 +0000 (+0000)
Subject: when a value is selected, hide the 'time' entry field
X-Git-Tag: 1.5.0beta3~36
X-Git-Url: http://git.cyclocoop.org/?a=commitdiff_plain;h=5c85f1c8669bb4e82d514f4db6c9a4c3196a823f;p=lhc%2Fweb%2Fwiklou.git

when a value is selected, hide the 'time' entry field
---

diff --git a/includes/SpecialBlockip.php b/includes/SpecialBlockip.php
index 98a4af2387..f1ea7cdd83 100644
--- a/includes/SpecialBlockip.php
+++ b/includes/SpecialBlockip.php
@@ -83,6 +83,7 @@ class IPBlockForm {
 
 		$blockExpiryFormOptions = "<option value=\"other\">$mIpbothertime</option>";
 		foreach (explode(',', $scBlockExpiryOptions) as $option) {
+			if (strstr($option, ":")) $option = "$option:$option";
 			list($show, $value) = explode(":", $option);
 			$show = htmlspecialchars($show);
 			$value = htmlspecialchars($value);
@@ -108,7 +109,7 @@ class IPBlockForm {
 			$wgOut->addHTML("
 			<td align=\"right\">{$mIpbexpiry}:</td>
 			<td align=\"left\">
-				<select tabindex='2' name=\"wpBlockExpiry\">
+				<select tabindex='2' id='wpBlockExpiry' name=\"wpBlockExpiry\" onchange=\"considerChangingExpiryFocus()\">
 					$blockExpiryFormOptions
 				</select>
 			</td>
@@ -116,7 +117,7 @@ class IPBlockForm {
 		}
 		$wgOut->addHTML("
 		</tr>
-		<tr>
+		<tr id='wpBlockOther'>
 			<td align=\"right\">{$mIpbother}:</td>
 			<td align=\"left\">
 				<input tabindex='3' type='text' size='40' name=\"wpBlockOther\" value=\"{$scBlockOtherTime}\" />
diff --git a/skins/common/wikibits.js b/skins/common/wikibits.js
index c251c78732..249f720646 100644
--- a/skins/common/wikibits.js
+++ b/skins/common/wikibits.js
@@ -485,3 +485,16 @@ function fillDestFilename() {
 	document.fname = fname;
 }
 	
+
+function considerChangingExpiryFocus() {
+	if (!document.getElementById) return;
+	var drop = document.getElementById('wpBlockExpiry');
+	if (!drop) return;
+	var field = document.getElementById('wpBlockOther');
+	if (!field) return;
+	var opt = drop.value;
+	if (opt == 'other')
+		field.style.display = '';
+	else
+		field.style.display = 'none';
+}