From: Kosta Harlan <kharlan@wikimedia.org>
Date: Mon, 1 Jul 2019 15:42:21 +0000 (-0400)
Subject: Remove group validator from UnitTestCase
X-Git-Tag: 1.34.0-rc.0~1216^2
X-Git-Url: http://git.cyclocoop.org/?a=commitdiff_plain;h=5c2d3a5bf4e917a496b771d9cb5f659c24e0a7c9;p=lhc%2Fweb%2Fwiklou.git

Remove group validator from UnitTestCase

Whether a unit test has `@group Database` is irrelevant, since it will simply
not work if it relies on database access.

Change-Id: Ibe01d4912160ae44ca86ef6f7c3946501a8c067e
---

diff --git a/tests/phpunit/MediaWikiUnitTestCase.php b/tests/phpunit/MediaWikiUnitTestCase.php
index c1dc0f9099..1065c2f26a 100644
--- a/tests/phpunit/MediaWikiUnitTestCase.php
+++ b/tests/phpunit/MediaWikiUnitTestCase.php
@@ -30,17 +30,5 @@ use PHPUnit\Framework\TestCase;
 abstract class MediaWikiUnitTestCase extends TestCase {
 	use PHPUnit4And6Compat;
 	use MediaWikiCoversValidator;
-	use MediaWikiGroupValidator;
-
-	/**
-	 * @throws ReflectionException
-	 */
-	protected function setUp() {
-		parent::setUp();
-		if ( $this->isTestInDatabaseGroup() ) {
-			throw new \Exception( get_class( $this ) .
-			  ' extends MediaWikiUnitTestCase, and may not have the @group Database annotation.' );
-		}
-	}
 
 }