From: Santhosh Thottingal <santhosh.thottingal@gmail.com>
Date: Tue, 31 May 2016 09:48:14 +0000 (+0530)
Subject: Avoid passing integers to mw.RegExp.escape
X-Git-Tag: 1.31.0-rc.0~6745^2
X-Git-Url: http://git.cyclocoop.org/?a=commitdiff_plain;h=53b92dbca18dbb570cde8cea31c42e418e57140f;p=lhc%2Fweb%2Fwiklou.git

Avoid passing integers to mw.RegExp.escape

Passing the index value of the loop to mw.RegExp.escape
causes javascript error at str.replace. mw.RegExp.escape
expects string parameters. It is not required to escape
the loop index here.

Follow-up to c81ab8ae5f89056d23a4b0d36066120b9701d07e.

Bug: T135743
Change-Id: I818bc2c671193e79848ae183f509473200c6abf5
---

diff --git a/resources/src/moment-locale-overrides.js b/resources/src/moment-locale-overrides.js
index 9af0598ec1..dd33b007f6 100644
--- a/resources/src/moment-locale-overrides.js
+++ b/resources/src/moment-locale-overrides.js
@@ -27,7 +27,7 @@ moment.locale( moment.locale(), {
 		if ( mw.config.get( 'wgTranslateNumerals' ) ) {
 			for ( i = 0; i < 10; i++ ) {
 				if ( table[ i ] !== undefined ) {
-					s = s.replace( new RegExp( mw.RegExp.escape( i ), 'g' ), table[ i ] );
+					s = s.replace( new RegExp( i, 'g' ), table[ i ] );
 				}
 			}
 		}