From: Bartosz Dziewoński <matma.rex@gmail.com>
Date: Mon, 3 Sep 2018 19:21:42 +0000 (+0200)
Subject: SpecialPreferences: Escape HTML in tab titles in legacy form
X-Git-Tag: 1.34.0-rc.0~4213^2
X-Git-Url: http://git.cyclocoop.org/?a=commitdiff_plain;h=376bcd30eeaf17b64d8b2e53b9ccb44232ea7692;p=lhc%2Fweb%2Fwiklou.git

SpecialPreferences: Escape HTML in tab titles in legacy form

They shouldn't intentionally contain HTML (except by abuse of
PreferencesGetLegend hook), and other than trivial formatting,
it wouldn't display correctly because they are styled as links.

It is already being escaped in OOUI form.

Change-Id: I303afe92fcb0208d1a2b040321866c0c95f27aa9
---

diff --git a/includes/specials/SpecialPreferences.php b/includes/specials/SpecialPreferences.php
index 0490cbbfce..08b33c1310 100644
--- a/includes/specials/SpecialPreferences.php
+++ b/includes/specials/SpecialPreferences.php
@@ -130,7 +130,7 @@ class SpecialPreferences extends SpecialPage {
 						'role' => 'presentation',
 						'class' => ( $key === 'personal' ) ? 'selected' : null
 					],
-					Html::rawElement( 'a',
+					Html::element( 'a',
 						[
 							'id' => 'preftab-' . $key,
 							'role' => 'tab',