From: Aaron Schulz <aschulz@wikimedia.org>
Date: Sat, 14 Sep 2019 05:41:10 +0000 (-0700)
Subject: Make doTestLockCalls() faster
X-Git-Tag: 1.34.0-rc.0~213^2
X-Git-Url: http://git.cyclocoop.org/?a=commitdiff_plain;h=20c645945ccab2fe569c4ed08522ea103e9bd31f;p=lhc%2Fweb%2Fwiklou.git

Make doTestLockCalls() faster

This was mostly doing many runs just to test for random lock errors in
versions of Windows from a few years back. Just do three quick rounds.

Change-Id: I2ec2a8ce66a5c14bfc9338b60f8a57b2de8eaece
---

diff --git a/tests/phpunit/includes/filebackend/FileBackendTest.php b/tests/phpunit/includes/filebackend/FileBackendTest.php
index 3b30d7ef71..e344d57d42 100644
--- a/tests/phpunit/includes/filebackend/FileBackendTest.php
+++ b/tests/phpunit/includes/filebackend/FileBackendTest.php
@@ -2422,7 +2422,7 @@ class FileBackendTest extends MediaWikiTestCase {
 			"$base/subdir2/subdir/sub/120-px-file.txt",
 		];
 
-		for ( $i = 0; $i < 25; $i++ ) {
+		for ( $i = 0; $i < 2; $i++ ) {
 			$status = $this->backend->lockFiles( $paths, LockManager::LOCK_EX );
 			$this->assertEquals( print_r( [], true ), print_r( $status->getErrors(), true ),
 				"Locking of files succeeded ($backendName) ($i)." );